[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

It's there for both masters and tservers, since it's the same code path for 
both.

If you run that runkudu script once, let it succeed and start 3 masters, 3 
tservers, then run it again, you should see those FATALs on stderr in your 
shell, one per server, unless you've changed the configuration.


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:26:34 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

> > Hi Will. Could you tell me how to do "trying to start up a
 > tserver
 > > on top of the files of a running tservers"? I only saw the double "Could 
 > > not lock.." on master_main.cc when I ran ./runkudu


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:23:19 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

> Hi Will. Could you tell me how to do "trying to start up a tserver
 > on top of the files of a running tservers"?

NVM. Just found out it comes with the ./runkudu..


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 17:03:02 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

Hi Will. Could you tell me how to do "trying to start up a tserver on top of 
the files of a running tservers"?


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:58:50 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..


Patch Set 1:

(1 comment)

I noticed another funny thing about the fatal log when trying to start up a 
tserver on top of the files of a running tservers:

F0516 08:58:17.725335 2979312512 tablet_server_main.cc:86] Check failed: 
_s.ok() Bad status: IO error: Failed to load FS layout: Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance: Resource 
temporarily unavailable (error 35)

See how the part "Could not lock 
/private/tmp/kudu/data/tserver/0/data/block_manager_instance" is repeated 
twice? Could you see if that's easy to fix as well?

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc@449
PS1, Line 449: Is Kudu already running or are you trying "
 :"to run Kudu with a different user 
than before?
The Status s comes from fs_manager_->Open, and could be any Status that 
function returns. If you look at FsManager::Open, there's a lot of things that 
can go wrong besides being unable to lock an instance file. The "Can not lock" 
message comes from DataDirManager::Open(), so we either need to adjust the 
message there or detect the error here and adjust the error just in that case.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 16:08:01 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Failed to load FS layout" error log

[Fengling Wang (Code Review)]

Fengling Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10419


Change subject: KUDU-1867 Improve the "Failed to load FS layout" error log
..

KUDU-1867 Improve the "Failed to load FS layout" error log

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/server/server_base.cc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/1
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang