[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10185 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..

KUDU-2416: Fix PartialRow.setMin and add a unit test

* Fixes a missing break after the decimal type that could
   lead to IllegalArgumentExceptions.
* Fixes INTEGER.MIN_VALUE being used for LONG colums
  that could lead to incorrect partition prunning.
* Adds a unit test for all types.

Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Reviewed-on: http://gerrit.cloudera.org:8080/10185
Reviewed-by: Todd Lipcon 
Reviewed-by: Dan Burkert 
Tested-by: Grant Henke 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
2 files changed, 22 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Dan Burkert: Looks good to me, approved
  Grant Henke: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10185 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Apr 2018 17:52:45 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10185 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Patch Set 1: Code-Review+2

> Patch Set 1: Code-Review+2
>
> Looks good. Would be good to understand the impact so we know how far back to 
> backport this, etc

This bug can result in Kudu incorrectly pruning partitions in specific 
scenarios.  It requires multiple range partition columns, a partition bound 
value being less than -2^31 on any column _except_ the first.  Then, it 
requires a certain set of predicates to trigger the pruning.  Here is the 
simplest repro I've found (in Impala):

CREATE TABLE t (a BIGINT, b BIGINT, PRIMARY KEY (a, b))
PARTITION BY RANGE (a, b) (
PARTITION VALUE = (0, 0),
PARTITION VALUE = (0, -2147483649)
) STORED AS KUDU;
INSERT INTO t VALUES (0, 0), (0, -2147483649);
SELECT * FROM t WHERE a >= 0;

results in a single result: (0, 0), where it should result in both values.

I think we should backport this patch widely given the 'obviousness' of the 
fix.  I'll come up with a regression test in another patch.


--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Apr 2018 17:31:19 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10185 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Patch Set 1: Code-Review+2

Looks good. Would be good to understand the impact so we know how far back to 
backport this, etc


--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Apr 2018 16:41:25 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10185


Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..

KUDU-2416: Fix PartialRow.setMin and add a unit test

* Fixes a missing break after the decimal type that could
   lead to IllegalArgumentExceptions.
* Fixes INTEGER.MIN_VALUE being used for LONG colums
  that could lead to incorrect partition prunning.
* Adds a unit test for all types.

Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
2 files changed, 22 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/10185/1
--
To view, visit http://gerrit.cloudera.org:8080/10185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke