[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 2: Code-Review+2 Carrying over Hao's +2 from PS1 -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 15:55:20 + Gerrit-HasComments: No
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory This patch fixes a flakiness in the TestCompletedOpsHistory scenario. The flakiness is a test-only issue which became apparent as a result of the recent changes introduced into the MaintenanceManager with 9e4664d44 changelist. In essence, with finer granularity of locking in the scoped cleanup of the MaintenanceManager::LaunchOp() method, the test thread calling MaintenanceManager::GetMaintenanceManagerStatusDump() has a slight chance of acquiring 'completed_ops_lock_' ahead of the thread executing the code in the LaunchOp()'s scoped cleanup. This patch wraps the related code into ASSERT_EVENTUALLY to resolve test-only race condition mentioned above. I verified that this patch fixes the issue by running the test scenario multiple times under dist-test (RELEASE build). Before: 2 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611806979.74192 After : 0 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611809676.95320 Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Reviewed-on: http://gerrit.cloudera.org:8080/16991 Tested-by: Alexey Serbin Reviewed-by: Alexey Serbin --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 21 insertions(+), 13 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 2: Verified+1 unrelated test failure in TestKuduClient.readYourWrites: testReadYourWritesSyncClosestReplica(org.apache.kudu.client.TestKuduClient) java.util.concurrent.ExecutionException: java.lang.AssertionError at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at org.apache.kudu.client.TestKuduClient.readYourWrites(TestKuduClient.java:1259) at org.apache.kudu.client.TestKuduClient.testReadYourWritesSyncClosestReplica(TestKuduClient.java:1167) -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 15:54:58 + Gerrit-HasComments: No
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16991/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16991/1/src/kudu/util/maintenance_manager-test.cc@587 PS1, Line 587: information > nit: information. Done -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 08:20:07 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16991 to look at the new patch set (#2). Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory This patch fixes a flakiness in the TestCompletedOpsHistory scenario. The flakiness is a test-only issue which became apparent as a result of the recent changes introduced into the MaintenanceManager with 9e4664d44 changelist. In essence, with finer granularity of locking in the scoped cleanup of the MaintenanceManager::LaunchOp() method, the test thread calling MaintenanceManager::GetMaintenanceManagerStatusDump() has a slight chance of acquiring 'completed_ops_lock_' ahead of the thread executing the code in the LaunchOp()'s scoped cleanup. This patch wraps the related code into ASSERT_EVENTUALLY to resolve test-only race condition mentioned above. I verified that this patch fixes the issue by running the test scenario multiple times under dist-test (RELEASE build). Before: 2 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611806979.74192 After : 0 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611809676.95320 Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 21 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/16991/2 -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16991/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16991/1/src/kudu/util/maintenance_manager-test.cc@587 PS1, Line 587: information nit: information. -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 07:18:19 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 1: Verified+1 Unrelated failure in RollingRestartArgs/RollingRestartITest.TestWorkloads/3 -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 07:02:10 + Gerrit-HasComments: No
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16991 Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory This patch fixes a flakiness in the TestCompletedOpsHistory scenario. The flakiness is a test-only issue which became apparent as result of the recent changes introduced into the MaintenanceManager with 9e4664d44 changelist. In essence, with the finer granularity of locking in the scoped cleanup of the MaintenanceManager::LaunchOp() method, the test thread calling MaintenanceManager::GetMaintenanceManagerStatusDump() have non-zero chances of acquiring 'completed_ops_lock_' ahead of the thread executing the code in the LaunchOp()'s scoped cleanup. This patch wraps the related code into ASSERT_EVENTUALLY to resolve test-only race condition mentioned above. I verified this fix addresses the issue running the affected test scenario multiple times under dist-test for RELEASE build. Before: 2 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611806979.74192 After : 0 out of 256 runs failed http://dist-test.cloudera.org//job?job_id=aserbin.1611809676.95320 Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 20 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/16991/1 -- To view, visit http://gerrit.cloudera.org:8080/16991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I760287b3ed4d50e32d2f9257e5390fdf8fa8f288 Gerrit-Change-Number: 16991 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
