[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. KUDU-3265 txn-related options to 'kudu perf loadgen' This patch adds the following txn-related options to the 'kudu perf loadgen' tool: (1) --txn_start (2) --txn_commit (3) --txn_rollback With those, it's possible to insert rows into the table in the scope of a multi-row transaction, and then (1) leave the transaction as is, or (2) commit the transaction, or (3) rollback the transaction explicitly. Semantically, specifying --txn_commit or --txn_rollback implies setting --txn_start as well. This patch partially addresses KUDU-3265. A follow-up patch will add functionality to write and read transactional tokens in serialized form, so the newly introduced --txn_start option starts making more sense. With that, it will be possible to start a new multi-row transaction in one session of the kudu CLI tool, and then continue adding more rows in another session of the kudu CLI tool, passing around transactional token. Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Reviewed-on: http://gerrit.cloudera.org:8080/17526 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_perf.cc 2 files changed, 262 insertions(+), 28 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17526/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17526/4/src/kudu/tools/kudu-tool-test.cc@2625 PS4, Line 2625: 12 Good call. -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jun 2021 23:27:18 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17526/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17526/3/src/kudu/tools/kudu-tool-test.cc@2737 PS3, Line 2737: > nit: would it make sense to maybe run `txn list` to check the status of tra Done -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jun 2021 22:55:26 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17526 to look at the new patch set (#4). Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. KUDU-3265 txn-related options to 'kudu perf loadgen' This patch adds the following txn-related options to the 'kudu perf loadgen' tool: (1) --txn_start (2) --txn_commit (3) --txn_rollback With those, it's possible to insert rows into the table in the scope of a multi-row transaction, and then (1) leave the transaction as is, or (2) commit the transaction, or (3) rollback the transaction explicitly. Semantically, specifying --txn_commit or --txn_rollback implies setting --txn_start as well. This patch partially addresses KUDU-3265. A follow-up patch will add functionality to write and read transactional tokens in serialized form, so the newly introduced --txn_start option starts making more sense. With that, it will be possible to start a new multi-row transaction in one session of the kudu CLI tool, and then continue adding more rows in another session of the kudu CLI tool, passing around transactional token. Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_perf.cc 2 files changed, 262 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17526/4 -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 3: Code-Review+2 (1 comment) It's not necessary, but if there is time to get this into the 1.15 release, that'd be great. CC Bankim since he's release manager. http://gerrit.cloudera.org:8080/#/c/17526/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17526/3/src/kudu/tools/kudu-tool-test.cc@2737 PS3, Line 2737: } nit: would it make sense to maybe run `txn list` to check the status of transactions in the cluster after this test? -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jun 2021 22:08:05 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 2: > (1 comment) > > +1 for the approach. Thank you for the feedback! -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jun 2021 02:05:58 + Gerrit-HasComments: No
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17526/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17526/2//COMMIT_MSG@22 PS2, Line 22: A follow-up patch will add : functionality to write and read transactional tokens in serialized form, > Would it instead make sense to allow users to supply the txn ID, and print Good point. I guess having both txnID and txnToken available here would not hurt: at least other tools report information on transactions using txnID. -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jun 2021 02:05:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17526 to look at the new patch set (#3). Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. KUDU-3265 txn-related options to 'kudu perf loadgen' This patch adds the following txn-related options to the 'kudu perf loadgen' tool: (1) --txn_start (2) --txn_commit (3) --txn_rollback With those, it's possible to insert rows into the table in the scope of a multi-row transaction, and then (1) leave the transaction as is, or (2) commit the transaction, or (3) rollback the transaction explicitly. Semantically, specifying --txn_commit or --txn_rollback implies setting --txn_start as well. This patch partially addresses KUDU-3265. A follow-up patch will add functionality to write and read transactional tokens in serialized form, so the newly introduced --txn_start option starts making more sense. With that, it will be possible to start a new multi-row transaction in one session of the kudu CLI tool, and then continue adding more rows in another session of the kudu CLI tool, passing around transactional token. Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_perf.cc 2 files changed, 231 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/17526/3 -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
