[kudu-CR] WIP: Add basic Hive MetaStore client

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: WIP: Add basic Hive MetaStore client
..


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/hms/hive_metastore-test.cc
File src/kudu/hms/hive_metastore-test.cc:

Line 29: #include "kudu/hms/mini_hms.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done


http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/hms/hive_metastore.cc
File src/kudu/hms/hive_metastore.cc:

Line 87:   HMS_RET_NOT_OK(client_.create_database(db), "create Hive MetaStore 
database");
> warning: passing result of std::move() as a const reference argument; no mo
Done


http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

Line 50: 
> warning: using decl 'vector' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

Line 768:   break;
> warning: do not use 'else' after 'break' [readability-else-after-return]
I hate this rule.


Line 772: }
> warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o
Done


http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/util/subprocess.h
File src/kudu/util/subprocess.h:

Line 201: Status GetExecutablePath(const std::string& binary,
> warning: function 'kudu::GetExecutablePath' has a definition with different
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] WIP: Add basic Hive MetaStore client

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7053

to look at the new patch set (#3).

Change subject: WIP: Add basic Hive MetaStore client
..

WIP: Add basic Hive MetaStore client

This is a work-in-progress patch to create a basic HiveMetastore client.

- Thrift has been added as a dependency, and a mechanism for performing
  Thrift codegen at compile time has been added (see FindThrift.cmake,
  based on FindProtobuf.cmake)
- Hive and Hadoop have been added to thirdparty as test-only dependency.
- A Hive MetaStore external mini server is included for testing. See
  mini_hms.[h|cc].

WIP because it's not yet expected to work with dist-test (Hive and
Hadoop artifacts need to be distributed).

Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
---
M CMakeLists.txt
M build-support/dist_test.py
A cmake_modules/FindJavaHome.cmake
A cmake_modules/FindThrift.cmake
A src/kudu/hms/CMakeLists.txt
A src/kudu/hms/hive_metastore-test.cc
A src/kudu/hms/hive_metastore.cc
A src/kudu/hms/hive_metastore.h
A src/kudu/hms/hive_metastore.thrift
A src/kudu/hms/mini_hms-test.cc
A src/kudu/hms/mini_hms.cc
A src/kudu/hms/mini_hms.h
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/test/mini_kdc.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M src/kudu/util/test_util.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
21 files changed, 2,157 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/7053/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] WIP: Add basic Hive MetaStore client

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7053

to look at the new patch set (#2).

Change subject: WIP: Add basic Hive MetaStore client
..

WIP: Add basic Hive MetaStore client

This is a work-in-progress patch to create a basic HiveMetastore client.

- Thrift has been added as a dependency, and a mechanism for performing
  Thrift codegen at compile time has been added (see FindThrift.cmake,
  based on FindProtobuf.cmake)
- Hive and Hadoop have been added to thirdparty as test-only dependency.
- A Hive MetaStore external mini server is included for testing. See
  mini_hms.[h|cc].

WIP because it's not yet expected to work with dist-test (Hive and
Hadoop artifacts need to be distributed).

Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
---
M CMakeLists.txt
A cmake_modules/FindJavaHome.cmake
A cmake_modules/FindThrift.cmake
A src/kudu/hms/CMakeLists.txt
A src/kudu/hms/hive_metastore-test.cc
A src/kudu/hms/hive_metastore.cc
A src/kudu/hms/hive_metastore.h
A src/kudu/hms/hive_metastore.thrift
A src/kudu/hms/mini_hms-test.cc
A src/kudu/hms/mini_hms.cc
A src/kudu/hms/mini_hms.h
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/test/mini_kdc.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M src/kudu/util/test_util.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
20 files changed, 2,158 insertions(+), 103 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/7053/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] WIP: Add basic Hive MetaStore client

[Dan Burkert (Code Review)]

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7053

Change subject: WIP: Add basic Hive MetaStore client
..

WIP: Add basic Hive MetaStore client

This is a work-in-progress patch to create a basic HiveMetastore client.

- Thrift has been added as a dependency, and a mechanism for performing
  Thrift codegen at compile time has been added (see FindThrift.cmake,
  based on FindProtobuf.cmake)
- Hive and Hadoop have been added to thirdparty as test-only dependency.
- A Hive MetaStore external mini server is included for testing. See
  mini_hms.[h|cc].

WIP because it's not yet expected to work with TSAN (thrift needs to be
built in TSAN mode), or dist-test (Hive and Hadoop artifacts need to be
distributed).

Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
---
M CMakeLists.txt
A cmake_modules/FindJavaHome.cmake
A cmake_modules/FindThrift.cmake
A src/kudu/hms/CMakeLists.txt
A src/kudu/hms/hive_metastore-test.cc
A src/kudu/hms/hive_metastore.cc
A src/kudu/hms/hive_metastore.h
A src/kudu/hms/hive_metastore.thrift
A src/kudu/hms/mini_hms-test.cc
A src/kudu/hms/mini_hms.cc
A src/kudu/hms/mini_hms.h
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
15 files changed, 2,127 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/7053/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert