[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Jean-Daniel Cryans has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Web UI: switch /maintenance-manager endpoint to mustache This cherry-picks just the changes to switch the /maintenance-manager endpoint to use mustache by Sam Okrent in https://gerrit.cloudera.org/#/c/7570/, with the aim of making it easier to review the swimlane-specific changes. Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Reviewed-on: http://gerrit.cloudera.org:8080/7607 Tested-by: Kudu Jenkins Reviewed-by: Todd LipconReviewed-by: Jean-Daniel Cryans --- M src/kudu/tserver/tserver-path-handlers.cc M src/kudu/tserver/tserver-path-handlers.h M src/kudu/util/easy_json.cc A www/maintenance-manager.mustache 4 files changed, 119 insertions(+), 47 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Todd Lipcon: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Todd Lipcon has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Dan Burkert has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7607/1//COMMIT_MSG Commit Message: Line 12: changes. > Worth saying that this is Sam's code? Done -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7607 to look at the new patch set (#2). Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Web UI: switch /maintenance-manager endpoint to mustache This cherry-picks just the changes to switch the /maintenance-manager endpoint to use mustache by Sam Okrent in https://gerrit.cloudera.org/#/c/7570/, with the aim of making it easier to review the swimlane-specific changes. Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 --- M src/kudu/tserver/tserver-path-handlers.cc M src/kudu/tserver/tserver-path-handlers.h M src/kudu/util/easy_json.cc A www/maintenance-manager.mustache 4 files changed, 119 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/7607/2 -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Jean-Daniel Cryans has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7607/1//COMMIT_MSG Commit Message: Line 12: changes. Worth saying that this is Sam's code? -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache
Hello Jean-Daniel Cryans, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7607 to review the following change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Web UI: switch /maintenance-manager endpoint to mustache This cherry-picks just the changes to switch the /maintenance-manager endpoint to use mustache from https://gerrit.cloudera.org/#/c/7570/, with the aim of making it easier to review the swimlane-specific changes. Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 --- M src/kudu/tserver/tserver-path-handlers.cc M src/kudu/tserver/tserver-path-handlers.h M src/kudu/util/easy_json.cc A www/maintenance-manager.mustache 4 files changed, 119 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/7607/1 -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf331f5d789893171608bac4d970db7680e0fcc4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Jean-Daniel Cryans