[kudu-CR] consensus: Don't replay config changes
Todd Lipcon has submitted this change and it was merged. Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a config change operation, so we will now simply check those invariants during tablet bootstrap. This patch removes plumbing of ConsensusMetadataManager into TabletBootstrap, since it is not needed there, and instead simply passes in the previously-committed raft config from the consensus metadata in order to check for correctness. Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Reviewed-on: http://gerrit.cloudera.org:8080/7614 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon--- M src/kudu/consensus/consensus_meta_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tserver/ts_tablet_manager.cc 6 files changed, 55 insertions(+), 60 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: Don't replay config changes
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: Don't replay config changes
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#4). Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a config change operation, so we will now simply check those invariants during tablet bootstrap. This patch removes plumbing of ConsensusMetadataManager into TabletBootstrap, since it is not needed there, and instead simply passes in the previously-committed raft config from the consensus metadata in order to check for correctness. Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 --- M src/kudu/consensus/consensus_meta_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tserver/ts_tablet_manager.cc 6 files changed, 55 insertions(+), 60 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7614/4 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: Don't replay config changes
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#3). Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a config change operation, so we will now simply check those invariants during tablet bootstrap. This patch removes plumbing of ConsensusMetadataManager into TabletBootstrap, since it is not needed there, and instead simply passes in the previously-committed raft config from the consensus metadata in order to check for correctness. Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 --- M src/kudu/consensus/consensus_meta_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tserver/ts_tablet_manager.cc 6 files changed, 54 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7614/3 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: Don't replay config changes
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: Don't replay config changes
Mike Percy has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7614/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 81: using consensus::ChangeConfigRecordPB; > yea Done PS1, Line 1418: IllegalState > maybe Corruption is more appropriate Done -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] consensus: Don't replay config changes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#2). Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a config change operation, so we will now simply check those invariants during tablet bootstrap. This patch removes plumbing of ConsensusMetadataManager into TabletBootstrap, since it is not needed there, and instead simply passes in the previously-committed raft config from the consensus metadata in order to check for correctness. Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 --- M src/kudu/consensus/consensus_meta_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tserver/ts_tablet_manager.cc 6 files changed, 54 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7614/2 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: Don't replay config changes
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7614/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 81: using consensus::ChangeConfigRecordPB; > warning: using decl 'ChangeConfigRecordPB' is unused [misc-unused-using-dec yea PS1, Line 1418: IllegalState maybe Corruption is more appropriate -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] consensus: Don't replay config changes
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/7614 Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a config change operation, so we will now simply check those invariants during tablet bootstrap. This patch removes plumbing of ConsensusMetadataManager into TabletBootstrap, since it is not needed there, and instead simply passes in the previously-committed raft config from the consensus metadata in order to check for correctness. Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 --- M src/kudu/consensus/consensus_meta_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tserver/ts_tablet_manager.cc 6 files changed, 54 insertions(+), 58 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/7614/1 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id62bf96b21560b2ef5838415e52aeb3720875e62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy