[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: master: tag master_addresses as stable
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: master: tag master_addresses as stable
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3212/

-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Adar Dembo (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4298

to look at the new patch set (#2).

Change subject: master: tag master_addresses as stable
..

master: tag master_addresses as stable

Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
---
M src/kudu/master/master_options.cc
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/4298/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] master: tag master addresses as stable

2016-09-02 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: master: tag master_addresses as stable
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4298/1/src/kudu/master/master_options.cc
File src/kudu/master/master_options.cc:

PS1, Line 31: in this Raft configuration
> May be, replace 'in this Raft configuration' with 'in this cluster'?
OK, will replace with "in this cluster" as Alexey suggested.


-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] master: tag master addresses as stable

2016-09-01 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: master: tag master_addresses as stable
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4298/1/src/kudu/master/master_options.cc
File src/kudu/master/master_options.cc:

PS1, Line 31: Raft configuration
I don't think we should leak implementation details (i.e mention raft) into the 
user-facing configuration documentation, at least not in the first sentence of 
the description.


-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] master: tag master addresses as stable

2016-09-01 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: master: tag master_addresses as stable
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3203/

-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master: tag master addresses as stable

2016-09-01 Thread Adar Dembo (Code Review) 
Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4298

to review the following change.

Change subject: master: tag master_addresses as stable
..

master: tag master_addresses as stable

Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
---
M src/kudu/master/master_options.cc
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/4298/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3d2071cab88a2aa25ce171e5b4b3f98204dd499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon