[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-07 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


master_rpc: pass back more details from ConnectToCluster

This plumbs back the ConnectToMasterResponsePB from the ConnectToCluster
RPC. This brings us one step closer to inserting the CA cert into the
TlsContext and passing the token somewhere useful.

Along the way, I switched to std::function instead of gutil Callback
since it allows the slightly easier lambda syntax.

No new tests here since all the existing client tests cover this code
path.

Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Reviewed-on: http://gerrit.cloudera.org:8080/5892
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/integration-tests/external_mini_cluster.cc
5 files changed, 63 insertions(+), 56 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-07 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-06 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-06 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 5: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-03 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-03 Thread Todd Lipcon (Code Review) 
Hello Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5892

to look at the new patch set (#2).

Change subject: master_rpc: pass back more details from ConnectToCluster
..

master_rpc: pass back more details from ConnectToCluster

This plumbs back the ConnectToMasterResponsePB from the ConnectToCluster
RPC. This brings us one step closer to inserting the CA cert into the
TlsContext and passing the token somewhere useful.

Along the way, I switched to std::function instead of gutil Callback
since it allows the slightly easier lambda syntax.

No new tests here since all the existing client tests cover this code
path.

Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/integration-tests/external_mini_cluster.cc
5 files changed, 63 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/5892/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-03 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

Line 606: const master::ConnectToMasterResponsePB& connect_response) {
> warning: parameter 'connect_response' is unused [misc-unused-parameters]
Done


Line 607:   Status new_status = status;
> warning: local copy 'new_status' of the variable 'status' is never modified
Done


http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/client/master_rpc.cc
File src/kudu/client/master_rpc.cc:

Line 273: user_cb_(status, {}, {});
> Interesting. Didn't know an empty initializer list could be used to call th
yea, more convenient than typing out the class name.


http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/client/master_rpc.h
File src/kudu/client/master_rpc.h:

PS1, Line 119:   // The index of the master that was determined to be the 
leader.
 :   // -1 indicates no leader found.
> Index in addrs_ and responses_? May want to make that explicit.
Done


http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/integration-tests/external_mini_cluster.cc
File src/kudu/integration-tests/external_mini_cluster.cc:

PS1, Line 476: const Sockaddr& leader_master,
 : const master::ConnectToMasterResponsePB& resp) {
> Nit: indentation here?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-02 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..


Patch Set 1:

(3 comments)

Callback chains make my brain hurt...

http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/client/master_rpc.cc
File src/kudu/client/master_rpc.cc:

Line 273: user_cb_(status, {}, {});
Interesting. Didn't know an empty initializer list could be used to call the 
default constructor of a "non-container" type.


http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/client/master_rpc.h
File src/kudu/client/master_rpc.h:

PS1, Line 119:   // The index of the master that was determined to be the 
leader.
 :   // -1 indicates no leader found.
Index in addrs_ and responses_? May want to make that explicit.


http://gerrit.cloudera.org:8080/#/c/5892/1/src/kudu/integration-tests/external_mini_cluster.cc
File src/kudu/integration-tests/external_mini_cluster.cc:

PS1, Line 476: const Sockaddr& leader_master,
 : const master::ConnectToMasterResponsePB& resp) {
Nit: indentation here?


-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] master rpc: pass back more details from ConnectToCluster

2017-02-02 Thread Todd Lipcon (Code Review) 
Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/5892

to review the following change.

Change subject: master_rpc: pass back more details from ConnectToCluster
..

master_rpc: pass back more details from ConnectToCluster

This plumbs back the ConnectToMasterResponsePB from the ConnectToCluster
RPC. This brings us one step closer to inserting the CA cert into the
TlsContext and passing the token somewhere useful.

Along the way, I switched to std::function instead of gutil Callback
since it allows the slightly easier lambda syntax.

Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/integration-tests/external_mini_cluster.cc
5 files changed, 58 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/5892/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b5056c9f31237249516a2e7ae68d641c9f6bd02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert