[kudu-CR] rowblock: add copying functionality
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a function that enables copying of row data between RowBlocks. It's a building block for the "whole block copy" MergeIterator optimization, wherein part of a (or an entire) sub-iterator RowBlock is copied to the client's RowBlock. Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Reviewed-on: http://gerrit.cloudera.org:8080/13008 Reviewed-by: Mike Percy Tested-by: Adar Dembo --- M src/kudu/common/CMakeLists.txt M src/kudu/common/columnblock-test.cc A src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 262 insertions(+), 8 deletions(-) Approvals: Mike Percy: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 5: Verified+1 Overriding Jenkins, known Java test flakes. -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 17 Apr 2019 21:01:39 + Gerrit-HasComments: No
[kudu-CR] rowblock: add copying functionality
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 17 Apr 2019 01:59:46 + Gerrit-HasComments: No
[kudu-CR] rowblock: add copying functionality
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13008/4/src/kudu/common/columnblock.cc File src/kudu/common/columnblock.cc: http://gerrit.cloudera.org:8080/#/c/13008/4/src/kudu/common/columnblock.cc@40 PS4, Line 40: cell_idx)) > Can we document this in the header file as part of the contract of this met Agreed, and done. -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 17 Apr 2019 00:59:16 + Gerrit-HasComments: Yes
[kudu-CR] rowblock: add copying functionality
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#5). Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a function that enables copying of row data between RowBlocks. It's a building block for the "whole block copy" MergeIterator optimization, wherein part of a (or an entire) sub-iterator RowBlock is copied to the client's RowBlock. Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 --- M src/kudu/common/CMakeLists.txt M src/kudu/common/columnblock-test.cc A src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 262 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13008/5 -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#4). Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a function that enables copying of row data between RowBlocks. It's a building block for the "whole block copy" MergeIterator optimization, wherein part of a (or an entire) sub-iterator RowBlock is copied to the client's RowBlock. Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 --- M src/kudu/common/CMakeLists.txt M src/kudu/common/columnblock-test.cc A src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 262 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13008/4 -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 3: Verified+1 Overriding Jenkins, known Java flakes. -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 15 Apr 2019 04:45:09 + Gerrit-HasComments: No
[kudu-CR] rowblock: add copying functionality
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#3). Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a function that enables copying of row data between RowBlocks. It's a building block for the "whole block copy" MergeIterator optimization, wherein part of a (or an entire) sub-iterator RowBlock is copied to the client's RowBlock. Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 --- M src/kudu/common/CMakeLists.txt M src/kudu/common/columnblock-test.cc A src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 262 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13008/3 -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] rowblock: add copying functionality
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 2: Verified+1 Overriding Jenkins, hit KUDU-2059. -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sun, 14 Apr 2019 18:01:41 + Gerrit-HasComments: No
[kudu-CR] rowblock: add copying functionality
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13008 to review the following change. Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a function that enables copying of row data between RowBlocks. It's a building block for the "whole block copy" MergeIterator optimization, wherein part of a (or an entire) sub-iterator RowBlock is copied to the client's RowBlock. Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 --- M src/kudu/common/CMakeLists.txt M src/kudu/common/columnblock-test.cc A src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 262 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13008/1 -- To view, visit http://gerrit.cloudera.org:8080/13008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I735796f11e3a388ffc66e3d92f8c2097cdec3a91 Gerrit-Change-Number: 13008 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
