[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8391 )

Change subject: thirdparty: treat cc the same as gcc when building boost
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Gerrit-Change-Number: 8391
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 26 Oct 2017 20:39:39 +
Gerrit-HasComments: No


[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8391 )

Change subject: thirdparty: treat cc the same as gcc when building boost
..

thirdparty: treat cc the same as gcc when building boost

Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Reviewed-on: http://gerrit.cloudera.org:8080/8391
Tested-by: Adar Dembo 
Reviewed-by: Todd Lipcon 
---
M thirdparty/build-definitions.sh
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Gerrit-Change-Number: 8391
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8391 )

Change subject: thirdparty: treat cc the same as gcc when building boost
..


Patch Set 1: Verified+1

Overriding Jenkins, the failure was a strange one in client_samples-test, but 
I'm fairly confident it's unrelated to this patch.


--
To view, visit http://gerrit.cloudera.org:8080/8391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Gerrit-Change-Number: 8391
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 26 Oct 2017 01:10:56 +
Gerrit-HasComments: No


[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-25 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/8391 )

Change subject: thirdparty: treat cc the same as gcc when building boost
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Gerrit-Change-Number: 8391
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-25 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8391

to review the following change.


Change subject: thirdparty: treat cc the same as gcc when building boost
..

thirdparty: treat cc the same as gcc when building boost

Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
---
M thirdparty/build-definitions.sh
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/8391/1
--
To view, visit http://gerrit.cloudera.org:8080/8391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c26723b2bcbcba524aad441e39b2d3fbe580079
Gerrit-Change-Number: 8391
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon