[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21192 ) Change subject: [thirdparty] upgrade bison up to 3.8.2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558 Gerrit-Change-Number: 21192 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Mar 2024 16:32:11 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21192 ) Change subject: [thirdparty] upgrade bison up to 3.8.2 .. [thirdparty] upgrade bison up to 3.8.2 This patch updates the bison library in Kudu's 3rd-party from 3.5.4 to 3.8.2 version. The rationale behind the upgrade was getting the following build error on macOS when building with clang 15.0.0 which comes with Xcode 15.3: kudu/thirdparty/src/bison-3.5.4/lib/obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types] __attribute_noreturn__ void (*obstack_alloc_failed_handler) (void) ^ 1 error generated. make[2]: *** [lib/libbison_a-obstack.o] Error 1 Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558 Reviewed-on: http://gerrit.cloudera.org:8080/21192 Tested-by: Alexey Serbin Reviewed-by: Abhishek Chennaka --- M thirdparty/vars.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558 Gerrit-Change-Number: 21192 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] fix building mustache with clang15 on macOS
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21196 ) Change subject: [thirdparty] fix building mustache with clang15 on macOS .. Patch Set 1: Code-Review+1 Does it make sense to add a TODO for the permanent fix or can we just rely on this commit message for permanent fix? -- To view, visit http://gerrit.cloudera.org:8080/21196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id97af5f7300b2ca2eef4edf33712fa6ec93daa96 Gerrit-Change-Number: 21196 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Mar 2024 16:35:54 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade boost up to 1.84.0
Hello Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21196
to look at the new patch set (#2).
Change subject: [thirdparty] upgrade boost up to 1.84.0
..
[thirdparty] upgrade boost up to 1.84.0
Upgrade Boost library up to 1.84.0 version. At least, this version
properly handles BOOST_NO_CXX98_FUNCTION_BASE macro in
boost/config/stdlib/libcpp.hpp, defining it with CLANG 15.
Otherwise, it would be necessary to add BOOST_NO_CXX98_FUNCTION_BASE
into CFLAGS and CXXFLAGS to avoid compilation errors like the below
at least when compiling with CLANG 15:
In file included from
thirdparty/installed/uninstrumented/include/boost/type_index/stl_type_index.hpp:47:
thirdparty/installed/uninstrumented/include/boost/container_hash/hash.hpp:131:33:
error: no template named 'unary_function' in namespace 'std'; did you mean
'__unary_function'?
struct hash_base : std::unary_function {};
~^~
__unary_function
This patch fixes compilation of the mustache library in the 3rd-party
with CLANG 15 which comes with Xcode 15.3 on macOS: std::unary_function
has been deprecated since C++11 and removed in C++17 [1], so it was just
a matter of time when C++ compilers started to strictly enforce
the C++17 standard.
[1] https://en.cppreference.com/w/cpp/utility/functional/unary_function
Change-Id: Id97af5f7300b2ca2eef4edf33712fa6ec93daa96
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/21196/2
--
To view, visit http://gerrit.cloudera.org:8080/21196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id97af5f7300b2ca2eef4edf33712fa6ec93daa96
Gerrit-Change-Number: 21196
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade boost up to 1.84.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21196 ) Change subject: [thirdparty] upgrade boost up to 1.84.0 .. Patch Set 2: > Does it make sense to add a TODO for the permanent fix or can we > just rely on this commit message for permanent fix? After looking closer at this macOS compilation issue, it turned out a proper fix is to upgrade the boost library to the version that properly defines the BOOST_NO_CXX98_FUNCTION_BASE macro depending on the compiler version. I decided to upgrade up to 1.84.0 version -- the very recent version of the boost library as of March 2024. -- To view, visit http://gerrit.cloudera.org:8080/21196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id97af5f7300b2ca2eef4edf33712fa6ec93daa96 Gerrit-Change-Number: 21196 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 26 Mar 2024 01:11:03 + Gerrit-HasComments: No
[kudu-CR] [cmake modules] recognize linker coming with LLVM 15
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21202 Change subject: [cmake_modules] recognize linker coming with LLVM 15 .. [cmake_modules] recognize linker coming with LLVM 15 This patch updates the GET_LINKER_VERSION cmake's function to work with ld linker that comes with LLVM 15 as a part of Xcode 15.3 on macOS. Without this patch, running cmake in the build directory on macOS using Xcode 15.3 would fail with an error like below: -- Checking linker version when not specifying any flags CMake Error at cmake_modules/KuduLinker.cmake:87 (message): Could not find a suitable linker Change-Id: If120b281a44fa7a9b9976d078c34f36ab942f089 --- M cmake_modules/KuduLinker.cmake 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/21202/1 -- To view, visit http://gerrit.cloudera.org:8080/21202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If120b281a44fa7a9b9976d078c34f36ab942f089 Gerrit-Change-Number: 21202 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
