[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation

[Ambreen Kazi (Code Review)]

Ambreen Kazi has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5837

Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
..

KUDU-1854 Fixed broken links to Cloudera's Kudu documentation

Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
---
M docs/administration.adoc
M docs/configuration.adoc
M docs/installation.adoc
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5837/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
..


Patch Set 1:

> Looks good. What about the various installation links to
 > archive.cloudera.com in installation.adoc? Do you have more
 > up-to-date ones to replace there? It seems they're still pointing
 > to /beta/ and they don't have 1.2 packages/parcels.

Ah, let me fix those.

-- 
To view, visit http://gerrit.cloudera.org:8080/5837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

[Ambreen Kazi (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5837

to look at the new patch set (#3).

Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation 
and archive.cloudera
..

KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and archive.cloudera

With the 1.2 release, Cloudera's Kudu documentation was moved
out of the /betas/ folder. This broke any existing links we had to
the Cloudera docs. I made a pass through the docs and fixed the links.

The Kudu packages on archive.cloudera were also moved out of the /betas
directory. Those links were updated as well.

Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
---
M docs/administration.adoc
M docs/configuration.adoc
M docs/installation.adoc
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5837/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

[Ambreen Kazi (Code Review)]

Ambreen Kazi has abandoned this change.

Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation 
and archive.cloudera
..


Abandoned

Did not notice a new changeID. The changes will be added to an existing gerrit 
- Change 5837.

-- 
To view, visit http://gerrit.cloudera.org:8080/5838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5e4abb1f410209d8e8e98493502d5417c61544db
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

[Ambreen Kazi (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5837

to look at the new patch set (#4).

Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation 
and archive.cloudera
..

KUDU-1854 Fixed broken links to Cloudera's Kudu documentation
and archive.cloudera

With the 1.2 release, Cloudera's Kudu documentation was moved
out of the /betas/ folder. This broke any existing links we had to
the Cloudera docs. I made a pass through the docs and fixed the links.

The Kudu packages on archive.cloudera were also moved out of the /betas
directory. Those links were updated as well.

Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
---
M docs/administration.adoc
M docs/configuration.adoc
M docs/installation.adoc
3 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5837/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic158ddd6a576e7a3680d0f69c326768b7b3e5049
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Initial draft of release notes and doc updates for 1.2

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: Initial draft of release notes and doc updates for 1.2
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5604/4/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 41: Redaction is enabled by default, but may be disabled by setting the new
Should this be added to the docs? Unresolved comment.


Line 78: // TODO(danburkert): this new flag is marked experimental, should we 
make it
Should this be added to the docs? Unresolved comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/5604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08326171dd2bf6097a7594b95adca946bb5922eb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: Update Impala docs for upcoming Impala 2.8 release
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5733/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

PS2, Line 158: Tables are divided into tablets which are each served by one or 
more tablet
 : servers. Ideally, tablets should split a table's data relatively 
equally. Kudu currently
 : has no mechanism for automatically (or manually) splitting a 
pre-existing tablet.
 : Until this feature has been implemented, *you must specify your 
partitioning when
 : creating a table*. When designing your table schema, consider 
primary keys that will allow you to
 : split your table into partitions which grow at similar rates. 
You can designate
 : partitions using a `PARTITION BY` clause when creating a table 
using Impala:
 : 
 : NOTE: Impala keywords, such as `group`, are enclosed by 
back-tick characters when
 : they are not used in their keyword sense.
This text has been duplicated in the Partitioning Tables section below.


PS2, Line 370: `DISTRIBUTE
 : BY HASH (id, sku)`.
old syntax - DISTRIBUTE BY


-- 
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43d18e8d92c52e5868e1d48b91351bca41b53f8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add admin workflow for recovering from disk failure

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: [docs] Add admin workflow for recovering from disk failure
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6606/1/docs/administration.adoc
File docs/administration.adoc:

PS1, Line 612: via
using


-- 
To view, visit http://gerrit.cloudera.org:8080/6606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6541bffc5e9546c523df610fd8c025dd05e403bf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add security guide

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: [docs] Add security guide
..


Patch Set 2:

(17 comments)

http://gerrit.cloudera.org:8080/#/c/6479/2/docs/security.adoc
File docs/security.adoc:

PS2, Line 33: a list of
: security features which are known deficiencies in the security 
capabilities.
a list of known deficiencies in Kudu's security capabilities.


PS2, Line 53: Secure clusters
: should
To secure a cluster, always ...


PS2, Line 65: is able to offer
1 word - offers


PS2, Line 77: limited to seven days of validi
rewrite - are only valid for seven days, so that even if a token were 
compromised, it ...


PS2, Line 80: is able to take
1 word - takes


PS2, Line 79: the users of
: Kudu
just 'users'


PS2, Line 81: needing to communicate
1 word - communicating


PS2, Line 81: ,
remove comma


PS2, Line 110: Secure clusters
 : should 
To secure a cluster, use ..


PS2, Line 117: may 
can


PS2, Line 120: `kudu tserver set_flag`
describe this in words rather than just the command.


PS2, Line 131: based on
using


Line 132: one for each of the two levels. Each access control list specifies a 
comma-separated
.. list 'either' specifies a comma ..


PS2, Line 138: A
lower case


PS2, Line 155: may
can


PS2, Line 158: such as `/metrics`
 : which may be relied upon by monitoring systems to gather metrics 
data.
such as `/metrics`. Monitoring systems rely on these endpoints to gather 
metrics data.


Line 166: will be redacted. This feature can be turned off using the `--redact` 
flag
by default?


-- 
To view, visit http://gerrit.cloudera.org:8080/6479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add security guide

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: [docs] Add security guide
..


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/6479/4/docs/security.adoc
File docs/security.adoc:

PS4, Line 31: will explain
describes


PS4, Line 66: requiring
: certificates be manually deployed on every node.
requiring you to manually deploy certificates on every node.


PS4, Line 168: turned off configuring the
 : `--redact` flag
by setting --redact to false?


PS4, Line 220: yet
Remove 'yet'.


PS4, Line 226: yet 
Remove.


PS4, Line 229:  yet
Remove'.


PS4, Line 242: The 
Remove 'the'


-- 
To view, visit http://gerrit.cloudera.org:8080/6479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] Add ksck section to admin guide common workflows

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: Add ksck section to admin guide common workflows
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6598/1/docs/administration.adoc
File docs/administration.adoc:

PS1, Line 579: flag
flags.


Line 580: checksum scan to specific tables or tablets, respectively.
This ending is abrupt. A sample command for checking integrity would help.


-- 
To view, visit http://gerrit.cloudera.org:8080/6598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9631337b113d2c67be0057f728c68f792e8a4fd6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add ksck section to admin guide common workflows

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: Add ksck section to admin guide common workflows
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6598/1/docs/administration.adoc
File docs/administration.adoc:

PS1, Line 579: scope
.. used to limit the scope of the ...


-- 
To view, visit http://gerrit.cloudera.org:8080/6598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9631337b113d2c67be0057f728c68f792e8a4fd6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Refresh and augment the known issues

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: [docs] Refresh and augment the known issues
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6699/2/docs/known_issues.adoc
File docs/known_issues.adoc:

PS2, Line 135: Supported
This seems out of place in the Known Issues doc - There is a requirements 
section at the top of the installation doc that already lists the supported 
OSs. The supported filesystems could be added there.


PS2, Line 168: == Spark
The Admin topic also has a list of limitations for Spark integration - could 
you take a look and make sure they're still applicable?

We should also maintain this information in 1 topic, rather than two. Perhaps 
move the content from the Admin topic to this one and just link back from the 
Admin topic to this section (or vice versa).

https://kudu.apache.org/docs/developing.html#_spark_integration_known_issues_and_limitations


PS2, Line 172: Impala
Same comment as Spark - Consider maintaining in 1 place rather than two.

https://kudu.apache.org/docs/kudu_impala_integration.html#_known_issues_and_limitations


-- 
To view, visit http://gerrit.cloudera.org:8080/6699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8e817a402f419aeb5ed9d700a8207ad9f91e4d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add security guide

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: [docs] Add security guide
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6479/2/docs/security.adoc
File docs/security.adoc:

Line 40: gaining access to Kudu, and securely identifies the connecting user for
user or service


PS2, Line 41: the purposes of authorization decisions
.. for authorization checks.


PS2, Line 127: Kudu internally
Internally, Kudu has ...


PS2, Line 128: may not
cannot


-- 
To view, visit http://gerrit.cloudera.org:8080/6479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [DOCS] KUDU-2051-Update Impala integration limitations

[Ambreen Kazi (Code Review)]

Ambreen Kazi has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7355

Change subject: [DOCS] KUDU-2051-Update Impala integration limitations
..

[DOCS] KUDU-2051-Update Impala integration limitations

- Impala's TIMESTAMP and Kudu's UNIXTIME_MACROS
from the list of limitations.

- Impala now pushes down NULL/NOT NULL to Kudu. Those were
removed from the list.

Change-Id: I884b5c6905bc7371e7696133c53ba0df8594e945
---
M docs/kudu_impala_integration.adoc
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7355/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I884b5c6905bc7371e7696133c53ba0df8594e945
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi