[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Mike Percy (Code Review) 
Mike Percy has submitted this change and it was merged.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..


Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

I looped this test 500x on ASAN and 500x on TSAN and saw no failures.

Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Reviewed-on: http://gerrit.cloudera.org:8080/3528
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
2 files changed, 41 insertions(+), 20 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2120/

-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Mike Percy (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3528

to look at the new patch set (#2).

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..

Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

I looped this test 500x on ASAN and 500x on TSAN and saw no failures.

Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
2 files changed, 41 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3528/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-28 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3528/1/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:

Line 555:   // TODO: Re-elect TS-1
What does this mean in the context of this patch?


-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2090/

-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-28 Thread Mike Percy (Code Review) 
Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3528

to review the following change.

Change subject: Fix flaky 
DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
..

Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

I looped this test 500x on ASAN and 500x on TSAN and saw no failures.

Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
2 files changed, 38 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3528/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Todd Lipcon