[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Specify guaranteed semantics of GetTableLocations RPC
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2b5b647e33c0ee8fc052192870f814eff8c178
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Specify guaranteed semantics of GetTableLocations RPC
..


Patch Set 1:

actually it's missing tests for a few of the guarantees, I'll add specific 
tests for those.

-- 
To view, visit http://gerrit.cloudera.org:8080/3240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2b5b647e33c0ee8fc052192870f814eff8c178
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Specify guaranteed semantics of GetTableLocations RPC
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 3093: StatusToPB(Status::ServiceUnavailable("Tablet not running"),
 :  resp->mutable_error()->mutable_status());
> BuildLocationsForTablet() can also return Status::NotFound for deleted tabl
no 'break' here?


-- 
To view, visit http://gerrit.cloudera.org:8080/3240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2b5b647e33c0ee8fc052192870f814eff8c178
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes