[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3619/6/CMakeLists.txt
File CMakeLists.txt:

Line 1000: # "make doxydocs" target
Sorry to be a buzz kill, but can we just make this target "doxygen" instead of 
"doxydocs"?


Line 1015: COMMAND make all install DESTDIR=${DOXY_CLIENT_DESTDIR}
Can this be made to work with Ninja was well? I think you just need to replace 
make with ${CMAKE_MAKE_PROGRAM}


http://gerrit.cloudera.org:8080/#/c/3619/6/docs/.gitignore
File docs/.gitignore:

Line 19
nit: spurious change


http://gerrit.cloudera.org:8080/#/c/3619/6/src/kudu/client/client.h
File src/kudu/client/client.h:

Line 28: #include 
This change isn't required for this patch, is it?


http://gerrit.cloudera.org:8080/#/c/3619/6/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

Line 262: if ! `which -s doxygen` && [ ! -d $DOXYGEN_DIR ]; then
The -s command-line flag is not available on GNU systems. You can do:

if ! which doxygen >/dev/null && [ ! -d "$DOXYGEN_DIR" ]; then


-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/2500/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-13 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3619/5/CMakeLists.txt
File CMakeLists.txt:

Line 963:   find_package(Doxygen REQUIRED)
> Sure, if doxygen is in the thirdparty tree then that's fine. Out of curiosi
On my MacBookPro if running 'make -j8':

real0m16.457s
user1m8.855s
sys 0m6.126s

Plus a 8 seconds to generate GNU makefiles out of cmakefiles.


-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Anonymous Coward (Code Review) 
Anonymous Coward #206 has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 5:

(1 comment)

Hi Alexey,

This is not a review, only testing my review subscription via this. Also 
pointing a typo I noticed in client.h.

~Dinesh.

http://gerrit.cloudera.org:8080/#/c/3619/5/src/kudu/client/client.h
File src/kudu/client/client.h:

PS5, Line 197: is
"returned." is omitted here.


-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward #206
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Alexey Serbin (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3619

to look at the new patch set (#5).

Change subject: client.h: doxygen comments for C++ API
..

client.h: doxygen comments for C++ API

To generate the Doxygen docs from client.h, run 'make doxydocs'.
Open $REPO_ROOT/docs/doxygen/html/index.html in your favorite browser
to see the generated documentation.  The 'docs' target generates
doxygen documentaion as well since it depends on the 'doxydocs' target.

Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
---
M CMakeLists.txt
A cmake_modules/FindDoxygen.cmake
M docs/.gitignore
A docs/support/doxygen/client.doxy
M src/kudu/client/client.h
5 files changed, 1,410 insertions(+), 717 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3619/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2331/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2330/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2329/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2321/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3619

to look at the new patch set (#2).

Change subject: client.h: doxygen comments for C++ API
..

client.h: doxygen comments for C++ API

To generate the Doxygen docs from client.h, run 'make doxydocs'.
Open $REPO_ROOT/docs/doxygen/html/index.html in your favorite browser
to see the generated documentation.  The 'docs' target generates
doxygen documentaion as well since it depends on the 'doxydocs' target.

Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
---
M CMakeLists.txt
M docs/.gitignore
A docs/support/doxygen/client.doxy
M src/kudu/client/client.h
4 files changed, 1,239 insertions(+), 717 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3619/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 1:

(1 comment)

> (3 comments)
 > 
 > Thank you for review, Mike!
 > 
 > The auto-generated docs are available at:
 > https://alexeyserbin.github.io/

I only looked briefly but noticed 2 things we probably want to change:

1. the Main page is blank
2. the includes are wrong. it says #include  but should say #include 


http://gerrit.cloudera.org:8080/#/c/3619/1/docs/.gitignore
File docs/.gitignore:

Line 19: doxygen/**
> The committed files are not covered by this pattern, actually.  This patter
Can we generate the doxygen files in a subdirectory of the same tree that we 
generate the other docs in?


-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client.h: doxygen comments for C++ API
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2311/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3619

Change subject: client.h: doxygen comments for C++ API
..

client.h: doxygen comments for C++ API

To generate the Doxygen docs from client.h, run 'make doxydocs' target.
Open $REPO_ROOT/docs/doxygen/html/index.html in your favorite browser
to see the generated documentation.

Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
---
M CMakeLists.txt
M docs/.gitignore
A docs/support/doxygen/client.doxy
M src/kudu/client/client.h
4 files changed, 3,581 insertions(+), 716 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3619/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin