[kudu-CR] consensus: Crash if we fail to append to the WAL

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged.

Change subject: consensus: Crash if we fail to append to the WAL
..


consensus: Crash if we fail to append to the WAL

Being unable to write to the WAL is a serious problem with complicated
consequences. Let's always crash when that happens.

This patch adds a fault injection test and a callback that simply
crashes on failure.

Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Reviewed-on: http://gerrit.cloudera.org:8080/3406
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
Reviewed-by: Adar Dembo 
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/util/status_callback.cc
M src/kudu/util/status_callback.h
9 files changed, 139 insertions(+), 9 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] consensus: Crash if we fail to append to the WAL

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: consensus: Crash if we fail to append to the WAL
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3406/3/src/kudu/util/status_callback.cc
File src/kudu/util/status_callback.cc:

Line 19: 
Nit: why the reorder? Doesn't "status" precede "status_callback"?


-- 
To view, visit http://gerrit.cloudera.org:8080/3406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] consensus: Crash if we fail to append to the WAL

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: consensus: Crash if we fail to append to the WAL
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1893/

-- 
To view, visit http://gerrit.cloudera.org:8080/3406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] consensus: Crash if we fail to append to the WAL

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: consensus: Crash if we fail to append to the WAL
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1868/

-- 
To view, visit http://gerrit.cloudera.org:8080/3406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No