[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG
Commit Message:

PS5, Line 13: It's still a mystery why the Java tests
Can't get a regression test in C++?


-- 
To view, visit http://gerrit.cloudera.org:8080/3309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change.

Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting 
for replicas
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change.

Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting 
for replicas
..


Patch Set 3:

Todd was also +2 on PS2.

-- 
To view, visit http://gerrit.cloudera.org:8080/3308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-08 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1469. Fix handling of fully-deduped requests after a 
leader change
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new patch set (#6).

Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..

KUDU-1473: fix some tablet lock usage in CatalogManager

This was probably due to the refactoring done in commit 59ff89d. Now that
we're releasing tablet write locks as early as possible, we need to
reacquire them (in read mode) for some operations.

The lock misuse reared its head most often in the Java test
TestKuduTable.testGetLocations, but could trigger in just about any test
that didn't wait for table creation to finish before accessing the table.
For example, CreateTableITest.TestCreateWhenMajorityOfReplicasFailCreation
was a little flaky too. The backtrace was always the same:

cow_object.h:82] Check failed: lock_.HasReaders() || lock_.HasWriteLock()
@ 0x7fecb643e37b  kudu::CowObject<>::state() at ??:0
@ 0x7fecb6422fe9  
kudu::master::CatalogManager::ProcessPendingAssignments() at ??:0
@ 0x7fecb6421d3a  kudu::master::CatalogManagerBgTasks::Run() at ??:0
@ 0x7fecb645c1f7  boost::_mfi::mf0<>::operator()() at ??:0
@ 0x7fecb645c15b  boost::_bi::list1<>::operator()<>() at ??:0
@ 0x7fecb645c104  boost::_bi::bind_t<>::operator()() at ??:0
@ 0x7fecb645bf2a  
boost::detail::function::void_function_obj_invoker0<>::invoke() at ??:0
@ 0x7fecb0b66d82  boost::function0<>::operator()() at ??:0
@ 0x7fecafba96c0  kudu::Thread::SuperviseThread() at ??:0
@   0x423faa  __tsan_thread_start_func at ??:0
@ 0x7fecb28459d1  start_thread at ??:0
@ 0x7fecacd108fd  clone at ??:0

Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 41 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/3309/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: [java client] Fix a race in TabletClient cleanup
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3340/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:

Line 186:   LOG.debug("rpcs_inflight is empty and this TabletClient is 
dead, will assume that whis " +
Use {} substitution instead of string concat.


-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [java client] Fix a race in TabletClient cleanup
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1785/

-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3340

to look at the new patch set (#2).

Change subject: [java client] Fix a race in TabletClient cleanup
..

[java client] Fix a race in TabletClient cleanup

Dan noticed some weird things going on after fixing 
TestAsyncKuduClient#testDisconnect,
we're either not handling some RPCs or doing it twice.

The reason is that we add to rpcs_inflight directly without caring for the 
state of
TabletClient (if it's connected or not). Later, we try to detect if we got 
disconnected
but there was no easy way to tell if our RPC was already retried for us or not.

This patch tries to make it clear whether the RPC at the end of 
TabletClient#sendRpc
is already handled or not: if the TabletClient is dead, and the rpcs_inflight 
list is
empty, then it got taken care of. If it's not empty, then it means the RPC 
needs to
be sent back to the AsyncKuduClient.

This patch fixes flakiness in the test mentioned above.

Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
---
M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
1 file changed, 32 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/3340/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change.

Change subject: [java client] Fix a race in TabletClient cleanup
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3340/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:

Line 186:   LOG.debug("rpcs_inflight is empty and this TabletClient is 
dead, will assume that whis " +
> Use {} substitution instead of string concat.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3340

Change subject: [java client] Fix a race in TabletClient cleanup
..

[java client] Fix a race in TabletClient cleanup

Dan noticed some weird things going on after fixing 
TestAsyncKuduClient#testDisconnect,
we're either not handling some RPCs or doing it twice.

The reason is that we add to rpcs_inflight directly without caring for the 
state of
TabletClient (if it's connected or not). Later, we try to detect if we got 
disconnected
but there was no easy way to tell if our RPC was already retried for us or not.

This patch tries to make it clear whether the RPC at the end of 
TabletClient#sendRpc
is already handled or not: if the TabletClient is dead, and the rpcs_inflight 
list is
empty, then it got taken care of. If it's not empty, then it means the RPC 
needs to
be sent back to the AsyncKuduClient.

This patch fixes flakiness in the test mentioned above.

Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
---
M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
1 file changed, 32 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/3340/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [java client] Fix a race in TabletClient cleanup
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1782/

-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Adar Dembo (Code Review) 
Hello Jean-Daniel Cryans,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/2887

to look at the new patch set (#11).

Change subject: KUDU-1353: remove per-tablet replica locations cache
..

KUDU-1353: remove per-tablet replica locations cache

This is the simpler alternative to rebuilding the caches on metadata load.
Instead of using the caches to retrieve tserver RPC addresses, we'll look
the addresses up on the spot using the TSDescriptor cache. The two caches
should be equally coherent, as both were populated as a result of the master
receiving TS heartbeats.

I've also done away with the concept of a 'stale' locations response. The
distinction can be real, but it's confusing, and more importantly, clients
never took advantage of it. And if we're going to persist TSDescriptor data
in master state as has been recently discussed, the distinction becomes even
less useful.

Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d
---
M 
java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java
M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
M src/kudu/master/master-test-util.h
M src/kudu/master/master.proto
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/tools/create-demo-table.cc
13 files changed, 174 insertions(+), 306 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/2887/11
-- 
To view, visit http://gerrit.cloudera.org:8080/2887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1353: remove per-tablet replica locations cache
..


Patch Set 11:

Build Started http://104.196.14.100/job/kudu-gerrit/1783/

-- 
To view, visit http://gerrit.cloudera.org:8080/2887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Update documentation and build helper script

2016-06-08 Thread Cenk Uyan (Code Review) 
Cenk Uyan has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3336

Change subject: Update documentation and build helper script
..

Update documentation and build helper script

Added 'unzip' pkg among dependencies for building kudu from source
on Centos 6.6 .
Removed dependency on `lsb_release` command required by
enable_devtoolset.sh (which requires redhat-lsb-core RPM package).

Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
---
M build-support/enable_devtoolset.sh
M docs/installation.adoc
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/3336/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan

[kudu-CR] Update documentation and build helper script

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Update documentation and build helper script
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1781/

-- 
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1788/

-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Remove the LocalConsensus implementation

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1794/

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-08 Thread Mike Percy (Code Review) 
Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3345

to review the following change.

Change subject: Add WaitUntilLeader() to Consensus interface
..

Add WaitUntilLeader() to Consensus interface

This is mostly useful for tests.

Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
---
M src/kudu/consensus/consensus.h
M src/kudu/consensus/local_consensus.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
4 files changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/3345/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Use RaftConsensus instead of LocalConsensus in tests
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1790/

-- 
To view, visit http://gerrit.cloudera.org:8080/3346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add WaitUntilLeader() to Consensus interface
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1789/

-- 
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-08 Thread Mike Percy (Code Review) 
Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3346

to review the following change.

Change subject: Use RaftConsensus instead of LocalConsensus in tests
..

Use RaftConsensus instead of LocalConsensus in tests

This paves the way to remove the LocalConsensus implementation.

Changes the following tests to use RaftConsensus:

* tablet_peer-test
* remote_bootstrap_client-test
* remote_bootstrap_session-test
* tablet_server-test
* ts_tablet_manager-test

Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
---
M src/kudu/tablet/tablet_peer-test.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/remote_bootstrap-test-base.h
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
9 files changed, 46 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/3346/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves

[kudu-CR] Always write last known addr into ConsensusMetadata

2016-06-08 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: Always write last_known_addr into ConsensusMetadata
..


Patch Set 1:

I'm actually not quite sure about this solution. It works for now but it may 
not work well for multi-homed master hosts. We don't really have a solution for 
that and we likely need to do more work on it as part of the HA master work.

-- 
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1398 CFile index blocks can store shortest separating 
prefix
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/1787/

-- 
To view, visit http://gerrit.cloudera.org:8080/3304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Will Berkeley (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3304

to look at the new patch set (#5).

Change subject: KUDU-1398 CFile index blocks can store shortest separating 
prefix
..

KUDU-1398 CFile index blocks can store shortest separating prefix

This changes the values stored as index keys to be a shortest key
between the first key of the data block and the last key of the previous
data block. However, this change does not apply to deltafiles, because
deltafiles expect to be able to decode an index key into a DeltaKey.

The way the change works is illustrated with the example from the JIRA,
extended:

Block 1: apple, banana, cardamom
Block 2: carrot, epazote, fennel
Block 3: fig, guava, kiwi

Before: ['apple' -> block 1, 'carrot' -> block 2, 'fig' -> block 3]

After: ['a' -> block 1, 'carr' -> block 2, 'fi' -> block 3]

Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315
---
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_encodings.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/gvint_block.cc
M src/kudu/cfile/gvint_block.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/rle_block.h
M src/kudu/tablet/deltafile.cc
20 files changed, 206 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3304/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1398 CFile index blocks can store shortest separating 
prefix
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/1786/

-- 
To view, visit http://gerrit.cloudera.org:8080/3304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No