[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread itholic 
Github user itholic commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
@vanzin hi vanzin, I'm very sorry to bother you. but it looks this PR isn't 
yet merged to master. could you take a look at it again when you available, 
please? ;D


---

[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread itholic 
Github user itholic commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
@vanzin hi veanzin, I'm very sorry to bother you. but it looks this PR  
isn't yet merged to master. could you check it again when you available, 
plesae? ;D


---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-16 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r225716038
  
--- Diff: 
thriftserver/server/src/main/resources/org/apache/livy/server/ui/static/js/thrift-sessions.js
 ---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+function loadThriftSessionsTable(sessions) {
+  $.each(sessions, function(index, session) {
+$("#thrift-sessions-table .sessions-table-body").append(
+  "" +
+tdWrap(session.sessionId) +
+tdWrap(uiLink("session/" + session.livySessionId, 
session.livySessionId)) +
+tdWrap(session.owner) +
+tdWrap(session.createdAt) +
+   ""
--- End diff --

nit: indentation seems off


---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-16 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r225715892
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import org.apache.livy.server.JsonServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+
+class ThriftJsonServlet(val basePath: String) extends JsonServlet {
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
--- End diff --

This isn't showing the time zone, so it can be confusing. I think it would 
be better to do this rendering client-side, and return something that it 
UTC-based in the JSON payload.

Similar in spirit to SPARK-16986.


---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-16 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r225715972
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import org.apache.livy.server.JsonServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+
+class ThriftJsonServlet(val basePath: String) extends JsonServlet {
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
+
+  case class SessionInfo(sessionId: String,
+livySessionId: String,
--- End diff --

nit: use the usual double-indentation for multi line args


---

[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread vanzin 
Github user vanzin commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
Merging to master.


---

[GitHub] incubator-livy pull request #123: [MINOR] There is some typo in PULL_REQUEST...

2018-10-16 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-livy/pull/123


---

[GitHub] incubator-livy issue #123: [MINOR] There is some typo in PULL_REQUEST_TEMPLA...

2018-10-16 Thread vanzin 
Github user vanzin commented on the issue:

https://github.com/apache/incubator-livy/pull/123
  
Merging.


---

[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
+1


---

[GitHub] incubator-livy issue #123: [MINOR] There is some typo in PULL_REQUEST_TEMPLA...

2018-10-16 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/incubator-livy/pull/123
  
+1


---

[GitHub] incubator-livy pull request #123: [MINOR] There is some typo in PULL_REQUEST...

2018-10-16 Thread itholic 
GitHub user itholic opened a pull request:

https://github.com/apache/incubator-livy/pull/123

[MINOR] There is some typo in PULL_REQUEST_TEMPLATE

## What changes were proposed in this pull request?

I found a typo In PULL_REQUEST_TEMPLATE,

> `Iinclude` a link to the associated JIRA and make sure to add a link to 
this pr on the JIRA as well)

So i suggest this typo fix to `(include`



## How was this patch tested?

N/A

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/itholic/incubator-livy MINOR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-livy/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #123


commit 425db4de392dc7bf228e2fa35bd9716ad3eff230
Author: itholic 
Date:   2018-10-16T14:52:25Z

[MINOR] There is some typo in PULL_REQUEST_TEMPLATE




---

[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=h1) 
Report
> Merging 
[#122](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-livy/commit/a068363a0c097ab167e8fb6de1015930e71b4cb8?src=pr&el=desc)
 will **decrease** coverage by `4.38%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-livy/pull/122/graphs/tree.svg?width=650&token=0MkVbiUFwE&height=150&src=pr)](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
## master #122  +/-   ##

- Coverage 70.85%   66.47%   -4.39% 
+ Complexity  923  890  -33 

  Files   100  100  
  Lines  5500 5500  
  Branches828  828  

- Hits   3897 3656 -241 
- Misses 1068 1339 +271 
+ Partials535  505  -30
```


| [Impacted 
Files](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==)
 | `1.68% <0%> (-33.15%)` | `2% <0%> (-7%)` | |
| 
[...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=)
 | `55.63% <0%> (-21.84%)` | `29% <0%> (-4%)` | |
| 
[...rc/main/scala/org/apache/livy/utils/SparkApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0FwcC5zY2FsYQ==)
 | `56% <0%> (-20%)` | `1% <0%> (ø)` | |
| 
[core/src/main/scala/org/apache/livy/Logging.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvTG9nZ2luZy5zY2FsYQ==)
 | `66.66% <0%> (-16.67%)` | `0% <0%> (ø)` | |
| 
[...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==)
 | `66.32% <0%> (-15.31%)` | `13% <0%> (-5%)` | |
| 
[...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh)
 | `54.74% <0%> (-13.61%)` | `40% <0%> (-3%)` | |
| 
[...src/main/scala/org/apache/livy/sessions/Kind.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvS2luZC5zY2FsYQ==)
 | `65% <0%> (-10%)` | `2% <0%> (ø)` | |
| 
[...server/interactive/InteractiveSessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uU2VydmxldC5zY2FsYQ==)
 | `59.83% <0%> (-6.56%)` | `6% <0%> (ø)` | |
| 
[...rc/main/java/org/apache/livy/rsc/BaseProtocol.java](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9CYXNlUHJvdG9jb2wuamF2YQ==)
 | `69.14% <0%> (-5.32%)` | `1% <0%> (ø)` | |
| 
[...org/apache/livy/server/recovery/SessionStore.scala](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvcmVjb3ZlcnkvU2Vzc2lvblN0b3JlLnNjYWxh)
 | `75% <0%> (-5%)` | `9% <0%> (-1%)` | |
| ... and [23 
more](https://codecov.io/gh/apache/incubator-livy/pull/122/diff?src=pr&el=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=footer).
 Last update 
[a068363...b62edfa](https://codecov.io/gh/apache/incubator-livy/pull/122?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] incubator-livy issue #122: [LIVY-529][DOCS] Fix supported Python version fro...

2018-10-16 Thread itholic 
Github user itholic commented on the issue:

https://github.com/apache/incubator-livy/pull/122
  
Hi @vanzin and @jerryshao. Could you take a look at this one when you are 
available please?


---

[GitHub] incubator-livy pull request #122: [LIVY-529][DOCS] Fix supported Python vers...

2018-10-16 Thread itholic 
GitHub user itholic opened a pull request:

https://github.com/apache/incubator-livy/pull/122

[LIVY-529][DOCS] Fix supported Python version from 2.6+ to 2.7+ in 
documentation

## What changes were proposed in this pull request?

As of Spark 2.2, Python 2.6 is officially 
dropped(https://issues.apache.org/jira/browse/SPARK-12661).

Since Livy support Spark 2.2+, looks this limitation is inheritted.

Currently, Livy doc 
(https://github.com/apache/incubator-livy/blob/master/README.md) notes Python 
2.6+ is required.

It looks this should be changed to 2.7+

## How was this patch tested?

N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/itholic/incubator-livy LIVY-529

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-livy/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #122


commit b62edfad628c27fa73fdeefccc46b6c9c8adf6a2
Author: itholic 
Date:   2018-10-16T13:56:05Z

Fix supported Python version from 2.6+ to 2.7+ in documentation




---