Re: Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[haosdent huang]

> On July 5, 2015, 6:36 a.m., Anindya Sinha wrote:
> > I know this is already merged but can't we just get rid of the foreach 
> > (const Environment::Variable...) block since env already contains the 
> > contents of commandInfo.environment().variables(). Or are there scenarios 
> > when that is not true?

I think add check in "foreach (const Environment::Variable& variable," should 
be better instead of remove this foreach. Because "src/docker/docker.cpp" is a 
independence class. When it has contain the interface like
```cpp
Future Docker::run(
const ContainerInfo& containerInfo,
const CommandInfo& commandInfo,
const string& name,
const string& sandboxDirectory,
const string& mappedDirectory,
const Option& resources,
const Option>& env,
const Option& stdoutPath,
const Option& stderrPath)
```
it should contains `commandInfo.environment().variables()` semantically. Other 
class maybe have some minor mistakes in call this method, but I think we could 
not remove this foreach because of other classes problem. And add this check
```
if (env.isSome() &&
  env.get().find(variable.name()) != env.get().end()) {
  // Skip to avoid duplicate environment variables.
  continue;
}
```
I think could avoid the problem when other classes call docker->run with 
duplicate between `env` and `commandInfo.environment()`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/#review90402
---


On July 4, 2015, noon, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36179/
> ---
> 
> (Updated July 4, 2015, noon)
> 
> 
> Review request for mesos, Anindya Sinha and Timothy Chen.
> 
> 
> Bugs: MESOS-2882
> https://issues.apache.org/jira/browse/MESOS-2882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix duplicate "-e" environment variables option in Docker::run.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 
> 
> Diff: https://reviews.apache.org/r/36179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/#review90402
---


I know this is already merged but can't we just get rid of the foreach (const 
Environment::Variable...) block since env already contains the contents of 
commandInfo.environment().variables(). Or are there scenarios when that is not 
true?

- Anindya Sinha


On July 4, 2015, noon, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36179/
> ---
> 
> (Updated July 4, 2015, noon)
> 
> 
> Review request for mesos, Anindya Sinha and Timothy Chen.
> 
> 
> Bugs: MESOS-2882
> https://issues.apache.org/jira/browse/MESOS-2882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix duplicate "-e" environment variables option in Docker::run.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 
> 
> Diff: https://reviews.apache.org/r/36179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36181: Port CFS support to Docker Containerizer

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review90399
---


Patch looks great!

Reviews applied: [36181]

All tests passed.

- Mesos ReviewBot


On July 4, 2015, 4:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> ---
> 
> (Updated July 4, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Port CFS support to Docker Containerizer
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
> 
> Diff: https://reviews.apache.org/r/36181/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/#review90398
---


Patch looks great!

Reviews applied: [36179]

All tests passed.

- Mesos ReviewBot


On July 4, 2015, noon, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36179/
> ---
> 
> (Updated July 4, 2015, noon)
> 
> 
> Review request for mesos, Anindya Sinha and Timothy Chen.
> 
> 
> Bugs: MESOS-2882
> https://issues.apache.org/jira/browse/MESOS-2882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix duplicate "-e" environment variables option in Docker::run.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 
> 
> Diff: https://reviews.apache.org/r/36179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

> On July 4, 2015, 5:34 p.m., Timothy Chen wrote:
> > src/slave/containerizer/docker.cpp, line 282
> > 
> >
> > These flags are supported only after a certain docker version right?
> > 
> > I think we need to log and disable this when the user is using a older 
> > version that doens't support these flags.

Is it possible to support cfs in older docker? Maybe we could change to that 
way.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review90392
---


On July 4, 2015, 4:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> ---
> 
> (Updated July 4, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Port CFS support to Docker Containerizer
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
> 
> Diff: https://reviews.apache.org/r/36181/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review90394
---


Patch looks great!

Reviews applied: [36180]

All tests passed.

- Mesos ReviewBot


On July 4, 2015, 1:31 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated July 4, 2015, 1:31 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/#review90393
---

Ship it!


Ship It!

- Timothy Chen


On July 4, 2015, noon, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36179/
> ---
> 
> (Updated July 4, 2015, noon)
> 
> 
> Review request for mesos, Anindya Sinha and Timothy Chen.
> 
> 
> Bugs: MESOS-2882
> https://issues.apache.org/jira/browse/MESOS-2882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix duplicate "-e" environment variables option in Docker::run.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 
> 
> Diff: https://reviews.apache.org/r/36179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36181: Port CFS support to Docker Containerizer

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review90392
---



src/slave/containerizer/docker.cpp (line 282)


These flags are supported only after a certain docker version right?

I think we need to log and disable this when the user is using a older 
version that doens't support these flags.


- Timothy Chen


On July 4, 2015, 4:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> ---
> 
> (Updated July 4, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Port CFS support to Docker Containerizer
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
> 
> Diff: https://reviews.apache.org/r/36181/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36177: Throw legal ExecutionException in jni calls.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36177/#review90391
---


Patch looks great!

Reviews applied: [36177]

All tests passed.

- Mesos ReviewBot


On July 4, 2015, 11 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36177/
> ---
> 
> (Updated July 4, 2015, 11 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2718
> https://issues.apache.org/jira/browse/MESOS-2718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Throw legal ExecutionException in jni calls.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> b454bb17a0d47a2a7ce8607716cbd3114b8ea8c3 
>   src/java/src/org/apache/mesos/state/State.java 
> 58885d9e61f693e08b3e5088cce6a07155d91e01 
> 
> Diff: https://reviews.apache.org/r/36177/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-2154
https://issues.apache.org/jira/browse/MESOS-2154


Repository: mesos


Description
---

Port CFS support to Docker Containerizer


Diffs
-

  src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 

Diff: https://reviews.apache.org/r/36181/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36173/#review90389
---


Patch looks great!

Reviews applied: [36173]

All tests passed.

- Mesos ReviewBot


On July 3, 2015, 9:30 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36173/
> ---
> 
> (Updated July 3, 2015, 9:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update attributes doc to reflect current supported attributes types.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 0ae8b5908fe0b3a3499e6d813afbb328a13bdcde 
> 
> Diff: https://reviews.apache.org/r/36173/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 36106: cgroups: added cpuacct subsystem

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90387
---


Patch looks great!

Reviews applied: [36106]

All tests passed.

- Mesos ReviewBot


On July 2, 2015, 8:09 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36106/
> ---
> 
> (Updated July 2, 2015, 8:09 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> cgroups implementation does not have a cpuacct subsystem implementation as of
> today. Adding the implementation for stat function.
> 
> Changes:
>   - added Stats class to encapsulate cpuacct.stat data
>   - added implementation for cpuacct::stats
>   - added unit tests
> 
> Jira: MESOS-2961
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 
>   src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 
>   src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a 
> 
> Diff: https://reviews.apache.org/r/36106/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36167: Updated FirewallRule interface so is consistent with http::Response usage in the project.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36167/#review90386
---


Patch looks great!

Reviews applied: [36167]

All tests passed.

- Mesos ReviewBot


On July 3, 2015, 2:23 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36167/
> ---
> 
> (Updated July 3, 2015, 2:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While returning an `Option` may lead to object slicing. 
> Currently it is not a problem since descendants of http::Response do not 
> alter the memory mapping of the object, i.e. they don't add new fields. At 
> the same time, every where else the usage is return `Future`.
> 
> In order to keep it consistent the return value of `FirewallRule::apply()` is 
> updated.
> 
> Keep in mind that if object slicing ever happens, this change must be 
> reverted and usage of `Future` should be changed to 
> `Future`.
> 
> For discussion see [r/35919/](https://reviews.apache.org/r/35919/)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/firewall.hpp 
> 692e065f2744f38035d81c0137760d996a295df6 
>   3rdparty/libprocess/src/process.cpp 
> 883776a6d87f3f14d04e2d574b0e0baa469af579 
> 
> Diff: https://reviews.apache.org/r/36167/diff/
> 
> 
> Testing
> ---
> 
> make check
> make distcheck
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/
---

Review request for mesos and Adam B.


Bugs: MESOS-2765
https://issues.apache.org/jira/browse/MESOS-2765


Repository: mesos


Description
---

Avoid multi writers write to same file in PortMappingIsolatorTests.


Diffs
-

  src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb 

Diff: https://reviews.apache.org/r/36180/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36126/#review90383
---


Patch looks great!

Reviews applied: [36126]

All tests passed.

- Mesos ReviewBot


On July 2, 2015, 7:50 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36126/
> ---
> 
> (Updated July 2, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2983
> https://issues.apache.org/jira/browse/MESOS-2983
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing json extension for HTTP endpoints in slave
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-cat 73dc63e 
>   src/cli/mesos-ps ee14d51 
>   src/cli/mesos-tail 256a804 
>   src/master/flags.cpp 60ac64d 
>   src/slave/flags.cpp 8632677 
>   src/slave/http.cpp b0fe5f5 
>   src/slave/monitor.cpp 82aa659 
>   src/slave/slave.hpp dec4ca8 
>   src/slave/slave.cpp 008170f 
>   src/tests/fault_tolerance_tests.cpp 1070ccf 
>   src/tests/monitor_tests.cpp 53fb53e 
>   src/tests/slave_tests.cpp 4ddc608 
>   src/webui/master/static/js/controllers.js 3445028 
>   src/webui/master/static/js/services.js 2cd9d7d 
> 
> Diff: https://reviews.apache.org/r/36126/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/
---

(Updated July 4, 2015, noon)


Review request for mesos, Anindya Sinha and Timothy Chen.


Bugs: MESOS-2882
https://issues.apache.org/jira/browse/MESOS-2882


Repository: mesos


Description
---

Fix duplicate "-e" environment variables option in Docker::run.


Diffs (updated)
-

  src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 

Diff: https://reviews.apache.org/r/36179/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36125: Removing '.json' extension in master endpoints url

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36125/#review90381
---


Patch looks great!

Reviews applied: [36125]

All tests passed.

- Mesos ReviewBot


On July 2, 2015, 7:42 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36125/
> ---
> 
> (Updated July 2, 2015, 7:42 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2719
> https://issues.apache.org/jira/browse/MESOS-2719
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing json extension for HTTP endpoints in master
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-cat 73dc63e 
>   src/cli/mesos-ps ee14d51 
>   src/cli/mesos-scp 77b8557 
>   src/cli/mesos-tail 256a804 
>   src/master/constants.hpp 7cec18b 
>   src/master/http.cpp 2be613b 
>   src/master/master.hpp af83d3e 
>   src/master/master.cpp a7486d8 
>   src/tests/fault_tolerance_tests.cpp 1070ccf 
>   src/tests/master_tests.cpp 57721b7 
>   src/webui/master/static/js/controllers.js 3445028 
> 
> Diff: https://reviews.apache.org/r/36125/diff/
> 
> 
> Testing
> ---
> 
> make checl
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Review Request 36179: Fix duplicate "-e" environment variables option in Docker::run.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/
---

Review request for mesos, Anindya Sinha and Timothy Chen.


Bugs: MESOS-2882
https://issues.apache.org/jira/browse/MESOS-2882


Repository: mesos


Description
---

Fix duplicate "-e" environment variables option in Docker::run.


Diffs
-

  src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f 

Diff: https://reviews.apache.org/r/36179/diff/


Testing
---


Thanks,

haosdent huang

Review Request 36177: Throw legal ExecutionException in jni calls.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36177/
---

Review request for mesos.


Bugs: MESOS-2718
https://issues.apache.org/jira/browse/MESOS-2718


Repository: mesos


Description
---

Throw legal ExecutionException in jni calls.


Diffs
-

  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
b454bb17a0d47a2a7ce8607716cbd3114b8ea8c3 
  src/java/src/org/apache/mesos/state/State.java 
58885d9e61f693e08b3e5088cce6a07155d91e01 

Diff: https://reviews.apache.org/r/36177/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 32384: Adding perf check to configure

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32384/#review90380
---


Patch looks great!

Reviews applied: [32384]

All tests passed.

- Mesos ReviewBot


On July 2, 2015, 8:09 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32384/
> ---
> 
> (Updated July 2, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Bugs: MESOS-2166
> https://issues.apache.org/jira/browse/MESOS-2166
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> PerfEventIsolatorTest.ROOT_CGROUPS_Sample requires 'perf' to be installed
> 
> 
> Diffs
> -
> 
>   configure.ac 9290958 
>   src/tests/environment.cpp f111a77 
> 
> Diff: https://reviews.apache.org/r/32384/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 36127: Removing '.json' extension in files endpoints url

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36127/#review90378
---


Patch looks great!

Reviews applied: [36127]

All tests passed.

- Mesos ReviewBot


On July 2, 2015, 8:03 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36127/
> ---
> 
> (Updated July 2, 2015, 8:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2984
> https://issues.apache.org/jira/browse/MESOS-2984
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing json extension for HTTP endpoints in files
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-cat 73dc63e 
>   src/cli/mesos-tail 256a804 
>   src/files/files.cpp 3a62ee7 
>   src/master/flags.cpp 60ac64d 
>   src/slave/flags.cpp 8632677 
>   src/tests/files_tests.cpp 53771cd 
>   src/tests/gc_tests.cpp 5666cd1 
>   src/webui/master/static/browse.html 0904c87 
>   src/webui/master/static/js/controllers.js 3445028 
> 
> Diff: https://reviews.apache.org/r/36127/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>