Review Request 36601: Fixed UserCgroupIsolatorTest to be more explicit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36601/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/isolator_tests.cpp b3832b4e2113c07e51dc3c12a62309878b021ca1 Diff: https://reviews.apache.org/r/36601/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 36600: Fixes for NsTest on Ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/#review92213 --- Ship it! - Joerg Schad On July 19, 2015, 6:04 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- (Updated July 19, 2015, 6:04 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36604: Preemptively fail tests if previous invocations failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/#review92209 --- Ship it! Doesn't solve the underlying problem but helps understand what is happening and how to fix it manually. - Joerg Schad On July 19, 2015, 5:40 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/ --- (Updated July 19, 2015, 5:40 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36604/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36527: Fix cgroup tests to not verify order.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36527/ --- (Updated July 19, 2015, 6:55 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3058 https://issues.apache.org/jira/browse/MESOS-3058 Repository: mesos Description --- Fix cgroup tests to not verify order. Diffs (updated) - src/tests/cgroups_tests.cpp 3924a4a Diff: https://reviews.apache.org/r/36527/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 36604: Preemptively fail tests if previous invocations failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/ --- (Updated July 19, 2015, 5:54 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36604/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/#review92210 --- src/tests/cgroups_tests.cpp (line 991) https://reviews.apache.org/r/36605/#comment146234 I wonder what is the follow up action around this TODO? Seems like it stated why we commented the code but not anything we should do in the future? src/tests/perf_tests.cpp (line 172) https://reviews.apache.org/r/36605/#comment146235 ditto - Timothy Chen On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- (Updated July 19, 2015, 5:54 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36527: Fix cgroup tests to not verify order.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36527/ --- (Updated July 19, 2015, 6:39 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3058 https://issues.apache.org/jira/browse/MESOS-3058 Repository: mesos Description --- Fix cgroup tests to not verify order. Diffs (updated) - src/tests/cgroups_tests.cpp 3924a4a Diff: https://reviews.apache.org/r/36527/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36600: Fixes for NsTest on Ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/#review92208 --- Ship it! Ship It! - Joerg Schad On July 19, 2015, 5:38 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- (Updated July 19, 2015, 5:38 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36527: Fix cgroup tests to not verify order.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36527/#review92207 --- Ship it! src/tests/cgroups_tests.cpp (lines 389 - 390) https://reviews.apache.org/r/36527/#comment146232 s/c1/cgroup1/ s/c2/cgroup2/ src/tests/cgroups_tests.cpp (line 402) https://reviews.apache.org/r/36527/#comment146233 Let's just wrap the `find` lines below like you did in the test above. - Benjamin Hindman On July 19, 2015, 4:50 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36527/ --- (Updated July 19, 2015, 4:50 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3058 https://issues.apache.org/jira/browse/MESOS-3058 Repository: mesos Description --- Fix cgroup tests to not verify order. Diffs - src/tests/cgroups_tests.cpp a371ee205f89de10e15902057848c35f7c278d77 Diff: https://reviews.apache.org/r/36527/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 36600: Fixes for NsTest on Ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- (Updated July 19, 2015, 6:13 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs (updated) - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36600: Fixes for NsTest on Ubuntu.
On July 19, 2015, 5:46 p.m., Timothy Chen wrote: src/tests/ns_tests.cpp, line 97 https://reviews.apache.org/r/36600/diff/1/?file=1016067#file1016067line97 MESOS-3079 actually doesn't provide any more information, just a list of failed tests. I think either we put more info in the JIRA ticket or just leave out the ticket. Added reference to MESOS-3083. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/#review92205 --- On July 19, 2015, 5:38 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- (Updated July 19, 2015, 5:38 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/#review92215 --- Ship it! Ship It! - Timothy Chen On July 19, 2015, 6:04 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- (Updated July 19, 2015, 6:04 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36604: Preemptively fail tests if previous invocations failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/#review92214 --- Ship it! Ship It! - Timothy Chen On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/ --- (Updated July 19, 2015, 5:54 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36604/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36425: Enabling IP Discovery script
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review92219
---
src/master/main.cpp (line 139)
https://reviews.apache.org/r/36425/#comment146238
We've tried to name our flags the same as how you'd see them on the command
line, so s/ipDiscoveryScript/ip_discovery_script/ here please.
Also, what about s/script/command/ here? Since we might not be executing a
script here and it's more inline with the fact that we'll be executing this via
the shell (i.e., it's a shell command, as opposed to say doing
s/script/executable/ which might imply we're going to fork/exec).
src/master/main.cpp (line 144)
https://reviews.apache.org/r/36425/#comment146239
Rather than overriding the setting any reason not to error out to be more
friendly to an operator? Seems like this would save someone some time debugging
in the future and would be as simple as:
if (ip.isSome() ip_discovery_script.isSome()) {
// Print nice error message and maybe usage and exit.
}
src/master/main.cpp (lines 181 - 209)
https://reviews.apache.org/r/36425/#comment146240
Apologies for not giving you this feedback sooner, but we already have a
wrapper for `popen` with `os::shell`. It's used a handful of places in the code
instead of `popen`:
ostringstream out;
Tryint status = os::shell(out, ip_discovery_script.get());
if (status.isError()) {
EXIT(EXIT_FAILURE) ...;
} else if (WIFSIGNALED(status.get())) {
EXIT(EXIT_FAILURE) ... strsignal(WTERMSIG(status.get()));
} else if (WEXITSTATUS(status.get()) != EXIT_SUCCESS) {
EXIT(EXIT_FAILURE) ... stringify
(WEXITSTATUS(status.get()));
}
const string ipAddress = strings::trim(out.get());
LOG(INFO) ...;
os::setenv(LIBPROCESS_IP, ipAddress);
src/master/main.cpp (line 184)
https://reviews.apache.org/r/36425/#comment146242
What is process::executeCommand? Did you mean process::subprocess here?
src/master/main.cpp (line 208)
https://reviews.apache.org/r/36425/#comment146241
We've tried to consistently wrap things like IPs in single quotes in string
messages.
- Benjamin Hindman
On July 13, 2015, 9:35 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 13, 2015, 9:35 p.m.)
Review request for mesos, Benjamin Hindman and Cody Maloney.
Bugs: MESOS-2902
https://issues.apache.org/jira/browse/MESOS-2902
Repository: mesos
Description
---
Jira: MESOS-2902
It is sometimes useful to enable an external script to
configure the IP address the Mesos Master will bind to
on the server, where it's not desirable to set the
--ip flag and/or a wrapper script is not a viable option.
This patch adds a --ip_discovery_script to point to a local
script that will emit as its only output the IP address that
the Master will bind to: only spaces and newlines are allowed;
further, as we cannot use the `libprocess` sub-processing
facilities, we cannot timeout the script, should this block
for long times (or even forever).
This will override the --ip flag, which, even if set, will be
ignored.
Diffs
-
docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01
src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1
Diff: https://reviews.apache.org/r/36425/diff/
Testing
---
make check
Thanks,
Marco Massenzio
Re: Review Request 36600: Fixes for NsTest on Ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/#review92205 --- src/tests/ns_tests.cpp (line 97) https://reviews.apache.org/r/36600/#comment146230 MESOS-3079 actually doesn't provide any more information, just a list of failed tests. I think either we put more info in the JIRA ticket or just leave out the ticket. src/tests/setns_test_helper.cpp (line 52) https://reviews.apache.org/r/36600/#comment146231 ditto - Timothy Chen On July 19, 2015, 5:38 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- (Updated July 19, 2015, 5:38 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- (Updated July 19, 2015, 6:04 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs (updated) - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
On July 19, 2015, 5:55 p.m., Timothy Chen wrote: src/tests/cgroups_tests.cpp, line 992 https://reviews.apache.org/r/36605/diff/1/?file=1016074#file1016074line992 I wonder what is the follow up action around this TODO? Seems like it stated why we commented the code but not anything we should do in the future? Added the JIRA issue for tracking. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/#review92210 --- On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36605/ --- (Updated July 19, 2015, 5:54 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36605/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36603: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36603/ --- (Updated July 19, 2015, 5:50 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36603/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36527: Fix cgroup tests to not verify order.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36527/ --- (Updated July 19, 2015, 6:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3058 https://issues.apache.org/jira/browse/MESOS-3058 Repository: mesos Description --- Fix cgroup tests to not verify order. Diffs (updated) - src/tests/cgroups_tests.cpp 3924a4a Diff: https://reviews.apache.org/r/36527/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 36450: Introduced Address and URL protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review92218 --- Hasn't this been submitted? - Benjamin Hindman On July 17, 2015, 1:36 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/ --- (Updated July 17, 2015, 1:36 a.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS-3012 https://issues.apache.org/jira/browse/MESOS-3012 Repository: mesos Description --- To make the API more consistent, we'd like to have a single way to express a network address. Also would like a way to express an HTTP address (a URL), which may include a path prefix. This also enables the message passing optimization in the scheduler driver when receiving events, per MESOS-3012. Diffs - include/mesos/mesos.proto d2f482668e671b30f2586f6aae9c20132ab4d1e4 include/mesos/type_utils.hpp eb7fe2562cfcff52288d1c216425068d1ba551c0 src/common/type_utils.cpp 2ad5b4cbe324c83e81fd7df7430652f5c0a4e30f src/master/master.cpp 082758ef54597ad32cf0d025c147f0f44dd11961 src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc Diff: https://reviews.apache.org/r/36450/diff/ Testing --- Modified the simplest test I could find for offers. Thanks, Ben Mahler
Review Request 36608: Add ppc64le architecture support for leveldb and zookeeper
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36608/ --- Review request for mesos. Bugs: MESOS-3084 https://issues.apache.org/jira/browse/MESOS-3084 Repository: mesos Description --- Add ppc64le architecture support for leveldb and zookeeper Diffs - 3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc Diff: https://reviews.apache.org/r/36608/diff/ Testing --- make check has passed on mesos-0.22.1. [--] Global test environment tear-down [==] 539 tests from 86 test cases ran. (366753 ms total) [ PASSED ] 539 tests. Thanks, Jihun Kang
Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/ --- Review request for mesos. Bugs: MESOS-3085 https://issues.apache.org/jira/browse/MESOS-3085 Repository: mesos Description --- Add explicit syscall header file to linux fs Diffs - src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd Diff: https://reviews.apache.org/r/36610/diff/ Testing --- Thanks, Jihun Kang
Review Request 36602: Fixed cgroups test to ignore output ordering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36602/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab Diff: https://reviews.apache.org/r/36602/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 36603: Cleaned up 'perf' related tests to work on Ubuntu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36603/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36603/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 36604: Preemptively fail tests if previous invocations failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36604/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36604/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36600: Fixes for NsTest on Ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/#review92216 --- Ship it! Ship It! - Timothy Chen On July 19, 2015, 6:13 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36600/ --- (Updated July 19, 2015, 6:13 p.m.) Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/ns_tests.cpp 400ce937e8c53482d78ce91c8d9515a626ea src/tests/setns_test_helper.cpp 87f4d6a42a41bae8eec00aa5a9f4173906915a52 Diff: https://reviews.apache.org/r/36600/diff/ Testing --- make check Thanks, Benjamin Hindman
