Re: Review Request 36318: Refactored framework struct in master to support http frameworks

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
---

(Updated July 25, 2015, 6:49 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco 
Massenzio, and Vinod Kone.


Changes
---

Modified code to use the encoder from MESOS-3067


Bugs: MESOS-2294
https://issues.apache.org/jira/browse/MESOS-2294


Repository: mesos


Description
---

This change refactors the framework struct in master to introduce support for
http frameworks.
- pid becomes a optional field now in the framework struct.
- added optional fields for supporting http frameworks to the framework struct


Diffs (updated)
-

  src/common/http.hpp 765860fa7d0ce354320e9d293d09719be87efca0 
  src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
  src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 
  src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca 

Diff: https://reviews.apache.org/r/36318/diff/


Testing
---

make check + tests now go in a separate patch now.


Thanks,

Anand Mazumdar

Re: Review Request 36625: Windows: Split up platform specific functions into separate headers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36625/
---

(Updated July 24, 2015, 6:11 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Rename "linux" folder to "posix".


Bugs: MESOS-3101
https://issues.apache.org/jira/browse/MESOS-3101


Repository: mesos


Description
---

To support the upcoming Windows Containerizer (MESOS-3094), we're splitting up 
(refactoring) platform specific functions into separate files.

We will avoid having `#ifdef __WINDOWS__` all over the stout/libprcess code by 
separating Linux/Windows versions.
This first patch is to establish a pattern in splitting up the headers.

Patterns:

* abort.hpp, format.hpp, gzip.hpp, thread.hpp - Functions are moved to a Linux 
folder; copied to a Windows folder and gutted for later implementation.
* duration.hpp - An #ifdef for one of the headers (time.h vs Winsock2.h). No 
need to split the header.
* exit.hpp, unreachable.hpp - Even though the implementations only differ by a 
single (compilation) macro, the methods are still copy-pasted into different 
files.
* ip.hpp - Needed to split the class IP into ip/ip.hpp so that the include 
order is ip/ip.hpp, ip.hpp (for common functions), then [linux|windows]/ip.hpp.
* net.hpp - Multiple #ifdef's needed in the top-level file. Linux file needed 
forward declarations of some functions.


Other:

* Instances of #include "local file.hpp" were changed to #include " to match os.hpp.
* Some missing #endif comments (i.e. `// __APPLE__`) were added.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
3aa9487bed2df038ca27a8bb94c24608ca7910a4 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
bba8303347aac3f70566a9e69625a928cfb1bd24 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
8c16a224433d7a43bf6bf17e1129e6eb9bbbd573 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
0b95819205af6caae05c01cb4d0b25620abe791c 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
a0ea23797376288e8dc96886fd3c0702e5edf846 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
a538fb1a343aab039aecabe508b7747e683fd46e 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/exit.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/format.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/thread.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/unreachable.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
552d6e97c882a36d6a889af205c422e51f544b34 
  3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 
fed0a7ba81c98be83a0d66c2317e768877f8e40d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/abort.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/exit.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/thread.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/unreachable.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/36625/diff/


Testing
---

`make` and `make check` (Mac OSX)


Thanks,

Joseph Wu

Review Request 36807: [WIP] Adding a test for MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs
-

  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36807/diff/


Testing
---

make check
(the test by itself passes - but it will hang indefinitely when run after the 
other MasterZookeeperTest)


Thanks,

Marco Massenzio

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review93018
---


Bad patch!

Reviews applied: [36618, 36627]

Failed command: ./support/apply-review.sh -n -r 36627

Error:
 2015-07-25 00:48:22 URL:https://reviews.apache.org/r/36627/diff/raw/ 
[3244/3244] -> "36627.patch" [1]
error: src/tests/cgroups_tests.cpp: does not exist in index
error: src/tests/memory_test_helper.cpp: does not exist in index
Failed to apply patch

- Mesos ReviewBot


On July 25, 2015, 12:32 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36627/
> ---
> 
> (Updated July 25, 2015, 12:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2660
> https://issues.apache.org/jira/browse/MESOS-2660
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/36627/diff/
> 
> 
> Testing
> ---
> 
> It seems there is still one more cgroups memory test failing on more test 
> failing on my box. I'd like to fix that too and commit it together with this 
> one. 
> 
> sudo make check
> 
> Verified that the process actually gets killed by oom-killer:
> 
> ```
> # tail -f /var/log/syslog
> 
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
> lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
> lt-memory-test- cpuset=/ mems_allowed=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 
> PID: 76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
> #57~14.04.1-Ubuntu
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
> name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
> BIOS 6.00 05/20/2014
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
> 88022efc1000 8801fd2efc30 81765721 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
> 8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
> 8801fd2efc80 81165067 880231f10ee8 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
> [] dump_stack+0x45/0x56
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
> [] dump_header+0x7f/0x1f1
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
> [] ? find_lock_task_mm+0x47/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
> [] oom_kill_process+0x205/0x360
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
> [] ? security_capable_noaudit+0x15/0x20
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
> [] mem_cgroup_oom_synchronize+0x581/0x5e0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
> [] ? mem_cgroup_try_charge_mm+0xa0/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
> [] pagefault_out_of_memory+0x14/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
> [] mm_fault_error+0x67/0x140
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
> [] __do_page_fault+0x4ec/0x560
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
> [] ? __enqueue_entity+0x78/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
> [] ? set_next_entity+0x95/0xb0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
> [] ? __switch_to+0x167/0x580
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
> [] do_page_fault+0x31/0x70
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
> [] page_fault+0x28/0x30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
> /mesos_test killed as a result of limit of /mesos_test
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
> usage 65536kB, limit 65536kB, failcnt 24
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] 
> memory+swap: usage 0kB, limit 18014398509481983kB, failcnt 0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: 
> usage 0kB, limit 18014398509481983kB, failcnt 0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memor

Re: Review Request 36663: Added ip_address field to MasterInfo

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review93017
---

Ship it!


Ship It!

- Vinod Kone


On July 25, 2015, 12:36 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36663/
> ---
> 
> (Updated July 25, 2015, 12:36 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added address field to MasterInfo
> 
> As part of the new HTTP API and the need to
> provide a better interface for clients that
> do not integrate libmesos, we provide the IP
> address of the Leader Master in the information
> that gets serialized (in JSON) to ZooKeeper.
> 
> This will eventually supersede the `ip`, `port`
> and `hostname` fields that are currently in
> MasterInfo an which cannot fully support IPv6
> addresses.
> 
> Jira: MESOS-2736
> 
> Review: https://reviews.apache.org/r/36663
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1a8649d00f3bcc792a75c11dedeb42a667e2ce88 
>   include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
>   src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
>   src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
>   src/tests/master_contender_detector_tests.cpp 
> d7a3b46b2e437818631064ae34317e49c9aa3748 
> 
> Diff: https://reviews.apache.org/r/36663/diff/
> 
> 
> Testing
> ---
> 
> make check
> (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the 
> information serialized to ZK is readable and as expected).
> 
> Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; 
> getting both versions in turn to be Leader, and also ran a 0.23 Slave with a 
> 0.24 Leader, and they all recognized each other.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36663: Added ip_address field to MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---

(Updated July 25, 2015, 12:36 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

removed the test - will be part of another review (it causes tests to hang in 
ZK)


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

Added address field to MasterInfo

As part of the new HTTP API and the need to
provide a better interface for clients that
do not integrate libmesos, we provide the IP
address of the Leader Master in the information
that gets serialized (in JSON) to ZooKeeper.

This will eventually supersede the `ip`, `port`
and `hostname` fields that are currently in
MasterInfo an which cannot fully support IPv6
addresses.

Jira: MESOS-2736

Review: https://reviews.apache.org/r/36663


Diffs (updated)
-

  CHANGELOG 1a8649d00f3bcc792a75c11dedeb42a667e2ce88 
  include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
  src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
  src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
  src/tests/master_contender_detector_tests.cpp 
d7a3b46b2e437818631064ae34317e49c9aa3748 

Diff: https://reviews.apache.org/r/36663/diff/


Testing
---

make check
(also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the 
information serialized to ZK is readable and as expected).

Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; 
getting both versions in turn to be Leader, and also ran a 0.23 Slave with a 
0.24 Leader, and they all recognized each other.


Thanks,

Marco Massenzio

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

> On July 23, 2015, 8:02 p.m., Marco Massenzio wrote:
> > src/tests/memory_test_helper.cpp, line 87
> > 
> >
> > micro-nit: missing an `a` in `posix_memlign`

Fixed in the latest commit. Thanks!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review92862
---


On July 24, 2015, 5:32 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36627/
> ---
> 
> (Updated July 24, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2660
> https://issues.apache.org/jira/browse/MESOS-2660
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/36627/diff/
> 
> 
> Testing
> ---
> 
> It seems there is still one more cgroups memory test failing on more test 
> failing on my box. I'd like to fix that too and commit it together with this 
> one. 
> 
> sudo make check
> 
> Verified that the process actually gets killed by oom-killer:
> 
> ```
> # tail -f /var/log/syslog
> 
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
> lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
> lt-memory-test- cpuset=/ mems_allowed=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 
> PID: 76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
> #57~14.04.1-Ubuntu
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
> name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
> BIOS 6.00 05/20/2014
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
> 88022efc1000 8801fd2efc30 81765721 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
> 8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
> 8801fd2efc80 81165067 880231f10ee8 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
> [] dump_stack+0x45/0x56
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
> [] dump_header+0x7f/0x1f1
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
> [] ? find_lock_task_mm+0x47/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
> [] oom_kill_process+0x205/0x360
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
> [] ? security_capable_noaudit+0x15/0x20
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
> [] mem_cgroup_oom_synchronize+0x581/0x5e0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
> [] ? mem_cgroup_try_charge_mm+0xa0/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
> [] pagefault_out_of_memory+0x14/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
> [] mm_fault_error+0x67/0x140
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
> [] __do_page_fault+0x4ec/0x560
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
> [] ? __enqueue_entity+0x78/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
> [] ? set_next_entity+0x95/0xb0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
> [] ? __switch_to+0x167/0x580
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
> [] do_page_fault+0x31/0x70
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
> [] page_fault+0x28/0x30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
> /mesos_test killed as a result of limit of /mesos_test
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
> usage 65536kB, limit 65536kB, failcnt 24
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] 
> memory+swap: usage 0kB, limit 18014398509481983kB, failcnt 0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: 
> usage 0kB, limit 18014398509481983kB, failcnt 0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memory 
> cgroup stats for /mesos_test: cache:0KB rss:65536KB rss_huge:63488KB 
> mapped_file:0KB w

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---

(Updated July 24, 2015, 5:32 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Summary (updated)
-

Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.


Bugs: MESOS-2660
https://issues.apache.org/jira/browse/MESOS-2660


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 

Diff: https://reviews.apache.org/r/36627/diff/


Testing
---

It seems there is still one more cgroups memory test failing on more test 
failing on my box. I'd like to fix that too and commit it together with this 
one. 

sudo make check

Verified that the process actually gets killed by oom-killer:

```
# tail -f /var/log/syslog

Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
lt-memory-test- cpuset=/ mems_allowed=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 PID: 
76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
#57~14.04.1-Ubuntu
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
BIOS 6.00 05/20/2014
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
88022efc1000 8801fd2efc30 81765721 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
8801fd2efc80 81165067 880231f10ee8 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
[] dump_stack+0x45/0x56
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
[] dump_header+0x7f/0x1f1
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
[] ? find_lock_task_mm+0x47/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
[] oom_kill_process+0x205/0x360
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
[] ? security_capable_noaudit+0x15/0x20
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
[] mem_cgroup_oom_synchronize+0x581/0x5e0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
[] ? mem_cgroup_try_charge_mm+0xa0/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
[] pagefault_out_of_memory+0x14/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
[] mm_fault_error+0x67/0x140
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
[] __do_page_fault+0x4ec/0x560
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
[] ? __enqueue_entity+0x78/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
[] ? set_next_entity+0x95/0xb0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
[] ? __switch_to+0x167/0x580
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
[] do_page_fault+0x31/0x70
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
[] page_fault+0x28/0x30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
/mesos_test killed as a result of limit of /mesos_test
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
usage 65536kB, limit 65536kB, failcnt 24
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] memory+swap: 
usage 0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: usage 
0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memory 
cgroup stats for /mesos_test: cache:0KB rss:65536KB rss_huge:63488KB 
mapped_file:0KB writeback:0KB inactive_anon:0KB active_anon:0KB 
inactive_file:0KB active_file:0KB unevictable:65536KB
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052467] [ pid ]   
uid  tgid total_vm  rss nr_ptes swapents oom_score_adj name
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052574] [76599] 
0 765998245231766 1221 0 lt-memory-test-
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052575] Memory 
cgroup out of memory: Kill process 76599 (lt-memory-test-) score 14 or 
sacrifice child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed 
process 76599 (lt-memory-test-) total-vm:3

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---

(Updated July 24, 2015, 5:32 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Changes
---

Added a fix for flaky cgroups memory pressure test.


Bugs: MESOS-2660
https://issues.apache.org/jira/browse/MESOS-2660


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 

Diff: https://reviews.apache.org/r/36627/diff/


Testing
---

It seems there is still one more cgroups memory test failing on more test 
failing on my box. I'd like to fix that too and commit it together with this 
one. 

sudo make check

Verified that the process actually gets killed by oom-killer:

```
# tail -f /var/log/syslog

Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
lt-memory-test- cpuset=/ mems_allowed=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 PID: 
76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
#57~14.04.1-Ubuntu
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
BIOS 6.00 05/20/2014
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
88022efc1000 8801fd2efc30 81765721 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
8801fd2efc80 81165067 880231f10ee8 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
[] dump_stack+0x45/0x56
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
[] dump_header+0x7f/0x1f1
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
[] ? find_lock_task_mm+0x47/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
[] oom_kill_process+0x205/0x360
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
[] ? security_capable_noaudit+0x15/0x20
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
[] mem_cgroup_oom_synchronize+0x581/0x5e0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
[] ? mem_cgroup_try_charge_mm+0xa0/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
[] pagefault_out_of_memory+0x14/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
[] mm_fault_error+0x67/0x140
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
[] __do_page_fault+0x4ec/0x560
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
[] ? __enqueue_entity+0x78/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
[] ? set_next_entity+0x95/0xb0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
[] ? __switch_to+0x167/0x580
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
[] do_page_fault+0x31/0x70
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
[] page_fault+0x28/0x30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
/mesos_test killed as a result of limit of /mesos_test
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
usage 65536kB, limit 65536kB, failcnt 24
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] memory+swap: 
usage 0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: usage 
0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memory 
cgroup stats for /mesos_test: cache:0KB rss:65536KB rss_huge:63488KB 
mapped_file:0KB writeback:0KB inactive_anon:0KB active_anon:0KB 
inactive_file:0KB active_file:0KB unevictable:65536KB
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052467] [ pid ]   
uid  tgid total_vm  rss nr_ptes swapents oom_score_adj name
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052574] [76599] 
0 765998245231766 1221 0 lt-memory-test-
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052575] Memory 
cgroup out of memory: Kill process 76599 (lt-memory-test-) score 14 or 
sacrifice child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed 
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,

Re: Review Request 36805: Updated slave to always set task status's uuid in status update.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/#review93015
---


Bad patch!

Reviews applied: [36805]

Failed command: ./support/apply-review.sh -n -r 36805

Error:
 2015-07-25 00:29:34 URL:https://reviews.apache.org/r/36805/diff/raw/ 
[2971/2971] -> "36805.patch" [1]
error: patch failed: src/scheduler/scheduler.cpp:625
error: src/scheduler/scheduler.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On July 25, 2015, 12:04 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36805/
> ---
> 
> (Updated July 25, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This should've been done in 0.23.0.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658 
>   src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
> 
> Diff: https://reviews.apache.org/r/36805/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36625: Windows: Split up platform specific functions into separate headers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36625/
---

(Updated July 24, 2015, 5:24 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Alex Clemmer, 
and Joris Van Remoortere.


Changes
---

Split up thread.hpp


Summary (updated)
-

Windows: Split up platform specific functions into separate headers.


Bugs: MESOS-3101
https://issues.apache.org/jira/browse/MESOS-3101


Repository: mesos


Description (updated)
---

To support the upcoming Windows Containerizer (MESOS-3094), we're splitting up 
(refactoring) platform specific functions into separate files.

We will avoid having `#ifdef __WINDOWS__` all over the stout/libprcess code by 
separating Linux/Windows versions.
This first patch is to establish a pattern in splitting up the headers.

Patterns:

* abort.hpp, format.hpp, gzip.hpp, thread.hpp - Functions are moved to a Linux 
folder; copied to a Windows folder and gutted for later implementation.
* duration.hpp - An #ifdef for one of the headers (time.h vs Winsock2.h). No 
need to split the header.
* exit.hpp, unreachable.hpp - Even though the implementations only differ by a 
single (compilation) macro, the methods are still copy-pasted into different 
files.
* ip.hpp - Needed to split the class IP into ip/ip.hpp so that the include 
order is ip/ip.hpp, ip.hpp (for common functions), then [linux|windows]/ip.hpp.
* net.hpp - Multiple #ifdef's needed in the top-level file. Linux file needed 
forward declarations of some functions.


Other:

* Instances of #include "local file.hpp" were changed to #include " to match os.hpp.
* Some missing #endif comments (i.e. `// __APPLE__`) were added.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
3aa9487bed2df038ca27a8bb94c24608ca7910a4 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
bba8303347aac3f70566a9e69625a928cfb1bd24 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
8c16a224433d7a43bf6bf17e1129e6eb9bbbd573 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
0b95819205af6caae05c01cb4d0b25620abe791c 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
a0ea23797376288e8dc96886fd3c0702e5edf846 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/exit.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/format.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/gzip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/thread.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/linux/unreachable.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
a538fb1a343aab039aecabe508b7747e683fd46e 
  3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
552d6e97c882a36d6a889af205c422e51f544b34 
  3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 
fed0a7ba81c98be83a0d66c2317e768877f8e40d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/abort.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/exit.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/ip.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/thread.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/unreachable.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/36625/diff/


Testing (updated)
---

`make` and `make check` (Mac OSX)


Thanks,

Joseph Wu

Re: Review Request 36803: Added helpers for converting scheduler messages to Events.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/#review93014
---


Patch looks great!

Reviews applied: [36803]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 11:27 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36803/
> ---
> 
> (Updated July 24, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helpers for converting scheduler messages to Events.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
>   src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
>   src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
> 
> Diff: https://reviews.apache.org/r/36803/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36805: Updated slave to always set task status's uuid in status update.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/#review93013
---

Ship it!


Thanks!

- Ben Mahler


On July 25, 2015, 12:04 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36805/
> ---
> 
> (Updated July 25, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This should've been done in 0.23.0.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658 
>   src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
> 
> Diff: https://reviews.apache.org/r/36805/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36803: Added helpers for converting scheduler messages to Events.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/#review93012
---

Ship it!


Ship It!

- Ben Mahler


On July 24, 2015, 11:27 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36803/
> ---
> 
> (Updated July 24, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helpers for converting scheduler messages to Events.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
>   src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
>   src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
> 
> Diff: https://reviews.apache.org/r/36803/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 36805: Updated slave to always set task status's uuid in status update.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

This should've been done in 0.23.0.


Diffs
-

  src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658 
  src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
  src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 

Diff: https://reviews.apache.org/r/36805/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 36804: Added documentation about MesosIsolator.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36804/#review93011
---

Ship it!


Ship It!

- Benjamin Hindman


On July 24, 2015, 11:28 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36804/
> ---
> 
> (Updated July 24, 2015, 11:28 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation about MesosIsolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolator.hpp 
> aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b 
> 
> Diff: https://reviews.apache.org/r/36804/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Jie Yu]

> On July 24, 2015, 6:52 p.m., Benjamin Hindman wrote:
> > src/slave/containerizer/isolator.hpp, line 37
> > 
> >
> > This class should be documented. In particular, that it's just a 
> > wrapper around IsolatorProcess that to support async isolators. Let's 
> > please get in the habit of adding more documentation!

https://reviews.apache.org/r/36804/


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92961
---


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 36804: Added documentation about MesosIsolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36804/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added documentation about MesosIsolator.


Diffs
-

  src/slave/containerizer/isolator.hpp aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b 

Diff: https://reviews.apache.org/r/36804/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 36803: Added helpers for converting scheduler messages to Events.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/
---

Review request for mesos, Anand Mazumdar and Ben Mahler.


Repository: mesos


Description
---

Added helpers for converting scheduler messages to Events.


Diffs
-

  src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
  src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
  src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 

Diff: https://reviews.apache.org/r/36803/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 36761: Added tests for unset framework pid in the slave.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review93006
---


Patch looks great!

Reviews applied: [36759, 36760, 36761]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 10:27 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> ---
> 
> (Updated July 24, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36801/#review93005
---

Ship it!



src/Makefile.am (line 1481)


white space.



src/Makefile.am (line 1489)


ws



src/Makefile.am (line 1492)


ws


- Vinod Kone


On July 24, 2015, 10:56 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36801/
> ---
> 
> (Updated July 24, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved containerizer related tests under src/tests/containerizer.
> 
> As we adding more and more tests, it makes sense to have a hierarchical 
> structure for our tests to improve searchablity and readability.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 93a6a7abb81543fa2c03b35d1320c404e8d62851 
>   src/tests/cgroups_isolator_tests.cpp  
>   src/tests/cgroups_tests.cpp b63d956b9dafb2c485080ff5e016e2a05f03db15 
>   src/tests/composing_containerizer_tests.cpp  
>   src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
>   src/tests/docker_containerizer_tests.cpp  
>   src/tests/docker_tests.cpp  
>   src/tests/external_containerizer_test.cpp 
> 17bfb72cbefc637d45fa26cf5b412b58059282a9 
>   src/tests/fs_tests.cpp  
>   src/tests/isolator.hpp  
>   src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4 
>   src/tests/launch_tests.cpp  
>   src/tests/launcher.hpp  
>   src/tests/memory_pressure_tests.cpp  
>   src/tests/memory_test_helper.hpp  
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
>   src/tests/memory_test_helper_main.cpp 
> 362535fe85d84eb16d6db60c0183aa249eab5b07 
>   src/tests/ns_tests.cpp bcd0e12a302e60e602a768fd794407cce1394ea2 
>   src/tests/perf_tests.cpp  
>   src/tests/port_mapping_tests.cpp  
>   src/tests/routing_tests.cpp  
>   src/tests/sched_tests.cpp  
>   src/tests/setns_test_helper.hpp  
>   src/tests/setns_test_helper.cpp eff1e6e85a344ed9f45ae9c1c2b49bf0d265a184 
>   src/tests/setns_test_helper_main.cpp 
> 00d38166fcc44fc23093a2f50dc2f8139cdc5e74 
> 
> Diff: https://reviews.apache.org/r/36801/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36801/
---

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos


Description
---

Moved containerizer related tests under src/tests/containerizer.

As we adding more and more tests, it makes sense to have a hierarchical 
structure for our tests to improve searchablity and readability.


Diffs
-

  src/Makefile.am 93a6a7abb81543fa2c03b35d1320c404e8d62851 
  src/tests/cgroups_isolator_tests.cpp  
  src/tests/cgroups_tests.cpp b63d956b9dafb2c485080ff5e016e2a05f03db15 
  src/tests/composing_containerizer_tests.cpp  
  src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
  src/tests/docker_containerizer_tests.cpp  
  src/tests/docker_tests.cpp  
  src/tests/external_containerizer_test.cpp 
17bfb72cbefc637d45fa26cf5b412b58059282a9 
  src/tests/fs_tests.cpp  
  src/tests/isolator.hpp  
  src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4 
  src/tests/launch_tests.cpp  
  src/tests/launcher.hpp  
  src/tests/memory_pressure_tests.cpp  
  src/tests/memory_test_helper.hpp  
  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
  src/tests/memory_test_helper_main.cpp 
362535fe85d84eb16d6db60c0183aa249eab5b07 
  src/tests/ns_tests.cpp bcd0e12a302e60e602a768fd794407cce1394ea2 
  src/tests/perf_tests.cpp  
  src/tests/port_mapping_tests.cpp  
  src/tests/routing_tests.cpp  
  src/tests/sched_tests.cpp  
  src/tests/setns_test_helper.hpp  
  src/tests/setns_test_helper.cpp eff1e6e85a344ed9f45ae9c1c2b49bf0d265a184 
  src/tests/setns_test_helper_main.cpp 00d38166fcc44fc23093a2f50dc2f8139cdc5e74 

Diff: https://reviews.apache.org/r/36801/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/#review93003
---


Patch looks great!

Reviews applied: [36718, 36754, 36755, 36799]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 10:05 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36799/
> ---
> 
> (Updated July 24, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new names better reflect the contents since the Limitation and State are 
> for the container.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 
>   include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 
>   src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
>   src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
>   src/slave/containerizer/isolator.hpp 
> aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b 
>   src/slave/containerizer/isolator.cpp 
> 9d2af8b42f37550a75eae52ef1f5c1a647131072 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 409a3a997a7b2c7104421f48ee1078e8fd369a2a 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ccaf1e372c0693522aed2e0aa8d680e404faf8ef 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> d43ba6d3debfc6279a023bd28f584635eeb79dc3 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 70c9868dbb670278b3bb4e4322598285488851fe 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 3796b30a56799a00f1ddbec9bd20b9203d689856 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> a62a4e6ca573230af17781495eae63115ef28f00 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> 2afc572d20acb3d31d3981d99ffe6ea45ae93dff 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 5e5a896d9888375259a38dcc68d03dce6406a28e 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 61db386b1d6f602edcba8a1fa251cfd12a534aca 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 29be94b96ed9a3db90c88a4b60517d78e95b7144 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 3f35782c9e0e458169777bab778178c524a58b2b 
>   src/slave/containerizer/isolators/posix.hpp 
> 58d9911fef6f57dd078c533221094f9c69489fe4 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 845496c865a92946910a4e9dd50d05482503b7ef 
>   src/slave/containerizer/launcher.hpp 
> a19b8592f943d3a2ae0337c142f54c0ada204536 
>   src/slave/containerizer/launcher.cpp 
> ecb33309ff0941985eebf7a94d831330076978de 
>   src/slave/containerizer/linux_launcher.hpp 
> 28a7d35d99881486a9d63eb0aaedad15cb99 
>   src/slave/containerizer/linux_launcher.cpp 
> ed2e881f555d651ad1e5f1b62f32848ade09b424 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 5155362bef9163af3fa5334be3a39b91549e1ec1 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 11eedf30674b326ea3e1f6f71d27f9eb54126368 
>   src/slave/containerizer/provisioner.hpp 
> f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 
>   src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
>   src/tests/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 
>   src/tests/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 
> 
> Diff: https://reviews.apache.org/r/36799/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 36761: Added tests for unset framework pid in the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review93002
---

Ship it!


Ship It!

- Vinod Kone


On July 24, 2015, 10:27 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> ---
> 
> (Updated July 24, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36760/#review93001
---

Ship it!


Ship It!

- Vinod Kone


On July 24, 2015, 10:27 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36760/
> ---
> 
> (Updated July 24, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is anticipation of HTTP scheduler support in 0.24.0.
> Note that the 'pid' is set for driver-based schedulers. The
> corresponding master changes to not set 'pid' for HTTP
> schedulers have not occurred yet.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
>   src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
>   src/slave/state.hpp 4e00468a777145e3c61b8dee7dfe496f8d65b0e4 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 
>   src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 
> 
> Diff: https://reviews.apache.org/r/36760/diff/
> 
> 
> Testing
> ---
> 
> Added tests in [r/36761](https://reviews.apache.org/r/36761/).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36761: Added tests for unset framework pid in the slave.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/
---

(Updated July 24, 2015, 10:27 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Some cleanups from vinod's review.


Bugs: MESOS-3132
https://issues.apache.org/jira/browse/MESOS-3132


Repository: mesos


Description
---

Since we do not yet have HTTP schedulers, this adds tests
that spoof empty pids coming from the master.


Diffs (updated)
-

  src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
  src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 

Diff: https://reviews.apache.org/r/36761/diff/


Testing
---

Ran in repetition.


Thanks,

Ben Mahler

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36759/
---

(Updated July 24, 2015, 10:27 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Added more explanation to why the handler was installed in 0.24.0. NNFR.


Bugs: MESOS-3132
https://issues.apache.org/jira/browse/MESOS-3132


Repository: mesos


Description
---

This enables the slave to forward messages through the master.


Diffs (updated)
-

  src/master/master.hpp 29113cb4e9a5c7c122e14feb0654ae93798a5dab 
  src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
  src/master/metrics.hpp d37d74a472a3e5605a4689420513f56e713aa8f3 
  src/master/metrics.cpp 10e2937c2364b4025ec44ddfe47c3cb958a62773 
  src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 

Diff: https://reviews.apache.org/r/36759/diff/


Testing
---

Added tests in [r/36761](https://reviews.apache.org/r/36761/).


Thanks,

Ben Mahler

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36760/
---

(Updated July 24, 2015, 10:27 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Cleanups from reviews.


Bugs: MESOS-3132
https://issues.apache.org/jira/browse/MESOS-3132


Repository: mesos


Description
---

This is anticipation of HTTP scheduler support in 0.24.0.
Note that the 'pid' is set for driver-based schedulers. The
corresponding master changes to not set 'pid' for HTTP
schedulers have not occurred yet.


Diffs (updated)
-

  src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
  src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45 
  src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
  src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
  src/slave/state.hpp 4e00468a777145e3c61b8dee7dfe496f8d65b0e4 
  src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
  src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 
  src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 

Diff: https://reviews.apache.org/r/36760/diff/


Testing
---

Added tests in [r/36761](https://reviews.apache.org/r/36761/).


Thanks,

Ben Mahler

Re: Review Request 36761: Added tests for unset framework pid in the slave.

[Ben Mahler]

> On July 24, 2015, 6:36 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 2641
> > 
> >
> > s/Fail over/Restart/

Yeah that's better, I'll change the test name too.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review92954
---


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

[Benjamin Hindman]

> On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp, line 32
> > 
> >
> > Why not add these to try.hpp like we did with Option?
> 
> Ben Mahler wrote:
> Decided to punt because I'm not sure whether equality should include the 
> error message equality, thoughts?

Hmm, good question. I might start by not testing for error message equality to 
deter that use case, and see if it becomes necessary later. Either way, a 
comment above these operators as to why we're keeping them here instead of 
pulling them to try.hpp would be very helpful for a future code reader!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36677/#review92812
---


On July 22, 2015, 11:24 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36677/
> ---
> 
> (Updated July 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-3067
> https://issues.apache.org/jira/browse/MESOS-3067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that most "Record-IO" encodings are used for file I/O
> and consequently use a fixed-size header to encode the record
> length. However, decoding a base-10 integer is more
> straightforward to implement in most languages, and so this
> was chosen instead. (Note that the Twitter streaming API
> uses the same technique for portability).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 2394b95462182273464f0847f416ad83c3b64485 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 8c75f6b28c18596018eaefe427b238424aae2fd9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36677/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

[Ben Mahler]

> On July 24, 2015, 2:17 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 1302
> > 
> >
> > Option > 
> > The default constructor already initializes to None.

Right, we often do this just to make it more readable, although I can see how 
that's a bit inconsistent with our other types.. hmm..


> On July 24, 2015, 2:17 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 1758
> > 
> >
> > Curious, why not UPID() as is the case at other places ?

Thanks, I'll use getOrElse then.


> On July 24, 2015, 2:17 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 3039
> > 
> >
> > s/to/at

This is where the message is being sent "to", we use "from" and "to" pretty 
consistently, why "at"?


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36760/#review92855
---


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36760/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is anticipation of HTTP scheduler support in 0.24.0.
> Note that the 'pid' is set for driver-based schedulers. The
> corresponding master changes to not set 'pid' for HTTP
> schedulers have not occurred yet.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
>   src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
>   src/slave/state.hpp 4e00468a777145e3c61b8dee7dfe496f8d65b0e4 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36760/diff/
> 
> 
> Testing
> ---
> 
> Added tests in [r/36761](https://reviews.apache.org/r/36761/).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

The new names better reflect the contents since the Limitation and State are 
for the container.


Diffs
-

  include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 
  include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 
  src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
  src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
  src/slave/containerizer/isolator.hpp aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b 
  src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
409a3a997a7b2c7104421f48ee1078e8fd369a2a 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ccaf1e372c0693522aed2e0aa8d680e404faf8ef 
  src/slave/containerizer/isolators/cgroups/mem.hpp 
d43ba6d3debfc6279a023bd28f584635eeb79dc3 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
70c9868dbb670278b3bb4e4322598285488851fe 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
3796b30a56799a00f1ddbec9bd20b9203d689856 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
a62a4e6ca573230af17781495eae63115ef28f00 
  src/slave/containerizer/isolators/filesystem/posix.hpp 
2afc572d20acb3d31d3981d99ffe6ea45ae93dff 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
5e5a896d9888375259a38dcc68d03dce6406a28e 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
4694025eb9b3adad70cc1ec7541c3d3f95fec2bc 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
61db386b1d6f602edcba8a1fa251cfd12a534aca 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
29be94b96ed9a3db90c88a4b60517d78e95b7144 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
3f35782c9e0e458169777bab778178c524a58b2b 
  src/slave/containerizer/isolators/posix.hpp 
58d9911fef6f57dd078c533221094f9c69489fe4 
  src/slave/containerizer/isolators/posix/disk.hpp 
86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a 
  src/slave/containerizer/isolators/posix/disk.cpp 
845496c865a92946910a4e9dd50d05482503b7ef 
  src/slave/containerizer/launcher.hpp a19b8592f943d3a2ae0337c142f54c0ada204536 
  src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de 
  src/slave/containerizer/linux_launcher.hpp 
28a7d35d99881486a9d63eb0aaedad15cb99 
  src/slave/containerizer/linux_launcher.cpp 
ed2e881f555d651ad1e5f1b62f32848ade09b424 
  src/slave/containerizer/mesos/containerizer.hpp 
5155362bef9163af3fa5334be3a39b91549e1ec1 
  src/slave/containerizer/mesos/containerizer.cpp 
11eedf30674b326ea3e1f6f71d27f9eb54126368 
  src/slave/containerizer/provisioner.hpp 
f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 
  src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
  src/tests/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 
  src/tests/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 

Diff: https://reviews.apache.org/r/36799/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36755/
---

(Updated July 24, 2015, 6:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3133
https://issues.apache.org/jira/browse/MESOS-3133


Repository: mesos


Description
---

Append the environment variables returned by Isolator::prepare() to the
list of environment variables being passed to the executor. Added a test
to verify that the executor is launched with the said environment
variables.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
11eedf30674b326ea3e1f6f71d27f9eb54126368 
  src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 

Diff: https://reviews.apache.org/r/36755/diff/


Testing
---

make check with an added test.


Thanks,

Kapil Arya

Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36754/
---

(Updated July 24, 2015, 6:05 p.m.)


Review request for mesos and Jie Yu.


Changes
---

renamed IsolatorPrepareInfo to ContainerPrepareInfo; rebased.


Summary (updated)
-

Updated Isolator::prepare to return ContainerPrepareInfo.


Bugs: MESOS-3133
https://issues.apache.org/jira/browse/MESOS-3133


Repository: mesos


Description (updated)
---

ContainerPrepareInfo contains CommandInfo as well as Environment. While
the CommandInfo lists the commands to be run inside the containerized
context, the Environment allows the isolator to specify environment
variables for the Executor itself.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 
  include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 
  src/slave/containerizer/isolator.hpp aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b 
  src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
409a3a997a7b2c7104421f48ee1078e8fd369a2a 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ccaf1e372c0693522aed2e0aa8d680e404faf8ef 
  src/slave/containerizer/isolators/cgroups/mem.hpp 
d43ba6d3debfc6279a023bd28f584635eeb79dc3 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
70c9868dbb670278b3bb4e4322598285488851fe 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
3796b30a56799a00f1ddbec9bd20b9203d689856 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
a62a4e6ca573230af17781495eae63115ef28f00 
  src/slave/containerizer/isolators/filesystem/posix.hpp 
2afc572d20acb3d31d3981d99ffe6ea45ae93dff 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
5e5a896d9888375259a38dcc68d03dce6406a28e 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
4694025eb9b3adad70cc1ec7541c3d3f95fec2bc 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
61db386b1d6f602edcba8a1fa251cfd12a534aca 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
29be94b96ed9a3db90c88a4b60517d78e95b7144 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
3f35782c9e0e458169777bab778178c524a58b2b 
  src/slave/containerizer/isolators/posix.hpp 
58d9911fef6f57dd078c533221094f9c69489fe4 
  src/slave/containerizer/isolators/posix/disk.hpp 
86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a 
  src/slave/containerizer/isolators/posix/disk.cpp 
845496c865a92946910a4e9dd50d05482503b7ef 
  src/slave/containerizer/mesos/containerizer.hpp 
5155362bef9163af3fa5334be3a39b91549e1ec1 
  src/slave/containerizer/mesos/containerizer.cpp 
11eedf30674b326ea3e1f6f71d27f9eb54126368 
  src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
  src/tests/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 
  src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4 

Diff: https://reviews.apache.org/r/36754/diff/


Testing
---

make check with an added test (in the followup review).


Thanks,

Kapil Arya

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

[Ben Mahler]

> On July 24, 2015, 6:36 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 3199
> > 
> >
> > i would just put the quote in the next line.
> > 
> > here and everywhere else below.

Really? That looks less readable IMO, easier to make mistakes that way by 
forgetting the close quote as well, no?


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36759/#review92939
---


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36759/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This enables the slave to forward messages through the master.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
>   src/master/metrics.hpp d37d74a472a3e5605a4689420513f56e713aa8f3 
>   src/master/metrics.cpp 10e2937c2364b4025ec44ddfe47c3cb958a62773 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
> 
> Diff: https://reviews.apache.org/r/36759/diff/
> 
> 
> Testing
> ---
> 
> Added tests in [r/36761](https://reviews.apache.org/r/36761/).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

[Michael Park]

> On July 8, 2015, 5:59 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, lines 133-135
> > 
> >
> > And we introduce a libprocess dependency into `Allocator` interface. I 
> > think it's a prominent step, right now an allocator implementation is not 
> > even required to be asynchronous. I don't want to say it's a bad change, I 
> > want us to think a bit more about the consequences of such step. Maybe it 
> > is worth discussing on the dev list.
> 
> Jie Yu wrote:
> Most of our module interfaces depends on libprocess (e.g., resource 
> estimator, qos controller, isolator, etc.). Why do you think this is a 
> prominent step?
> 
> > right now an allocator implementation is not even required to be 
> asynchronous
> 
> I think at the time we introduced modules, we agreed on that internal 
> interfaces are subject to change without needing a formal deprecation cycle. 
> It's up to the module developer to use proper versioning to deal with changes 
> in the interfaces.
> 
> Alexander Rukletsov wrote:
> To clarify, I think it's fine updating an interface, but giving the 
> growing complexity of allocator, introducing a libprocess dependency doesn't 
> make it easier : ). However, if we all share same concerns and are eager to 
> refactor the allocator interface in the near future, I'm fine with the change.

Hey Alex, I've filed 
[MESOS-3147](https://issues.apache.org/jira/browse/MESOS-3147) to keep track of 
the allocator refactor work and to get take the discussion out of these 
reviews. Please augment the ticket with your thoughts and plans, Thanks!


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35947/#review90936
---


On July 24, 2015, 9:26 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35947/
> ---
> 
> (Updated July 24, 2015, 9:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-3146
> https://issues.apache.org/jira/browse/MESOS-3146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Needed to implement the master HTTP endpoints: `/reserve`, `/unreserve`, 
> `/create` and `/destroy`.
> 
> This API is similar to `updateSlave` which is currently very specific to 
> oversubscription.
> I considered consolidating `updateAvailable` and `updateSlave` but it will 
> require making offers be generated within the allocator to enable this.
> 
> In specific, `updateAvailable` could fail if there aren't sufficient 
> available resources to update, whereas `updateSlave` avoids failing by 
> keeping the allocator in an over-allocated state. For `updateSlave`, leaving 
> the allocator in an over-allocated state is ok. This is because it does not 
> modify resources therefore `total - allocated` will work out to __empty__. 
> `updateAvailable` cannot leave the allocator in an over-allocated state, 
> because it modifies resources, and therefore `total - allocated` is not 
> guaranteed to yield __empty__.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 22992c0c77058af4fcd28aa8e4a1191693a16f44 
>   src/master/allocator/mesos/allocator.hpp 
> 72470ec7f56f84a9a9815c09adb88def90ef672f 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3264d145d52b48852878abf7ab9be29ab98208cc 
>   src/tests/hierarchical_allocator_tests.cpp 
> 3258840135290cd008ca09235d18b7f093dafd2e 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
> 
> Diff: https://reviews.apache.org/r/35947/diff/
> 
> 
> Testing
> ---
> 
> (1) Added `HierarchicalAllocatorTest.updateAvailableSuccess` and 
> `HierarchicalAllocatorTest.updateAvailableFail`
> (2) `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36705/#review92991
---

Ship it!


Ship It!

- Benjamin Hindman


On July 22, 2015, 8:23 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36705/
> ---
> 
> (Updated July 22, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Replaced ThreadLocal use with thread_local.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/executor.hpp 
> 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
>   3rdparty/libprocess/include/process/process.hpp 
> 8620547148f8a69d5b661eaf08063ca72347b6a4 
>   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
>   3rdparty/libprocess/src/libev.cpp 8960c75010e3ceca3486a1fbb0fdeeffd62f4ec8 
>   3rdparty/libprocess/src/libevent.hpp 
> 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
>   3rdparty/libprocess/src/libevent.cpp 
> 02f9e61c1357e7b450e53b252b49d1979e782ae8 
>   3rdparty/libprocess/src/process.cpp 
> d6b0d5517964bf7c7276689e801a38b34a3f9db2 
> 
> Diff: https://reviews.apache.org/r/36705/diff/
> 
> 
> Testing
> ---
> 
> make check with gcc-4.8, gcc-4.9, clang-3.5, clang-3.6
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

[Michael Park]

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, line 749
> > 
> >
> > I think reserve is too abstract and may collide with future actions 
> > (think quota). How about `/dynamic/reserve`?
> 
> Alexander Rukletsov wrote:
> Though we currently do not support slashes in endpoints, I think we 
> should fix that first before introducing a `/reserve` endpoint, given these 
> endpoint are not targeted for 0.23.
> 
> Joris Van Remoortere wrote:
> Cody had some patches for enabling sub namespaces in endpoints (as in 
> enabling slashes). Might be worth pulling those in.
> 
> Alexander Rukletsov wrote:
> Yep, it's https://issues.apache.org/jira/browse/MESOS-2130, I plan to 
> bring up the discussion today at the community sync.

The concensus for now seems that (1) we introduce the allocator changes, but 
address the allocator refactor sooner rather than later, (2) go with `/reserve` 
for now and update them once the HTTP API folks get to supporting the nested 
endpoint stuff.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review88781
---


On June 28, 2015, 8:36 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35702/
> ---
> 
> (Updated June 28, 2015, 8:36 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This involved a lot more challenges than I anticipated, I've captured the 
> various approaches and limitations and deal-breakers of those approaches 
> here: [Master Endpoint Implementation 
> Challenges](https://docs.google.com/document/d/1cwVz4aKiCYP9Y4MOwHYZkyaiuEv7fArCye-vPvB2lAI/edit#)
> 
> Key points:
> 
> * This is a stop-gap solution until we shift the offer creation/management 
> logic from the master to the allocator.
> * `updateAvailable` and `updateSlave` are kept separate because
>   (1) `updateAvailable` is allowed to fail whereas `updateSlave` must not.
>   (2) `updateAvailable` returns a `Future` whereas `updateSlave` does not.
>   (3) `updateAvailable` never leaves the allocator in an over-allocated state 
> and must not, whereas `updateSlave` does, and can.
> * The algorithm:
> * Initially, the master pessimistically assume that what seems like 
> "available" resources will be gone.
>   This is due to the race between the allocator scheduling an `allocate` 
> call to itself vs master's `allocator->updateAvailable` invocation.
>   As such, we first try to satisfy the request only with the offered 
> resources.
> * We greedily rescind one offer at a time until we've rescinded 
> sufficiently many offers.
>   IMPORTANT: We perform `recoverResources(..., Filters())` rather than 
> `recoverResources(..., None())` so that we can pretty much always win the 
> race against `allocate`.
>  In the case that we lose, no disaster occurs. We simply fail 
> to satisfy the request.
> * If we still don't have enough resources after resciding all offers, be 
> optimistic and forward the request to the allocator since there may be 
> available resources to satisfy the request.
> * If the allocator returns a failure, report the error to the user with 
> `PreconditionFailed`. This could be updated to be `Forbidden`, or `Conflict` 
> maybe as well. We'll pick one eventually.
> 
> This approach is clearly not ideal, since we would prefer to rescind as 
> little offers as possible.
> The challenges of implementing the ideal solution in the current state is 
> described in the document above.
> 
> TODO(mpark): Add more comments and test cases.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df 
>   src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 
>   src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 
> 
> Diff: https://reviews.apache.org/r/35702/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
---

(Updated July 24, 2015, 9:42 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco 
Massenzio, and Vinod Kone.


Changes
---

Moving subscribeHttpFramework(...)/subscribe(...) in a separate patch. This 
patch only deals with the framework refactoring now.


Bugs: MESOS-2294
https://issues.apache.org/jira/browse/MESOS-2294


Repository: mesos


Description (updated)
---

This change refactors the framework struct in master to introduce support for
http frameworks.
- pid becomes a optional field now in the framework struct.
- added optional fields for supporting http frameworks to the framework struct


Diffs (updated)
-

  src/common/protobuf_utils.hpp 2e827a0923de83d5cf853a12435b451cc7c55891 
  src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
  src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 
  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
  src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 

Diff: https://reviews.apache.org/r/36318/diff/


Testing
---

make check + tests now go in a separate patch now.


Thanks,

Anand Mazumdar

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

[Ben Mahler]

> On July 23, 2015, 6:01 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp, line 130
> > 
> >
> > Not needed?

Yeah, I've restructured the logic to be more clear (now we always transition to 
RECORD, but for 0 length we parse immediately and transition back to HEADER). 
Thanks jie!


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36677/#review92627
---


On July 22, 2015, 11:24 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36677/
> ---
> 
> (Updated July 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-3067
> https://issues.apache.org/jira/browse/MESOS-3067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that most "Record-IO" encodings are used for file I/O
> and consequently use a fixed-size header to encode the record
> length. However, decoding a base-10 integer is more
> straightforward to implement in most languages, and so this
> was chosen instead. (Note that the Twitter streaming API
> uses the same technique for portability).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 2394b95462182273464f0847f416ad83c3b64485 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 8c75f6b28c18596018eaefe427b238424aae2fd9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36677/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

[Ben Mahler]

> On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote:
> > The names 'encode' and 'decode' seem weird for the function parameters to 
> > Encoder and Decoder, since Encoder::encode and Decoder::decode (which are 
> > named the same thing) are really the things that are "encoding" and 
> > "decoding" the stream (i.e., adding the number and newline). These inner 
> > functions are more like 'serialize' and 'deserialize'? And by default 
> > shouldn't we just assume we'll take string to string?
> > 
> > Also, this is not async, but I guess we'll async read data that we plug 
> > into Decoder::Decode?

serialize and deserialize are much clearer, thanks Ben!

Yeah, it's not async for now, so we'll just plug in the data, but per my 
comment earlier I'll add a TODO for making it async.


> On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp, line 32
> > 
> >
> > Why not add these to try.hpp like we did with Option?

Decided to punt because I'm not sure whether equality should include the error 
message equality, thoughts?


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36677/#review92812
---


On July 22, 2015, 11:24 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36677/
> ---
> 
> (Updated July 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-3067
> https://issues.apache.org/jira/browse/MESOS-3067
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that most "Record-IO" encodings are used for file I/O
> and consequently use a fixed-size header to encode the record
> length. However, decoding a base-10 integer is more
> straightforward to implement in most languages, and so this
> was chosen instead. (Note that the Twitter streaming API
> uses the same technique for portability).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 2394b95462182273464f0847f416ad83c3b64485 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 8c75f6b28c18596018eaefe427b238424aae2fd9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36677/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35947/
---

(Updated July 24, 2015, 9:26 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, 
and Jie Yu.


Changes
---

Added JIRA ticket.


Bugs: MESOS-3146
https://issues.apache.org/jira/browse/MESOS-3146


Repository: mesos


Description
---

Needed to implement the master HTTP endpoints: `/reserve`, `/unreserve`, 
`/create` and `/destroy`.

This API is similar to `updateSlave` which is currently very specific to 
oversubscription.
I considered consolidating `updateAvailable` and `updateSlave` but it will 
require making offers be generated within the allocator to enable this.

In specific, `updateAvailable` could fail if there aren't sufficient available 
resources to update, whereas `updateSlave` avoids failing by keeping the 
allocator in an over-allocated state. For `updateSlave`, leaving the allocator 
in an over-allocated state is ok. This is because it does not modify resources 
therefore `total - allocated` will work out to __empty__. `updateAvailable` 
cannot leave the allocator in an over-allocated state, because it modifies 
resources, and therefore `total - allocated` is not guaranteed to yield 
__empty__.


Diffs
-

  include/mesos/master/allocator.hpp 22992c0c77058af4fcd28aa8e4a1191693a16f44 
  src/master/allocator/mesos/allocator.hpp 
72470ec7f56f84a9a9815c09adb88def90ef672f 
  src/master/allocator/mesos/hierarchical.hpp 
3264d145d52b48852878abf7ab9be29ab98208cc 
  src/tests/hierarchical_allocator_tests.cpp 
3258840135290cd008ca09235d18b7f093dafd2e 
  src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 

Diff: https://reviews.apache.org/r/35947/diff/


Testing
---

(1) Added `HierarchicalAllocatorTest.updateAvailableSuccess` and 
`HierarchicalAllocatorTest.updateAvailableFail`
(2) `make check`


Thanks,

Michael Park

Re: Review Request 36794: Handle potential 'net::hostname()' failure.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36794/#review92986
---

Ship it!


Committing, thanks MPark!


src/sched/sched.cpp (line 1526)


s/result/hostname/?


- Benjamin Hindman


On July 24, 2015, 9:24 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36794/
> ---
> 
> (Updated July 24, 2015, 9:24 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3145
> https://issues.apache.org/jira/browse/MESOS-3145
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
>   src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453 
> 
> Diff: https://reviews.apache.org/r/36794/diff/
> 
> 
> Testing
> ---
> 
> `make check` + successfully ran the following test:
> 
> ```
> $ sudo hostname foo  # an unresolvable hostname
> $ sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> $ LIBPROCESS_IP=127.0.0.1 ./src/mesos-execute --master=127.0.0.1:5050 
> --name=bar --command="while true; do sleep 100; done"
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 36794: Handle potential 'net::hostname()' failure.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36794/
---

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-3145
https://issues.apache.org/jira/browse/MESOS-3145


Repository: mesos


Description
---

See summary


Diffs
-

  include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
  src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453 

Diff: https://reviews.apache.org/r/36794/diff/


Testing
---

`make check` + successfully ran the following test:

```
$ sudo hostname foo  # an unresolvable hostname
$ sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
$ LIBPROCESS_IP=127.0.0.1 ./src/mesos-execute --master=127.0.0.1:5050 
--name=bar --command="while true; do sleep 100; done"
```


Thanks,

Michael Park

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review92985
---



src/master/main.cpp (lines 131 - 135)


I'd like to use 'advertise_ip' and 'advertise_port' here, and I'd also like 
to update the help string to really make it clear that WE HAVE NOT BOUND to 
this IP address, but rather it's the IP address that we tell _some parts of the 
stack_ that we are accessible by. I say "some parts of the stack" because there 
are likely other places in the code where we don't determine our IP address by 
looking at the IP address that comes from libprocess, but via reverse DNS or 
another mechanism, which means when we use that IP address it's unlikely that 
it will be the advertised IP.


- Benjamin Hindman


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34129/
> ---
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos and Cosmin Lehene.
> 
> 
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If set, these IP/Port shall be advertised by libprocess (although bind is
> not done on this IP/Port). If not set, libprocess advertises the IP/Port
> on which bind was done.
> 
> Command line arguments added:
> public_ip: Public IP address to reach mesos. Defaults to the command line 
> argument `ip`.
> public_port: Public port to reach mesos. Defaults to the command line 
> argument `port`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
>   docs/operational-guide.md 23b76ff129ca396a4b14a6826b4d842fc8527a8a 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/main.cpp d5666bc8ee8d7a0f0b8685f76d65dd1f9ac2a280 
> 
> Diff: https://reviews.apache.org/r/34129/diff/
> 
> 
> Testing
> ---
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 34128: Enable different IP/Port for external access.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review92983
---

Ship it!



3rdparty/libprocess/src/process.cpp (line 774)


Why the extra variable here? This part of the code shouldn't need to change 
IIUC.



3rdparty/libprocess/src/process.cpp (lines 819 - 835)


Let's be more specific in the naming here, how about 
LIBPROCESS_ADVERTISE_IP and LIBPROCESS_ADVERTISE_PORT. You use the verb 
'advertise' in your description above, which is much more self-explanatory than 
PUBLIC.

Also, I'm not sure why the 'os::getenv' change didn't make it in here but 
we should use that throught here as well (and 'numify' instead of 'atoi'), but 
feel free to follow up in a subsequent patch. Thanks!


- Benjamin Hindman


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34128/
> ---
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expose environment variables LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT 
> as the IP and
> port which libprocess would advertise (if set). If not set, it defaults to
> the IP and port on which it binded to.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> e3de3cd6b536aaaf59784360aed546512dd04dc9 
> 
> Diff: https://reviews.apache.org/r/34128/diff/
> 
> 
> Testing
> ---
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 36425: Enabling IP Discovery script

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review92972
---

Ship it!


I took care of these minor issues and also added a comment to replace update 
'os::shell' as per discussion on 
https://issues.apache.org/jira/browse/MESOS-3142.


docs/configuration.md (line 91)


Still would like to call this 'ip_discovery_command', to signify that we're 
executing a command which may or may not be a script. If we wanted this to be a 
path to a script we should have made the flag type be Path.



src/master/main.cpp (line 21)


Not needed any more! (No more popen.)


- Benjamin Hindman


On July 22, 2015, 7:39 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36425/
> ---
> 
> (Updated July 22, 2015, 7:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2902
> https://issues.apache.org/jira/browse/MESOS-2902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-2902
> 
> It is sometimes useful to enable an external script to
> configure the IP address the Mesos Master will bind to
> on the server, where it's not desirable to set the
> --ip flag and/or a "wrapper" script is not a viable option.
> 
> This patch adds a --ip_discovery_script to point to a local
> script that will emit as its only output the IP address that
> the Master will bind to: only spaces and newlines are allowed;
> further, as we cannot use the `libprocess` sub-processing
> facilities, we cannot timeout the script, should this block
> for long times (or even forever).
> 
> This will conflict with the --ip flag, so if both set, we will fail
> with an appropriate error message.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md babbd2f67b32d4f317cfdf8bb87f8725917b0aca 
>   src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 
> 
> Diff: https://reviews.apache.org/r/36425/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> also tested against a couple of simple scripts that emulate the three 
> possible cases: a valid IP; a bogus one; an error exit code.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36676: Removed pthread from Zookeeper test helper.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36676/#review92980
---

Ship it!


Ship It!

- Benjamin Hindman


On July 22, 2015, 5:59 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36676/
> ---
> 
> (Updated July 22, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/zookeeper.hpp 32fc83b95cd779fdf9b75460a7daeb9a053f21b6 
>   src/tests/zookeeper.cpp 5012017226bd08d3c0ddc2fd625e3db442497cee 
> 
> Diff: https://reviews.apache.org/r/36676/diff/
> 
> 
> Testing
> ---
> 
> Make check. Waiting for reviewbot to run java based tests.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36733: Moved framework struct in master to end of file

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/
---

(Updated July 24, 2015, 8:12 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
---

rebased + added a new line I had removed erroneously.


Repository: mesos


Description
---

Moved framework struct to end of file since the framework struct needs to know 
about the implementation of master for invoking templated send(...). Needed for 
r36318.


Diffs (updated)
-

  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 

Diff: https://reviews.apache.org/r/36733/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review92977
---

Ship it!



docs/operational-guide.md (line 50)


why would zookeeper try to reach master?

s/zookeeper/framework scheduler/


- Vinod Kone


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34129/
> ---
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos and Cosmin Lehene.
> 
> 
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If set, these IP/Port shall be advertised by libprocess (although bind is
> not done on this IP/Port). If not set, libprocess advertises the IP/Port
> on which bind was done.
> 
> Command line arguments added:
> public_ip: Public IP address to reach mesos. Defaults to the command line 
> argument `ip`.
> public_port: Public port to reach mesos. Defaults to the command line 
> argument `port`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
>   docs/operational-guide.md 23b76ff129ca396a4b14a6826b4d842fc8527a8a 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/main.cpp d5666bc8ee8d7a0f0b8685f76d65dd1f9ac2a280 
> 
> Diff: https://reviews.apache.org/r/34129/diff/
> 
> 
> Testing
> ---
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 34128: Enable different IP/Port for external access.

[Vinod Kone]

> On June 11, 2015, 7:34 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 820-836
> > 
> >
> > If two libprocess based unix processes (e.g., scheudler and master) are 
> > within the *same* bridged container, would they able to communicate with 
> > this change? Can you test this to confirm?
> > 
> > 
> > If not, a better option might be to instead have LIBPROCESS_BIND_IP and 
> > LIBPROCESS_BIND_PORT that just changes the address we bind to. 
> > LIBPROCESS_IP and LIBPROCESS_PORT semantics could be left untouched.
> 
> Anindya Sinha wrote:
> If 2 libprocess based unix processes are running, they would point to a 
> different  (most likely same public_ip but a different 
> public_port, ie. same LIBPROCESS_PUBLIC_IP but a different 
> LIBPROCESS_PUBLIC_PORT). The processes themselves would bind as it does today 
> on  (based in LIBPROCESS_IP and LIBPROCESS_PORT). Once a request 
> lands on a corresponding , a proxy listening on that 
> would forward that to the actual  corresponding to the 
> .
> 
> As an example, mesos-master binds on 10.11.12.13:5050 (ip:port) with 
> public_ip:public_port as 192.168.100.100:6050, and say scheduler binds on 
> 10.11.12.13:8081 with public_ip:public_port as 192.168.100.100:9081. Requests 
> received on 192.168.100.100:6050 shall be proxied over to 10.11.12.13:5050 
> (to reach mesos-master) and requests received on 192.168.100.100:9081 shall 
> be proxied over to 10.11.12.13:8081 (to reach scheduler).
> 
> Vinod Kone wrote:
> ```
> a proxy listening on that would forward that...
> ```
> 
> who sets up this proxy? or do you mean this is what happens currently in 
> bridged mode containers (e.g., docker)?
> 
> Anindya Sinha wrote:
> No this is not something that is part of docker. The proxy would be 
> something external to the container which would proxy the request to your 
> application within the container.
> This patch enables external entities viz. zookeeper reach the host (based 
> on public_ip:public_port) from where a proxy will be required to route to the 
> application running within the container. If we use , zookeeper 
> won't be able to reach. The setting up of the proxy is not a part of docker 
> or libprocess.
> Please also refer to relevant issue 
> https://issues.apache.org/jira/browse/MESOS-2587.
> 
> Anindya Sinha wrote:
> Can we get some inputs on this so as to move forward?
> Please also look into https://reviews.apache.org/r/34129/ which is also a 
> part of this fix.

sorry for the delay. can you rebase, so that i can commit this? thanks.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review87611
---


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34128/
> ---
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expose environment variables LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT 
> as the IP and
> port which libprocess would advertise (if set). If not set, it defaults to
> the IP and port on which it binded to.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> e3de3cd6b536aaaf59784360aed546512dd04dc9 
> 
> Diff: https://reviews.apache.org/r/34128/diff/
> 
> 
> Testing
> ---
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 34128: Enable different IP/Port for external access.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review92974
---

Ship it!


Ship It!

- Vinod Kone


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34128/
> ---
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expose environment variables LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT 
> as the IP and
> port which libprocess would advertise (if set). If not set, it defaults to
> the IP and port on which it binded to.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> e3de3cd6b536aaaf59784360aed546512dd04dc9 
> 
> Diff: https://reviews.apache.org/r/34128/diff/
> 
> 
> Testing
> ---
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 36757: Added https support.

[Jojy Varghese]

> On July 24, 2015, 7:23 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 1025-1029
> > 
> >
> > Why do you need a std::stringstream for this? We can simplify with just 
> > a string, and also construct it like the protocol exposes:
> > 
> > string buffer =
> >   "HTTP/1.1 200 OK\r\n" +
> >   "Content-Length : " + stringify(data.length()) + "\r\n" +
> >   "\r\n" +
> >   data;
> >   
> > Same for test above too.

Only for efficiency reasons. string+ operator will create temp objects.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92966
---


On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 5:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36663: Added ip_address field to MasterInfo

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92958
---



include/mesos/mesos.proto (line 397)


Can you please add these deprecation warnings to 0.24.0 CHANGELOG?

```
Release Notes - Mesos - Version 0.24.0 (WIP)

* Deprecations
 
```



src/common/protobuf_utils.cpp (line 194)


s/remove/Remove/



src/master/master.cpp (line 320)


s/the/The/



src/tests/master_tests.cpp (line 995)


Make this a MasterZooKeeperTest so that we can use zookeeper detector here 
and test Master::Master() changes!

TEST_F(MasterZooKeeperTest, MasterInfoAddress)

you'll want to move this to #2163



src/tests/master_tests.cpp (line 1023)


new line.



src/tests/master_tests.cpp (line 1024)


period at the end.


- Vinod Kone


On July 24, 2015, 12:17 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36663/
> ---
> 
> (Updated July 24, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added address field to MasterInfo
> 
> As part of the new HTTP API and the need to
> provide a better interface for clients that
> do not integrate libmesos, we provide the IP
> address of the Leader Master in the information
> that gets serialized (in JSON) to ZooKeeper.
> 
> This will eventually supersede the `ip`, `port`
> and `hostname` fields that are currently in
> MasterInfo an which cannot fully support IPv6
> addresses.
> 
> Jira: MESOS-2736
> 
> Review: https://reviews.apache.org/r/36663
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
>   src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
>   src/master/master.cpp bab04feaf238e51c4d50feb1d3a9c0735ec68fec 
>   src/tests/master_contender_detector_tests.cpp 
> d7a3b46b2e437818631064ae34317e49c9aa3748 
>   src/tests/master_tests.cpp 826f276317da2507cdf99b2f2e21a14769d8 
> 
> Diff: https://reviews.apache.org/r/36663/diff/
> 
> 
> Testing
> ---
> 
> make check
> (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the 
> information serialized to ZK is readable and as expected).
> 
> Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; 
> getting both versions in turn to be Leader, and also ran a 0.23 Slave with a 
> 0.24 Leader, and they all recognized each other.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36757: Added https support.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92966
---



3rdparty/libprocess/src/http.cpp (line 707)


We should do s/getSocket/createSocket/ to match the fact that you're 
calling 'Socket::create' under the covers, and the variable below is called 
'create', etc. Also, any reason to name the function at all? We'd like to move 
to a static initialization world where we do stuff like this but it'll just 
look like:

Try create = [&url]() -> Try {
  if (url.scheme == "http") {
return Socket::create(Socket::POLL);
  }

#ifdef USE_SSL_SOCKET
  if (url.scheme == "https") {
return Socket::create(Socket::SSL);
  }
#endif

  return Error("Unsupported URL scheme");
}();



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 1020)


Do you want to check that this payload and content-type actually make their 
way to the socket by doing a read and parsing into a request?



3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 1025 - 1029)


Why do you need a std::stringstream for this? We can simplify with just a 
string, and also construct it like the protocol exposes:

string buffer =
  "HTTP/1.1 200 OK\r\n" +
  "Content-Length : " + stringify(data.length()) + "\r\n" +
  "\r\n" +
  data;
  
Same for test above too.



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 1030)


Moot point if we just use a string (see comment above) but you should not 
have needed the `c_str()` here.

Also, looks like we need a const& Future::get in our future (pun intended).


- Benjamin Hindman


On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 5:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36757: Added https support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92962
---


Patch looks great!

Reviews applied: [36712, 36757]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 5:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92961
---



src/slave/containerizer/isolator.hpp (line 37)


This class should be documented. In particular, that it's just a wrapper 
around IsolatorProcess that to support async isolators. Let's please get in the 
habit of adding more documentation!


- Benjamin Hindman


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36761: Added tests for unset framework pid in the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review92954
---



src/tests/mesos.hpp (lines 1300 - 1303)


Why stick this in between the two SendStatusUpdate overloads? I would pull 
this below #1313



src/tests/slave_tests.cpp (line 2450)


s/task/task message/



src/tests/slave_tests.cpp (line 2490)


new line.



src/tests/slave_tests.cpp (line 2529)


s/an/a/



src/tests/slave_tests.cpp (line 2537)


s/,/;/



src/tests/slave_tests.cpp (line 2561)


s/fail over/restart/ ?



src/tests/slave_tests.cpp (line 2641)


s/Fail over/Restart/



src/tests/slave_tests.cpp (line 2661)


s/update/Update/



src/tests/slave_tests.cpp (line 2667)


s/an/a/



src/tests/slave_tests.cpp (line 2669)


s/driver/scheduler driver/



src/tests/slave_tests.cpp (line 2699)


nice tests/


- Vinod Kone


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36760/#review92945
---


modulo anand's comments.


src/messages/messages.proto (lines 347 - 351)


I would recommend just pointing to RunTaskMessage.pid for comments to avoid 
duplication.



src/slave/slave.cpp (lines 2145 - 2146)


Do you want to expand on the comment, on why we do this for posterity?



src/slave/slave.cpp (line 4733)


new line, like you did above?


- Vinod Kone


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36760/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is anticipation of HTTP scheduler support in 0.24.0.
> Note that the 'pid' is set for driver-based schedulers. The
> corresponding master changes to not set 'pid' for HTTP
> schedulers have not occurred yet.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
>   src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
>   src/slave/state.hpp 4e00468a777145e3c61b8dee7dfe496f8d65b0e4 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36760/diff/
> 
> 
> Testing
> ---
> 
> Added tests in [r/36761](https://reviews.apache.org/r/36761/).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36759/#review92939
---

Ship it!



src/master/master.cpp (line 3199)


i would just put the quote in the next line.

here and everywhere else below.


- Vinod Kone


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36759/
> ---
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
> https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This enables the slave to forward messages through the master.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
>   src/master/metrics.hpp d37d74a472a3e5605a4689420513f56e713aa8f3 
>   src/master/metrics.cpp 10e2937c2364b4025ec44ddfe47c3cb958a62773 
>   src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
> 
> Diff: https://reviews.apache.org/r/36759/diff/
> 
> 
> Testing
> ---
> 
> Added tests in [r/36761](https://reviews.apache.org/r/36761/).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92949
---


Patch looks great!

Reviews applied: [36763]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36757: Added https support.

[Anand Mazumdar]

> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1015
> > 
> >
> > s/{}/None()
> > s/payload/None()
> > 
> > You should be able to do without setting headers and body here.
> 
> Jojy Varghese wrote:
> It will work but the test here is for having "some" payload and https not 
> crapping out for actual POST data.

I see, my bad. Mind atleast removing the default headers here ?


> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 989
> > 
> >
> > AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response);
> 
> Jojy Varghese wrote:
> The pattern "ASSERT_EQ(http::statuses[200], response.get().status)" is 
> the one adopted in http_tests.cpp. Not sure if I want to have a new pattern 
> for https tests.

There are not many places left in our code that still use this old style. ( All 
the remaining ones left would eventually get cleaned up ).


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
---


On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 5:49 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Jie Yu]

> On July 24, 2015, 5:58 p.m., Timothy Chen wrote:
> > src/slave/containerizer/isolator.hpp, line 19
> > 
> >
> > Just wondering if we ever decided on a standard on these, seems odd to 
> > see just ISOLATOR_HPP here and MESOS_SLAVE_ISOLATOR in the include.

The plan is to move all Mesos containerizer related stuff to 
src/slave/containerizer/mesos 
(https://issues.apache.org/jira/browse/MESOS-3129).

I'll rename it to `__SLAVA_CONTAINERIZER_MESOS_ISOLATOR_HPP__` while doing the 
above change.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92942
---


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92942
---

Ship it!


Ship It!


src/slave/containerizer/isolator.hpp (line 19)


Just wondering if we ever decided on a standard on these, seems odd to see 
just ISOLATOR_HPP here and MESOS_SLAVE_ISOLATOR in the include.


- Timothy Chen


On July 24, 2015, 5:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36717: Add missing include in cpp file.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36717/#review92940
---

Ship it!


Ship It!

- Ben Mahler


On July 23, 2015, 2:25 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36717/
> ---
> 
> (Updated July 23, 2015, 2:25 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2294
> https://issues.apache.org/jira/browse/MESOS-2294
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Looks like we never used to include the corresponding header file :-)
> 
> Added the file and fixed the trivial compilation error as a result of it ( 
> involving default arguments in implementation )
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
> 
> Diff: https://reviews.apache.org/r/36717/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 36757: Added https support.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/
---

(Updated July 24, 2015, 5:49 p.m.)


Review request for mesos, Joris Van Remoortere and Timothy Chen.


Changes
---

added tests for server response validation.


Bugs: MESOS-3093
https://issues.apache.org/jira/browse/MESOS-3093


Repository: mesos


Description
---

Current http implementation lacks a https interface. This change exposes
SSL socket for "https" URL scheme.

JIRA: MESOS-3093


Diffs (updated)
-

  3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
2fe50601615b0bee57bd3e05dc9c932f93ca7477 

Diff: https://reviews.apache.org/r/36757/diff/


Testing
---

make check


Thanks,

Jojy Varghese

Re: Review Request 36757: Added https support.

[Jojy Varghese]

> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 989
> > 
> >
> > AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response);

The pattern "ASSERT_EQ(http::statuses[200], response.get().status)" is the one 
adopted in http_tests.cpp. Not sure if I want to have a new pattern for https 
tests.


> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1015
> > 
> >
> > s/{}/None()
> > s/payload/None()
> > 
> > You should be able to do without setting headers and body here.

It will work but the test here is for having "some" payload and https not 
crapping out for actual POST data.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
---


On July 24, 2015, 3:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92933
---

Ship it!


Ship It!

- Kapil Arya


On July 24, 2015, 1:26 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, Timothy Chen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 2aa8406b8386c7e407c9330400629a651f346ddf 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/
---

(Updated July 24, 2015, 5:26 p.m.)


Review request for mesos, Ben Mahler, Kapil Arya, and Vinod Kone.


Changes
---

Kapil's comments.


Bugs: MESOS-3130
https://issues.apache.org/jira/browse/MESOS-3130


Repository: mesos


Description
---

Made the Isolator interface not dependent on IsolatorProcess.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
  src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
  src/slave/containerizer/isolator.hpp PRE-CREATION 
  src/slave/containerizer/isolator.cpp ec14b207be36af7ca601e0f327e7025a155f41e4 
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
b1ebdaddc211bab023be85084bc82b6b82093f0b 
  src/slave/containerizer/isolators/cgroups/mem.hpp 
c198c832f8fb3765e932f1f20d3e16524340a7f2 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
919e0f7eccff1d4c10852260965bda2bdb1c4267 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
243cf5a6ff699aa37f885cc164977126413d155b 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
367cb4364212ce057a474b574b8dbf8ccc1ae235 
  src/slave/containerizer/isolators/filesystem/posix.hpp 
d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
2aa8406b8386c7e407c9330400629a651f346ddf 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
f90045e7696b54b7b5082b9aa16c78d0347afde6 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
702f331d39acc75e9c98183c30227ec47f10e904 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
39d1813ee534df184cd5cf2b11af22e0195b0802 
  src/slave/containerizer/isolators/posix.hpp 
6ddab7df489feb2a7762178183191d5d1dc99e15 
  src/slave/containerizer/isolators/posix/disk.hpp 
fdf24a18bfca97863b7c15c39378b879d7b43517 
  src/slave/containerizer/isolators/posix/disk.cpp 
238f17941712e0709eba1cf78c6bc825b3b4459e 
  src/slave/containerizer/mesos/containerizer.cpp 
c21e925e9584bc914f492d7f459498f732779fc8 
  src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
  src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 

Diff: https://reviews.apache.org/r/36763/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36741/#review92930
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 23, 2015, 4:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36741/
> ---
> 
> (Updated July 23, 2015, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are two things that have to change in the current CMake build
> solution in order to work on OS X 10.10:
>   * librt (which holds the POSIX.1b Realtime Extensions interfaces in
> Linux, including things like async I/O and memory-mapped files, etc.)
> does not exist on OS X, and does not need to be linked
>   * The version of GTest attempts to find std::tr1::tuple, which is not
> available on OS X 10.10. Like we have done in autotools (see[1] and
> also configure.ac) we simply define `GTEST_USE_OWN_TR1_TUPLE` when
> we're compiling on OS X.
> 
> [1] 
> https://mail-archives.apache.org/mod_mbox/mesos-dev/201403.mbox/%3c20140306223933.2625.25...@reviews.apache.org%3E
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 851ab94e4c0f901520c9a4d209f5b9c928116d3c 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> d6cdd05e281f23f0a57809d3798b5766fb2e9aa6 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 082489ca4a31843886f764105e70e6af9779ca11 
> 
> Diff: https://reviews.apache.org/r/36741/diff/
> 
> 
> Testing
> ---
> 
> Tested fixes on OS X 10.10 and Ubuntu 14 boxes.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 36757: Added https support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92924
---


Patch looks great!

Reviews applied: [36712, 36757]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 3:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36757: Added https support.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
---

Ship it!



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 988)


AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response);



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 1014)


s/{}/None()
s/payload/None()

You should be able to do without setting headers and body here.



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 1022)


Same as above.


- Anand Mazumdar


On July 24, 2015, 3:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> ---
> 
> (Updated July 24, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
> 
> JIRA: MESOS-3093
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36757/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36501: MESOS-3023

[Klaus Ma]

On July 24, 2015, 2:01 p.m., Klaus Ma wrote:
> > If you don't get to them first, I will fix the remaining little style 
> > suggestions when committing.

OK, please help to fix it. I'll learn it from the final code :). Thanks very 
much.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92911
---


On July 24, 2015, 9:57 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 24, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp e2a52f7 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35947/
---

(Updated July 24, 2015, 3:50 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, 
and Jie Yu.


Changes
---

Addressed comments from Jie and Till.


Repository: mesos


Description
---

Needed to implement the master HTTP endpoints: `/reserve`, `/unreserve`, 
`/create` and `/destroy`.

This API is similar to `updateSlave` which is currently very specific to 
oversubscription.
I considered consolidating `updateAvailable` and `updateSlave` but it will 
require making offers be generated within the allocator to enable this.

In specific, `updateAvailable` could fail if there aren't sufficient available 
resources to update, whereas `updateSlave` avoids failing by keeping the 
allocator in an over-allocated state. For `updateSlave`, leaving the allocator 
in an over-allocated state is ok. This is because it does not modify resources 
therefore `total - allocated` will work out to __empty__. `updateAvailable` 
cannot leave the allocator in an over-allocated state, because it modifies 
resources, and therefore `total - allocated` is not guaranteed to yield 
__empty__.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 22992c0c77058af4fcd28aa8e4a1191693a16f44 
  src/master/allocator/mesos/allocator.hpp 
72470ec7f56f84a9a9815c09adb88def90ef672f 
  src/master/allocator/mesos/hierarchical.hpp 
3264d145d52b48852878abf7ab9be29ab98208cc 
  src/tests/hierarchical_allocator_tests.cpp 
3258840135290cd008ca09235d18b7f093dafd2e 
  src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 

Diff: https://reviews.apache.org/r/35947/diff/


Testing
---

(1) Added `HierarchicalAllocatorTest.updateAvailableSuccess` and 
`HierarchicalAllocatorTest.updateAvailableFail`
(2) `make check`


Thanks,

Michael Park

Re: Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/
---

(Updated July 24, 2015, 3:33 p.m.)


Review request for mesos, Alexander Rojas, Bernd Mathiske, and Till Toenshoff.


Bugs: MESOS-2697
https://issues.apache.org/jira/browse/MESOS-2697


Repository: mesos


Description (updated)
---

Updated Authorization Documentation to use /teardown endpoint.

With Mesos 0.23 the /shutdown endpoint has been deprecated in favor of the 
/teardown endpoint. See MESOS=2697 for details.


Diffs
-

  docs/authorization.md 2634fbf3e5d66ce3a36a822d299f400f7b9924b6 

Diff: https://reviews.apache.org/r/36774/diff/


Testing
---

checked rendered version.


Thanks,

Joerg Schad

Re: Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/#review92919
---

Ship it!


Ship It!

- Vinod Kone


On July 24, 2015, 12:21 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36774/
> ---
> 
> (Updated July 24, 2015, 12:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2697
> https://issues.apache.org/jira/browse/MESOS-2697
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Authorization Documentation to use /teardown endpoint.
> 
> With Mesos 0.23 the /shutdown endpoint has been deprecated in favor of yhe 
> /teardown endpoint. See MESOS=2697 for details.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 2634fbf3e5d66ce3a36a822d299f400f7b9924b6 
> 
> Diff: https://reviews.apache.org/r/36774/diff/
> 
> 
> Testing
> ---
> 
> checked rendered version.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36757: Added https support.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/
---

(Updated July 24, 2015, 3:23 p.m.)


Review request for mesos, Joris Van Remoortere and Timothy Chen.


Changes
---

minor optimization.


Bugs: MESOS-3093
https://issues.apache.org/jira/browse/MESOS-3093


Repository: mesos


Description
---

Current http implementation lacks a https interface. This change exposes
SSL socket for "https" URL scheme.

JIRA: MESOS-3093


Diffs (updated)
-

  3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
2fe50601615b0bee57bd3e05dc9c932f93ca7477 

Diff: https://reviews.apache.org/r/36757/diff/


Testing
---

make check


Thanks,

Jojy Varghese

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92916
---


LGTM modulo some style issues below. Also, it looks like I'll need to rebase my 
Isolator::prepare patch :-).


src/Makefile.am (lines 651 - 652)


Why this move? Don't we prefer to put subdirectories after the regular 
entries in the sort order?



src/Makefile.am (line 655)


Could you also move this line above isolators/*?



src/slave/containerizer/isolator.cpp (lines 28 - 29)


Swap the order?



src/slave/containerizer/isolators/cgroups/mem.hpp (lines 27 - 28)


Swap the order?


- Kapil Arya


On July 24, 2015, 1:10 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36763/
> ---
> 
> (Updated July 24, 2015, 1:10 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-3130
> https://issues.apache.org/jira/browse/MESOS-3130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the Isolator interface not dependent on IsolatorProcess.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
>   src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
>   src/slave/containerizer/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/isolator.cpp 
> ec14b207be36af7ca601e0f327e7025a155f41e4 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1ebdaddc211bab023be85084bc82b6b82093f0b 
>   src/slave/containerizer/isolators/cgroups/mem.hpp 
> c198c832f8fb3765e932f1f20d3e16524340a7f2 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 919e0f7eccff1d4c10852260965bda2bdb1c4267 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 243cf5a6ff699aa37f885cc164977126413d155b 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 367cb4364212ce057a474b574b8dbf8ccc1ae235 
>   src/slave/containerizer/isolators/filesystem/posix.hpp 
> d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> 72d273897630b5861db0c2d55a26e9dab64f646f 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> f90045e7696b54b7b5082b9aa16c78d0347afde6 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 702f331d39acc75e9c98183c30227ec47f10e904 
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 39d1813ee534df184cd5cf2b11af22e0195b0802 
>   src/slave/containerizer/isolators/posix.hpp 
> 6ddab7df489feb2a7762178183191d5d1dc99e15 
>   src/slave/containerizer/isolators/posix/disk.hpp 
> fdf24a18bfca97863b7c15c39378b879d7b43517 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 238f17941712e0709eba1cf78c6bc825b3b4459e 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c21e925e9584bc914f492d7f459498f732779fc8 
>   src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
>   src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb 
> 
> Diff: https://reviews.apache.org/r/36763/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 35361: Added doc for standalone to HA

[Michael Schenck]

> On June 11, 2015, 4:03 p.m., Mesos ReviewBot wrote:
> > Patch looks great!
> > 
> > Reviews applied: [35361]
> > 
> > All tests passed.

This has been "reviewable" for a while now.  What are the next steps?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35361/#review87570
---


On June 11, 2015, 3:22 p.m., Michael Schenck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35361/
> ---
> 
> (Updated June 11, 2015, 3:22 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2855
> https://issues.apache.org/jira/browse/MESOS-2855
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for standalone to HA.  
> 
> This methodology has been discuessed in the mailing list and I've tested this 
> several times with a dev clsuter. 
> 
> Most recently, I've used this procedure to migrate a production mesos cluster 
> (with over 100 services and crons, and 6 mesos slaves) from _standalone_ to 
> `--quorum=2` with no issues.  It is probably worth noting that the only 
> framework in use on the cluster is Aurora.
> 
> 
> Diffs
> -
> 
>   docs/operational-guide.md 23b76ff129ca396a4b14a6826b4d842fc8527a8a 
> 
> Diff: https://reviews.apache.org/r/35361/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Schenck
> 
>

Re: Review Request 36501: MESOS-3023

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92911
---

Ship it!



src/tests/fetcher_tests.cpp (line 295)


It would be slightly better to separate these declarations more obviously 
by putting a new line here (between line 294 and 295).


If you don't get to them first, I will fix the remaining little style 
suggestions when committing.

- Bernd Mathiske


On July 24, 2015, 2:57 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 24, 2015, 2:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp e2a52f7 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 36501: MESOS-3023

[Bernd Mathiske]

> On July 20, 2015, 9:42 a.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
> Its a bit difficult to follow the mesos style guide at first. Maybe the 
> committer could help you reformat it when summit @klausma1982 . :-)
> 
> Klaus Ma wrote:
> Thanks very much for your patience; yes, it tooks time for me to swith 
> between different code style :).

Me too!


> On July 20, 2015, 9:42 a.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 314
> > 
> >
> > It would be better to add ```#include ``` after 
> > ```#include ```
> 
> Klaus Ma wrote:
> stout/stringify.hpp has been included; so did not add it.

No matter. Best to be explicit even if redundant, IMHO. (That's why we have 
provisions in headers that they only get processed once.)


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
---


On July 24, 2015, 2:57 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 24, 2015, 2:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp e2a52f7 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92909
---


Patch looks great!

Reviews applied: [36612, 36620]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 1:07 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> ---
> 
> (Updated July 24, 2015, 1:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
> https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---

(Updated July 24, 2015, 1:07 p.m.)


Review request for mesos, Benjamin Hindman and Timothy Chen.


Bugs: MESOS-3086
https://issues.apache.org/jira/browse/MESOS-3086


Repository: mesos


Description
---

WIP Added Non-Freezeer Task Killer.


Diffs (updated)
-

  src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 

Diff: https://reviews.apache.org/r/36620/diff/


Testing
---

sudo make check


Thanks,

Joerg Schad

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92901
---


Bad patch!

Reviews applied: [36612, 36620]

Failed command: ./support/apply-review.sh -n -r 36620

Error:
 2015-07-24 12:57:59 URL:https://reviews.apache.org/r/36620/diff/raw/ 
[234469/234469] -> "36620.patch" [1]
Successfully applied: WIP Added Non-Freezeer Task Killer.

WIP Added Non-Freezeer Task Killer.


Review: https://reviews.apache.org/r/36620
Checking 54 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  cmake/MesosConfigure.cmake
  docs/app-framework-development-guide.md
  docs/fetcher-cache-internals.md
  docs/release-guide.md
  include/mesos/mesos.proto
  include/mesos/scheduler/scheduler.proto
  include/mesos/slave/isolator.hpp
  include/mesos/slave/isolator.proto
  src/Makefile.am
  src/common/protobuf_utils.cpp
  src/common/protobuf_utils.hpp
  src/exec/exec.cpp
  src/linux/cgroups.cpp
  src/master/master.cpp
  src/master/master.hpp
  src/sched/sched.cpp
  src/scheduler/scheduler.cpp
  src/slave/containerizer/isolator.cpp
  src/slave/containerizer/isolators/cgroups/cpushare.cpp
  src/slave/containerizer/isolators/cgroups/cpushare.hpp
  src/slave/containerizer/isolators/cgroups/mem.cpp
  src/slave/containerizer/isolators/cgroups/mem.hpp
  src/slave/containerizer/isolators/cgroups/perf_event.cpp
  src/slave/containerizer/isolators/cgroups/perf_event.hpp
  src/slave/containerizer/isolators/filesystem/posix.cpp
  src/slave/containerizer/isolators/filesystem/posix.hpp
  src/slave/containerizer/isolators/filesystem/shared.cpp
  src/slave/containerizer/isolators/filesystem/shared.hpp
  src/slave/containerizer/isolators/namespaces/pid.cpp
  src/slave/containerizer/isolators/namespaces/pid.hpp
  src/slave/containerizer/isolators/network/port_mapping.cpp
  src/slave/containerizer/isolators/network/port_mapping.hpp
  src/slave/containerizer/isolators/posix.hpp
  src/slave/containerizer/isolators/posix/disk.cpp
  src/slave/containerizer/isolators/posix/disk.hpp
  src/slave/containerizer/launcher.cpp
  src/slave/containerizer/linux_launcher.cpp
  src/slave/containerizer/mesos/containerizer.cpp
  src/slave/containerizer/mesos/containerizer.hpp
  src/tests/containerizer_tests.cpp
  src/tests/disk_quota_tests.cpp
  src/tests/docker_containerizer_tests.cpp
  src/tests/external_containerizer_test.cpp
  src/tests/fault_tolerance_tests.cpp
  src/tests/hook_tests.cpp
  src/tests/isolator.hpp
  src/tests/master_authorization_tests.cpp
  src/tests/master_slave_reconciliation_tests.cpp
  src/tests/master_tests.cpp
  src/tests/master_validation_tests.cpp
  src/tests/memory_pressure_tests.cpp
  src/tests/partition_tests.cpp
  src/tests/persistent_volume_tests.cpp
  src/tests/port_mapping_tests.cpp
  src/tests/rate_limiting_tests.cpp
  src/tests/reconciliation_tests.cpp
  src/tests/registrar_zookeeper_tests.cpp
  src/tests/scheduler_tests.cpp
  src/tests/slave_recovery_tests.cpp
  src/tests/slave_tests.cpp
  support/tag.sh
stout:
  3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake
  3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake
  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt
libprocess:
  3rdparty/libprocess/3rdparty/CMakeLists.txt
  3rdparty/libprocess/cmake/ProcessConfigure.cmake
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
  3rdparty/libprocess/include/process/http.hpp
  3rdparty/libprocess/src/tests/CMakeLists.txt
Failed to commit patch

- Mesos ReviewBot


On July 24, 2015, 12:15 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> ---
> 
> (Updated July 24, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
> https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> d7c6dfb04120a7fd28e1a4682f39015bd149eb40 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 
> 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
>   3rdparty/libprocess/3r

Re: Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/#review92899
---


Patch looks great!

Reviews applied: [36774]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 12:21 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36774/
> ---
> 
> (Updated July 24, 2015, 12:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2697
> https://issues.apache.org/jira/browse/MESOS-2697
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Authorization Documentation to use /teardown endpoint.
> 
> With Mesos 0.23 the /shutdown endpoint has been deprecated in favor of yhe 
> /teardown endpoint. See MESOS=2697 for details.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 2634fbf3e5d66ce3a36a822d299f400f7b9924b6 
> 
> Diff: https://reviews.apache.org/r/36774/diff/
> 
> 
> Testing
> ---
> 
> checked rendered version.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/
---

(Updated July 24, 2015, 12:21 p.m.)


Review request for mesos, Alexander Rojas, Bernd Mathiske, and Till Toenshoff.


Bugs: MESOS-2697
https://issues.apache.org/jira/browse/MESOS-2697


Repository: mesos


Description (updated)
---

Updated Authorization Documentation to use /teardown endpoint.

With Mesos 0.23 the /shutdown endpoint has been deprecated in favor of yhe 
/teardown endpoint. See MESOS=2697 for details.


Diffs
-

  docs/authorization.md 2634fbf3e5d66ce3a36a822d299f400f7b9924b6 

Diff: https://reviews.apache.org/r/36774/diff/


Testing
---

checked rendered version.


Thanks,

Joerg Schad

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---

(Updated July 24, 2015, 12:15 p.m.)


Review request for mesos, Benjamin Hindman and Timothy Chen.


Changes
---

Addressed comments


Bugs: MESOS-3086
https://issues.apache.org/jira/browse/MESOS-3086


Repository: mesos


Description
---

WIP Added Non-Freezeer Task Killer.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
d7c6dfb04120a7fd28e1a4682f39015bd149eb40 
  3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 
4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
  3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 
87737395d011393e7ef0c86fa18a3d31f3045fb0 
  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
6e7eb00b79e81cb6426cf08d50e22075898f2616 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
d58f8a4ab8f6f761adb6a9db2dac438ffe0e211b 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
b1a519007e5bed196541f294c4676277f9708714 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
4681eef1347fd46e85e1768795cc2f34aaba02b2 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 
  3rdparty/libprocess/include/process/http.hpp 
9faed55247a3ccd629db7b85dbf31d3117e120e9 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
b61ca1e5be2054c1156205c62a1e8311a575bfa5 
  cmake/MesosConfigure.cmake ee47842a5a2681221838e736738943572e96e702 
  docs/app-framework-development-guide.md 
db0181c0b82fded1860ef636747e70d80e3884f2 
  docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b 
  docs/release-guide.md a946c7e2c57632d3ff1b4cd6ac6c47df69dcf80c 
  include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db 
  include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 
  src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 
  src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab 
  src/common/protobuf_utils.cpp 4cfbda4696d4abc169b3d1a05dc522889232ebcd 
  src/exec/exec.cpp 54ef622ca3e9a004b065e2f3a496a1b87902f722 
  src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
  src/master/master.hpp bf61bb2deb61a73303f4122383dcb7e8f5d726de 
  src/master/master.cpp bab04feaf238e51c4d50feb1d3a9c0735ec68fec 
  src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453 
  src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 
  src/slave/containerizer/isolator.cpp ec14b207be36af7ca601e0f327e7025a155f41e4 
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
b1ebdaddc211bab023be85084bc82b6b82093f0b 
  src/slave/containerizer/isolators/cgroups/mem.hpp 
c198c832f8fb3765e932f1f20d3e16524340a7f2 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
919e0f7eccff1d4c10852260965bda2bdb1c4267 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
243cf5a6ff699aa37f885cc164977126413d155b 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
367cb4364212ce057a474b574b8dbf8ccc1ae235 
  src/slave/containerizer/isolators/filesystem/posix.hpp 
d44023eb95c48d6ffbd69334f91a2b4c4b760db0 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
2aa8406b8386c7e407c9330400629a651f346ddf 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
f90045e7696b54b7b5082b9aa16c78d0347afde6 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
702f331d39acc75e9c98183c30227ec47f10e904 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
4241fa7a917ab31f52ece4caf16e94b3ef9ac353 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
39d1813ee534df184cd5cf2b11af22e0195b0802 
  src/slave/containerizer/isolators/posix.hpp 
6ddab7df489feb2a7762178183191d5d1dc99e15 
  src/slave/containerizer/isolators/posix/disk.hpp 
fdf24a18bfca97863b7c15c39378b879d7b43517 
  src/slave/containerizer/isolators/posix/disk.cpp 
238f17941712e0709eba1cf78c6bc825b3b4459e 
  src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de 
  src/slave/containerizer/linux_launcher.cpp 
ed2e881f555d651ad1e5f1b62f32848ade09b424 
  src/slave/containerizer/mesos/containerizer.hpp 
5155362bef9163af3fa5334be3a39b91549e1ec1 
  src/slave/containerizer/mesos/containerizer.cpp 
c21e925e9584bc914f492d7f459498f732779fc8 
  src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 
  src/tests/disk_quota_tests.cpp 1ed1342a10a4d59b84ef13a3d66eef95150c4e53 
  src/tests

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review92895
---



src/slave/containerizer/fetcher.cpp (line 994)


This new behavior should be reflected in the documentation. AFAIK there are 
two markdown files which would need updating..


- Joerg Schad


On July 24, 2015, 10:33 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> ---
> 
> (Updated July 24, 2015, 10:33 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an 
> existing cache entry is requested, it is moved to the back of the list. 
> During cache eviction entries are removed from the front of the list until 
> enough cache space can be freed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 17225072ba5c1c9a7209f2923bcf562fcb76201f 
>   src/slave/containerizer/fetcher.cpp 
> e030deabd5e749100cbccabb256dbd4af8b2fe58 
>   src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 
> 
> Diff: https://reviews.apache.org/r/36773/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/
---

Review request for mesos, Alexander Rojas and Till Toenshoff.


Bugs: MESOS-2697
https://issues.apache.org/jira/browse/MESOS-2697


Repository: mesos


Description
---

Updated Authorization Documentation to use /teardown endpoint.


Diffs
-

  docs/authorization.md 2634fbf3e5d66ce3a36a822d299f400f7b9924b6 

Diff: https://reviews.apache.org/r/36774/diff/


Testing
---

checked rendered version.


Thanks,

Joerg Schad

Re: Review Request 36501: MESOS-3023

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92889
---


Patch looks great!

Reviews applied: [36501]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 9:57 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 24, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp e2a52f7 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36732/#review92888
---

Ship it!


Ship It!

- Bernd Mathiske


On July 23, 2015, 10:33 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36732/
> ---
> 
> (Updated July 23, 2015, 10:33 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-2697
> https://issues.apache.org/jira/browse/MESOS-2697
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove deprecated /shutdown master endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 
>   src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
> 
> Diff: https://reviews.apache.org/r/36732/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---

Review request for mesos.


Bugs: MESOS-3112
https://issues.apache.org/jira/browse/MESOS-3112


Repository: mesos


Description
---

A linked list is used to keep cache entries in LRU-to-MRU order. Each time an 
existing cache entry is requested, it is moved to the back of the list. During 
cache eviction entries are removed from the front of the list until enough 
cache space can be freed.


Diffs
-

  src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f 
  src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 
  src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 

Diff: https://reviews.apache.org/r/36773/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 36501: MESOS-3023

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---

(Updated July 24, 2015, 9:57 a.m.)


Review request for mesos.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Fix for MESOS-3023 (Factoring out the pattern for URL generation)


Diffs (updated)
-

  src/tests/fetcher_tests.cpp e2a52f7 

Diff: https://reviews.apache.org/r/36501/diff/


Testing
---

1. Build successfully in Linux
2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest


Thanks,

Klaus Ma

Re: Review Request 36501: MESOS-3023

[Klaus Ma]

> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 297
> > 
> >
> > According 
> > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definitioninvocation
> >  You indent is not correct here. Maybe need change to like this
> > 
> > ```
> > process::http::URL url(
> > "http",
> > process.self().address.ip,
> > process.self().address.port,
> > "/help");
> > ```
> > 
> > But I perfer chang it like this
> > ```
> > const network::Address& address = process.self().address;
> > process::http::URL url("http", address.ip, address.port, "/help");
> > ```
> > 
> > Or add `using URL` like this
> > ```
> > using process::Future;
> > 
> > using process::http::URL; (Left a blank below and after process::Future)
> > ```
> > 
> > and then
> > ```
> > const network::Address& address = process.self().address;
> > URL url("http", address.ip, address.port, "/help");
> > ```
> 
> Bernd Mathiske wrote:
> I agree. Thanks, haosdent!

I address the comments by option 2. Reguarding "using URL", it'll compile 
because there's also mesos::URL here. But mesos::URL is a protobuf class, it 
will make code more complex.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
---


On July 18, 2015, 9:47 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 18, 2015, 9:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp ae10c42 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 36501: MESOS-3023

[Klaus Ma]

> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
> Its a bit difficult to follow the mesos style guide at first. Maybe the 
> committer could help you reformat it when summit @klausma1982 . :-)

Thanks very much for your patience; yes, it tooks time for me to swith between 
different code style :).


> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 314
> > 
> >
> > It would be better to add ```#include ``` after 
> > ```#include ```

stout/stringify.hpp has been included; so did not add it.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
---


On July 18, 2015, 9:47 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> ---
> 
> (Updated July 18, 2015, 9:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp ae10c42 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> ---
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>