Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37700/ --- Review request for mesos. Bugs: MESOS-3305 https://issues.apache.org/jira/browse/MESOS-3305 Repository: mesos Description --- Document libsasl2-modules as a required dependency when building on ubuntu. Diffs - docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 Diff: https://reviews.apache.org/r/37700/diff/ Testing --- Thanks, Andrew Smith
Re: Review Request 37669: Ignore overflow components in version parsing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96112 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line 17) https://reviews.apache.org/r/37669/#comment151327 We put this below the stdlib includes. - Timothy Chen On Aug. 21, 2015, 2:53 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 21, 2015, 2:53 a.m.) Review request for mesos, Isabel Jimenez and Timothy Chen. Bugs: MESOS-2986 https://issues.apache.org/jira/browse/MESOS-2986 Repository: mesos Description --- Ignore overflow components in version parsing. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 51010845e8885ac52ce88ec0deb6b65a81122cba 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp e8f8358f3c113b4e21e30cb5e9d6a3d229191484 Diff: https://reviews.apache.org/r/37669/diff/ Testing --- Thanks, haosdent huang
Review Request 37684: Added symlink test for /bin, lib, and /lib64.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 4:51 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing (updated) --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96054 --- Ship it! Ship It! - Marco Massenzio On Aug. 21, 2015, 4:51 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 4:51 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 37114: MESOS-3187, support docker host command line option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 8:54 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod Kone. Changes --- Fixed review comment on default value for docker_socket in test program Bugs: MESOS-3187 https://issues.apache.org/jira/browse/MESOS-3187 Repository: mesos Description --- MESOS-3187, support docker host command line option. Docker daemon supports starting on a non-default port. Such scenarios would needed when starting Docker daemon on TCP or non-default unix port. Mesos slave does not work if Docker daemon is started on any of such non-default port. The code change is needed in Mesos slave to accept this parameter so as connect for its operations to the right Docker daemon. The change is made in Mesos slave, so as it is available to any framework making using Docker executor. The code is added to start slave binary with --docker_host, instructing it to connect on port as specified in the parameter. The default value of --default_host is unix:///var/run/docker.sock, which is default port for Docker daemon. The main class src/docker.cpp/.hpp is kept backward compartible to make Docker cli execute on default Docker port. Diffs (updated) - src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc Diff: https://reviews.apache.org/r/37114/diff/ Testing --- Following scenarios were executed to test the code changes. Kindly suggest if more test-cases are required: a) Mesos slave with unix port : unix:///var/run/docker_myport.sock i) Start slave with --docker_host parameter unix:///var/run/docker_myport.sock ii) Using a framework, in my case Marathon, post a Docker job iii) The docker job does get started on the slave, confirmed with docker ps command output docker -H unix:///var/run/docker_myport.sock ps CONTAINER IDIMAGE COMMANDCREATED STATUS PORTS NAMES 07fc4ec86bacmygoserver /bin/sh -c /mygoser 19 minutes ago Up 19 minutes */tcp, */udp mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c iv) Stop or destroy the job from Marathon GUI b) Two mesos slave with non-default docker port i) On two different hosts, start slave, with one running on default port and other non-default. The start slaves with attributes - default and or non-default. ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting slave - non-default default iii) Stop/destroy the jobs d) Modified unit test-case taking docker port value - make check Thanks, Vaibhav Khanduja
Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.
On Aug. 21, 2015, 6:14 p.m., Jie Yu wrote: src/tests/containerizer/rootfs.hpp, lines 111-126 https://reviews.apache.org/r/37684/diff/1/?file=1046779#file1046779line111 Can you combine the this loop with the loop below (like the following). Also, could you use 'realpath' here to resolve the symlink. ``` foreach (const std::string directory, directories) { // Some linux distros are moving all binaries and libraries // to /usr, in which case /bin, /lib, and /lib64 will be // symlinks to their equivalent directories in /usr. So we // call the realpath here first. Resultstd::string realpath = os::realpath(directory); if (!realpath.isSome()) { return Error(Failed to get realpath for ' + directory + ': + (realpath.isError() ? realpath.error() : No such directory); } TryNothing result = rootfs-add(realpath.get()); ... } ``` Thanks Jie, that's much better! :-) Comments addressed. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96068 --- On Aug. 21, 2015, 7:15 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 7:15 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 7:15 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs (updated) - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 37114: MESOS-3187, support docker host command line option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96064 --- src/tests/flags.hpp (line 86) https://reviews.apache.org/r/37114/#comment151271 Change defualt value without unix prefix - Vaibhav Khanduja On Aug. 21, 2015, 6:05 p.m., Vaibhav Khanduja wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 6:05 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod Kone. Bugs: MESOS-3187 https://issues.apache.org/jira/browse/MESOS-3187 Repository: mesos Description --- MESOS-3187, support docker host command line option. Docker daemon supports starting on a non-default port. Such scenarios would needed when starting Docker daemon on TCP or non-default unix port. Mesos slave does not work if Docker daemon is started on any of such non-default port. The code change is needed in Mesos slave to accept this parameter so as connect for its operations to the right Docker daemon. The change is made in Mesos slave, so as it is available to any framework making using Docker executor. The code is added to start slave binary with --docker_host, instructing it to connect on port as specified in the parameter. The default value of --default_host is unix:///var/run/docker.sock, which is default port for Docker daemon. The main class src/docker.cpp/.hpp is kept backward compartible to make Docker cli execute on default Docker port. Diffs - src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc Diff: https://reviews.apache.org/r/37114/diff/ Testing --- Following scenarios were executed to test the code changes. Kindly suggest if more test-cases are required: a) Mesos slave with unix port : unix:///var/run/docker_myport.sock i) Start slave with --docker_host parameter unix:///var/run/docker_myport.sock ii) Using a framework, in my case Marathon, post a Docker job iii) The docker job does get started on the slave, confirmed with docker ps command output docker -H unix:///var/run/docker_myport.sock ps CONTAINER IDIMAGE COMMANDCREATED STATUS PORTS NAMES 07fc4ec86bacmygoserver /bin/sh -c /mygoser 19 minutes ago Up 19 minutes */tcp, */udp mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c iv) Stop or destroy the job from Marathon GUI b) Two mesos slave with non-default docker port i) On two different hosts, start slave, with one running on default port and other non-default. The start slaves with attributes - default and or non-default. ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting slave - non-default default iii) Stop/destroy the jobs d) Modified unit test-case taking docker port value - make check Thanks, Vaibhav Khanduja
Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37114: MESOS-3187, support docker host command line option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 6:05 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod Kone. Changes --- Review comments taken care Bugs: MESOS-3187 https://issues.apache.org/jira/browse/MESOS-3187 Repository: mesos Description --- MESOS-3187, support docker host command line option. Docker daemon supports starting on a non-default port. Such scenarios would needed when starting Docker daemon on TCP or non-default unix port. Mesos slave does not work if Docker daemon is started on any of such non-default port. The code change is needed in Mesos slave to accept this parameter so as connect for its operations to the right Docker daemon. The change is made in Mesos slave, so as it is available to any framework making using Docker executor. The code is added to start slave binary with --docker_host, instructing it to connect on port as specified in the parameter. The default value of --default_host is unix:///var/run/docker.sock, which is default port for Docker daemon. The main class src/docker.cpp/.hpp is kept backward compartible to make Docker cli execute on default Docker port. Diffs (updated) - src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc Diff: https://reviews.apache.org/r/37114/diff/ Testing --- Following scenarios were executed to test the code changes. Kindly suggest if more test-cases are required: a) Mesos slave with unix port : unix:///var/run/docker_myport.sock i) Start slave with --docker_host parameter unix:///var/run/docker_myport.sock ii) Using a framework, in my case Marathon, post a Docker job iii) The docker job does get started on the slave, confirmed with docker ps command output docker -H unix:///var/run/docker_myport.sock ps CONTAINER IDIMAGE COMMANDCREATED STATUS PORTS NAMES 07fc4ec86bacmygoserver /bin/sh -c /mygoser 19 minutes ago Up 19 minutes */tcp, */udp mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c iv) Stop or destroy the job from Marathon GUI b) Two mesos slave with non-default docker port i) On two different hosts, start slave, with one running on default port and other non-default. The start slaves with attributes - default and or non-default. ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting slave - non-default default iii) Stop/destroy the jobs d) Modified unit test-case taking docker port value - make check Thanks, Vaibhav Khanduja
Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96068 --- Ship it! Thanks src/tests/containerizer/rootfs.hpp (lines 111 - 126) https://reviews.apache.org/r/37684/#comment151272 Can you combine the this loop with the loop below (like the following). Also, could you use 'realpath' here to resolve the symlink. ``` foreach (const std::string directory, directories) { // Some linux distros are moving all binaries and libraries // to /usr, in which case /bin, /lib, and /lib64 will be // symlinks to their equivalent directories in /usr. So we // call the realpath here first. Resultstd::string realpath = os::realpath(directory); if (!realpath.isSome()) { return Error(Failed to get realpath for ' + directory + ': + (realpath.isError() ? realpath.error() : No such directory); } TryNothing result = rootfs-add(realpath.get()); ... } ``` - Jie Yu On Aug. 21, 2015, 4:51 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 4:51 p.m.) Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and MESOS-3297 https://issues.apache.org/jira/browse/MESOS-3296 https://issues.apache.org/jira/browse/MESOS-3297 Repository: mesos Description --- Added symlink test for /bin, /lib, and /lib64. Diffs - src/tests/containerizer/rootfs.hpp 961003fd6768ee0f7effd2804d1c453f8d45e058 Diff: https://reviews.apache.org/r/37684/diff/ Testing --- On CentOS 7.1 and other distros with symlinked /bin, /lib, /lib64: sudo make check Some tests will fail due to other root test issues being tracked at MESOS-3292, MESOS-3293, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann
Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- include/mesos/mesos.proto (lines 917 - 920) https://reviews.apache.org/r/36321/#comment151276 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like `Period`? I'm thinking about a use case, when a custom allocator uses InverseOffers to ask a framework to release resources. In this case, we need a timeout, which is naturally expressed by `unavailability.start`. Given we don't need duration in this case, the name can be misleading for users. - Alexander Rukletsov On Aug. 12, 2015, 10:07 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 12, 2015, 10:07 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs - include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like `Period`? I'm thinking about a use case, when a custom allocator uses InverseOffers to ask a framework to release resources. In this case, we need a timeout, which is naturally expressed by `unavailability.start`. Given we don't need duration in this case, the name can be misleading for users. A while ago, I posted a few diffs where this object was called `Interval` (https://reviews.apache.org/r/36321/diff/7/). The reason why it was changed back to `Unavailability` is that we may wish to extend this object to be more specific, in the future. (We've already removed all the maintenance-specific language in the comments for `Unavailability` and `InverseOffer`.) Taking your example, the custom allocator asks for resources back. It says that these will be unavailable by the `start` time. Duration is optional; in the case of maintenance, when `duration` is omitted, it means the duration is forever or unknown. I think the term also works for non-maintenance uses. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- On Aug. 12, 2015, 3:07 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 12, 2015, 3:07 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs - include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3304 https://issues.apache.org/jira/browse/MESOS-3304 Repository: mesos Description --- Removed remnants of LIBPROCESS_STATISTICS_WINDOW. Diffs - 3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6 Diff: https://reviews.apache.org/r/37699/diff/ Testing --- Thanks, Greg Mann