Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like `Period`? I'm thinking about a use case, when a custom allocator uses InverseOffers to ask a framework to release resources. In this case, we need a timeout, which is naturally expressed by `unavailability.start`. Given we don't need duration in this case, the name can be misleading for users. Joseph Wu wrote: A while ago, I posted a few diffs where this object was called `Interval` (https://reviews.apache.org/r/36321/diff/7/). The reason why it was changed back to `Unavailability` is that we may wish to extend this object to be more specific, in the future. (We've already removed all the maintenance-specific language in the comments for `Unavailability` and `InverseOffer`.) Taking your example, the custom allocator asks for resources back. It says that these will be unavailable by the `start` time. Duration is optional; in the case of maintenance, when `duration` is omitted, it means the duration is forever or unknown. I think the term also works for non-maintenance uses. For me unavailability implies the resources will be given back once the period (interval) is over. Unless resource are reserved, this is not the case, since allocator has no obligations to offer resources to prior users once unavailability period is over. In an offline conversation, Joris pointed out, that unavailability events are mostly interesting for stateful frameworks, which most probably will have reservations for resources. If you plan to leave current term, could you please reflect in the comment what unavailability guarantees and what it does not? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- On Aug. 12, 2015, 10:07 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 12, 2015, 10:07 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs - include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/ --- (Updated Aug. 23, 2015, 12:26 p.m.) Review request for mesos. Bugs: MESOS-3264 https://issues.apache.org/jira/browse/MESOS-3264 Repository: mesos Description --- Add destruct ShutdownHook in java MesosExecutorDriver. Diffs (updated) - src/examples/java/TestFramework.java aad94c055ca25a54405d1fabe56feb50c2f80388 src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 8cbc7989d7dffd2648f044b3b63cc03a24d81936 src/java/src/org/apache/mesos/MesosExecutorDriver.java 6741b3239daa435045ab01f830cf495dd2e65a3f Diff: https://reviews.apache.org/r/37508/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37505: Fix broken health check in docker executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Aug. 23, 2015, 8:58 a.m.) Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description --- Fix broken health check in docker executor. Diffs (updated) - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing --- # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose Thanks, haosdent huang
Re: Review Request 37505: Fix broken health check in docker executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Aug. 23, 2015, 8:59 a.m.) Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description --- Fix broken health check in docker executor. Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing (updated) --- # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask # Docker health check command is run through docker exec sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose Thanks, haosdent huang
Re: Review Request 37505: Fix broken health check in docker executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Aug. 23, 2015, 9:44 a.m.) Review request for mesos, Adam B and Timothy Chen. Changes --- Add a new test case. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description --- Fix broken health check in docker executor. Diffs (updated) - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing (updated) --- # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange # Docker health check command is run through docker exec sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose sudo ./bin/mesos-tests.sh --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange --verbose Thanks, haosdent huang
Re: Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/ --- (Updated Aug. 23, 2015, 12:33 p.m.) Review request for mesos. Bugs: MESOS-3264 https://issues.apache.org/jira/browse/MESOS-3264 Repository: mesos Description --- Add destruct ShutdownHook in java MesosExecutorDriver. Diffs (updated) - src/examples/java/TestFramework.java aad94c055ca25a54405d1fabe56feb50c2f80388 src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 8cbc7989d7dffd2648f044b3b63cc03a24d81936 src/java/src/org/apache/mesos/MesosExecutorDriver.java 6741b3239daa435045ab01f830cf495dd2e65a3f Diff: https://reviews.apache.org/r/37508/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37268: Style checker checking for { on newline
On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [37266]
Failed command: ./support/apply-review.sh -n -r 37266
Error:
2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/
[8119/8119] - 37266.patch [1]
Traceback (most recent call last):
File ./support/jsonurl.py, line 25, in module
print data
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in
position 3: ordinal not in range(128)
Successfully applied: Style checker checking for { on newline
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the mesos project
Review: https://reviews.apache.org/r/37266
fatal: empty ident name (for guilherme@gmail.com) not allowed
Failed to commit patch
Jose Guilherme Vanz wrote:
Solved. There is a issue with description with
Actually, I discovered the real issue. There is an issue in the
apply-review.sh. The script crashes because my name has é. After I changed my
name in the review board the script runs fine
- Jose Guilherme
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
---
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
---
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
---
Thanks,
Jose Guilherme Vanz
