Re: Review Request 37703: Add docker exec command.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review101402
---


Patch looks great!

Reviews applied: [37703]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> ---
> 
> (Updated Oct. 3, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add docker exec command.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
>   src/tests/containerizer/docker_tests.cpp 
> babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/
---

(Updated Oct. 3, 2015, 3:55 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

update test description.


Bugs: MESOS-3392
https://issues.apache.org/jira/browse/MESOS-3392


Repository: mesos


Description
---

Enhanced option for Docker cli volume plugin.


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 

Diff: https://reviews.apache.org/r/38338/diff/


Testing (updated)
---

# When use volume-driver
```
I1003 23:49:41.986047 11268 docker.cpp:571] Running docker -H 
unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
MESOS_CONTAINER_NAME=mesos-docker-test -v src:target:rw -v 
/tmp/DockerTest_ROOT_DOCKER_volume_driver_D3Fxye:/mnt/mesos/sandbox 
--volume-driver=flocker --net host --entrypoint /bin/sh --name 
mesos-docker-test busybox -c sleep 120
```
Could see `-v src:target`

# When don't use volume-driver
```
1003 23:53:48.028715 12125 docker.cpp:571] Running docker -H 
unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
MESOS_CONTAINER_NAME=mesos-docker-test -v 
/tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw -v 
/tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt:/mnt/mesos/sandbox --net host 
--entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
```
Could see `-v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw`


Thanks,

haosdent huang

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/
---

(Updated Oct. 3, 2015, 1:26 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Add test case.


Bugs: MESOS-3479
https://issues.apache.org/jira/browse/MESOS-3479


Repository: mesos


Description
---

Kill health check external command process and continue check after timeout.


Diffs (updated)
-

  src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 

Diff: https://reviews.apache.org/r/38932/diff/


Testing (updated)
---

GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose


Thanks,

haosdent huang

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review101405
---


IMHO, we keep both apply-reviews.py and apply-reviews.sh and call 
apply-reviews.sh in apply-reviews.py looks strange. It would be better we add 
this function to apply-review.sh. Or create apply-reviews.py and deprecated 
apply-reviews.sh

- haosdent huang


On Oct. 1, 2015, 5:12 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 1, 2015, 5:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/#review101404
---


Patch looks great!

Reviews applied: [38932]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 1:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38932/
> ---
> 
> (Updated Oct. 3, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3479
> https://issues.apache.org/jira/browse/MESOS-3479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Kill health check external command process and continue check after timeout.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
> 
> Diff: https://reviews.apache.org/r/38932/diff/
> 
> 
> Testing
> ---
> 
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37703: Add docker exec command.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
---

(Updated Oct. 3, 2015, 9:09 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Update according @tnachen reviews


Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291


Repository: mesos


Description
---

Add docker exec command.


Diffs (updated)
-

  src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f 
  src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
  src/tests/containerizer/docker_tests.cpp 
babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 

Diff: https://reviews.apache.org/r/37703/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 36816: Support HTTP checks in Mesos health check program

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---

(Updated Oct. 3, 2015, 5:49 p.m.)


Review request for mesos, Adam B, Michael Park, and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533


Repository: mesos


Description
---

Support HTTP checks in Mesos health check program


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 

Diff: https://reviews.apache.org/r/36816/diff/


Testing
---

* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check


Thanks,

haosdent huang

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

[Vaibhav Khanduja]

> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote:
> > Can you add a test for this logic?
> 
> haosdent huang wrote:
> Could, but because volume-driver depends on flocker, my test ideas for 
> this is verify the docker run command is correct.

Docker also supports "local" as a volume driver. If the value is "local" it 
won't connect to any backed driver, flocker etc. 

docker run -d --volume-driver=local -v /tmp:/src   

If local is given ... the value of volume would start from "/" ... the logic 
below should ideally ...

https://docs.docker.com/extend/plugins_volume/ 

If test-case is really required ... local can probably be used ...


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review100643
---


On Oct. 3, 2015, 3:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> ---
> 
> (Updated Oct. 3, 2015, 3:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3392
> https://issues.apache.org/jira/browse/MESOS-3392
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced option for Docker cli volume plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
> 
> Diff: https://reviews.apache.org/r/38338/diff/
> 
> 
> Testing
> ---
> 
> # When use volume-driver
> ```
> I1003 23:49:41.986047 11268 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_D3Fxye:/mnt/mesos/sandbox 
> --volume-driver=flocker --net host --entrypoint /bin/sh --name 
> mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v src:target`
> 
> # When don't use volume-driver
> ```
> 1003 23:53:48.028715 12125 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt:/mnt/mesos/sandbox --net 
> host --entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37023: Add an endpoint that exposes component flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---

(Updated Oct. 3, 2015, 4:49 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebase


Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104


Repository: mesos


Description
---

Add an endpoint that exposes component flags.


Diffs (updated)
-

  src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
  src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 

Diff: https://reviews.apache.org/r/37023/diff/


Testing
---

manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
{
  "flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
  }
}
```

```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
  "flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
  }
}
```


Thanks,

haosdent huang

Re: Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/
---

(Updated Oct. 3, 2015, 5:14 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-2154
https://issues.apache.org/jira/browse/MESOS-2154


Repository: mesos


Description
---

Port CFS support to Docker Containerizer


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 

Diff: https://reviews.apache.org/r/36181/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/#review101417
---


Patch looks great!

Reviews applied: [36431]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36431/
> ---
> 
> (Updated Oct. 3, 2015, 4:12 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-1084
> https://issues.apache.org/jira/browse/MESOS-1084
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Show stdout/stderr when using mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
> 
> Diff: https://reviews.apache.org/r/36431/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> ![demo](https://issues.apache.org/jira/secure/attachment/12744923/12744923_show_stdout_stderr.gif
>  "Demo")
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38337: Extract gz file in fetcher.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/
---

(Updated Oct. 3, 2015, 4:05 p.m.)


Review request for mesos, Adam B and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-3407
https://issues.apache.org/jira/browse/MESOS-3407


Repository: mesos


Description
---

Extract gz file in fetcher.


Diffs (updated)
-

  src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
  src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 

Diff: https://reviews.apache.org/r/38337/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" 
--verbose


Thanks,

haosdent huang

Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36838/
---

(Updated Oct. 3, 2015, 5:18 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-3111
https://issues.apache.org/jira/browse/MESOS-3111


Repository: mesos


Description
---

Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.


Diffs (updated)
-

  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/slave/containerizer/containerizer.cpp 
25c87e9f948b7efe8b9a853c403bee69982d6c4c 

Diff: https://reviews.apache.org/r/36838/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/
---

(Updated Oct. 3, 2015, 4 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
---

Rebase


Bugs: MESOS-3473
https://issues.apache.org/jira/browse/MESOS-3473


Repository: mesos


Description
---

Add error message when cgroup don't support memory.pressure_level.


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
75a3bc0009c037dc18ce319db2eb44630f083e8c 

Diff: https://reviews.apache.org/r/38532/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review101406
---


Patch looks great!

Reviews applied: [38338]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 3:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> ---
> 
> (Updated Oct. 3, 2015, 3:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3392
> https://issues.apache.org/jira/browse/MESOS-3392
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced option for Docker cli volume plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
> 
> Diff: https://reviews.apache.org/r/38338/diff/
> 
> 
> Testing
> ---
> 
> # When use volume-driver
> ```
> I1003 23:49:41.986047 11268 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_D3Fxye:/mnt/mesos/sandbox 
> --volume-driver=flocker --net host --entrypoint /bin/sh --name 
> mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v src:target`
> 
> # When don't use volume-driver
> ```
> 1003 23:53:48.028715 12125 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt:/mnt/mesos/sandbox --net 
> host --entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/
---

(Updated Oct. 3, 2015, 4:52 p.m.)


Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.


Changes
---

Rebase


Bugs: MESOS-2765
https://issues.apache.org/jira/browse/MESOS-2765


Repository: mesos


Description
---

Avoid multi writers write to same file in PortMappingIsolatorTests.


Diffs (updated)
-

  src/tests/containerizer/port_mapping_tests.cpp 
feca2043503436ac9abac6017ae9059b3fcbed21 

Diff: https://reviews.apache.org/r/36180/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review101411
---


Patch looks great!

Reviews applied: [35711]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated Oct. 3, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/
---

(Updated Oct. 3, 2015, 4:12 p.m.)


Review request for mesos, Adam B and Michael Park.


Changes
---

Rebase


Bugs: MESOS-1084
https://issues.apache.org/jira/browse/MESOS-1084


Repository: mesos


Description
---

Show stdout/stderr when using mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 

Diff: https://reviews.apache.org/r/36431/diff/


Testing
---

make check

![demo](https://issues.apache.org/jira/secure/attachment/12744923/12744923_show_stdout_stderr.gif
 "Demo")


Thanks,

haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---

(Updated Oct. 3, 2015, 4:11 p.m.)


Review request for mesos, Adam B, Jie Yu, and Michael Park.


Changes
---

Rebase


Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210


Repository: mesos


Description
---

Disallow special characters in role name.


Diffs (updated)
-

  include/mesos/roles.hpp PRE-CREATION 
  src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/common/roles.cpp PRE-CREATION 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/tests/roles_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35711/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/#review101408
---


Patch looks great!

Reviews applied: [38532]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38532/
> ---
> 
> (Updated Oct. 3, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3473
> https://issues.apache.org/jira/browse/MESOS-3473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add error message when cgroup don't support memory.pressure_level.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 75a3bc0009c037dc18ce319db2eb44630f083e8c 
> 
> Diff: https://reviews.apache.org/r/38532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/
---

(Updated Oct. 3, 2015, 4:17 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
---

Rebase


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.


Diffs (updated)
-

  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 

Diff: https://reviews.apache.org/r/38164/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose


Thanks,

haosdent huang

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38527/
---

(Updated Oct. 3, 2015, 4:15 p.m.)


Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Rebase


Bugs: MESOS-3470
https://issues.apache.org/jira/browse/MESOS-3470


Repository: mesos


Description
---

Fix UserCgroupIsolatorTest failed on CentOS 6.6.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
237f3f27722b01ff92d0dcbaba7910613542a1a7 

Diff: https://reviews.apache.org/r/38527/diff/


Testing (updated)
---

# In CentOS 6.6
sudo ./bin/mesos-tests.sh --gtest_filter="UserCgroupIsolatorTest*" --verbose


Thanks,

haosdent huang

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38825/#review101413
---

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38825/
> ---
> 
> (Updated Sept. 29, 2015, 8:21 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3543
> https://issues.apache.org/jira/browse/MESOS-3543
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> 9c369e2c94abcd2dfa463f98fb3b6527033064ab 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 076c8836d9d53b8bc69330a46a7e1d3039aa476b 
> 
> Diff: https://reviews.apache.org/r/38825/diff/
> 
> 
> Testing
> ---
> 
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
> 
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 36816: Support HTTP checks in Mesos health check program

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---

(Updated Oct. 3, 2015, 6:01 p.m.)


Review request for mesos, Adam B, Michael Park, and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533


Repository: mesos


Description
---

Support HTTP checks in Mesos health check program


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 

Diff: https://reviews.apache.org/r/36816/diff/


Testing
---

* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check


Thanks,

haosdent huang

Re: Review Request 38337: Extract gz file in fetcher.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/#review101409
---


Patch looks great!

Reviews applied: [38337]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:05 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38337/
> ---
> 
> (Updated Oct. 3, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-3407
> https://issues.apache.org/jira/browse/MESOS-3407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extract gz file in fetcher.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
>   src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 
> 
> Diff: https://reviews.apache.org/r/38337/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="FetcherTest.ExtractGzipFile" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38826/
---

(Updated Oct. 3, 2015, 11:36 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3543
https://issues.apache.org/jira/browse/MESOS-3543


Repository: mesos


Description
---

CMake: Added support for libevent for Unix builds.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
31d77d5629dba7ee0d1a4ceb7b60899f6047165f 
  CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be 
  src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
  src/slave/cmake/SlaveConfigure.cmake 230e574f3ddc6aa12cc74105de7201a33dd7cdab 

Diff: https://reviews.apache.org/r/38826/diff/


Testing
---

# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04

cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8


Thanks,

Alex Clemmer

Review Request 38976: CMake: Removed unused libsvn binaries from `FindSvn.cmake`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38976/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Removed unused libsvn binaries from `FindSvn.cmake`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 
87737395d011393e7ef0c86fa18a3d31f3045fb0 

Diff: https://reviews.apache.org/r/38976/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 38976: CMake: Removed unused libsvn binaries from `FindSvn.cmake`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38976/#review101419
---

Ship it!


- Joris Van Remoortere


On Oct. 3, 2015, 10:03 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38976/
> ---
> 
> (Updated Oct. 3, 2015, 10:03 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Removed unused libsvn binaries from `FindSvn.cmake`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 
> 87737395d011393e7ef0c86fa18a3d31f3045fb0 
> 
> Diff: https://reviews.apache.org/r/38976/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/#review101415
---

Ship it!


- Joris Van Remoortere


On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38827/
> ---
> 
> (Updated Sept. 29, 2015, 8:21 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Expanded support for compiling much of the master.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
> 
> Diff: https://reviews.apache.org/r/38827/diff/
> 
> 
> Testing
> ---
> 
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
> 
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38837: CMake: Disable agent build on Windows.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review101416
---

Ship it!


- Joris Van Remoortere


On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> ---
> 
> (Updated Sept. 29, 2015, 8:21 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Disable slave build on Windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be 
> 
> Diff: https://reviews.apache.org/r/38837/diff/
> 
> 
> Testing
> ---
> 
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
> 
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38826/#review101414
---

Ship it!


- Joris Van Remoortere


On Oct. 3, 2015, 11:45 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38826/
> ---
> 
> (Updated Oct. 3, 2015, 11:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3543
> https://issues.apache.org/jira/browse/MESOS-3543
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added support for libevent for Unix builds.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
>   src/slave/cmake/SlaveConfigure.cmake 
> 230e574f3ddc6aa12cc74105de7201a33dd7cdab 
> 
> Diff: https://reviews.apache.org/r/38826/diff/
> 
> 
> Testing
> ---
> 
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
> 
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38900: Update command executor to support rootfs.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38900/
---

(Updated Oct. 4, 2015, 5:35 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-3428
https://issues.apache.org/jira/browse/MESOS-3428


Repository: mesos


Description
---

Update command executor to support rootfs.


Diffs (updated)
-

  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341 
  src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55 
  src/slave/containerizer/mesos/containerizer.hpp 
4c1419290645ad4c44360a81618a6cea7ad190df 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 

Diff: https://reviews.apache.org/r/38900/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 38900: Update command executor to support rootfs.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38900/#review101430
---



src/slave/slave.cpp (line 3312)


Jie we explicitly set shell to true above, do you remember why?

This works locally.


- Timothy Chen


On Oct. 4, 2015, 5:35 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38900/
> ---
> 
> (Updated Oct. 4, 2015, 5:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3428
> https://issues.apache.org/jira/browse/MESOS-3428
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update command executor to support rootfs.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341 
>   src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4c1419290645ad4c44360a81618a6cea7ad190df 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38900/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review101420
---


Patch looks great!

Reviews applied: [38164]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Oct. 3, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38826/
---

(Updated Oct. 3, 2015, 11:45 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3543
https://issues.apache.org/jira/browse/MESOS-3543


Repository: mesos


Description
---

CMake: Added support for libevent for Unix builds.


Diffs (updated)
-

  CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be 
  src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
  src/slave/cmake/SlaveConfigure.cmake 230e574f3ddc6aa12cc74105de7201a33dd7cdab 

Diff: https://reviews.apache.org/r/38826/diff/


Testing
---

# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04

cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8


Thanks,

Alex Clemmer

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38825/
---

(Updated Oct. 3, 2015, 11:45 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3543
https://issues.apache.org/jira/browse/MESOS-3543


Repository: mesos


Description
---

CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
31d77d5629dba7ee0d1a4ceb7b60899f6047165f 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
9c369e2c94abcd2dfa463f98fb3b6527033064ab 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
076c8836d9d53b8bc69330a46a7e1d3039aa476b 

Diff: https://reviews.apache.org/r/38825/diff/


Testing
---

# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04

cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8


Thanks,

Alex Clemmer

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101422
---


Patch looks great!

Reviews applied: [36180]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated Oct. 3, 2015, 4:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36838/#review101424
---


Patch looks great!

Reviews applied: [36838]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 5:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36838/
> ---
> 
> (Updated Oct. 3, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3111
> https://issues.apache.org/jira/browse/MESOS-3111
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use flags.executor_shutdown_grace_period as shutdownTimeout in 
> ShutdownProcess.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/slave/containerizer/containerizer.cpp 
> 25c87e9f948b7efe8b9a853c403bee69982d6c4c 
> 
> Diff: https://reviews.apache.org/r/36838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 38977: Add reason for declineOffer

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/
---

Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.


Bugs: MESOS-3041
https://issues.apache.org/jira/browse/MESOS-3041


Repository: mesos


Description
---

Since this depends on MESOS-3522, so this patch only update the
interface and proto file.


Diffs
-

  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/v1/scheduler/scheduler.proto 
871c2ef00b13eb93f65119096577ed45a95aead3 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 

Diff: https://reviews.apache.org/r/38977/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37993: Add explanatory comments for Allocator interface

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/
---

(Updated 十月 4, 2015, 4:24 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.


Changes
---

Addressed Joseph and Alex's comments. Thanks both for the detailed review!


Bugs: MESOS-2224
https://issues.apache.org/jira/browse/MESOS-2224


Repository: mesos


Description
---

Add explanatory comments for Allocator interface


Diffs (updated)
-

  include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 

Diff: https://reviews.apache.org/r/37993/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 37993: Add explanatory comments for Allocator interface

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review101429
---


Patch looks great!

Reviews applied: [37993]

All tests passed.

- Mesos ReviewBot


On Oct. 4, 2015, 4:24 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> ---
> 
> (Updated Oct. 4, 2015, 4:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38977: Add reason for declineOffer

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/#review101427
---


Patch looks great!

Reviews applied: [38977]

All tests passed.

- Mesos ReviewBot


On Oct. 4, 2015, 3:20 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38977/
> ---
> 
> (Updated Oct. 4, 2015, 3:20 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3041
> https://issues.apache.org/jira/browse/MESOS-3041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since this depends on MESOS-3522, so this patch only update the
> interface and proto file.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/v1/scheduler/scheduler.proto 
> 871c2ef00b13eb93f65119096577ed45a95aead3 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
> 
> Diff: https://reviews.apache.org/r/38977/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38527/#review101418
---


Patch looks great!

Reviews applied: [38527]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38527/
> ---
> 
> (Updated Oct. 3, 2015, 4:15 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-3470
> https://issues.apache.org/jira/browse/MESOS-3470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UserCgroupIsolatorTest failed on CentOS 6.6.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 237f3f27722b01ff92d0dcbaba7910613542a1a7 
> 
> Diff: https://reviews.apache.org/r/38527/diff/
> 
> 
> Testing
> ---
> 
> # In CentOS 6.6
> sudo ./bin/mesos-tests.sh --gtest_filter="UserCgroupIsolatorTest*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36816: Support HTTP checks in Mesos health check program

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review101426
---


Patch looks great!

Reviews applied: [36816]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated Oct. 3, 2015, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Michael Park, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support HTTP checks in Mesos health check program
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37023: Add an endpoint that exposes component flags.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101428
---


For the description, I think that the current endpoint does not include ".json"?


src/master/http.cpp (line 526)


Does this needed?


- Guangya Liu


On 十月 3, 2015, 4:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated 十月 3, 2015, 4:49 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38579: Refactored registry client

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review101401
---



src/slave/containerizer/provisioner/docker/registry_client.cpp (lines 654 - 671)


I believe I left a comment about this before and talked to Joris, we're 
missing the file option that we can stream/splice to disk from libprocess.


- Timothy Chen


On Oct. 2, 2015, 12:24 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> ---
> 
> (Updated Oct. 2, 2015, 12:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Moved ManifestResponse struct from RegistryClient to namespace.
> - Cleanup
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>