date:20160207

Re: Review Request 43324: Updated endpoints/index.md.

2016-02-07 Thread Joerg Schad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43324/#review118208
---


Ship it!




Ship It!

- Joerg Schad


On Feb. 8, 2016, 7:07 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43324/
> ---
> 
> (Updated Feb. 8, 2016, 7:07 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The index was updated to reflect updates to the
> generate-endpoints-help.py script used to generate it.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 43293: Ignored invalid env vars.

2016-02-07 Thread Guangya Liu



> On 二月 7, 2016, 9:13 a.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 398
> > 
> >
> > Seems add quote back would be better.

I was adding '' instead of quota, hope it is OK.


> On 二月 7, 2016, 9:13 a.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 382
> > 
> >
> > Shoud we use LOG(WARNING) here?

This error will not impact the mesos behavior, so I'm just using VLOG(1) 
instead.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/#review118174
---


On 二月 7, 2016, 9:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43293/
> ---
> 
> (Updated 二月 7, 2016, 9:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4607
> https://issues.apache.org/jira/browse/MESOS-4607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored invalid env vars when creating docker image.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
> 
> Diff: https://reviews.apache.org/r/43293/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> $ GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DockerImageTest
> [ RUN  ] DockerImageTest.ParseInspectonImage
> I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
> files@192.168.0.100:49551
> I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
> I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
> I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate 
> environment variable 'JAVA_VERSION'
> I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
> variable 'JAVA_VERSION+8u66' for 'ContainerConfig.Env'
> I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
> AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
> 02:30:01.899522048+00:00
> I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
> I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
> files@192.168.0.100:49551
> I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
> [   OK ] DockerImageTest.ParseInspectonImage (8 ms)
> [--] 1 test from DockerImageTest (8 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (18 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43293: Ignored invalid env vars.

2016-02-07 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/
---

(Updated 二月 7, 2016, 9:40 a.m.)


Review request for mesos, haosdent huang, Jie Yu, and Timothy Chen.


Changes
---

Addressed haosdent's comments.


Bugs: MESOS-4607
https://issues.apache.org/jira/browse/MESOS-4607


Repository: mesos


Description
---

Ignored invalid env vars when creating docker image.


Diffs (updated)
-

  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/tests/containerizer/docker_tests.cpp 
620819330847a10d9dcd817968df9d2b180a9a29 

Diff: https://reviews.apache.org/r/43293/diff/


Testing (updated)
---

make
make check

$ GLOG_v=2 ./bin/mesos-tests.sh  
--gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from DockerImageTest
[ RUN  ] DockerImageTest.ParseInspectonImage
I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
files@192.168.0.100:49551
I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate environment 
variable 'JAVA_VERSION'
I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
variable 'JAVA_VERSION+8u66' for 'ContainerConfig.Env'
I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
02:30:01.899522048+00:00
I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
files@192.168.0.100:49551
I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
[   OK ] DockerImageTest.ParseInspectonImage (8 ms)
[--] 1 test from DockerImageTest (8 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (18 ms total)
[  PASSED  ] 1 test.


Thanks,

Guangya Liu

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

(Updated Feb. 7, 2016, 8:12 a.m.)


Review request for mesos, Jan Schlicht and Paul Brett.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Wait for perf statistics processes exit.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/43284/diff/


Testing (updated)
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```

This also fix similar error in 
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward`.


Thanks,

haosdent huang

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

(Updated Feb. 7, 2016, 8:14 a.m.)


Review request for mesos, Jan Schlicht and Paul Brett.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Wait for perf statistics processes exit.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/43284/diff/


Testing (updated)
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```

This also fix similar error in 
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated Feb. 7, 2016, 8:14 a.m.)


Review request for mesos, Jan Schlicht and Paul Brett.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing (updated)
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 43293: Ignored invalid env vars.

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/#review118174
---


Fix it, then Ship it!




Ship It!


src/docker/docker.cpp (line 382)


Shoud we use LOG(WARNING) here?



src/docker/docker.cpp (line 391)


Suggest add `'` for value here as well.



src/docker/docker.cpp (line 398)


Seems add quote back would be better.


- haosdent huang


On Feb. 7, 2016, 2:35 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43293/
> ---
> 
> (Updated Feb. 7, 2016, 2:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4607
> https://issues.apache.org/jira/browse/MESOS-4607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored invalid env vars when creating docker image.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
> 
> Diff: https://reviews.apache.org/r/43293/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DockerImageTest
> [ RUN  ] DockerImageTest.ParseInspectonImage
> I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
> files@192.168.0.100:49551
> I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
> I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
> I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate 
> environment variable: JAVA_VERSION
> I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
> variable: JAVA_VERSION+8u66for 'ContainerConfig.Env'
> I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
> AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
> 02:30:01.899522048+00:00
> I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
> I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
> files@192.168.0.100:49551
> I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
> [   OK ] DockerImageTest.ParseInspectonImage (8 ms)
> [--] 1 test from DockerImageTest (8 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (18 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43293: Ignored invalid env vars.

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/#review118176
---



Patch looks great!

Reviews applied: [43293]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 9:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43293/
> ---
> 
> (Updated Feb. 7, 2016, 9:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4607
> https://issues.apache.org/jira/browse/MESOS-4607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored invalid env vars when creating docker image.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
> 
> Diff: https://reviews.apache.org/r/43293/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> $ GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DockerImageTest
> [ RUN  ] DockerImageTest.ParseInspectonImage
> I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
> files@192.168.0.100:49551
> I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
> I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
> I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate 
> environment variable 'JAVA_VERSION'
> I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
> variable 'JAVA_VERSION+8u66' for 'ContainerConfig.Env'
> I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
> AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
> 02:30:01.899522048+00:00
> I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
> I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
> files@192.168.0.100:49551
> I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
> [   OK ] DockerImageTest.ParseInspectonImage (8 ms)
> [--] 1 test from DockerImageTest (8 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (18 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/#review118178
---



Patch looks great!

Reviews applied: [43302, 43303, 43304, 43305, 43306, 43307, 43308, 43309]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43309/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> d64832477313de2ef39aa43db67486cfa4023813 
> 
> Diff: https://reviews.apache.org/r/43309/diff/
> 
> 
> Testing
> ---
> 
> make check
> manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43313: Fixed Typos in support/hooks

2016-02-07 Thread Disha Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43313/
---

Review request for mesos and switched to 'mcypark'.


Repository: mesos


Description
---

Fixed Typos in support/hooks


Diffs
-

  support/hooks/post-rewrite af907de7c6dd44fd6a7f34f52aaaed4460c44bc1 
  support/hooks/pre-commit bdc12af4c2e3f1c32c6b7763c791e41d7e9d72d4 

Diff: https://reviews.apache.org/r/43313/diff/


Testing
---

No testing needed.


Thanks,

Disha  Singh

Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43307/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/docker.cpp 19daf7d73cc8e0b0fd4afa58cc5ff7f6b7d9e345 

Diff: https://reviews.apache.org/r/43307/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43305: Moved systemd executor slice initialization logic.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43305/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/linux/systemd.hpp dc8605b323cafdc0dde00d36a2cc5cf2c241e51c 
  src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a 
  src/slave/containerizer/mesos/linux_launcher.hpp 
b061981b063a67d837fe8e291921ca9c44d3ac40 
  src/slave/containerizer/mesos/linux_launcher.cpp 
c2e252ec6ed0d6d4c47e244f700315bd340cee5f 
  src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 

Diff: https://reviews.apache.org/r/43305/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/mesos/launcher.cpp 
d64832477313de2ef39aa43db67486cfa4023813 

Diff: https://reviews.apache.org/r/43309/diff/


Testing
---

make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.


Thanks,

Joris Van Remoortere

Review Request 43304: Mesos: Disambiguated call to 'subprocess' in linux launcher.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43304/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/mesos/linux_launcher.cpp 
c2e252ec6ed0d6d4c47e244f700315bd340cee5f 

Diff: https://reviews.apache.org/r/43304/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43306/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a 
  src/slave/containerizer/mesos/linux_launcher.cpp 
c2e252ec6ed0d6d4c47e244f700315bd340cee5f 
  src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 

Diff: https://reviews.apache.org/r/43306/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
bb50cc3070245a294fa16efe44f14ae893bc5518 
  3rdparty/libprocess/src/subprocess.cpp 
ff477e37a9619c780bddd5a8e629fa981b729715 

Diff: https://reviews.apache.org/r/43302/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/container_loggers/lib_logrotate.cpp 
01a3ff031b70366443214e2895803cd4b2606ad8 

Diff: https://reviews.apache.org/r/43308/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 43303: Libprocess: Added 'options' as an argument to 'subprocess'.

2016-02-07 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43303/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

In the future we will remove the default argument for `options` to
force the caller to think about what kind of subprocess they want
to launch.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
bb50cc3070245a294fa16efe44f14ae893bc5518 
  3rdparty/libprocess/src/subprocess.cpp 
ff477e37a9619c780bddd5a8e629fa981b729715 

Diff: https://reviews.apache.org/r/43303/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-07 Thread Ben Mahler


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/#review118185
---


Ship it!




Ship It!

- Ben Mahler


On Feb. 6, 2016, 11:30 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43122/
> ---
> 
> (Updated Feb. 6, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-4584
> https://issues.apache.org/jira/browse/MESOS-4584
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are three components to generating new doxygen pages:
> 
> 1. Now that we have a Doxyfile, pass it to `doxygen` command.
> 2. Genarate doxygen pages in a diretcory named `doxygen` in the current 
> directory.
> 3. Once the doxygen pages have been generated, move them into 
> `publish/api/latest/c++`.
> 
> After step 3, one can copy over the publish directory to mesos-site svn 
> repository.
> 
> 
> Diffs
> -
> 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/43122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-07 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118186
---

Fix it, then Ship it!

site/README.md (line 11)

Conflicting version numbers of what? Seems a bit vague?

site/README.md (line 23)

Could you also add this to the release guide so folks don't forget?

site/README.md (lines 61 - 88)

Thanks! Next step will be to script this up :)

One step at a time.. :)

site/README.md (lines 73 - 74)

Meaning, if publish doesn't contain an api directory, or? How does one 
check this?

site/README.md (lines 86 - 87)

Could you include a "-m " here so that people are including 
messages when they make commits?

- Ben Mahler

On Feb. 7, 2016, 12:02 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> ---
> 
> (Updated Feb. 7, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 
> 
> Diff: https://reviews.apache.org/r/43263/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-07 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118193
---



Looks good. Just a couple of minor issues.


src/tests/slave_tests.cpp (line 1339)


Can we just do:

`TestContainerizer containerizer1;` similar to what we do a few lines later 
in this test for `containerizer2` to be consistent?

Another option can be to modify both the occurences and wrap them in 
`process::Owned`. I would prefer the first option since we do so for all the 
other tests in this file too.



src/tests/slave_tests.cpp (line 1357)


Nit: I thought we decided to not do `Times(1)` explicitly in our test code?



src/tests/slave_tests.cpp (line 1397)


This expectation should be done before we invoke `StartSlave` to avoid a 
potential race.


- Anand Mazumdar


On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> ---
> 
> (Updated Feb. 5, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> ---
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review118184
---



Patch looks great!

Reviews applied: [42696, 43316]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 7, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43312: Updated docs/presentations.md

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43312/#review118179
---



Bad patch!

Reviews applied: [43312]

Failed command: ./support/apply-review.sh -n -r 43312

Error:
2016-02-07 16:48:28 URL:https://reviews.apache.org/r/43312/diff/raw/ [748/748] 
-> "43312.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/11306/console

- Mesos ReviewBot


On Feb. 7, 2016, 4:13 p.m., Disha  Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43312/
> ---
> 
> (Updated Feb. 7, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-2444
> https://issues.apache.org/jira/browse/MESOS-2444
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs/presentations.md
> 
> 
> Diffs
> -
> 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
> 
> Diff: https://reviews.apache.org/r/43312/diff/
> 
> 
> Testing
> ---
> 
> No testing needed.
> 
> 
> Thanks,
> 
> Disha  Singh
> 
>

Re: Review Request 43313: Fixed Typos in support/hooks

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43313/#review118180
---



Bad patch!

Reviews applied: [43313]

Failed command: ./support/apply-review.sh -n -r 43313

Error:
2016-02-07 17:19:30 URL:https://reviews.apache.org/r/43313/diff/raw/ 
[1123/1123] -> "43313.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/11307/console

- Mesos ReviewBot


On Feb. 7, 2016, 4:14 p.m., Disha  Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43313/
> ---
> 
> (Updated Feb. 7, 2016, 4:14 p.m.)
> 
> 
> Review request for mesos and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed Typos in support/hooks
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite af907de7c6dd44fd6a7f34f52aaaed4460c44bc1 
>   support/hooks/pre-commit bdc12af4c2e3f1c32c6b7763c791e41d7e9d72d4 
> 
> Diff: https://reviews.apache.org/r/43313/diff/
> 
> 
> Testing
> ---
> 
> No testing needed.
> 
> 
> Thanks,
> 
> Disha  Singh
> 
>

Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

Review request for mesos.


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 7, 2016, 6:38 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang

Review Request 43319: Remove md files from doxygen.

2016-02-07 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43319/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4619
https://issues.apache.org/jira/browse/MESOS-4619


Repository: mesos


Description
---

The doxygen html pages corresponding to `doc/*` markdown files are redundant 
and have broken links. As such, they don't serve any reasonable purpose in 
doxygen site.


Diffs
-

  Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 

Diff: https://reviews.apache.org/r/43319/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-07 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43318/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 

Diff: https://reviews.apache.org/r/43318/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 43319: Remove md files from doxygen.

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43319/#review118199
---



Patch looks great!

Reviews applied: [43120, 43121, 43122, 43263, 43318, 43319]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 12:40 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43319/
> ---
> 
> (Updated Feb. 8, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4619
> https://issues.apache.org/jira/browse/MESOS-4619
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The doxygen html pages corresponding to `doc/*` markdown files are redundant 
> and have broken links. As such, they don't serve any reasonable purpose in 
> doxygen site.
> 
> 
> Diffs
> -
> 
>   Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 
> 
> Diff: https://reviews.apache.org/r/43319/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-07 Thread Kapil Arya



> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, line 11
> > 
> >
> > Conflicting version numbers of what? Seems a bit vague?

Elaborated a bit.


> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, line 23
> > 
> >
> > Could you also add this to the release guide so folks don't forget?

Create a new RR: https://reviews.apache.org/r/43263/


> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, lines 61-88
> > 
> >
> > Thanks! Next step will be to script this up :)
> > 
> > One step at a time.. :)

Yup :).


> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, lines 73-74
> > 
> >
> > Meaning, if publish doesn't contain an api directory, or? How does one 
> > check this?

Let's keep it as is for now and we can handle it when we automate the steps 
later.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118186
---


On Feb. 7, 2016, 7:33 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> ---
> 
> (Updated Feb. 7, 2016, 7:33 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 
> 
> Diff: https://reviews.apache.org/r/43263/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-07 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/
---

(Updated Feb. 7, 2016, 7:33 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Address BenM's comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 

Diff: https://reviews.apache.org/r/43263/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-07 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4175
https://issues.apache.org/jira/browse/MESOS-4175


Repository: mesos


Description
---

Speeded up SchedulerTest.Decline by advancing the clock.


Diffs
-

  src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 

Diff: https://reviews.apache.org/r/43321/diff/


Testing
---

sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*

```sh
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
```


Thanks,

Shuai Lin

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-07 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review118203
---


Ship it!




Ship It!

- haosdent huang


On Feb. 8, 2016, 4:20 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43321/
> ---
> 
> (Updated Feb. 8, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4175
> https://issues.apache.org/jira/browse/MESOS-4175
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up SchedulerTest.Decline by advancing the clock.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/43321/diff/
> 
> 
> Testing
> ---
> 
> sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*
> 
> ```sh
> [ RUN  ] ContentType/SchedulerTest.Decline/0
> [   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
> [ RUN  ] ContentType/SchedulerTest.Decline/1
> [   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 43324: Updated endpoints/index.md.

2016-02-07 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43324/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3831
https://issues.apache.org/jira/browse/MESOS-3831


Repository: mesos


Description
---

The index was updated to reflect updates to the
generate-endpoints-help.py script used to generate it.


Diffs
-

  docs/endpoints/index.md PRE-CREATION 

Diff: https://reviews.apache.org/r/43324/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

2016-02-07 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43220/
---

(Updated Feb. 8, 2016, 7:06 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Changes
---

Updated to address bmahler's newest comments.


Bugs: MESOS-3831
https://issues.apache.org/jira/browse/MESOS-3831


Repository: mesos


Description
---

Invoke this script from anywhere within the mesos source tree
(including in the build directory) to autogenerate documentation for
all endpoint strings and install them into the docs/endpoint folder.
In a subsequent commit we commit all of these autogenerated files back
to the source repo and add a link in home.md to find them.


Diffs (updated)
-

  support/generate-endpoint-help.py PRE-CREATION 

Diff: https://reviews.apache.org/r/43220/diff/


Testing
---

Ran and generated files from it.  Then rebuilt the website and verified that 
everything looked as it should.


Thanks,

Kevin Klues

Re: Review Request 43313: Fixed Typos in support/hooks.

2016-02-07 Thread Disha Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43313/
---

(Updated Feb. 8, 2016, 5:22 a.m.)


Review request for mesos and switched to 'mcypark'.


Summary (updated)
-

Fixed Typos in support/hooks.


Repository: mesos


Description (updated)
---

Fixed Typos in support/hooks.


Diffs
-

  support/hooks/post-rewrite af907de7c6dd44fd6a7f34f52aaaed4460c44bc1 
  support/hooks/pre-commit bdc12af4c2e3f1c32c6b7763c791e41d7e9d72d4 

Diff: https://reviews.apache.org/r/43313/diff/


Testing
---

No testing needed.


Thanks,

Disha  Singh

Re: Review Request 43312: Updated docs/presentations.md.

2016-02-07 Thread Disha Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43312/
---

(Updated Feb. 8, 2016, 5:23 a.m.)


Review request for mesos and switched to 'mcypark'.


Summary (updated)
-

Updated docs/presentations.md.


Bugs: MESOS-2444
https://issues.apache.org/jira/browse/MESOS-2444


Repository: mesos


Description (updated)
---

Updated docs/presentations.md.


Diffs
-

  docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 

Diff: https://reviews.apache.org/r/43312/diff/


Testing
---

No testing needed.


Thanks,

Disha  Singh

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review118202
---



Patch looks great!

Reviews applied: [43321]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 4:20 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43321/
> ---
> 
> (Updated Feb. 8, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4175
> https://issues.apache.org/jira/browse/MESOS-4175
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up SchedulerTest.Decline by advancing the clock.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/43321/diff/
> 
> 
> Testing
> ---
> 
> sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*
> 
> ```sh
> [ RUN  ] ContentType/SchedulerTest.Decline/0
> [   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
> [ RUN  ] ContentType/SchedulerTest.Decline/1
> [   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

2016-02-07 Thread Avinash sridharan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
---

(Updated Feb. 8, 2016, 6:43 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
---

Added a unit-test to test net_cls major handles set from command line.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
84fe4fb61ac032e68d2ab22e85f6b41481c04644 

Diff: https://reviews.apache.org/r/42782/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-07 Thread Avinash sridharan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/
---

(Updated Feb. 8, 2016, 6:44 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Adding info logging.


Bugs: MESOS-4489
https://issues.apache.org/jira/browse/MESOS-4489


Repository: mesos


Description
---

Implemented the `status` method in `CgroupNetClsIsolatorProcess`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
fd674090d4b7f22b98571b693d71493d71b8e05e 

Diff: https://reviews.apache.org/r/42947/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Review Request 43322: Exposed `ContainerStatus` in `state.json`.

2016-02-07 Thread Avinash sridharan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43322/
---

Review request for mesos.


Repository: mesos


Description
---

Exposed `ContainerStatus` in `state.json`.


Diffs
-

  src/common/http.cpp a56c3f1fdc1beec0bf842eba826279e82d4648ec 

Diff: https://reviews.apache.org/r/43322/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-07 Thread Avinash sridharan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 8, 2016, 6:43 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
1e362d2756690368fde46a3a516c258d9ead2154 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43319: Remove md files from doxygen.

2016-02-07 Thread Joerg Schad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43319/#review118205
---


Ship it!




Ship It!

- Joerg Schad


On Feb. 8, 2016, 12:40 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43319/
> ---
> 
> (Updated Feb. 8, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4619
> https://issues.apache.org/jira/browse/MESOS-4619
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The doxygen html pages corresponding to `doc/*` markdown files are redundant 
> and have broken links. As such, they don't serve any reasonable purpose in 
> doxygen site.
> 
> 
> Diffs
> -
> 
>   Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 
> 
> Diff: https://reviews.apache.org/r/43319/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

43 matches

Mail list logo