Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Adam B 


> On March 16, 2016, 3:30 a.m., Adam B wrote:
> > Ship It!

Went back to look at the patch that originally added the Disk column, and found 
one more copy/paste error in src/webui/master/static/slave.html
I'm fixing that one too with the same commit.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44888/#review123850
---


On March 16, 2016, 3:05 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44888/
> ---
> 
> (Updated March 16, 2016, 3:05 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4957
> https://issues.apache.org/jira/browse/MESOS-4957
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix the typo.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/offers.html 
> 25e487193ae5244dde40d1de1d96ce892a7c67b9 
> 
> Diff: https://reviews.apache.org/r/44888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44888/#review123850
---


Ship it!




Ship It!

- Adam B


On March 16, 2016, 3:05 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44888/
> ---
> 
> (Updated March 16, 2016, 3:05 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4957
> https://issues.apache.org/jira/browse/MESOS-4957
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix the typo.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/offers.html 
> 25e487193ae5244dde40d1de1d96ce892a7c67b9 
> 
> Diff: https://reviews.apache.org/r/44888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/#review123847
---



Patch looks great!

Reviews applied: [44832]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 16, 2016, 1:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44832/
> ---
> 
> (Updated March 16, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Kevin Klues.
> 
> 
> Bugs: MESOS-2023
> https://issues.apache.org/jira/browse/MESOS-2023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate string when convert `Flags` to `hashmap`.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp 9535fad0d50b469fbb4dc6ac5cf5c89b40d29b47 
> 
> Diff: https://reviews.apache.org/r/44832/diff/
> 
> 
> Testing
> ---
> 
> 1. Without pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a'
> ```
> 
> Output:
> ```
> Starting task test
> Forked command at 4542
> sh -c 'echo $a'
> I0315 11:45:39.153188  4402 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0001 from execu
> tor(1)@127.0.0.1:54698
> I0315 11:45:39.153964  4401 status_update_manager.cpp:320] Received status 
> update TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task 
> test of framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-
> 0001
> ```
> 
> 2. Pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo 
> $a' --env="{\"a\": \"stdin\"}"
> ```
> 
> Output:
> ```
> Registered executor on localhost
> Starting task test
> Forked command at 4675
> sh -c 'echo $a'
> stdin
> I0315 11:46:34.797502  4408 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 16040c40-f5e4-4bf0-8690-447f2901310b) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0003 from execu
> tor(1)@127.0.0.1:57831
> ```
> 
> 3. Pass incorrect json format in `--env=`.
> ```
> ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a' 
> --env="{\"a\": {}}"
> Failed to load flag 'env': Failed to load value '{"a": {}}': The value of key 
> 'a' in '{"a":{}}' is not a valid string.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44888/
---

(Updated March 16, 2016, 10:05 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4957
https://issues.apache.org/jira/browse/MESOS-4957


Repository: mesos


Description
---

Fix the typo.


Diffs
-

  src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9 

Diff: https://reviews.apache.org/r/44888/diff/


Testing
---


Thanks,

Yongqiao Wang

Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44888/
---

Review request for mesos and Adam B.


Repository: mesos


Description
---

Fix the typo.


Diffs
-

  src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9 

Diff: https://reviews.apache.org/r/44888/diff/


Testing
---


Thanks,

Yongqiao Wang

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

2016-03-16 Thread Zhiwei Chen 


> On March 16, 2016, 8:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.
> 
> Zhiwei Chen wrote:
> Thanks Vinod, I need to combine all patches and then test on Power 
> platform, so I planed only to test single patches on ubuntu/rhel/apple one by 
> one, after all patches go into upstream, I will create a patch to fix ppc64le 
> test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch 
> and then test again. Will update the Testing section when I am done.

Hi Vinod, when I do make check, I encouter this message many times, could you 
tell me how to solve this?

**1. This will cause the CgroupsNoHierarchyTest failed**
We cannot run any cgroups tests that require mounting
hierarchies because you have the following hierarchies mounted:
/sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, 
/sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, 
/sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, 
/sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd
We'll disable the CgroupsNoHierarchyTest test fixture for now.

**2. I have no physical machine, so I can't do perf test**
The 'cpu-cycles' hardware event of 'perf' is not available on
this platform so tests using it will not be run.
One likely reason is that the tests are run in a virtual
machine that does not provide CPU performance counters

**3. I use Ubuntu 14.04 as dev environment, so no overlayfs test**

We cannot run any overlayfs tests because:
Overlayfs is not supported on your systems


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
---


On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 14, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native/ext_modules.py.in 
> eb93864733713dddad66141c6b8b6cd895f41484 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-16 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/
---

(Updated March 16, 2016, 8:03 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
---

Windows: Added Socket compatibility `#define`s to windows.hpp.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 

Diff: https://reviews.apache.org/r/44078/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44622/
---

(Updated March 16, 2016, 3:58 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Introduced a protobuf message "NetworkResult".


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/44622/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44514/
---

(Updated March 16, 2016, 3:49 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented prepare() method of "network/cni" isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44514/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44706/
---

(Updated March 16, 2016, 3:50 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented isolate() method of "network/cni" isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44706/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44622/
---

(Updated March 16, 2016, 3:48 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Introduced a protobuf message "NetworkResult".


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/44622/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/
---

(Updated March 16, 2016, 3:25 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented the framework and create() method of "network/cni" isolator.


Diffs (updated)
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44555/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 40532: Added notion of evict resources to RunTaskMessage.

2016-03-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review123842
---



Patch looks great!

Reviews applied: [40375, 41334, 41333, 42547, 40529, 40532]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 16, 2016, 1:46 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> ---
> 
> (Updated March 16, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added notion of evict resources to RunTaskMessage.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c 
> 
> Diff: https://reviews.apache.org/r/40532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

2016-03-16 Thread Zhiwei Chen 


> On March 16, 2016, 8:46 a.m., Vinod Kone wrote:
> > Can you explain what testing you have done in the "Testing done" section? 
> > 
> > According to MESOS-4312, we agreed to do the following tests:
> > 
> > -- Verify SSL, perf and docker related test cases work as expected on all 
> > platforms.
> > -- Do the validation on all platforms by "sudo make dist check" and "sudo 
> > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf 
> > numbers are OK.
> > -- Run compatibility tests between scheduler <=> master <=> slave <=> 
> > executor where each of the components is running either the 
> > patched/upgraded version or not.

Thanks Vinod, I need to combine all patches and then test on Power platform, so 
I planed only to test single patches on ubuntu/rhel/apple one by one, after all 
patches go into upstream, I will create a patch to fix ppc64le test 
cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch and then 
test again. Will update the Testing section when I am done.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review123812
---


On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 14, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native/ext_modules.py.in 
> eb93864733713dddad66141c6b8b6cd895f41484 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-16 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated March 16, 2016, 2:32 p.m.)


Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.


Changes
---

Address comments.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-16 Thread Klaus Ma 


> On March 16, 2016, 1:40 a.m., Greg Mann wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 56
> > 
> >
> > Is this true? It looks like we will launch multiple tasks on some 
> > slaves.

It should be `at most one task at a time on each slave.`


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review122307
---


On March 16, 2016, 2:27 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 16, 2016, 2:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-16 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated March 16, 2016, 2:27 p.m.)


Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.


Changes
---

Address Greg's comments.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48
> > 
> >
> > Let's remove this 'empty' check here since you hae the os::exists check 
> > below.
> 
> Qian Zhang wrote:
> They are for different purposes, `os::exist` is used to check if the 
> directory exists or not, and here 
> `flags.network_cni_plugins_dir.get().empty()` is used to check if operator 
> does not specify the value of `--network_cni_plugins_dir` (e.g., 
> "`--network_cni_plugins_dir=`") when starting agent.
> 
> Jie Yu wrote:
> ok, can you use flags.network_ci_plugin_dir->empty()?

`flags.network_ci_plugin_dir` is an `Option`, and I think there is 
no `empty()` method in `Option` class.


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > 
> >
> > Again, this check should be removed to support containers that do not 
> > specify NetworkInfo.
> 
> Qian Zhang wrote:
> We do support containers that do not specify NetworkInfo, please take a 
> look at the diff of https://reviews.apache.org/r/44514/, in `prepare()`, if 
> the container does not specify NetworkInfo, then it will not do anything 
> (just a no-op) and subsequently `isolate()` will not do anything for this 
> kind of container too.
> 
> So my idea is, if operator decides to use `network/cni` isolator, then 
> s/he must specify CNI network configuration and plugin which should be 
> acceptable since CNI isolator needs CNI network configuration and plugin 
> sounds a reasonable requirement to me. But for framework, they do not have to 
> launch container to join CNI network, if they do not want a container to join 
> any CNI networks, then just do not specify NetworkInfo or specify NetworkInfo 
> without `name` field, we should definitly support it.
> 
> Avinash sridharan wrote:
> I agree with Qian on this.  If the `network/cni` isolator is being used 
> then we "must" have associated network configs. If frameworks don't want to 
> use the cni network they can opt-out by not setting anything in the `name` 
> field for `NetworkInfo`.
> 
> Jie Yu wrote:
> ok, what I am thinking is that we made network/cni isolator the default 
> network isolator (like the default filesystem isolator). I think we need a 
> network isolator anyway because imagine a situation where no network isolator 
> is specified, but the framework specifies a name in the NetworkInfo, in that 
> case, we don't have a way to reject this task. Therefore, we can either build 
> a default network isolator which does nothing but reject containers that 
> specify networkInfo.name, or we make network/cni isolator the default, and 
> use it even if no cni plugins are specified by the operator (in that case, 
> it'll also reject any containers the specify a networkinfo.name). Does that 
> make sense?

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 15, 2016, 11:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>