Review Request 46306: Add `HealthCheckTest.HealthyTaskShellEscape`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46306/
---

Review request for mesos, Alexander Rukletsov and Lukas Loesche.


Repository: mesos


Description
---

Just for demo, please don't submit it.


Diffs
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46306/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129255
---


Fix it, then Ship it!





src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp (lines 29 - 33)


What's the ordering. Should we put 'using std::string' first as it's from 
library? I see some in consistency on this. Let's be consistent.



src/log/log.cpp (lines 742 - 744)


Can you move this to the top of the file?



src/state/log.cpp (lines 56 - 62)


I like this ordering. Can you stick to this ordering in other files?



src/tests/state_tests.cpp (lines 73 - 79)


Not yours, but mind pulling this up (no in the namespace braces).


- Jie Yu


On April 16, 2016, 1:27 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> ---
> 
> (Updated April 16, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced 'using namespace' with 'using'.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

[Neil Conway]

> On April 14, 2016, 7:10 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 489-490
> > 
> >
> > This is now effectively managed by the `ProcessManager`, so you could 
> > bring it into the `ProcessManager` 's scope (which would still be global).

This makes sense (and I would love to eliminate all the global state in 
libprocess), but AFAICS it won't be easy to implement: if we make `gc` a field 
of `ProcessManager`, we'd ideally like to initialize and spawn the GC process 
in `ProcessManager`'s constructor. But that isn't possible, because we can't 
safely call `spawn` at the time we are constructing the ProcessManager. We 
could still move `gc` to be a field of `ProcessManager` but spawn it 
separately, but I'm not sure if that is actually a net improvement at that 
point.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45996/#review128956
---


On April 11, 2016, 1:41 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45996/
> ---
> 
> (Updated April 11, 2016, 1:41 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `gc` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gc.hpp 
> 799468ebe49f2a49d325f40ffd8acea727abf74c 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45996/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---

(Updated April 16, 2016, 5:01 p.m.)


Review request for mesos and Adam B.


Changes
---

Rebase.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description (updated)
---

In this changes, we redirect to the leader master in those http
endpoints which depend on master elected status if current master is
not a leader.


Diffs (updated)
-

  src/master/http.cpp d83ccd394c688803369034e22de79b40277a3a7c 

Diff: https://reviews.apache.org/r/34646/diff/


Testing
---

make check

when current master is not a leader, it would redirect to the leader master.

```
$ curl -i http://master1:5050/master/tasks.json
HTTP/1.1 307 Temporary Redirect
Date: Mon, 01 Jun 2015 06:30:08 GMT
Location: http://master2:5050//master/tasks.json
Content-Length: 0
```


Thanks,

haosdent huang

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review129252
---



Patch looks great!

Reviews applied: [43520]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 3:37 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 16, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by reduce
> `executor_shutdown_grace_period`.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 16, 2016, 3:37 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.


Summary (updated)
-

Speeded up GarbageCollectorIntegrationTest.Restart.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description (updated)
---

Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.


Diffs (updated)
-

  src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 

Diff: https://reviews.apache.org/r/43520/diff/


Testing
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 46298: Rejected relative path agent work_dir.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129247
---


Ship it!




Ship It!

- haosdent huang


On April 16, 2016, 8:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> ---
> 
> (Updated April 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rejected relative path agent work_dir.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
> 
> Diff: https://reviews.apache.org/r/46298/diff/
> 
> 
> Testing
> ---
> 
> 1. make && make check
> 2. e2e test: 
>  
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44379: Use tokens size to parse perf stat format.

[haosdent huang]

> On April 16, 2016, 12:23 p.m., haosdent huang wrote:
> > src/linux/perf.cpp, line 346
> > 
> >
> > Hi, @fan.du. I believe @bmahler would like to elaborate more details 
> > here. Just my idea, feel free to correct it because I am not a native 
> > speaker.
> > 
> > ```
> > // NOTE: perf statistics csv output format for cgroups could 
> > possibly be one
> > // of the following formats:
> > //   * value,event,cgroup (since 2.6.38)
> > //   * value,unit,event,cgroup (since Linux kernel 3.14)
> > //   * value,unit,event,cgroup,running,ratio (since Linux kernel 
> > 4.1)
> > // Howerver, we could not match them exactly by check Linux kernel 
> > version
> > // because Linux distributions backport the related patches without 
> > change
> > // kernel version number. So we match the `perf stat` output by 
> > token size
> > // here.
> > if (tokens.size() == 3) {
> >   return Sample({tokens[0], internal::normalize(tokens[1]), 
> > tokens[2]});
> > } else if ((tokens.size() == 4) || (tokens.size() == 6)) {
> >   return Sample({tokens[0], internal::normalize(tokens[2]), 
> > tokens[3]});
> > }
> > ```

Sorry for typo, 
```
//   * value,event,cgroup (since 2.6.38)
```
shoud be
```
//   * value,event,cgroup (since 2.6.39)
```

This commit 
https://github.com/torvalds/linux/commit/023695d96ee06f36cf5014e286edcd623e9fb847


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review129245
---


On April 11, 2016, 7:01 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> ---
> 
> (Updated April 11, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4705
> https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use tokens size to parse perf stat format.
> 
> Co-authored with haosdent.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> ---
> 
> 1. {Found and Test} with Serenity, ema filter could get perf event statistics 
> correctly as expected.
> 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
> --log_dir=/tmp/mesos/
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 44379: Use tokens size to parse perf stat format.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review129245
---




src/linux/perf.cpp (line 346)


Hi, @fan.du. I believe @bmahler would like to elaborate more details here. 
Just my idea, feel free to correct it because I am not a native speaker.

```
// NOTE: perf statistics csv output format for cgroups could possibly 
be one
// of the following formats:
//   * value,event,cgroup (since 2.6.38)
//   * value,unit,event,cgroup (since Linux kernel 3.14)
//   * value,unit,event,cgroup,running,ratio (since Linux kernel 4.1)
// Howerver, we could not match them exactly by check Linux kernel 
version
// because Linux distributions backport the related patches without 
change
// kernel version number. So we match the `perf stat` output by token 
size
// here.
if (tokens.size() == 3) {
  return Sample({tokens[0], internal::normalize(tokens[1]), tokens[2]});
} else if ((tokens.size() == 4) || (tokens.size() == 6)) {
  return Sample({tokens[0], internal::normalize(tokens[2]), tokens[3]});
}
```


- haosdent huang


On April 11, 2016, 7:01 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> ---
> 
> (Updated April 11, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4705
> https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use tokens size to parse perf stat format.
> 
> Co-authored with haosdent.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> ---
> 
> 1. {Found and Test} with Serenity, ema filter could get perf event statistics 
> correctly as expected.
> 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
> --log_dir=/tmp/mesos/
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/#review129244
---



Patch looks great!

Reviews applied: [45083, 45084, 46043, 45085, 46158, 45087, 45352, 45362, 
46299, 45363, 45472, 45573, 45574, 43284, 46300, 45086]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 10:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45086/
> ---
> 
> (Updated April 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian 
> Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable cgroups unified isolator in isolation.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1e1a36903f4377497bb72b69e4ead63675d453c0 
> 
> Diff: https://reviews.apache.org/r/45086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 16, 2016, 10:29 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
1e1a36903f4377497bb72b69e4ead63675d453c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46300/
---

(Updated April 16, 2016, 10:29 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5075
https://issues.apache.org/jira/browse/MESOS-5075


Repository: mesos


Description
---

Wait for process:reap in CGROUPS_ROOT_PerfRollForward.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/46300/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45574/
---

(Updated April 16, 2016, 10:28 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45574/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

(Updated April 16, 2016, 10:28 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-5075
https://issues.apache.org/jira/browse/MESOS-5075


Repository: mesos


Description
---

Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
7b4d47bd9e99b71269093d7c11559f3b74a3e22b 

Diff: https://reviews.apache.org/r/43284/diff/


Testing
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```

This also fix similar error in 
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

(Updated April 16, 2016, 10:24 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-5075
https://issues.apache.org/jira/browse/MESOS-5075


Repository: mesos


Description
---

Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
7b4d47bd9e99b71269093d7c11559f3b74a3e22b 

Diff: https://reviews.apache.org/r/43284/diff/


Testing
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```

This also fix similar error in 
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 16, 2016, 10:24 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
1e1a36903f4377497bb72b69e4ead63675d453c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46300/
---

Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Bugs: MESOS-5075
https://issues.apache.org/jira/browse/MESOS-5075


Repository: mesos


Description
---

Wait for process:reap in CGROUPS_ROOT_PerfRollForward.


Diffs
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/46300/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45472/
---

(Updated April 16, 2016, 10:22 a.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian 
Downes, Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Add `NetClsSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45472/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45573: Add `PerfEventHandleManager`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

(Updated April 16, 2016, 10:22 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45574/
---

(Updated April 16, 2016, 10:22 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45574/diff/


Testing
---


Thanks,

haosdent huang

Review Request 46299: Ignore eventfd caused by hierarchy destruction.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46299/
---

Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Ignore eventfd caused by hierarchy destruction.


Diffs
-

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 

Diff: https://reviews.apache.org/r/46299/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45087/
---

(Updated April 16, 2016, 10:21 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Add `CpuSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45087/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated April 16, 2016, 10:22 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemorySubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated April 16, 2016, 10:21 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated April 16, 2016, 10:20 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs (updated)
-

  src/linux/cgroups.hpp 5f4010734ed9e3295dcc3a4390123e4f4ce99c16 
  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
---

(Updated April 16, 2016, 10:19 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45574/
---

(Updated April 16, 2016, 10:19 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45574/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45573: Add `PerfEventHandleManager`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

(Updated April 16, 2016, 10:17 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45472/
---

(Updated April 16, 2016, 10:17 a.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian 
Downes, Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Add `NetClsSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45472/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/
---

(Updated April 16, 2016, 10:16 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Migrate test cases for `memory` subsystem to cgroups unified isolator.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45364/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated April 16, 2016, 10:16 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs (updated)
-

  src/linux/cgroups.hpp 5f4010734ed9e3295dcc3a4390123e4f4ce99c16 
  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated April 16, 2016, 10:16 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemorySubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated April 16, 2016, 10:16 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45087/
---

(Updated April 16, 2016, 10:15 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Add `CpuSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45087/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46158/
---

(Updated April 16, 2016, 10:14 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Completed implementation of the cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46158/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 16, 2016, 10:14 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45085/
---

(Updated April 16, 2016, 10:14 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Added stubs for the cgroups unified isolator.


Diffs (updated)
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45085/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46043: Completed default implementation of `Subsystem` abstraction.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46043/
---

(Updated April 16, 2016, 10:13 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Completed default implementation of `Subsystem` abstraction.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46043/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45084/
---

(Updated April 16, 2016, 10:13 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added stubs for the `Subsystem` abstraction of cgroups unified isolator.


Diffs (updated)
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45084/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated April 16, 2016, 10:12 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description
---

Added ANY mode to futures collect mechanism.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46298: Rejected relative path agent work_dir.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129243
---



Patch looks great!

Reviews applied: [46298]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 8:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> ---
> 
> (Updated April 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rejected relative path agent work_dir.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
> 
> Diff: https://reviews.apache.org/r/46298/diff/
> 
> 
> Testing
> ---
> 
> 1. make && make check
> 2. e2e test: 
>  
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 46298: Rejected relative path agent work_dir.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/
---

Review request for mesos, Alexander Rukletsov and Jie Yu.


Bugs: MESOS-5123
https://issues.apache.org/jira/browse/MESOS-5123


Repository: mesos


Description
---

Rejected relative path agent work_dir.


Diffs
-

  src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 

Diff: https://reviews.apache.org/r/46298/diff/


Testing
---

1. make && make check
2. e2e test: 
 
```
$ ./src/mesos-slave --work_dir=aa --master=aa
The required option `--work_dir` must be absolute path.
```


Thanks,

Klaus Ma