Re: Review Request 52735: Removed TODO message for docker killing.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/
---

(Updated Oct. 24, 2016, 5:08 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Removed TODO message for docker killing.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 

Diff: https://reviews.apache.org/r/52735/diff/


Testing
---


Thanks,

Yubo Li

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/
---

(Updated Oct. 24, 2016, 5:07 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
docker and external containerizers do not need it anymore. This removed
the 'gpu/nvidia' isolator check for docker and external containerizers.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
2e722691475c84afae14009014ea70cc0fdd0e65 

Diff: https://reviews.apache.org/r/50947/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/
---

(Updated Oct. 24, 2016, 5:08 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

This added a testing case for end-to-end GPU support for docker
containerizer.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
73ae3906ff1efab1af11ba49bfe0c5a5d9d1d5a1 

Diff: https://reviews.apache.org/r/50127/diff/


Testing
---

GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j 
check


Thanks,

Yubo Li

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/
---

(Updated Oct. 24, 2016, 5 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

Added a new flag '--devices' to mesos-docker-executor, and gave its
feature to control devices exposition, isolation, and access permission.
Also, passed GPUs assignment to mesos-docker-executor.


Diffs (updated)
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
  src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 

Diff: https://reviews.apache.org/r/50125/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/
---

(Updated Oct. 24, 2016, 5 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

Assigned Nvidia GPU devices to docker container based on
GPUs allocated by Nvidia GPU allocator.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 

Diff: https://reviews.apache.org/r/50599/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/
---

(Updated Oct. 24, 2016, 4:59 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

Wrapped helper functions to 'Docker::Device' to handle data
parsing and serializing between 'Docker::Device' structure and
string.


Diffs (updated)
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e 

Diff: https://reviews.apache.org/r/50128/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/
---

(Updated Oct. 24, 2016, 4:59 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

Added control logic to allocate/deallocate GPUs to GPU-related task
when the task is started/terminated.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 

Diff: https://reviews.apache.org/r/50841/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-10-23 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/
---

(Updated Oct. 24, 2016, 4:57 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

This added 'NvidiaComponents' to docker containerizer process so that
docker containerizer process is ready to use it to allocate GPUs to task
with 'gpus' resource.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 
  src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 
  src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c 

Diff: https://reviews.apache.org/r/50123/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-23 Thread haosdent huang 


> On Oct. 24, 2016, 3:52 a.m., Jiang Yan Xu wrote:
> > I ran `sudo make check` and it seems to be fine but it'll be great if you 
> > can verify it in the "Testing Done" section. The `*Cgroups*` filter may not 
> > be sufficient as tests that depend on this include those don't have 
> > `*Cgroups*` in their names. e.g., previously 
> > `NestedMesosContainerizerTest*` broke the build for the master head when 
> > this was checked in.

Thank you, let me run a full `sudo make check`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/#review153669
---


On Oct. 22, 2016, 4:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51031/
> ---
> 
> (Updated Oct. 22, 2016, 4:18 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and 
> Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6035
> https://issues.apache.org/jira/browse/MESOS-6035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In some cases, we just want to get the children cgroups instead of
> retrieve descendant cgroups recursively. We added an argument to
> `cgroups::get` to indicate whether to retrieve cgroups recursively but
> made recursive retrieve the default behaviour. This patch fixed some
> incorrect `TEST_CGROUPS_ROOT` checks as well.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
>   src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
>   src/tests/containerizer/cgroups_tests.cpp 
> 0afaec6ae948cabf1472bf01103210d8f9809cb1 
> 
> Diff: https://reviews.apache.org/r/51031/diff/
> 
> 
> Testing
> ---
> 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-23 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/#review153669
---


Fix it, then Ship it!




I ran `sudo make check` and it seems to be fine but it'll be great if you can 
verify it in the "Testing Done" section. The `*Cgroups*` filter may not be 
sufficient as tests that depend on this include those don't have `*Cgroups*` in 
their names. e.g., previously `NestedMesosContainerizerTest*` broke the build 
for the master head when this was checked in.


src/tests/containerizer/cgroups_tests.cpp (line 426)


// Verify that we recursively retrieve the nested cgroups.



src/tests/containerizer/cgroups_tests.cpp (line 491)


// Verify that we don't recursively retrieve the nested cgroups.


- Jiang Yan Xu


On Oct. 21, 2016, 9:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51031/
> ---
> 
> (Updated Oct. 21, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and 
> Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6035
> https://issues.apache.org/jira/browse/MESOS-6035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In some cases, we just want to get the children cgroups instead of
> retrieve descendant cgroups recursively. We added an argument to
> `cgroups::get` to indicate whether to retrieve cgroups recursively but
> made recursive retrieve the default behaviour. This patch fixed some
> incorrect `TEST_CGROUPS_ROOT` checks as well.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
>   src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
>   src/tests/containerizer/cgroups_tests.cpp 
> 0afaec6ae948cabf1472bf01103210d8f9809cb1 
> 
> Diff: https://reviews.apache.org/r/51031/diff/
> 
> 
> Testing
> ---
> 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

2016-10-23 Thread Yubo Li 


> On 十月 22, 2016, 4:49 a.m., Guangya Liu wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3953-3956
> > 
> >
> > What is the use of this?

No use of that, this is copied from other test so that I'll remove that.


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review153521
---


On 十月 21, 2016, 9:12 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> ---
> 
> (Updated 十月 21, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a 
> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j 
> check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53053: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

2016-10-23 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/#review153655
---




src/slave/containerizer/mesos/utils.cpp (lines 25 - 38)


Any specific reason this change is part of this patch? We should probably 
have a separate patch for this change. Don't think it has anything to do with 
with whiteout conversion.

Also, don't think we support nested containers on anything other than linux 
at this point


- Avinash sridharan


On Oct. 23, 2016, 3:03 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53053/
> ---
> 
> (Updated Oct. 23, 2016, 3:03 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
> https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e192f86a1848b373f3aa73d29688a96375cac313 
>   src/slave/containerizer/mesos/utils.hpp 
> 178ebf3effac824e4788d7282795c18dc1cb5265 
>   src/slave/containerizer/mesos/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53053/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review153666
---



Patch looks great!

Reviews applied: [53124]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 23, 2016, 10:09 p.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 23, 2016, 10:09 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -
> 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53118: Fixed incorrect header order in `cni.cpp`.

2016-10-23 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53118/#review153665
---


Ship it!




Ship It!

- Qian Zhang


On Oct. 24, 2016, 2:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53118/
> ---
> 
> (Updated Oct. 24, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed incorrect header order in `cni.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 939142e36b926d9e4201d35dedd25e32e9f8c63c 
> 
> Diff: https://reviews.apache.org/r/53118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-23 Thread Lior Zeno 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/
---

(Updated Oct. 23, 2016, 10:09 p.m.)


Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.


Summary (updated)
-

Add documentation on Windows support


Repository: mesos


Description
---

This patch adds documentation on Windows support in Mesos.
Currently considered a WIP, published in order to receive inital feedback.


Diffs
-

  docs/home.md f47f7f9 
  docs/windows.md PRE-CREATION 

Diff: https://reviews.apache.org/r/53124/diff/


Testing
---


Thanks,

Lior Zeno

Review Request 53124: Add Windows support to Mesos documentation

2016-10-23 Thread Lior Zeno 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/
---

Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

This patch adds documentation on Windows support in Mesos.
Currently considered a WIP, published in order to receive inital feedback.


Diffs
-

  docs/home.md f47f7f9 
  docs/windows.md PRE-CREATION 

Diff: https://reviews.apache.org/r/53124/diff/


Testing
---


Thanks,

Lior Zeno

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-23 Thread James Peach 


> On Oct. 20, 2016, 4:03 a.m., James Peach wrote:
> > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 24
> > 
> >
> > Since the flags differ between platform, it might be a good idea to 
> > define stout-specific versions.
> 
> Qian Zhang wrote:
> Can you elaborate on stout-specific versions? Did you mean we define two 
> versions of setxattr() here, one for Linux and another for APPLE?
> 
> James Peach wrote:
> I meant that the flags differ across the two platforms. So the caller has 
> to know what flags are safe to pass for both. For example, the API doesn't 
> prevent you trying to pass ``XATTR_NOFOLLOW`` on Linux, which won't build. 
> I'm wondering whether stout ought to define its own versions of the flags so 
> that you can more easily write portable code using this API.
> 
> Qian Zhang wrote:
> I'd like to expose the native OS flags to caller and let the caller to 
> decides what kind of flags should be used, e.g., if caller pass 
> `XATTR_NOFOLLOW` on Linux and find it can not built, then the caller should 
> put its code under `__APPLE__`.

It is a pretty poor abstraction if the caller has to ifdef. But since that is 
not needed now AFAICT, it doesn't matter much.


> On Oct. 20, 2016, 4:03 a.m., James Peach wrote:
> > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 64
> > 
> >
> > You could use ``std::vector`` here to avoid manual memory 
> > management.
> 
> Qian Zhang wrote:
> Can you please let me know the advantage of std::vector? To me, new 
> + memset can satisfy my requirement here.
> 
> James Peach wrote:
> Dropped the issue since this is just a suggestion :)
> 
> IMHO, using vector is more robust since you get RAII behaviour and 
> don't need to explicitly delete on the error path, eg.
> 
> ```
> std::vector buffer(size);
> getxattr(path.c_str(), name.c_str(), [0], size, 0, 0);
> return std:string(buffer.begin(), buffer.size());
> 
> ```

Not sure that ``errno`` is guaranteed to be preserved across the ``delete``.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53041/#review153347
---


On Oct. 23, 2016, 3:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53041/
> ---
> 
> (Updated Oct. 23, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
> https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `setxattr()` and `getxattr()` in stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f 
>   3rdparty/stout/include/stout/os.hpp 
> 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 
>   3rdparty/stout/include/stout/os/posix/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/xattr.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 53122: Used child hooks to enter namespaces in health check.

2016-10-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53122/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
Schad, and Qian Zhang.


Bugs: MESOS-6184
https://issues.apache.org/jira/browse/MESOS-6184


Repository: mesos


Description
---

Used child hooks to enter namespaces in health check.


Diffs
-

  src/health-check/health_checker.hpp 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 

Diff: https://reviews.apache.org/r/53122/diff/


Testing
---


Thanks,

haosdent huang

Review Request 53121: Added a child hook for entering the target pid's namespaces.

2016-10-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53121/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, Joerg 
Schad, and Qian Zhang.


Bugs: MESOS-6236
https://issues.apache.org/jira/browse/MESOS-6236


Repository: mesos


Description
---

Added a child hook for entering the target pid's namespaces.


Diffs
-

  3rdparty/libprocess/include/process/subprocess_base.hpp 
1d02454d5541f96cb4928bf027fcae3764989d67 
  3rdparty/libprocess/src/subprocess.cpp 
284e22e28ae8d2c1486e4a6bea743b8663ce2023 

Diff: https://reviews.apache.org/r/53121/diff/


Testing
---


Thanks,

haosdent huang

Review Request 53119: Moved `ns.hpp` to stout [1/2].

2016-10-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53119/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and Qian 
Zhang.


Bugs: MESOS-6236
https://issues.apache.org/jira/browse/MESOS-6236


Repository: mesos


Description
---

Moved `ns.hpp` to stout [1/2].


Diffs
-

  3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f 
  3rdparty/stout/include/stout/ns.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/53119/diff/


Testing
---


Thanks,

haosdent huang

Review Request 53120: Moved `ns.hpp` to stout [2/2].

2016-10-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53120/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and Qian 
Zhang.


Bugs: MESOS-6236
https://issues.apache.org/jira/browse/MESOS-6236


Repository: mesos


Description
---

Moved `ns.hpp` to stout [2/2].


Diffs
-

  src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 
  src/linux/ns.hpp 76db0dcbc4ed90803d83b73ea2c79c9b6d6a8c4d 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
df16b8fee6799a69c7d96f33a5049bd9787c48f5 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
a1283e5ee92c916baaf9fca8ce314d597e8421b3 
  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
0d9ec57d9aa83bcc6cc2e5a8d75f2e2251179b1b 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
939142e36b926d9e4201d35dedd25e32e9f8c63c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
48202fb5bf1ede71b80760844c6d8a36ca7c700c 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
7b976d29226c3e0a4d52922e9d2f7e685de72297 
  src/slave/containerizer/mesos/launch.cpp 
377a9d94aa780ab598b1c2034c10ce25a4e02cbe 
  src/slave/containerizer/mesos/linux_launcher.cpp 
0305d14c1f791c93edcd3b32786b483b15f40a2d 
  src/tests/containerizer/isolator_tests.cpp 
8fefeef8c83ed2ab01f56a1ec572d3acb307143c 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
e6c690c411f57138207044f31b4816bd4090c1b7 
  src/tests/containerizer/ns_tests.cpp d6be1076a393f7959cd6ac225591c8b3aa66721d 
  src/tests/containerizer/port_mapping_tests.cpp 
fbdc0db9238c85d2f6eaba7d13ee5ce23342b527 
  src/tests/containerizer/setns_test_helper.cpp 
045caf684baf6e724fa5f99b6cc3feeb87817ba3 

Diff: https://reviews.apache.org/r/53120/diff/


Testing
---


Thanks,

haosdent huang

Review Request 53118: Fixed incorrect header order in `cni.cpp`.

2016-10-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53118/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, and Qian Zhang.


Repository: mesos


Description
---

Fixed incorrect header order in `cni.cpp`.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
939142e36b926d9e4201d35dedd25e32e9f8c63c 

Diff: https://reviews.apache.org/r/53118/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 53116: Removed `ProvisionerProcess::__provision()`.

2016-10-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53116/#review153658
---



Patch looks great!

Reviews applied: [53041, 53042, 53053, 53115, 53116]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 23, 2016, 3:10 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53116/
> ---
> 
> (Updated Oct. 23, 2016, 3:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
> https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed `ProvisionerProcess::__provision()`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> c5481c585f2a55bb926340290b939f98af3c2135 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> de2c12140652244bd3de9763ced203b144688ab2 
> 
> Diff: https://reviews.apache.org/r/53116/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>