Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

[Yubo Li]

> On 十一月 12, 2016, 12:26 p.m., Guangya Liu wrote:
> > Summary:
> > ```
> > Added `parse` helper function for `Docker::Device`.
> > ```
> > 
> > Description:
> > ```
> > Added a new helper function to parse a string to 'Docker::Device'
> > 'Docker::Device' structure. The string should be in the format of
> > `PathInHost:PathInContainer:Permission`.
> > ```

fixed


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review155778
---


On 十一月 10, 2016, 8:14 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> ---
> 
> (Updated 十一月 10, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to parse string input to 'Docker::Device'
> structure.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> Diff: https://reviews.apache.org/r/53532/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

[Yubo Li]

> On 十一月 12, 2016, 12:14 p.m., Guangya Liu wrote:
> > We do not have `external containerizer` now, so you can remove it from the 
> > `Descripiton`.
> > 
> > Summary
> > ```
> > Only check `gpu/nvidia` isolator for mesos containerizer.
> > ```
> > 
> > Description
> > ```
> > Mesos containerizer uses isolator `gpu/nvidia` for GPU isolation while
> > docker containerizers do not need it. This patch is making the isolator
> > `gpu/nvidia` check only available for mesos containerizer but not docker
> > containerizer in GPU allocator.
> > ```

fixed. thanks


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review155777
---


On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> ---
> 
> (Updated 十一月 10, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
> 2e722691475c84afae14009014ea70cc0fdd0e65 
> 
> Diff: https://reviews.apache.org/r/50947/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53704: Added a level of indirection for logger through IO Switchboard.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/#review155883
---



Patch looks great!

Reviews applied: [53704]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 15, 2016, 12:19 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53704/
> ---
> 
> (Updated Nov. 15, 2016, 12:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We are adding a new component to the mesos containerizer called
> IOSwitchboard. The purpose of this component is to feed stdin to a
> container from an external source, as well as redirect the
> stdin/stdout of a container to multiple targets.
> 
> The primary motivation of this component is to enable support in mesos
> similar to 'docker attach' and 'docker exec' whereby an external
> client can attach to the stdin/stdout/stderr of a running container as
> well as launch arbitrary subcommands inside a container and attach to
> its stdin/stdout/stderr.
> 
> to enable this functionatlity, we also introduce a new
> IOSwitchboardProcess in this commit (although it is not strictly
> necessary). We will be adding additional functionality that relies on
> it in subsequent commits.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 272052ddf85b50f817a110a9a83566b011598985 
>   src/slave/containerizer/mesos/containerizer.cpp 
> ec4ae32485a7ab6c9f73c512004d1220482a188e 
>   src/slave/containerizer/mesos/io_switchboard.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/io_switchboard.cpp PRE-CREATION 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> 2f21b49535856186e153cd299dd1eda11495fa17 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5aae23b1b470d5323ecc21fb5df7ad8ae2498dfa 
> 
> Diff: https://reviews.apache.org/r/53704/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 53770: CMake Cleanup: Alphabetize the list of sources.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53770/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This alphabetizes the sources by variable name, and then by filename.
A few missing files were added and some duplicate files were removed.


Diffs
-

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 

Diff: https://reviews.apache.org/r/53770/diff/


Testing
---

This being the final review in the chain, I ran the cmake build on several 
systems:

cmake ..
make check (OSX)
make check (CentOS 7)

sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7)

These have reached parity with the automake build configured with 
`--disable-java --disable-python`.


Thanks,

Joseph Wu

Review Request 53769: CMake: Added -fPIC to leveldb build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53769/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Leveldb is built statically (this is not configurable).
This supplies the `-fPIC` compiler option as well as the default
options used by leveldb (`-O2 -g`).


Diffs
-

  3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 

Diff: https://reviews.apache.org/r/53769/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53768: CMake Cleanup: Generate protobufs with fewer dependencies.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53768/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

The protobuf sub-library only actually requires the protobuf
dependencies in order to build.  Previously, it was dependent
on all of libprocess.


Diffs
-

  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 

Diff: https://reviews.apache.org/r/53768/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53767: CMake Cleanup: Rename SlaveConfigure.cmake.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53767/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Renamed to `AgentConfigure.cmake`.


Diffs
-

  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 

Diff: https://reviews.apache.org/r/53767/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53766: CMake: Added option for enabling optimization.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53766/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This mirrors the automake build, which sets -O2 by default.


Diffs
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/53766/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53765: CMake: Revised compilation configuration file.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53765/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This moves global configuration options into one place and
logically groups the various operations: by Posix, Linux, Windows,
and then "general" groups.


Diffs
-

  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/53765/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53764: CMake: Added a target for the default executor.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53764/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This executor has support for TaskGroups and will eventually take
precedence over the default command executor.


Diffs
-

  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/launcher/CMakeLists.txt 3137ea1479970c7ea46e6595536d481002fc585c 

Diff: https://reviews.apache.org/r/53764/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53763: CMake: Added binaries as dependencies for MESOS_TARGET.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53763/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This hooks up some of Mesos's companion binaries to the build chain.
Tests can now rely on the `MESOS_TARGET` to get a complete build.


Diffs
-

  src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
  src/docker/CMakeLists.txt dca15dbf0679ae196b7a993f2e782ce2907c6750 
  src/health-check/CMakeLists.txt ca577895411a13dcca27dbd67a63de831084ed37 
  src/launcher/CMakeLists.txt 3137ea1479970c7ea46e6595536d481002fc585c 
  src/local/CMakeLists.txt 643a6cf653d91b8a606ac83b126dfd2245fa49bd 
  src/log/CMakeLists.txt 8a92de4b0f9f69164930bd28c527f3a92ea0d17e 
  src/master/CMakeLists.txt d9b4c170148daf041cb68fcebbc993abcde98acf 
  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 
  src/slave/containerizer/mesos/CMakeLists.txt 
8cb3507d4d250dee4ee2f1b324ac3fe945cf23c4 
  src/slave/qos_controllers/CMakeLists.txt 
87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 
17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 
  src/usage/CMakeLists.txt e5df5e74977ae085db85e35c67dedc974832496a 

Diff: https://reviews.apache.org/r/53763/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53762: CMake: Renamed MESOS_TARGET to MESOS_LIBS_TARGET.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53762/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This purposefully excludes the dependency on `MESOS_TARGET` that
exists in `MesosTestsConfigure.cmake`, as the tests require all
of Mesos to be build first.


Diffs
-

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
  src/docker/CMakeLists.txt dca15dbf0679ae196b7a993f2e782ce2907c6750 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/health-check/CMakeLists.txt ca577895411a13dcca27dbd67a63de831084ed37 
  src/local/CMakeLists.txt 643a6cf653d91b8a606ac83b126dfd2245fa49bd 
  src/log/CMakeLists.txt 8a92de4b0f9f69164930bd28c527f3a92ea0d17e 
  src/master/CMakeLists.txt d9b4c170148daf041cb68fcebbc993abcde98acf 
  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 
  src/slave/containerizer/mesos/CMakeLists.txt 
8cb3507d4d250dee4ee2f1b324ac3fe945cf23c4 
  src/slave/qos_controllers/CMakeLists.txt 
87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 
17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 
  src/tests/cmake/MesosTestsConfigure.cmake 
3f543c010ae87ff04e6b45745bc49ef65b6590ff 
  src/usage/CMakeLists.txt e5df5e74977ae085db85e35c67dedc974832496a 

Diff: https://reviews.apache.org/r/53762/diff/


Testing
---

rm -rf build
mkdir build
cd build

cmake ..
make


Thanks,

Joseph Wu

Review Request 53760: CMake: Changed example module output location and depedencies.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53760/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This moves some test libraries from the default CMake build
output locations to `/src/.libs`, which is where
the Automake build outputs libraries.  We have a few tests
that expect modules to be located in this directory.

Additionally, this makes the test target (make check) depend
on the test modules and example frameworks, so that they are built
in the correct order.


Diffs
-

  src/examples/CMakeLists.txt PRE-CREATION 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 
  src/slave/qos_controllers/CMakeLists.txt 
87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 
17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 
  src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 

Diff: https://reviews.apache.org/r/53760/diff/


Testing
---

cmake ..
make clean
make


Thanks,

Joseph Wu

Review Request 53761: CMake: Add a target between MESOS_TARGET and MESOS_PROTOBUFs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53761/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

We need this extra level of targets in order to model the
dependency chain for binaries and libraries.  An example
is the mesos-containerizer binary, which depends on libmesos
(i.e. MESOS_TARGET) but does not get included in the dependency
chain if you only depend on MESOS_TARGET.


Diffs
-

  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 

Diff: https://reviews.apache.org/r/53761/diff/


Testing
---

See next review.


Thanks,

Joseph Wu

Review Request 53759: CMake: Change libprocess to a shared library.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53759/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

In order to load modules that are themselves based on libprocess,
we must link libprocess as a shared library.  Since modules are
only supported on non-Windows platforms, this changes the default
linking mode to SHARED on non-Windows.

This review replaces: https://reviews.apache.org/r/49924/


Diffs
-

  3rdparty/libprocess/src/CMakeLists.txt 
d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/53759/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53758: CMake: Added test sources to the build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53758/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This adds most existing tests to the CMake build.  This excludes
a few special cases, just as Java, Python, and network isolator
tests.

This review replaces: https://reviews.apache.org/r/49921/


Diffs
-

  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
  src/tests/cmake/MesosTestsConfigure.cmake 
3f543c010ae87ff04e6b45745bc49ef65b6590ff 

Diff: https://reviews.apache.org/r/53758/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53757: CMake: Moved logrotate container logger binary build definition.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53757/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This was originally included at a higher level.  Per CMake style,
build files should generally be included in the CMakeLists.txt file
located in the same directory.


Diffs
-

  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/53757/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53755: CMake: Added example frameworks and executors.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53755/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This builds some binaries that are mainly used in the example
framework tests.

This review replaces: https://reviews.apache.org/r/49870/


Diffs
-

  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/53755/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53753: CMake: Added variable for default linking strategy.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53753/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

The `MESOS_DEFAULT_LIBRARY_LINKAGE` changes all Mesos libraries to
the use specified linking strategy (static or shared).  This does
not affect third-party libraries, which have their own requirements.

On Posix, the default is shared linkage.  On Windows the default
is static linkage.

This review replaces: https://reviews.apache.org/r/49862/


Diffs
-

  3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/slave/qos_controllers/CMakeLists.txt 
87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 
17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 

Diff: https://reviews.apache.org/r/53753/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53756/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This review replaces: https://reviews.apache.org/r/49874/


Diffs
-

  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/53756/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53754/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Builds shared libraries that are dynamically loaded in the
module tests.  These are excluded on Windows, which only
supports static libraries.

This review replaces: https://reviews.apache.org/r/49863/


Diffs
-

  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/53754/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53327/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

The patch simply adds the mesos-tests target and renames the
existing `TEST_HELPER_*` definitions to `MESOS_TEST_*`.
The dependencies for the `test-helper` and the actual tests will
be identical.

This review replaces: https://reviews.apache.org/r/49688/


Diffs
-

  src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
  src/tests/cmake/MesosTestsConfigure.cmake 
3f543c010ae87ff04e6b45745bc49ef65b6590ff 

Diff: https://reviews.apache.org/r/53327/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53757: CMake: Moved logrotate container logger binary build definition.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53757/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description
---

This was originally included at a higher level.  Per CMake style,
build files should generally be included in the CMakeLists.txt file
located in the same directory.


Diffs
-

  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/53757/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53756: CMake: Added logrotate container logger module to the build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53756/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description
---

This review replaces: https://reviews.apache.org/r/49874/


Diffs
-

  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/53756/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53741: Display maintainance info in the webui.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review155882
---



Patch looks great!

Reviews applied: [53741]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 14, 2016, 9:27 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> ---
> 
> (Updated Nov. 14, 2016, 9:27 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Joseph Wu.
> 
> 
> Bugs: MESOS-6443
> https://issues.apache.org/jira/browse/MESOS-6443
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 
>   src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 
>   src/webui/master/static/js/controllers.js 
> dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 
>   src/webui/master/static/maintenance.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53741/diff/
> 
> 
> Testing
> ---
> 
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
> 
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 
> entires schedule generated with 
> [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 53755: CMake: Added example frameworks and executors.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53755/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description
---

This builds some binaries that are mainly used in the example
framework tests.

This review replaces: https://reviews.apache.org/r/49870/


Diffs
-

  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/53755/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53754/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description
---

Builds shared libraries that are dynamically loaded in the
module tests.  These are excluded on Windows, which only
supports static libraries.

This review replaces: https://reviews.apache.org/r/49863/


Diffs
-

  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/53754/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Review Request 53753: CMake: Added variable for default linking strategy.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53753/
---

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description
---

The `MESOS_DEFAULT_LIBRARY_LINKAGE` changes all Mesos libraries to
the use specified linking strategy (static or shared).  This does
not affect third-party libraries, which have their own requirements.

On Posix, the default is shared linkage.  On Windows the default
is static linkage.

This review replaces: https://reviews.apache.org/r/49862/


Diffs
-

  3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/slave/qos_controllers/CMakeLists.txt 
87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 
17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 

Diff: https://reviews.apache.org/r/53753/diff/


Testing
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53327/
---

(Updated Nov. 14, 2016, 7:03 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description (updated)
---

The patch simply adds the mesos-tests target and renames the
existing `TEST_HELPER_*` definitions to `MESOS_TEST_*`.
The dependencies for the `test-helper` and the actual tests will
be identical.

This review replaces: https://reviews.apache.org/r/49688/


Diffs (updated)
-

  src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
  src/tests/cmake/MesosTestsConfigure.cmake 
3f543c010ae87ff04e6b45745bc49ef65b6590ff 

Diff: https://reviews.apache.org/r/53327/diff/


Testing (updated)
---

cmake ..
make


Thanks,

Joseph Wu

Re: Review Request 53704: Added a level of indirection for logger through IO Switchboard.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/
---

(Updated Nov. 15, 2016, 12:19 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
---

Updated to introduce a `IOSwitchboardProcess` as part of this initial commit. 
Although not strictly necessary as part of this commit, it will be come 
necessary in subsequent commits, so it makes sense to introduce it now in 
preparation.


Summary (updated)
-

Added a level of indirection for logger through IO Switchboard.


Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description (updated)
---

We are adding a new component to the mesos containerizer called
IOSwitchboard. The purpose of this component is to feed stdin to a
container from an external source, as well as redirect the
stdin/stdout of a container to multiple targets.

The primary motivation of this component is to enable support in mesos
similar to 'docker attach' and 'docker exec' whereby an external
client can attach to the stdin/stdout/stderr of a running container as
well as launch arbitrary subcommands inside a container and attach to
its stdin/stdout/stderr.

to enable this functionatlity, we also introduce a new
IOSwitchboardProcess in this commit (although it is not strictly
necessary). We will be adding additional functionality that relies on
it in subsequent commits.


Diffs (updated)
-

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
  src/slave/containerizer/mesos/containerizer.hpp 
272052ddf85b50f817a110a9a83566b011598985 
  src/slave/containerizer/mesos/containerizer.cpp 
ec4ae32485a7ab6c9f73c512004d1220482a188e 
  src/slave/containerizer/mesos/io_switchboard.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io_switchboard.cpp PRE-CREATION 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 
2f21b49535856186e153cd299dd1eda11495fa17 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5aae23b1b470d5323ecc21fb5df7ad8ae2498dfa 

Diff: https://reviews.apache.org/r/53704/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 53645: Added '--task' into mesos-execute.

[Qian Zhang]

> On Nov. 14, 2016, 4:26 p.m., Abhishek Dasgupta wrote:
> > src/cli/execute.cpp, line 342
> > 
> >
> > Should we still continue with our old approach of creating task in 
> > mesos execute??

You can still continue with the old approach of creating task in 
`mesos-execute`, e.g., with the flag `--name`, `--command`, `--docker_image`, 
`--networks`, etc. And beyond that, we provide a new approach to creat task in 
this patch: you can just specify a json for the task that you want to create 
with the newly introduced flag `--task`. Please note, these two approaches are 
exclusive, you can only choose either of them when creating a task with 
`mesos-execute`.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53645/#review155798
---


On Nov. 11, 2016, 11:13 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53645/
> ---
> 
> (Updated Nov. 11, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6571
> https://issues.apache.org/jira/browse/MESOS-6571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--task' into mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 
> 
> Diff: https://reviews.apache.org/r/53645/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04, manually ran the command below to successfuly launch a 
> container which will be attached to a CNI network "net1".
> ```
> # sudo src/mesos-execute --master=192.168.122.216:5050 
> --task=file:///home/stack/workspace/mesos/build/task.json
> 
> # cat /home/stack/workspace/mesos/build/task.json
> {
>   "name": "test",
>   "task_id": {"value" : "test"},
>   "agent_id": {"value" : ""},
>   "resources": [
> {
>   "name": "cpus",
>   "type": "SCALAR",
>   "scalar": {
> "value": 0.1
>   },
>   "role": "*"
> },
> {
>   "name": "mem",
>   "type": "SCALAR",
>   "scalar": {
> "value": 32
>   },
>   "role": "*"
> }
>   ],
>   "command": {
> "value": "ifconfig"
>   },
>   "container": {
> "type": "MESOS",
> "mesos": {
>   "image": {
> "type": "DOCKER",
> "docker": {
>   "name": "busybox"
> }
>   }
> },
> "network_infos": [
>   {
> "name": "net1"
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53699/
---

(Updated Nov. 14, 2016, 9:51 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add test cases to test logrotate with switch_user set to true and false.


Diffs (updated)
-

  src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f 

Diff: https://reviews.apache.org/r/53699/diff/


Testing
---

Run the mesos-logrotate-logger with un-priviledged user and verify whether the 
logs are getting rotated.
Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52310/
---

(Updated Nov. 14, 2016, 9:52 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Switch the uid of the binary if a user is passed from the lib_logrotate.


Diffs (updated)
-

  src/slave/container_loggers/logrotate.cpp 
431bc3cbb54e94359078e4dae0b32ad301393640 

Diff: https://reviews.apache.org/r/52310/diff/


Testing
---

1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
the logs are getting rotated. 
2. Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52308/
---

(Updated Nov. 14, 2016, 9:52 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add variable user to handle switchUser passed from executor.


Diffs (updated)
-

  src/slave/container_loggers/logrotate.hpp 
d1db69236f5a9b1dbb3113ad02218a512afdb46b 

Diff: https://reviews.apache.org/r/52308/diff/


Testing
---

1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
the logs are getting rotated. 
2. Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53473/
---

(Updated Nov. 14, 2016, 9:52 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add new param user to logrotate's prepare function.


Diffs (updated)
-

  include/mesos/slave/container_logger.hpp 
939974736f9eb744c83036e074718d2a1eba8b0a 
  src/slave/container_loggers/lib_logrotate.hpp 
28fdf3bdcc66d473521b377f66ab0b48f6900f58 
  src/slave/container_loggers/lib_logrotate.cpp 
53698d339f0f4d2dc916b53239ca0c36bbebcd42 
  src/slave/container_loggers/logrotate.hpp 
d1db69236f5a9b1dbb3113ad02218a512afdb46b 
  src/slave/container_loggers/sandbox.hpp 
e0aeb32a9ec83af049af8a10010b819c1d8b25d8 
  src/slave/container_loggers/sandbox.cpp 
cc263ebef7e0c3e778fabafa49faa6dd315adc45 
  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
  src/slave/containerizer/mesos/containerizer.cpp 
ec4ae32485a7ab6c9f73c512004d1220482a188e 
  src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f 

Diff: https://reviews.apache.org/r/53473/diff/


Testing
---

Run the mesos-logrotate-logger with un-priviledged user and verify whether the 
logs are getting rotated.
Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Review Request 53741: Display maintainance info in the webui.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/
---

Review request for mesos, haosdent huang and Joseph Wu.


Bugs: MESOS-6443
https://issues.apache.org/jira/browse/MESOS-6443


Repository: mesos


Description
---

Create new page with Maintenance schedule. Schedule is downloaded on
page refresh. Schedule is not live like stats and tasks so there is
no need to poll it periodically.
Diable sorting when data-key is not defined in table header.


Diffs
-

  src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 
  src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 
  src/webui/master/static/js/controllers.js 
dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 
  src/webui/master/static/maintenance.html PRE-CREATION 

Diff: https://reviews.apache.org/r/53741/diff/


Testing
---

[Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)

Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 
entires schedule generated with 
[generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)


Thanks,

Tomasz Janiszewski

Re: Review Request 53695: Allows caching extractable files when outputFile is set.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53695/#review155842
---



Patch looks great!

Reviews applied: [53695]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 14, 2016, 3:02 p.m., Stephen Hankinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53695/
> ---
> 
> (Updated Nov. 14, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6587
> https://issues.apache.org/jira/browse/MESOS-6587
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows caching extractable files when outputFile is set.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
>   src/tests/fetcher_cache_tests.cpp 03e817d46194d451eceb70f4cebb54dfdcb4c2e7 
> 
> Diff: https://reviews.apache.org/r/53695/diff/
> 
> 
> Testing
> ---
> 
> A new test, FetcherCacheTest.LocalCachedExtractCustomOutputFile, was created 
> to confirm that when a URI is created with cached: true, extract: true, a 
> custom outputFile with a proper compression suffix set, and an original URI 
> that doesn't end with a proper compression suffix fails to extract properly 
> from the cache.
> 
> The test makes a copy of the test archive in the cache but appends "misc" to 
> the end, forming an invalid compression suffix, causing 
> mesos-fetcher-test-archive.tgz to become mesos-fetcher-test-archive.tgzmisc. 
> The URI path is set to this modified location. The outputFile of the URI is 
> set ARCHIVE_NAME which ends with a valid compression suffix, so therefore 
> should extract properly.
> 
> At the end of the test the temporary cached archive file 
> (mesos-fetcher-test-archive.tgzmisc) is deleted.
> 
> Before the patch was written this test was failing as expected. After 
> implementing the patch, this and all other tests were passing.
> 
> 
> Thanks,
> 
> Stephen Hankinson
> 
>

Re: Review Request 53313: Windows: Disable persistent state for Windows master.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53313/
---

(Updated Nov. 14, 2016, 7:08 p.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

Many agent tests currently use the master in some form. Of those,
relatively few use the leveldb-based persistence. Since we cannot
currently compile leveldb on Windows, and since running these tests on
Windows involves compiling and running the master, this commit will
remove the direct dependency on the replicated log for windows builds of
the master.


Diffs (updated)
-

  src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 
  src/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261 

Diff: https://reviews.apache.org/r/53313/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 53688: Implement a namespace/ipc isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53688/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6557
https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
---

Implement a namespace/ipc isolator.


Diffs (updated)
-

  src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
  src/slave/containerizer/mesos/containerizer.cpp 
ec4ae32485a7ab6c9f73c512004d1220482a188e 
  src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp PRE-CREATION 
  src/tests/containerizer/isolator_tests.cpp 
9766aaf144722b18d88f694ff37ffd53974cb60d 

Diff: https://reviews.apache.org/r/53688/diff/


Testing
---

Make check on Fedora 24.


Thanks,

James Peach

Re: Review Request 53627: Implement a namespaces/uts isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53627/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6556
https://issues.apache.org/jira/browse/MESOS-6556


Repository: mesos


Description
---

Implement a very simple namespaces/uts isolator that can be used to set
the hostname and domainname of a container without the necessity of a
CNI plugin.

Since we already had a `hostname` field in the ContainerInfo, we can
use that to set the host name once we are in the UTS namespace. Add a
corresponding `domainname` to the ContainerInfo to allow setting the
domain name.


Diffs (updated)
-

  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/slave/containerizer.proto 
2621522ae59cf9275f607679b4678ac54508993d 
  src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
  src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 
  src/slave/containerizer/mesos/containerizer.cpp 
ec4ae32485a7ab6c9f73c512004d1220482a188e 
  src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch.hpp 
155e3c5a27b8c710971ee4b508600d3b5589a2e0 
  src/slave/containerizer/mesos/launch.cpp 
320e42748adbabf09f77cb4f5951e2a7ea58fe64 
  src/tests/containerizer/isolator_tests.cpp 
9766aaf144722b18d88f694ff37ffd53974cb60d 

Diff: https://reviews.apache.org/r/53627/diff/


Testing
---

make check.


Thanks,

James Peach

Re: Review Request 53690: Add namespaces/ipc documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6557
https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
---

Add namespaces/ipc documentation.


Diffs (updated)
-

  docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 

Diff: https://reviews.apache.org/r/53690/diff/


Testing
---

Make check on Fedora 24.


Thanks,

James Peach

Re: Review Request 53626: Add net::setDomainname() helper API.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53626/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6556
https://issues.apache.org/jira/browse/MESOS-6556


Repository: mesos


Description
---

Add net::setDomainname() helper API.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/net.hpp 
39b89828d350d83bf1d4b0badcd3e63eb9d1a630 
  3rdparty/stout/include/stout/windows/net.hpp 
1bed115cb848332bf9c31e455b2d001c173face9 

Diff: https://reviews.apache.org/r/53626/diff/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 53628: Document the namespaces/uts isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53628/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6556
https://issues.apache.org/jira/browse/MESOS-6556


Repository: mesos


Description
---

Document the namespaces/uts isolator.


Diffs (updated)
-

  docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 

Diff: https://reviews.apache.org/r/53628/diff/


Testing
---

make check.


Thanks,

James Peach

Re: Review Request 53689: Use a common fixture for the PID namespace test.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53689/
---

(Updated Nov. 14, 2016, 6:51 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6557
https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
---

Use a common fixture for the PID namespace test.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
9766aaf144722b18d88f694ff37ffd53974cb60d 

Diff: https://reviews.apache.org/r/53689/diff/


Testing
---

Make check in Fedora 24.


Thanks,

James Peach

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52308/
---

(Updated Nov. 14, 2016, 3:46 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add variable user to handle switchUser passed from executor.


Diffs (updated)
-

  src/slave/container_loggers/logrotate.hpp 
d1db69236f5a9b1dbb3113ad02218a512afdb46b 

Diff: https://reviews.apache.org/r/52308/diff/


Testing
---

1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
the logs are getting rotated. 
2. Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52310/
---

(Updated Nov. 14, 2016, 3:46 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Switch the uid of the binary if a user is passed from the lib_logrotate.


Diffs (updated)
-

  src/slave/container_loggers/logrotate.cpp 
431bc3cbb54e94359078e4dae0b32ad301393640 

Diff: https://reviews.apache.org/r/52310/diff/


Testing
---

1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
the logs are getting rotated. 
2. Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53473/
---

(Updated Nov. 14, 2016, 3:43 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add new param user to logrotate's prepare function.


Diffs (updated)
-

  include/mesos/slave/container_logger.hpp 
939974736f9eb744c83036e074718d2a1eba8b0a 
  src/slave/container_loggers/lib_logrotate.hpp 
28fdf3bdcc66d473521b377f66ab0b48f6900f58 
  src/slave/container_loggers/lib_logrotate.cpp 
53698d339f0f4d2dc916b53239ca0c36bbebcd42 
  src/slave/container_loggers/logrotate.hpp 
d1db69236f5a9b1dbb3113ad02218a512afdb46b 
  src/slave/container_loggers/sandbox.hpp 
e0aeb32a9ec83af049af8a10010b819c1d8b25d8 
  src/slave/container_loggers/sandbox.cpp 
cc263ebef7e0c3e778fabafa49faa6dd315adc45 
  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
  src/slave/containerizer/mesos/containerizer.cpp 
ec4ae32485a7ab6c9f73c512004d1220482a188e 
  src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f 

Diff: https://reviews.apache.org/r/53473/diff/


Testing
---

Run the mesos-logrotate-logger with un-priviledged user and verify whether the 
logs are getting rotated.
Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

[Sivaram Kannan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53699/
---

Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add test cases to test logrotate with switch_user set to true and false.


Diffs
-

  src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f 

Diff: https://reviews.apache.org/r/53699/diff/


Testing
---

Run the mesos-logrotate-logger with un-priviledged user and verify whether the 
logs are getting rotated.
Run the mesos-logrotate-logger as root user and verify whether the logs are 
getting rotated.


Thanks,

Sivaram Kannan

Review Request 53695: Allows caching extractable files when outputFile is set.

[Stephen Hankinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53695/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6587
https://issues.apache.org/jira/browse/MESOS-6587


Repository: mesos


Description
---

Allows caching extractable files when outputFile is set.


Diffs
-

  src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
  src/tests/fetcher_cache_tests.cpp 03e817d46194d451eceb70f4cebb54dfdcb4c2e7 

Diff: https://reviews.apache.org/r/53695/diff/


Testing
---

A new test, FetcherCacheTest.LocalCachedExtractCustomOutputFile, was created to 
confirm that when a URI is created with cached: true, extract: true, a custom 
outputFile with a proper compression suffix set, and an original URI that 
doesn't end with a proper compression suffix fails to extract properly from the 
cache.

The test makes a copy of the test archive in the cache but appends "misc" to 
the end, forming an invalid compression suffix, causing 
mesos-fetcher-test-archive.tgz to become mesos-fetcher-test-archive.tgzmisc. 
The URI path is set to this modified location. The outputFile of the URI is set 
ARCHIVE_NAME which ends with a valid compression suffix, so therefore should 
extract properly.

At the end of the test the temporary cached archive file 
(mesos-fetcher-test-archive.tgzmisc) is deleted.

Before the patch was written this test was failing as expected. After 
implementing the patch, this and all other tests were passing.


Thanks,

Stephen Hankinson

Re: Review Request 53693: Added Stephen Hankinson to contributors list.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53693/#review155809
---


Ship it!




Ship It!

- Alexander Rukletsov


On Nov. 12, 2016, 10:36 p.m., Stephen Hankinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53693/
> ---
> 
> (Updated Nov. 12, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Stephen Hankinson to contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml c1e720eda052af55abf3ee58cacc4ee68b65d7d4 
> 
> Diff: https://reviews.apache.org/r/53693/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen Hankinson
> 
>

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52873/#review155802
---



Bad patch!

Reviews applied: [52873, 52872, 52871, 52870, 52869, 52868, 52867, 52866, 
52865, 52864, 52863]

Failed command: ./support/apply-review.sh -n -r 52865

Error:
2016-11-14 11:40:38 URL:https://reviews.apache.org/r/52865/diff/raw/ 
[5015/5015] -> "52865.patch" [1]
error: patch failed: src/health-check/health_checker.cpp:231
error: src/health-check/health_checker.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/16066/console

- Mesos ReviewBot


On Nov. 14, 2016, 10:30 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52873/
> ---
> 
> (Updated Nov. 14, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp 
> e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52873/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52870/
---

(Updated Nov. 14, 2016, 10:36 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Summary (updated)
-

Ensured docker executor stops health checking terminated tasks.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 

Diff: https://reviews.apache.org/r/52870/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/
---

(Updated Nov. 14, 2016, 10:35 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Summary (updated)
-

Ensured command executor stops health checking terminated tasks.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52869/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52866/
---

(Updated Nov. 14, 2016, 10:35 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description (updated)
---

To facilitate code reuse, HealthChecker::reschedule() is generalized.
This will become even more valuable when we add pause/resume functions.


Diffs
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52866/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52872: Used callback instead of `send()` for health status updates.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52872/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and 
haosdent huang.


Bugs: MESOS-6395
https://issues.apache.org/jira/browse/MESOS-6395


Repository: mesos


Description
---

Since HealthChecker is now used as a library only and does not live
in a separate OS process, there is no need to use libprocess message
sending for health status updates; a callback will do.


Diffs (updated)
-

  src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 
  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 
  src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 
  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52872/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52870/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates become
irrelevant and should be ignored. Now it is safe to start health
checks even if the task has been asked to terminate.


Diffs (updated)
-

  src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 

Diff: https://reviews.apache.org/r/52870/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52873/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52873/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates
become irrelevant and should be ignored.


Diffs (updated)
-

  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52869/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52871/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and 
haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates become
irrelevant and should be ignored. Now it is safe to start health
checks even if the task has been asked to terminate. Also if the
default executor shuts down, we can safely pause all health checkers.


Diffs (updated)
-

  src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 

Diff: https://reviews.apache.org/r/52871/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52868/
---

(Updated Nov. 14, 2016, 10:29 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52868/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Nov. 14, 2016, 10:28 a.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs (updated)
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52866/
---

(Updated Nov. 14, 2016, 10:28 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52866/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52865/
---

(Updated Nov. 14, 2016, 10:27 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and 
haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

Prior to this patch, HealthChecker would stop performing health
checks after it marks the task for kill. Since tasks' lifecycle
is managed by scheduler-executor, HealthChecker should never stop
health checking on its own.


Diffs (updated)
-

  src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 
  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 
  src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 
  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52865/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52864/
---

(Updated Nov. 14, 2016, 10:24 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description
---

After we have refactored the HealthChecker into a library from the
binary, there is no more need to wait before failing the promise to
ensure the message has been sent to the executor. HealthChecker
lifetime is managed by an executor, hence it is their responsibility
not to clean the instance until after the message with the `kill_task`
flag is received.


Diffs (updated)
-

  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52864/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52863: Refactored HealthCheck validation for clarity.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52863/
---

(Updated Nov. 14, 2016, 10:23 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52863/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 53704: Added level of indirection for logger through IO Switchboard.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/#review155800
---



Patch looks great!

Reviews applied: [53704]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 14, 2016, 4:59 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53704/
> ---
> 
> (Updated Nov. 14, 2016, 4:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We are adding a new component to the mesos containerizer called
> IOSwitchboard. The purpose of this component is to feed stdin to a
> container from an extrenal source, as well as redirect the
> stdin/stdout of a container to multiple targets.
> 
> The primary motivation of this component is to enable support in mesos
> similar to 'docker attach' and 'docker exec' whereby an external
> client can attach to the stdin/stdout/stderr or a running container as
> well as launch arbitrary subcommands inside a container and attach to
> its stdin/stdout/stderr.
> 
> We will be adding this additional functionality in subsequent commits.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 272052ddf85b50f817a110a9a83566b011598985 
>   src/slave/containerizer/mesos/containerizer.cpp 
> ec4ae32485a7ab6c9f73c512004d1220482a188e 
>   src/slave/containerizer/mesos/io_switchboard.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/io_switchboard.cpp PRE-CREATION 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> 2f21b49535856186e153cd299dd1eda11495fa17 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5aae23b1b470d5323ecc21fb5df7ad8ae2498dfa 
> 
> Diff: https://reviews.apache.org/r/53704/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 53645: Added '--task' into mesos-execute.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53645/#review155798
---




src/cli/execute.cpp (line 342)


Should we still continue with our old approach of creating task in mesos 
execute??


- Abhishek Dasgupta


On Nov. 11, 2016, 3:13 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53645/
> ---
> 
> (Updated Nov. 11, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6571
> https://issues.apache.org/jira/browse/MESOS-6571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--task' into mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 
> 
> Diff: https://reviews.apache.org/r/53645/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04, manually ran the command below to successfuly launch a 
> container which will be attached to a CNI network "net1".
> ```
> # sudo src/mesos-execute --master=192.168.122.216:5050 
> --task=file:///home/stack/workspace/mesos/build/task.json
> 
> # cat /home/stack/workspace/mesos/build/task.json
> {
>   "name": "test",
>   "task_id": {"value" : "test"},
>   "agent_id": {"value" : ""},
>   "resources": [
> {
>   "name": "cpus",
>   "type": "SCALAR",
>   "scalar": {
> "value": 0.1
>   },
>   "role": "*"
> },
> {
>   "name": "mem",
>   "type": "SCALAR",
>   "scalar": {
> "value": 32
>   },
>   "role": "*"
> }
>   ],
>   "command": {
> "value": "ifconfig"
>   },
>   "container": {
> "type": "MESOS",
> "mesos": {
>   "image": {
> "type": "DOCKER",
> "docker": {
>   "name": "busybox"
> }
>   }
> },
> "network_infos": [
>   {
> "name": "net1"
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 53604: Added SeccompInfo protobuf message.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/
---

(Updated Nov. 14, 2016, 8:09 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebase


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added SeccompInfo protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/slave/containerizer.proto 
2621522ae59cf9275f607679b4678ac54508993d 

Diff: https://reviews.apache.org/r/53604/diff/


Testing
---


Thanks,

Jay Guo