Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57964/#review172745
---



Patch looks great!

Reviews applied: [57963, 57964]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 22, 2017, 10 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57964/
> ---
> 
> (Updated April 22, 2017, 10 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7186
> https://issues.apache.org/jira/browse/MESOS-7186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to verify metrics when shared resources are present.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 
> 
> 
> Diff: https://reviews.apache.org/r/57964/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 58646: Fixed a style issue in v1 mesos.proto.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58646/#review172742
---



Patch looks great!

Reviews applied: [58641, 58642, 58643, 58644, 58645, 58646]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 22, 2017, 2:49 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58646/
> ---
> 
> (Updated April 22, 2017, 2:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4263
> https://issues.apache.org/jira/browse/MESOS-4263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a style issue in v1 mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 
> 
> 
> Diff: https://reviews.apache.org/r/58646/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57534/#review172739
---


Ship it!




Ship It!

- Anindya Sinha


On March 28, 2017, 8:24 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57534/
> ---
> 
> (Updated March 28, 2017, 8:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Greg 
> Mann.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added and implemented RegisterAgent ACL.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> ae10027eb716d4dcdeddf924223bcd4faed36de9 
>   include/mesos/authorizer/authorizer.proto 
> 736f76d552956f2351ffd40fc51d088dff83f8c8 
>   src/authorizer/local/authorizer.cpp 
> 1c1f912794cfe61112a0e513b217ba3a755f35f1 
>   src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d 
> 
> 
> Diff: https://reviews.apache.org/r/57534/diff/7/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57731/#review172738
---


Ship it!




Ship It!

- Anindya Sinha


On March 17, 2017, 3:55 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57731/
> ---
> 
> (Updated March 17, 2017, 3:55 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Vinod Kone.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - `MasterAuthorizationTest.PendingExecutorInfoDiffersOnDifferentSlaves`
>   used to assume the mock authorizer is only called for tasks
>   authorization but with the new `regsiter_agents` ACL this is no
>   longer true.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> 1a0285a3f345ef21a8256d4123d8bb684f538da4 
> 
> 
> Diff: https://reviews.apache.org/r/57731/diff/4/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57964/
---

(Updated April 22, 2017, 5 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Addressed review comments.


Bugs: MESOS-7186
https://issues.apache.org/jira/browse/MESOS-7186


Repository: mesos


Description
---

Added a test to verify metrics when shared resources are present.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 


Diff: https://reviews.apache.org/r/57964/diff/3/

Changes: https://reviews.apache.org/r/57964/diff/2-3/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

[Anindya Sinha]

> On April 21, 2017, 10:06 p.m., Jiang Yan Xu wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 1174-1175 (patched)
> > 
> >
> > The comment doesn't seem right?

Yes, ofcourse. Copy and paste issue. Fixed now.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57964/#review172689
---


On April 22, 2017, 5 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57964/
> ---
> 
> (Updated April 22, 2017, 5 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7186
> https://issues.apache.org/jira/browse/MESOS-7186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to verify metrics when shared resources are present.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 
> 
> 
> Diff: https://reviews.apache.org/r/57964/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57963/
---

(Updated April 22, 2017, 5 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Addressed review comments.


Bugs: MESOS-7186
https://issues.apache.org/jira/browse/MESOS-7186


Repository: mesos


Description
---

The following metrics take the shared counts of shared resources into
account in determination of the actual amount of used resources:
a) `master/_used`
b) `master/_revocable_used`
c) `slave/_used`
d) `slave/_revocable_used`


Diffs (updated)
-

  src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 
  src/slave/slave.cpp 4ff522e75bc8de34fe2e7720bdd8ce3d32cbf803 


Diff: https://reviews.apache.org/r/57963/diff/3/

Changes: https://reviews.apache.org/r/57963/diff/2-3/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58640/#review172735
---



Patch looks great!

Reviews applied: [58640]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 22, 2017, 1:56 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58640/
> ---
> 
> (Updated April 22, 2017, 1:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7280
> https://issues.apache.org/jira/browse/MESOS-7280
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created a non-empty file 'abc' under the agent's work directory, which
> is linked by the symlink '/xyz' in the 2nd layer of the testing image.
> This file should not be overwritten by the empty file '/xyz' in the 3rd
> layer. Please see the following link for more details:
>   https://hub.docker.com/r/chhsiao/overwrite/
> The testing image is updated in a way that it is compatible to the
> previous Overwrite test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c26e1f9b093fda66f14e474006d8148c0b9f3245 
> 
> 
> Diff: https://reviews.apache.org/r/58640/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make test
> Manually tested on commit bc12a58 to make sure that the 'abc' becomes empty 
> in the unpatched copy backend.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>