Re: Review Request 68068: Added tests for task metadata GC using the default executor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206576
---



PASS: Mesos patch 68068 was successfully built and tested.

Reviews applied: `['68065', '68066', '68067', '68095', '68068']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1998/mesos-review-68068

- Mesos Reviewbot Windows


On July 26, 2018, 7:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> ---
> 
> (Updated July 26, 2018, 7:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds two tests that launch a long-lived and short-lived task
> on the same executor.  The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
> 
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
> 
> One existing test is modified due to the extra GC event from
> task metadata.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
>   src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e 
> 
> 
> Diff: https://reviews.apache.org/r/68068/diff/2/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> (Other platforms pending...)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 68054: Added networking statistics to cni isolator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review206569
---



PASS: Mesos patch 68054 was successfully built and tested.

Reviews applied: `['68052', '68053', '68054']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1997/mesos-review-68054

- Mesos Reviewbot Windows


On July 27, 2018, 11:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68054/
> ---
> 
> (Updated July 27, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On receiving a request for getting `usage` for a given container
> the `network/cni` isolator uses getifaddrs(3) glibc function. The
> function returns basic networking metrics for each networking
> interface in the container networking namespace. It should work
> right out of the box on all modern Linux-based systems.
> 
> To get more networking metrics please use Netlink Protocol Library.
> However, you will have to open NETLINK sockets in each networking
> namespace and manage them from the `network/cni` isolator.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 31ec4ddb1049b7259b0784e5e40b002e29f6a8da 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 90d2d4103c8136d2dd883318acc135f7efca80d8 
> 
> 
> Diff: https://reviews.apache.org/r/68054/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68092: CMake: Always build gRPC in Mesos.

[Joseph Wu]

> On July 27, 2018, 2:08 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos binaries failed to build.
> > 
> > Reviews applied: `['68091', '68074', '68092']`
> > 
> > Failed command: `cmake.exe --build . --config Release -- /maxcpucount`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092
> > 
> > Relevant logs:
> > 
> > - 
> > [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092/logs/mesos-binaries-cmake-stdout.log):
> > 
> > ```
> >  
> > d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
> >  warning C4200: nonstandard extension used: zero-sized array in 
> > struct/union 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  
> > d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
> >  warning C4244: 'initializing': conversion from 'double' to 'int', possible 
> > loss of data 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  
> > d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
> >  warning C4200: nonstandard extension used: zero-sized array in 
> > struct/union 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  server_posix.obj : warning LNK4221: This object file does not 
> > define any previously undefined public symbols, so it will not be used by 
> > any link operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  rpc_method.obj : warning LNK4221: This object file does not define 
> > any previously undefined public symbols, so it will not be used by any link 
> > operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  create_channel_posix.obj : warning LNK4221: This object file does 
> > not define any previously undefined public symbols, so it will not be used 
> > by any link operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  server_posix.obj : warning LNK4221: This object file does not 
> > define any previously undefined public symbols, so it will not be used by 
> > any link operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  rpc_method.obj : warning LNK4221: This object file does not define 
> > any previously undefined public symbols, so it will not be used by any link 
> > operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >  create_channel_posix.obj : warning LNK4221: This object file does 
> > not define any previously undefined public symbols, so it will not be used 
> > by any link operation that consumes this library 
> > [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
> >
> > "D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj"
> >  (default target) (4) ->
> >"D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default 
> > target) (28) ->
> >(ClCompile target) -> 
> >  d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): 
> > warning C4722: '__Exit::~__Exit': destructor never returns, potential 
> > memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
> >  d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): 
> > warning C4722: '__Exit::~__Exit': destructor never returns, potential 
> > memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
> >
> > "D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj"
> >  (default target) (4) ->
> >"D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (22) ->
> >(CustomBuild target) -> 
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 1. 
> > 

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

[Joseph Wu]

> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > I'd prefer to split this patch into two, one for adding the new flag and 
> > updating the related docs, and another for updating the containerizer's 
> > code.

The containerizer code changes have been moved into: 
https://reviews.apache.org/r/68095/


> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > src/slave/flags.hpp
> > Lines 92 (patched)
> > 
> >
> > We also need to add this flag into `Http::STATE_HELP()` and a couple of 
> > docs, e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` 
> > and `CHANGELOG`.

Good idea.  I've updated the review with changes to all those.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
---


On July 27, 2018, 5:22 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> ---
> 
> (Updated July 27, 2018, 5:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
> 
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb 
>   docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 
>   docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
>   docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
>   docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
>   src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/3/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 68054: Added networking statistics to cni isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review206564
---



Havent finish reviewing the test yet. Will resume next week.


src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1506-1507 (patched)


No need for this temp variable



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1515 (patched)


Instead of passing in container network struct, i'd suggest we just pass in 
ifName:
```
Try NetworkCniIsolatorProcess::_usage(
const hashmap ifNames)
```


- Jie Yu


On July 27, 2018, 11:36 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68054/
> ---
> 
> (Updated July 27, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On receiving a request for getting `usage` for a given container
> the `network/cni` isolator uses getifaddrs(3) glibc function. The
> function returns basic networking metrics for each networking
> interface in the container networking namespace. It should work
> right out of the box on all modern Linux-based systems.
> 
> To get more networking metrics please use Netlink Protocol Library.
> However, you will have to open NETLINK sockets in each networking
> namespace and manage them from the `network/cni` isolator.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 31ec4ddb1049b7259b0784e5e40b002e29f6a8da 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 90d2d4103c8136d2dd883318acc135f7efca80d8 
> 
> 
> Diff: https://reviews.apache.org/r/68054/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68095/
---

Review request for mesos, Gilbert Song and Qian Zhang.


Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947


Repository: mesos


Description
---

When the --gc_non_executor_container_sandboxes agent flag is enabled,
this commit changes the MesosContainerizer to schedule nested container
sandboxes for garbage collection.  The GC policy is the same between
the MesosContainerizer and the Agent.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
7711d463c8ed92e2580c56e88d7f372c6dfaeb2b 
  src/slave/containerizer/mesos/containerizer.cpp 
98129d006cda9b65804b518619b6addc8990410a 


Diff: https://reviews.apache.org/r/68095/diff/1/


Testing
---

See last patch in chain.


Thanks,

Joseph Wu

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/
---

(Updated July 27, 2018, 5:22 p.m.)


Review request for mesos, Gilbert Song and Qian Zhang.


Changes
---

Changed this review to be mostly documentation.


Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947


Repository: mesos


Description (updated)
---

This adds an agent flag which enables garbage collection of finished
nested container sandboxes.

This also updates some documentation and recommends enabling this flag
when the user uses the same default executor to launch multiple tasks.


Diffs (updated)
-

  CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb 
  docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 
  docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
  docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
  docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43 
  src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
  src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 


Diff: https://reviews.apache.org/r/68067/diff/2/

Changes: https://reviews.apache.org/r/68067/diff/1-2/


Testing
---

See last patch in chain.


Thanks,

Joseph Wu

Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/#review206563
---



PASS: Mesos patch 68094 was successfully built and tested.

Reviews applied: `['67751', '68093', '68094']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1996/mesos-review-68094

- Mesos Reviewbot Windows


On July 27, 2018, 7:11 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68094/
> ---
> 
> (Updated July 27, 2018, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8993 and MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8993
> https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds the relevant options and source files, but with a fatal
> message if they're used, as we do not yet check for their
> dependencies. This also adds the `mesos-network-helper` executable as
> used by the port mapping isolator.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/slave/containerizer/mesos/CMakeLists.txt 
> ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8 
>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68094/diff/4/
> 
> 
> Testing
> ---
> 
> Pending... There isn't much to test for the isolators added, as they're added 
> with a fatal bailout. Double-checking that without enabling the new options, 
> everything still works as expected.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68053: Call any function in a specified namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68053/#review206562
---



I was chatting with Sergey offline on this. Record the findings here for 
posterity:

TL;DR: calling `Future::await()` in looper thread might cause the looper thread 
to be donated to a libprocess Process. If that Process is very busy (e.g., 
master or agent Process), it's possible that the looper thread will never 
re-gain control.

In this particular case, the namespce setting requests might never be fulfilled 
if the looper thread is donated to a busy Process.

This is why this could have happened:
1) `Future::await()` is called
2) Since future is not ready, `latch->await()` will be called.
3) `Latch` will create a new libprocess Process and call `process::wait` on the 
created Process 
(https://github.com/apache/mesos/blob/1.6.0/3rdparty/libprocess/src/process.cpp#L3165)
4) The current thread will be donated to a Process since it has nothing to do 
(https://github.com/apache/mesos/blob/1.6.0/3rdparty/libprocess/src/process.cpp#L3206)
5) If the Process to be resumed on the looper thread is a super busy thread, 
meaning that the message queue is never empty, the looper thread won't get a 
chance to execute its tasks on its stack.

- Jie Yu


On July 27, 2018, 8:35 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68053/
> ---
> 
> (Updated July 27, 2018, 8:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The NamespaceRunner runs any function in a specified namespace. To do
> that it manages a separate thread which would be re-associated with
> that namespace.
> 
> 
> Diffs
> -
> 
>   src/linux/ns.hpp 0b4136bd3cc2d3e0cfee163d89469558e699b5f2 
>   src/tests/containerizer/ns_tests.cpp 
> fa4349e29b975550e05b00a1f848a24cd8e4f0de 
> 
> 
> Diff: https://reviews.apache.org/r/68053/diff/3/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="NsTest*" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68054: Added networking statistics to cni isolator.

[Sergey Urbanovich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/
---

(Updated July 27, 2018, 11:36 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Fixed code style.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

On receiving a request for getting `usage` for a given container
the `network/cni` isolator uses getifaddrs(3) glibc function. The
function returns basic networking metrics for each networking
interface in the container networking namespace. It should work
right out of the box on all modern Linux-based systems.

To get more networking metrics please use Netlink Protocol Library.
However, you will have to open NETLINK sockets in each networking
namespace and manage them from the `network/cni` isolator.

JIRA: https://issues.apache.org/jira/browse/MESOS-5647


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
31ec4ddb1049b7259b0784e5e40b002e29f6a8da 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
f46c962d8f044092aaa113fafc536c6b25bab45c 
  src/tests/containerizer/cni_isolator_tests.cpp 
90d2d4103c8136d2dd883318acc135f7efca80d8 


Diff: https://reviews.apache.org/r/68054/diff/2/

Changes: https://reviews.apache.org/r/68054/diff/1-2/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68090: Added log_auto_compact flag to the master.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68090/#review206560
---



PASS: Mesos patch 68090 was successfully built and tested.

Reviews applied: `['68089', '68090']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1995/mesos-review-68090

- Mesos Reviewbot Windows


On July 27, 2018, 8:12 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68090/
> ---
> 
> (Updated July 27, 2018, 8:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-184
> https://issues.apache.org/jira/browse/MESOS-184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new flag enables experimental automatic compaction invocation for
> the LevelDB based replicated log storage. This is a workaround the
> problem described in for MESOS-184.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 3929c297b45e1203e5b00454e88f86988a8b1058 
>   src/master/flags.cpp 8fede0d2cf2254f34134329885f47c3c78dc5846 
>   src/master/main.cpp 2c7b1bb492a0655dec9280e98ff942a15e2ae8f0 
> 
> 
> Diff: https://reviews.apache.org/r/68090/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `make check`. Manually verified that the replicated log storage doesn't 
> grow over time with `--log_auto_compact=true`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 67916: Patched Google Test with upstream bugfix.

[Andrew Schwartzmeyer]

> On July 23, 2018, 12:35 a.m., Benjamin Bannier wrote:
> > > It is not yet known if the Autotools system will also need this patch. Do 
> > > we want it added there anyway?
> > 
> > I'd vote for enabling this on all platforms to simplify the build setup.

Ah, but that doesn't simplify it, it complicates it :P (I've never added a 
patch to Autotools).


> On July 23, 2018, 12:35 a.m., Benjamin Bannier wrote:
> > 3rdparty/googletest-release-1.8.0.patch
> > Lines 1 (patched)
> > 
> >
> > This patch has landed upstream so let's just use the patch from 
> > upstream `f66ab00704cd47e4e63ef6d425ca14b9192aaebb` instead of referencing 
> > a PR. If we do that we should also update our commit message.
> > 
> > `f66ab00704c` applied cleanly with some fuzziness for me, so if 
> > possible just use the actual upstream patch.

I believe that I did cherry-pick the merged upstream patch. This diff was 
generated from the cherry-picked commit, which is why the hash is not 
`f66ab00704cd47e4e63ef6d425ca14b9192aaebb`.


> On July 23, 2018, 12:35 a.m., Benjamin Bannier wrote:
> > 3rdparty/googletest-release-1.8.0.patch
> > Lines 1-10 (patched)
> > 
> >
> > Thanks for including the git metadata with the patch! This is much 
> > easier to maintain than bare diffs we have in many other patches.

The commit hash isn't useful since it was a cherry-pick, but the message I 
thought was nice to have :) I think I just generated with `git format-patch`... 
how else do people generate patches?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67916/#review206332
---


On July 13, 2018, 2:04 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67916/
> ---
> 
> (Updated July 13, 2018, 2:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8990
> https://issues.apache.org/jira/browse/MESOS-8990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per MESOS-8990, our Google Test dependency needs a patch from
> upstream, https://github.com/google/googletest/pull/1620, in order to
> continue building with the next version of MSVC (and potentially other
> compilers).
> 
> This patch file was generated by cherry-picking `f66ab00` from
> `master` onto `release-1.8.0` in the Google Test repo, and resolving
> the merge conflict.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f 
>   3rdparty/googletest-release-1.8.0.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67916/diff/1/
> 
> 
> Testing
> ---
> 
> Clean build on Windows using CMake (which is the only place this patch 
> currently applies). It is not yet known if the Autotools system will also 
> need this patch. Do we want it added there anyway?
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67751: Add missing files to CMake build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
---

(Updated July 27, 2018, 3:26 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
Joseph Wu.


Changes
---

Fix to not break on Windows.


Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994


Repository: mesos


Description (updated)
---

This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set and not on Windows, and
fixes some ordering oddities.


Diffs (updated)
-

  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9 
  src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427 
  src/python/executor/CMakeLists.txt PRE-CREATION 
  src/python/scheduler/CMakeLists.txt PRE-CREATION 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/67751/diff/3/

Changes: https://reviews.apache.org/r/67751/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68053: Call any function in a specified namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68053/#review206558
---




src/linux/ns.hpp
Lines 201 (patched)


period at the end of a comment. see style guide. Fix all occurances.



src/linux/ns.hpp
Lines 227-228 (patched)


can we do the following?
```
promise->set(func());
```



src/linux/ns.hpp
Lines 243 (patched)


I think there's a race here. It's possible that some one is deleting 
`NamespaceRunner`. It triggers the destructor `~NamespaceRunner` first. 
Assuming there T1 is the thread that's doing the `delete`, and T2 is the looper 
thread.

```
[T2] while (queue). Enter the loop body
[T1] queue.reset() in ~NamespaceRunner
[T2] queue->get() segfault
```



src/tests/containerizer/ns_tests.cpp
Line 268 (original), 268 (patched)


nits: 2 lines apart according to mesos style guide



src/tests/containerizer/ns_tests.cpp
Lines 274 (patched)


nits: period at the end of each comment according to style guide



src/tests/containerizer/ns_tests.cpp
Lines 277 (patched)


Ditto on period.



src/tests/containerizer/ns_tests.cpp
Lines 286 (patched)


Ditto on period.


- Jie Yu


On July 27, 2018, 8:35 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68053/
> ---
> 
> (Updated July 27, 2018, 8:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The NamespaceRunner runs any function in a specified namespace. To do
> that it manages a separate thread which would be re-associated with
> that namespace.
> 
> 
> Diffs
> -
> 
>   src/linux/ns.hpp 0b4136bd3cc2d3e0cfee163d89469558e699b5f2 
>   src/tests/containerizer/ns_tests.cpp 
> fa4349e29b975550e05b00a1f848a24cd8e4f0de 
> 
> 
> Diff: https://reviews.apache.org/r/68053/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose --gtest_filter="NsTest*" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/#review206557
---



FAIL: Mesos binaries failed to build.

Reviews applied: `['67751', '68093', '68094']`

Failed command: `cmake.exe --build . --config Release -- /maxcpucount`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1992/mesos-review-68094

Relevant logs:

- 
[mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1992/mesos-review-68094/logs/mesos-binaries-cmake-stdout.log):

```
   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   
"D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj" 
(default target) (46) ->
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj" (default target) 
(39) ->
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\launcher\mesos-fetcher.vcxproj" (default target) (40) 
->
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\src\launcher\mesos-fetcher.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (36) ->
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\src\slave\mesos-agent.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\cli\mesos-cli.vcxproj" (default target) (34) ->
   (ClCompile target) -> 
 d:\dcos\mesos\mesos\src\cli\mesos.cpp(17): fatal error C1083: Cannot 
open include file: 'unistd.h': No such file or directory 
[D:\DCOS\mesos\src\cli\mesos-cli.vcxproj]

411 Warning(s)
1 Error(s)

Time Elapsed 00:27:20.70
```

- Mesos Reviewbot Windows


On July 27, 2018, 7:11 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68094/
> ---
> 
> (Updated July 27, 2018, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8993 and MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8993
> https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds the relevant options, but with a fatal message if they're
> used, as we do not yet check for their dependency. This also adds the
> `mesos-network-helper` executable as used by the port mapping
> isolator.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/slave/containerizer/mesos/CMakeLists.txt 
> ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8 
>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68094/diff/1/
> 
> 
> Testing
> ---
> 
> Pending... There isn't much to test for the isolators added, as they're added 
> with a fatal bailout. Double-checking that without enabling the new options, 
> everything still works as expected.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68068: Added tests for task metadata GC using the default executor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206556
---



PASS: Mesos patch 68068 was successfully built and tested.

Reviews applied: `['68065', '68066', '68067', '68068']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1994/mesos-review-68068

- Mesos Reviewbot Windows


On July 26, 2018, 7:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> ---
> 
> (Updated July 26, 2018, 7:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds two tests that launch a long-lived and short-lived task
> on the same executor.  The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
> 
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
> 
> One existing test is modified due to the extra GC event from
> task metadata.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
>   src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e 
> 
> 
> Diff: https://reviews.apache.org/r/68068/diff/2/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> (Other platforms pending...)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 68092: CMake: Always build gRPC in Mesos.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68092/#review206555
---



FAIL: Mesos binaries failed to build.

Reviews applied: `['68091', '68074', '68092']`

Failed command: `cmake.exe --build . --config Release -- /maxcpucount`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092

Relevant logs:

- 
[mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092/logs/mesos-binaries-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file does not 
define any previously undefined public symbols, so it will not be used by any 
link operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file does not 
define any previously undefined public symbols, so it will not be used by any 
link operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   
"D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj" 
(default target) (4) ->
   "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) 
(28) ->
   (ClCompile target) -> 
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
 d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning 
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak 
[D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]


   "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
   
"D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj" 
(default target) (4) ->
   "D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (22) ->
   (CustomBuild target) -> 
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 1. 
[D:\DCOS\mesos\src\mesos-protobufs.vcxproj]

390 Warning(s)
1 Error(s)

Time Elapsed 00:09:09.93
```

- Mesos Reviewbot Windows


On July 27, 2018, 7:12 p.m., Chun-Hung Hsiao wrote:
> 

Re: Review Request 68052: Discard the queue's promises in the destructor.

[Sergey Urbanovich]

> On July 26, 2018, 7:07 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/queue.hpp
> > Line 112 (original), 112-115 (patched)
> > 
> >
> > Abandonment was added to address cases like these. The TODO was written 
> > before we introduced abandonment:
> > 
> > 
> > https://github.com/apache/mesos/tree/master/3rdparty/libprocess#futures-and-promises-abandoned-futures
> > 
> > Now, the futures will be abandoned during queue destruction. However, 
> > because abandonment was added much later, it is a sub-case of pending and 
> > has to be handled with Future::recover only for now.
> > 
> > For discard semantics we generally only return a discarded future in 
> > response to a request to discard from the client. That is, if the client 
> > never requested a discard, we generally don't surface discarded futures. 
> > Whether this is the right thing to do is up for debate (but probably not in 
> > this patch).
> > 
> > To maintain the status quo in this patch and leverage abandonment, we 
> > would need to whichever clients need to handle this case to use 
> > `Future::recover` until we can better integrate abandonment:
> > 
> > ```
> > Future f = q.get();
> > 
> > f
> >   .recover([](const Future& f) {
> > if (f.isAbandoned()) {
> >   return Failure(...);
> > }
> > return f;
> >   })
> >   .onAny([](const Future&) {
> > ...
> >   });
> > ```

Thank you very much for the review! I've updated my another review with your 
suggestion and will close this one.


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68052/#review206512
---


On July 26, 2018, 5:41 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68052/
> ---
> 
> (Updated July 26, 2018, 5:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It fixes the case when we can get forever-pending futures after the
> destruction of the queue.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/queue.hpp 
> c364b7dc831050bc1b23f669dc1ccc1f1255a9c8 
>   3rdparty/libprocess/src/tests/queue_tests.cpp 
> cc6b3d82ce5eb5ca16e2b9378dd5b1f28ac62fe8 
> 
> 
> Diff: https://reviews.apache.org/r/68052/diff/1/
> 
> 
> Testing
> ---
> 
> 3rdparty/libprocess/src/tests/libprocess-tests --verbose 
> --gtest_filter="QueueTest*" --gtest_break_on_failure --gtest_repeat=1000
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68053: Call any function in a specified namespace.

[Sergey Urbanovich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68053/
---

(Updated July 27, 2018, 8:35 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

To handle abandoned queue's futures `Future::recover()` was added.

Please see Benjamin's comment here: https://reviews.apache.org/r/68052/


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

The NamespaceRunner runs any function in a specified namespace. To do
that it manages a separate thread which would be re-associated with
that namespace.


Diffs (updated)
-

  src/linux/ns.hpp 0b4136bd3cc2d3e0cfee163d89469558e699b5f2 
  src/tests/containerizer/ns_tests.cpp fa4349e29b975550e05b00a1f848a24cd8e4f0de 


Diff: https://reviews.apache.org/r/68053/diff/2/

Changes: https://reviews.apache.org/r/68053/diff/1-2/


Testing
---

bin/mesos-tests.sh --verbose --gtest_filter="NsTest*" --gtest_break_on_failure 
--gtest_repeat=100


Thanks,

Sergey Urbanovich

Review Request 68090: Added log_auto_compact flag to the master.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68090/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-184
https://issues.apache.org/jira/browse/MESOS-184


Repository: mesos


Description
---

The new flag enables experimental automatic compaction invocation for
the LevelDB based replicated log storage. This is a workaround the
problem described in for MESOS-184.


Diffs
-

  src/master/flags.hpp 3929c297b45e1203e5b00454e88f86988a8b1058 
  src/master/flags.cpp 8fede0d2cf2254f34134329885f47c3c78dc5846 
  src/master/main.cpp 2c7b1bb492a0655dec9280e98ff942a15e2ae8f0 


Diff: https://reviews.apache.org/r/68090/diff/1/


Testing
---

Ran `make check`. Manually verified that the replicated log storage doesn't 
grow over time with `--log_auto_compact=true`.


Thanks,

Ilya Pronin

Review Request 68089: Added LevelDB compaction after replicated log truncation.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68089/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-184
https://issues.apache.org/jira/browse/MESOS-184


Repository: mesos


Description
---

LevelDB compaction algorithm doesn't seem to work well with out key
usage pattern and background compaction doesn't get triggered:
https://github.com/google/leveldb/issues/603. Because of that the
replicated log storage grows over time until it consumes all disk space
on the partition. As a workaround this change adds manual
leveldb::DB::CompactRange() invocation. Compaction is triggered after
every truncation action persistence that involved removal of stored
keys. By default this workaround is disabled and has to be turned on
with autoCompact parameter of the Log constructor.


Diffs
-

  include/mesos/log/log.hpp ba355331d682a7f2bdc534b4eb4402e2347528d8 
  src/log/leveldb.hpp 1d5842a13cfe99fa3ea2ac73eabb2a0b55e15239 
  src/log/leveldb.cpp 72eeffb17e2de39594de284bc01063445f82ab2c 
  src/log/log.hpp 5612a1a2c4f0d3bba3d946b365f34616180eb426 
  src/log/log.cpp 6a7080ab5115c777bd5039acb0f830563866781f 
  src/log/replica.hpp 082c81cd92e1d46f8014cd23953878f9e23a19d7 
  src/log/replica.cpp 25c128029c9d54f92145e2294f8f59d11b27da2a 
  src/tests/log_tests.cpp a8980e3676f51d14087f56338ff45de2927ea992 


Diff: https://reviews.apache.org/r/68089/diff/1/


Testing
---

Updated `LogStorageTest` cases to run with and without compaction enabled. Ran 
`make check`.


Thanks,

Ilya Pronin

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with agent flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68088/#review206552
---



PASS: Mesos patch 68088 was successfully built and tested.

Reviews applied: `['68087', '68088']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1991/mesos-review-68088

- Mesos Reviewbot Windows


On July 27, 2018, 6:16 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68088/
> ---
> 
> (Updated July 27, 2018, 6:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8038
> https://issues.apache.org/jira/browse/MESOS-8038
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `cgroups::DESTROY_TIMEOUT` with agent flag.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp 6a6f0e6df208bc0b0a888d132b3befd062755851 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 3bddcece7028745cec6623ac33dbfcaced629629 
> 
> 
> Diff: https://reviews.apache.org/r/68088/diff/1/
> 
> 
> Testing
> ---
> 
> `make` and `./bin/mesos-slave.sh --help`
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 68054: Added networking statistics to cni isolator.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review206551
---



Patch looks great!

Reviews applied: [68052, 68053, 68054]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2018, 10:42 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68054/
> ---
> 
> (Updated July 25, 2018, 10:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On receiving a request for getting `usage` for a given container
> the `network/cni` isolator uses getifaddrs(3) glibc function. The
> function returns basic networking metrics for each networking
> interface in the container networking namespace. It should work
> right out of the box on all modern Linux-based systems.
> 
> To get more networking metrics please use Netlink Protocol Library.
> However, you will have to open NETLINK sockets in each networking
> namespace and manage them from the `network/cni` isolator.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 31ec4ddb1049b7259b0784e5e40b002e29f6a8da 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 90d2d4103c8136d2dd883318acc135f7efca80d8 
> 
> 
> Diff: https://reviews.apache.org/r/68054/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Review Request 68092: CMake: Always build gRPC in Mesos.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68092/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description
---

CMake: Always build gRPC in Mesos.


Diffs
-

  3rdparty/CMakeLists.txt 9b0dfe0ab2187d6d57bb267939aa7c1dbf6c3e8d 
  cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/cmake/MesosProtobuf.cmake 9fadc9f0616a00f3c30c1fa81a44e0023ccf865f 
  src/examples/CMakeLists.txt 6a6ee7c3029552ef12726d1c36ccabd8c79ba1f8 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/68092/diff/1/


Testing
---

sudo make check with CMake
Built with Ninja


Thanks,

Chun-Hung Hsiao

Re: Review Request 68074: Autotools: Always build gRPC in Mesos.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68074/
---

(Updated July 27, 2018, 7:12 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Summary (updated)
-

Autotools: Always build gRPC in Mesos.


Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description (updated)
---

Autotools: Always build gRPC in Mesos.


Diffs (updated)
-

  3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 
  cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
  configure.ac 58003b6e823c8457f4b5a8c8d670be43bf96de8d 
  include/csi/spec.hpp 2e9b870617a6604e5d3e93eedce119ec029eea05 
  src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9 
  src/python/native_common/ext_modules.py.in 
dc4d91a8b8e3640e2191a53e657a5e4588fa911e 
  src/resource_provider/local.cpp ae23c2000b7941aad92d3b83e4e905bdf042ebe8 


Diff: https://reviews.apache.org/r/68074/diff/2/

Changes: https://reviews.apache.org/r/68074/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 68094: Add port mapping and network ports isolators sources to CMake.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
Joseph Wu.


Bugs: MESOS-8994 and MESOS-9118
https://issues.apache.org/jira/browse/MESOS-8994
https://issues.apache.org/jira/browse/MESOS-9118


Repository: mesos


Description
---

This adds the relevant options, but with a fatal message if they're
used, as we do not yet check for their dependency. This also adds the
`mesos-network-helper` executable as used by the port mapping
isolator.


Diffs
-

  cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/slave/containerizer/mesos/CMakeLists.txt 
ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/68094/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 68093: Add XFS disk isolator files to CMake.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68093/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
Joseph Wu.


Bugs: MESOS-8994 and MESOS-9117
https://issues.apache.org/jira/browse/MESOS-8994
https://issues.apache.org/jira/browse/MESOS-9117


Repository: mesos


Description
---

This adds an option to turn on the isolator, but that results in a
fatal error because we do not yet check for the required headers and
libraries.


Diffs
-

  cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/68093/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67751: Add missing files to CMake build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
---

(Updated July 27, 2018, 12:10 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and 
Joseph Wu.


Changes
---

Split out unrelated changes and addressed review.


Summary (updated)
-

Add missing files to CMake build.


Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994


Repository: mesos


Description (updated)
---

This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set, and fixes some ordering
oddities.


Diffs (updated)
-

  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9 
  src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427 
  src/python/executor/CMakeLists.txt PRE-CREATION 
  src/python/scheduler/CMakeLists.txt PRE-CREATION 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/67751/diff/2/

Changes: https://reviews.apache.org/r/67751/diff/1-2/


Testing (updated)
---


Thanks,

Andrew Schwartzmeyer

Review Request 68091: Always build gRPC in libprocess.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68091/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description
---

Always build gRPC in libprocess.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
da350b1d36b9f545372999f38acc5022a9ca1034 
  3rdparty/libprocess/Makefile.am abf667373aa65c9bb196d05a48d5d826d4d375e2 
  3rdparty/libprocess/configure.ac f125e43800bcb6477b3c2ea5802040fa38411565 
  3rdparty/libprocess/src/CMakeLists.txt 
bb8af6d09d4d5207c7eb75c32bbd2952fd4e75a6 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
5814bc615a8bf164ab563d9c32860f7d4e9325e0 


Diff: https://reviews.apache.org/r/68091/diff/1/


Testing
---

`sudo make check` for Mesos build and standalone libprocess build.


Thanks,

Chun-Hung Hsiao

Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with agent flag.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68088/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8038
https://issues.apache.org/jira/browse/MESOS-8038


Repository: mesos


Description
---

Replaced `cgroups::DESTROY_TIMEOUT` with agent flag.


Diffs
-

  src/linux/cgroups.hpp 6a6f0e6df208bc0b0a888d132b3befd062755851 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed 
  src/slave/containerizer/mesos/linux_launcher.cpp 
3bddcece7028745cec6623ac33dbfcaced629629 


Diff: https://reviews.apache.org/r/68088/diff/1/


Testing
---

`make` and `./bin/mesos-slave.sh --help`


Thanks,

Zhitao Li

Review Request 68087: Added new agent flag `cgroups_destroy_timeout`.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68087/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8038
https://issues.apache.org/jira/browse/MESOS-8038


Repository: mesos


Description
---

Added new agent flag `cgroups_destroy_timeout`.


Diffs
-

  src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
  src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 


Diff: https://reviews.apache.org/r/68087/diff/1/


Testing
---

`make` and run `./bin/mesos-slave.sh --help`.


Thanks,

Zhitao Li

Re: Review Request 68050: WIP: Refactored allocator performance benchmarks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68050/#review206549
---



Patch looks great!

Reviews applied: [68049, 68050]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2018, 11:50 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68050/
> ---
> 
> (Updated July 25, 2018, 11:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9103
> https://issues.apache.org/jira/browse/MESOS-9103
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP, still need to:
> - Refactor the remaining tests;
> - Add metrics summary;
> - Improve some tests logic;
> - Adjust test parameters to shorten test runtime.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
> 
> 
> Diff: https://reviews.apache.org/r/68050/diff/1/
> 
> 
> Testing
> ---
> 
> ./bin/mesos-tests.sh --gtest_filter=*AddAndUpdateSlave* --benchmark
> ./bin/mesos-tests.sh 
> --gtest_filter=*HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes* 
> --benchmark
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
---



I'd prefer to split this patch into two, one for adding the new flag and 
updating the related docs, and another for updating the containerizer's code.


src/slave/flags.hpp
Lines 92 (patched)


We also need to add this flag into `Http::STATE_HELP()` and a couple of 
docs, e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and 
`CHANGELOG`.


- Qian Zhang


On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> ---
> 
> (Updated July 27, 2018, 3:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.  Garbage collection follows the same
> policy as the agent (as defined by --gc_delay and --gc_disk_headroom).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 98129d006cda9b65804b518619b6addc8990410a 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 67187: Tested per-framework task state metrics.

[Greg Mann]

> On July 25, 2018, 9:06 p.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9107 (patched)
> > 
> >
> > Do we have to specify the resources? I think the defaults should be 
> > good.

But the resources are a required parameter for `createTask`?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/#review206466
---


On July 27, 2018, 4:23 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67187/
> ---
> 
> (Updated July 27, 2018, 4:23 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Gilbert Song.
> 
> 
> Bugs: MESOS-8847
> https://issues.apache.org/jira/browse/MESOS-8847
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds `MasterTest.TaskStateMetrics`, which verifies that
> per-framework task state metrics for both terminal and active task
> states report correct values, even after agent reregistration.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
>   src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 
> 
> 
> Diff: https://reviews.apache.org/r/67187/diff/6/
> 
> 
> Testing
> ---
> 
> The new test was run ~10,000 times with no failures.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 68085: Extended a v1 test helper.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68085/
---

Review request for mesos.


Repository: mesos


Description
---

Extended a v1 test helper.


Diffs
-

  src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 


Diff: https://reviews.apache.org/r/68085/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67187: Tested per-framework task state metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/
---

(Updated July 27, 2018, 4:23 p.m.)


Review request for mesos, Gastón Kleiman and Gilbert Song.


Bugs: MESOS-8847
https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
---

This patch adds `MasterTest.TaskStateMetrics`, which verifies that
per-framework task state metrics for both terminal and active task
states report correct values, even after agent reregistration.


Diffs (updated)
-

  src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
  src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 


Diff: https://reviews.apache.org/r/67187/diff/6/

Changes: https://reviews.apache.org/r/67187/diff/5-6/


Testing
---

The new test was run ~10,000 times with no failures.


Thanks,

Greg Mann

Re: Review Request 67187: Tested per-framework task state metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/
---

(Updated July 27, 2018, 4:16 p.m.)


Review request for mesos, Gastón Kleiman and Gilbert Song.


Bugs: MESOS-8847
https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
---

This patch adds `MasterTest.TaskStateMetrics`, which verifies that
per-framework task state metrics for both terminal and active task
states report correct values, even after agent reregistration.


Diffs (updated)
-

  src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
  src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 


Diff: https://reviews.apache.org/r/67187/diff/5/

Changes: https://reviews.apache.org/r/67187/diff/4-5/


Testing
---

The new test was run ~10,000 times with no failures.


Thanks,

Greg Mann

Re: Review Request 68082: Clarified instructions in docs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/#review206545
---



PASS: Mesos patch 68082 was successfully built and tested.

Reviews applied: `['68082']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1990/mesos-review-68082

- Mesos Reviewbot Windows


On July 27, 2018, 2:14 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68082/
> ---
> 
> (Updated July 27, 2018, 2:14 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The instructions for using libprocess memory profiling
> together with a custom libjemalloc.so had accidentally
> omitted a required condition.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 
> 
> 
> Diff: https://reviews.apache.org/r/68082/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68082: Clarified instructions in docs.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/#review206544
---


Ship it!




Ship It!

- Alexander Rukletsov


On July 27, 2018, 2:14 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68082/
> ---
> 
> (Updated July 27, 2018, 2:14 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The instructions for using libprocess memory profiling
> together with a custom libjemalloc.so had accidentally
> omitted a required condition.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 
> 
> 
> Diff: https://reviews.apache.org/r/68082/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 68082: Clarified instructions in docs.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68082/
---

Review request for mesos.


Repository: mesos


Description
---

The instructions for using libprocess memory profiling
together with a custom libjemalloc.so had accidentally
omitted a required condition.


Diffs
-

  docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f 


Diff: https://reviews.apache.org/r/68082/diff/1/


Testing
---


Thanks,

Benno Evers