Re: Review Request 67175: Added support for marking slave mounts.

[Jason Lai]

> On May 23, 2018, 12:18 a.m., James Peach wrote:
> > src/linux/fs.cpp
> > Lines 662 (patched)
> > 
> >
> > This seems like a logical extension to `os::touch`?
> > 
> > If we can emulate the `os::stat` API and use enum constants to make 
> > this more obvious at the call site:
> > ```
> > os::touch(path, os::Touch::RECURSIVE, os::Touch::FILE);
> > ```
> > 
> > cc @jieyu
> 
> Jason Lai wrote:
> Makes sense. I've dropped the function in this patch and will create 
> another patch in favor of your suggestion.

For `os::Touch::DIRECTORY`, I actually feel it doesn't bring much value to have 
`os::touch` to support both recursive and non-recursive cases (a direct call to 
`os::touch` would simply do the work).

The semantics of touching with an extra call to `os::utime` upon existing paths 
also feels unnecessary and/or could introduce breaking risks whn the path is 
readonly and the action is supposed to be no-op.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67175/#review203620
---


On Sept. 15, 2018, 12:36 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67175/
> ---
> 
> (Updated Sept. 15, 2018, 12:36 a.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
> Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added utility function for marking slave mounts in the mount table.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 502f85c4a32d8658bdd701975dd5ac3d802d308e 
>   src/linux/fs.cpp 9055ef42edd1fb90e1026d1d603a9ba902cfc1fd 
> 
> 
> Diff: https://reviews.apache.org/r/67175/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

[GitHub] gouravrattihalli commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

gouravrattihalli commented on issue #285: mesos.scheduler and mesos.executor 
seem to cause errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-422141145
 
 
   @tillt I got the "mesos-executor" egg from 
[pypi](https://pypi.org/project/mesos-executor/). I was trying to avoid 
building Mesos, hence used the one from pypi.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review208684
---


Ship it!




Ship It!

- Jason Lai


On Sept. 13, 2018, 5:17 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67022/
> ---
> 
> (Updated Sept. 13, 2018, 5:17 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Jason Lai.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp fd53d90776967ae97575140778129d6fddd726d2 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
> 
> 
> Diff: https://reviews.apache.org/r/67022/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 68736: Added `task cat` command to new CLI.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68736/#review208683
---



PASS: Mesos patch 68736 was successfully built and tested.

Reviews applied: `['68734', '68711', '68736']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2347/mesos-review-68736

- Mesos Reviewbot Windows


On Sept. 17, 2018, 3:46 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68736/
> ---
> 
> (Updated Sept. 17, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `task cat` command to new CLI.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/task.py 
> b54ade557f579a489e459f6022807146e0211fb0 
> 
> 
> Diff: https://reviews.apache.org/r/68736/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_cat (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 6 tests in 13.934s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68679/
---

(Updated Sept. 17, 2018, 4:30 p.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9214
https://issues.apache.org/jira/browse/MESOS-9214


Repository: mesos


Description
---

The `f_bsize` elemement denotes the preferred filesystem block
size, not the unit that `f_blocks` is counting in. We need to
use `f_frsize` for that.

Depending on the kernel version, `devtmpfs` might not report 0
usage, so switch to `devpts` since that always reports 0.


Diffs
-

  3rdparty/stout/tests/os/filesystem_tests.cpp 
be15395fc38f7b106ddcd886ba426197f2e783d1 


Diff: https://reviews.apache.org/r/68679/diff/3/


Testing (updated)
---

Ran stout tests on macOS 10.13.2, Fedora 28, Centos 6.9 and Ubuntu 14.04.


Thanks,

James Peach

Re: Review Request 68711: Added `task ls` command to new CLI.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/#review208681
---



PASS: Mesos patch 68711 was successfully built and tested.

Reviews applied: `['68734', '68711']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2346/mesos-review-68711

- Mesos Reviewbot Windows


On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68711/
> ---
> 
> (Updated Sept. 17, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `task ls` command to new CLI.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/agents.py PRE-CREATION 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/task.py 
> b54ade557f579a489e459f6022807146e0211fb0 
> 
> 
> Diff: https://reviews.apache.org/r/68711/diff/6/
> 
> 
> Testing
> ---
> 
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 5 tests in 9.656s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 68736: Added `task cat` command to new CLI.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68736/
---

Review request for mesos, Eric Chung and Kevin Klues.


Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description
---

Added `task cat` command to new CLI.


Diffs
-

  src/python/cli_new/lib/cli/plugins/task/main.py 
644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
  src/python/cli_new/lib/cli/tests/task.py 
b54ade557f579a489e459f6022807146e0211fb0 


Diff: https://reviews.apache.org/r/68736/diff/1/


Testing
---

Tested manually and:
```
(mesos-cli) bash-3.2$ mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_cat (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok

--
Ran 6 tests in 13.934s

OK
```


Thanks,

Armand Grillet

Review Request 68736: Added `task cat` command to new CLI.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68736/
---

Review request for mesos, Eric Chung and Kevin Klues.


Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description
---

Added `task cat` command to new CLI.


Diffs
-

  src/python/cli_new/lib/cli/plugins/task/main.py 
644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
  src/python/cli_new/lib/cli/tests/task.py 
b54ade557f579a489e459f6022807146e0211fb0 


Diff: https://reviews.apache.org/r/68736/diff/1/


Testing
---

Tested manually and:
```
(mesos-cli) bash-3.2$ mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_cat (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok

--
Ran 6 tests in 13.934s

OK
```


Thanks,

Armand Grillet

Re: Review Request 68711: Added `task ls` command to new CLI.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/#review208680
---



PASS: Mesos patch 68711 was successfully built and tested.

Reviews applied: `['68734', '68711']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2345/mesos-review-68711

- Mesos Reviewbot Windows


On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68711/
> ---
> 
> (Updated Sept. 17, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `task ls` command to new CLI.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/agents.py PRE-CREATION 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/task.py 
> b54ade557f579a489e459f6022807146e0211fb0 
> 
> 
> Diff: https://reviews.apache.org/r/68711/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually and:
> ```
> (mesos-cli) ?  cli_new (DCOS_OSS-4083) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 5 tests in 9.656s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorter performance.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68731/#review208679
---



PASS: Mesos patch 68731 was successfully built and tested.

Reviews applied: `['68729', '68730', '68731']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2344/mesos-review-68731

- Mesos Reviewbot Windows


On Sept. 16, 2018, 7:59 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68731/
> ---
> 
> (Updated Sept. 16, 2018, 7:59 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Bugs: MESOS-9239
> https://issues.apache.org/jira/browse/MESOS-9239
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This type replaces the use of hashmaps keyed by resource names in
> favor of storing vectors of `pair`, in order
> to avoid the performance penalty of using hashmaps.
> 
> Running *HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21 shows
> the following improvement:
> 
> Using 1 agents and 1000 frameworks
> Added 1000 frameworks in 42.49ms -> 42.85ms (no change)
> Added 1 agents in 7.69secs -> 4.89secs (normalized: 1 -> 0.64)
> round 0 allocate() took 5.42secs -> 3.53secs (nomralized: 1 -> 0.65)
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 5a4fa5e2dca61168923261230b1f5c245354cbb7 
> 
> 
> Diff: https://reviews.apache.org/r/68731/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68711: Added `task ls` command to new CLI.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/
---

(Updated Sept. 17, 2018, 12:37 p.m.)


Review request for mesos, Eric Chung and Kevin Klues.


Changes
---

Rebased on refactoring.


Summary (updated)
-

Added `task ls` command to new CLI.


Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description (updated)
---

Added `task ls` command to new CLI.


Diffs (updated)
-

  src/python/cli_new/lib/cli/agents.py PRE-CREATION 
  src/python/cli_new/lib/cli/plugins/task/main.py 
644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
  src/python/cli_new/lib/cli/tests/task.py 
b54ade557f579a489e459f6022807146e0211fb0 


Diff: https://reviews.apache.org/r/68711/diff/3/

Changes: https://reviews.apache.org/r/68711/diff/2-3/


Testing
---

Tested manually and:
```
(mesos-cli) ?  cli_new (DCOS_OSS-4083) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok

--
Ran 5 tests in 9.656s

OK
```


Thanks,

Armand Grillet

Review Request 68734: Refactored new CLI.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68734/
---

Review request for mesos, Eric Chung and Kevin Klues.


Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description
---

This adds two new files, `agent.py` and `tasks.py`, usable by
any plugin to do standard operations with agents and tasks.


Diffs
-

  src/python/cli_new/lib/cli/agents.py PRE-CREATION 
  src/python/cli_new/lib/cli/plugins/agent/main.py 
fc62d9fe62001e31d254a038cd7056751c846541 
  src/python/cli_new/lib/cli/plugins/task/main.py 
644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68734/diff/1/


Testing
---

Ran `mesos-cli-tests` successfully.


Thanks,

Armand Grillet

Re: Review Request 68728: Added rapidjson to RPM spec file.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/#review208677
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 68728`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2343/mesos-review-68728

Relevant logs:

- 
[apply-review-68728.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2343/mesos-review-68728/logs/apply-review-68728.log):

```
error: patch failed: support/packaging/centos/mesos.spec:161
error: support/packaging/centos/mesos.spec: patch does not apply
```

- Mesos Reviewbot Windows


On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68728/
> ---
> 
> (Updated Sept. 17, 2018, 1:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-9238
> https://issues.apache.org/jira/browse/MESOS-9238
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We didn't update the RPM spec file when we added the rapidjson
> dependencies. This will cause RPM build to fail like the following:
> 
> RPM build errors:
> error: Installed (but unpackaged) file(s) found:
>/usr/include/rapidjson/allocators.h
>/usr/include/rapidjson/document.h
>...
> 
> This patch fixed it by adding the rapidjson headers to the %files
> section accordingly.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/mesos.spec 
> 053298522ee198b3b23004ff9ce73aa60a39e8a4 
> 
> 
> Diff: https://reviews.apache.org/r/68728/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 68718: Added patch for PicoJSON.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68718/
---

(Updated Sept. 17, 2018, 8:51 a.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

This commit adds a backport of an upstream patch
provided by kazuho that introduces a maximum nesting
level for JSON objects.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 1a4ed5a5da4a97eeb2d94342065cda7983bc17ce 
  3rdparty/picojson-1.3.0.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/68718/diff/2/

Changes: https://reviews.apache.org/r/68718/diff/1-2/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 68728: Added rapidjson to RPM spec file.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/#review208675
---


Ship it!




Ship It!

- Till Toenshoff


On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68728/
> ---
> 
> (Updated Sept. 17, 2018, 1:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-9238
> https://issues.apache.org/jira/browse/MESOS-9238
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We didn't update the RPM spec file when we added the rapidjson
> dependencies. This will cause RPM build to fail like the following:
> 
> RPM build errors:
> error: Installed (but unpackaged) file(s) found:
>/usr/include/rapidjson/allocators.h
>/usr/include/rapidjson/document.h
>...
> 
> This patch fixed it by adding the rapidjson headers to the %files
> section accordingly.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/mesos.spec 
> 053298522ee198b3b23004ff9ce73aa60a39e8a4 
> 
> 
> Diff: https://reviews.apache.org/r/68728/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>