Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update.

2018-11-01 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69236/#review210271
---



Patch looks great!

Reviews applied: [69234, 69235, 69236]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2018, 9:29 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69236/
> ---
> 
> (Updated Nov. 1, 2018, 9:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9332
> https://issues.apache.org/jira/browse/MESOS-9332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a coding error that a test waited on a wrong task status update.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 
> 
> 
> Diff: https://reviews.apache.org/r/69236/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation.

2018-11-01 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69233/#review210269
---



Patch looks great!

Reviews applied: [69233]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2018, 8:33 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69233/
> ---
> 
> (Updated Nov. 1, 2018, 8:33 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9367
> https://issues.apache.org/jira/browse/MESOS-9367
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the XFS disk isolator didn't check that the persistent volume
> has a `DiskInfo::Source` before populating the corresponding field
> in the `ResourceStatistics` message. This caused the JSON conversion
> (triggered by operator API calls) to check fail. The fix is to simply
> check that the volume has a `DiskInfo::Source` before propagating it.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 44b7d0570b00d50e1fc454100ab73f4dfe5ca159 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> b2f977f15e2ea8cbe5f1d60e046a8f7d3560 
> 
> 
> Diff: https://reviews.apache.org/r/69233/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines.

2018-11-01 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/#review210268
---



PASS: Mesos patch 69237 was successfully built and tested.

Reviews applied: `['69237']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2563/mesos-review-69237

- Mesos Reviewbot Windows


On Nov. 1, 2018, 10:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69237/
> ---
> 
> (Updated Nov. 1, 2018, 10:28 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9341
> https://issues.apache.org/jira/browse/MESOS-9341
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Simplified 'test_exec' in new CLI to better manage newlines.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/tests/task.py 
> 4b03cf13185f1c718f24a990a75a4dd74e7e132a 
> 
> 
> Diff: https://reviews.apache.org/r/69237/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> (mesos-cli) ?  cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... giok
> test_list (cli.tests.task.TestTaskPlugin) ...  commiok
> 
> --
> Ran 7 tests in 17.531s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update.

2018-11-01 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69236/#review210267
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69234', '69235', '69236']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2562/mesos-review-69236

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2562/mesos-review-69236/logs/mesos-tests.log):

```
I1101 23:03:57.538496 12472 master.cpp:1273] Agent 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-S0 at slave(461)@192.10.1.5:62559 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1101 23:03:57.538496 12472 master.cpp:3289] Disconnecting agent 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-S0 at slave(461)@192.10.1.5:62559 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1101 23:03:57.538496 14928 hierarchical.cpp:357] Removed framework 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-
I1101 23:03:57.538496 12472 master.cpp:3308] Deactivating agent 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-S0 at slave(461)@192.10.1.5:62559 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1101 23:03:57.538496 12876 hierarchical.cpp:801] Agent 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-S0 deactivated
I1101 23:03:57.540508 12876 containerizer.cpp:2467] Destroying container 
5937d1d7-64a6-45f7-b7b4-170445c4e22f in RUNNING state
I1101 23:03:57.540508 12876 containerizer.cpp:3134] Transitioning the state of 
container 5937d1d7-64a6-45f7-b7b4-170445c4e22f from RUNNING to DESTROYING
I1101 23:03:57.540508 12876 launcher.cpp:166] Asked to destroy container 
5937d1d7-64a6-45f7-b7b4-170445c4e22f
W1101 23:03:57.541486 10536 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=4120 to peer '192.10.1.5:64357': IO fai[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (580 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (598 ms total)

[--] Global test environment tear-down
[==] 1053 tests from 103 test cases ran. (489158 ms total)
[  PASSED  ] 1051 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

led with error code: The specified network name is no longer available.

W1101 23:03:57.542479 10536 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5076 to peer '192.10.1.5:64358': IO failed with error 
code: The specified network name is no longer available.

I1101 23:03:57.01 11836 containerizer.cpp:2973] Container 
5937d1d7-64a6-45f7-b7b4-170445c4e22f has exited
I1101 23:03:57.584530 10080 master.cpp:1115] Master terminating
I1101 23:03:57.585494 12596 hierarchical.cpp:643] Removed agent 
3085d9bf-b40e-4de7-88af-f5cd54a6766e-S0
I1101 23:03:57.891475 10536 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 1, 2018, 10:29 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69236/
> ---
> 
> (Updated Nov. 1, 2018, 10:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9332
> https://issues.apache.org/jira/browse/MESOS-9332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a coding error that a test waited on a wrong task status update.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 
> 
> 
> Diff: https://reviews.apache.org/r/69236/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69115/#review210266
---



Committed with changes from comments applied by me manually.

- Kevin Klues


On Okt. 22, 2018, 2:40 nachm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69115/
> ---
> 
> (Updated Okt. 22, 2018, 2:40 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9342
> https://issues.apache.org/jira/browse/MESOS-9342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for interactive 'task exec'.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/tests/task.py 
> 4b03cf13185f1c718f24a990a75a4dd74e7e132a 
> 
> 
> Diff: https://reviews.apache.org/r/69115/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-6551) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 6 tests in 12.602s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines.

2018-11-01 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69237/
---

Review request for mesos and Kevin Klues.


Bugs: MESOS-9341
https://issues.apache.org/jira/browse/MESOS-9341


Repository: mesos


Description
---

Simplified 'test_exec' in new CLI to better manage newlines.


Diffs
-

  src/python/cli_new/lib/cli/tests/task.py 
4b03cf13185f1c718f24a990a75a4dd74e7e132a 


Diff: https://reviews.apache.org/r/69237/diff/1/


Testing
---

```
(mesos-cli) ?  cli_new (exec-attach) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... giok
test_list (cli.tests.task.TestTaskPlugin) ...  commiok

--
Ran 7 tests in 17.531s

OK
```


Thanks,

Armand Grillet

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69115/#review210265
---


Ship it!




Ship It!

- Kevin Klues


On Okt. 22, 2018, 2:40 nachm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69115/
> ---
> 
> (Updated Okt. 22, 2018, 2:40 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9342
> https://issues.apache.org/jira/browse/MESOS-9342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for interactive 'task exec'.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/tests/task.py 
> 4b03cf13185f1c718f24a990a75a4dd74e7e132a 
> 
> 
> Diff: https://reviews.apache.org/r/69115/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-6551) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 6 tests in 12.602s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69115/#review210242
---




src/python/cli_new/lib/cli/tests/task.py
Lines 95 (patched)


Typo



src/python/cli_new/lib/cli/tests/task.py
Lines 126 (patched)


Why do we need the strip() here?


- Kevin Klues


On Okt. 22, 2018, 2:40 nachm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69115/
> ---
> 
> (Updated Okt. 22, 2018, 2:40 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9342
> https://issues.apache.org/jira/browse/MESOS-9342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for interactive 'task exec'.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/tests/task.py 
> 4b03cf13185f1c718f24a990a75a4dd74e7e132a 
> 
> 
> Diff: https://reviews.apache.org/r/69115/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-6551) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 6 tests in 12.602s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation.

2018-11-01 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69233/#review210264
---



PASS: Mesos patch 69233 was successfully built and tested.

Reviews applied: `['69233']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2561/mesos-review-69233

- Mesos Reviewbot Windows


On Nov. 1, 2018, 8:33 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69233/
> ---
> 
> (Updated Nov. 1, 2018, 8:33 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9367
> https://issues.apache.org/jira/browse/MESOS-9367
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the XFS disk isolator didn't check that the persistent volume
> has a `DiskInfo::Source` before populating the corresponding field
> in the `ResourceStatistics` message. This caused the JSON conversion
> (triggered by operator API calls) to check fail. The fix is to simply
> check that the volume has a `DiskInfo::Source` before propagating it.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 44b7d0570b00d50e1fc454100ab73f4dfe5ca159 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> b2f977f15e2ea8cbe5f1d60e046a8f7d3560 
> 
> 
> Diff: https://reviews.apache.org/r/69233/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update.

2018-11-01 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69236/#review210263
---


Ship it!




Ship It!

- Gilbert Song


On Nov. 1, 2018, 2:29 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69236/
> ---
> 
> (Updated Nov. 1, 2018, 2:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9332
> https://issues.apache.org/jira/browse/MESOS-9332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a coding error that a test waited on a wrong task status update.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 
> 
> 
> Diff: https://reviews.apache.org/r/69236/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 69236: Fixed a coding error that a test waited on a wrong task status update.

2018-11-01 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69236/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9332
https://issues.apache.org/jira/browse/MESOS-9332


Repository: mesos


Description
---

Fixed a coding error that a test waited on a wrong task status update.


Diffs
-

  src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 


Diff: https://reviews.apache.org/r/69236/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 69235: Added a test `ROOT_UNPRIVILEGED_USER_DefaultExecutorCommandHealthCheck`.

2018-11-01 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69235/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9332
https://issues.apache.org/jira/browse/MESOS-9332


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_DefaultExecutorCommandHealthCheck`.


Diffs
-

  src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 


Diff: https://reviews.apache.org/r/69235/diff/1/


Testing
---

Ran this test repeatedly, all iterations succeeded.

This test will fail without its previous patch 
https://reviews.apache.org/r/69234/.


Thanks,

Qian Zhang

Review Request 69234: Made debug container runs as its parent container's user by default.

2018-11-01 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69234/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9332
https://issues.apache.org/jira/browse/MESOS-9332


Repository: mesos


Description
---

Made debug container runs as its parent container's user by default.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
03a4e0f1567b27b2efd8a443caea3a2a087d858c 
  src/slave/http.cpp 0d27ab576d5fa52c06826703e3dad38c2d374cc9 


Diff: https://reviews.apache.org/r/69234/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation.

2018-11-01 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69233/#review210261
---


Ship it!





src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 660 (patched)


Might be worth adding a comment about root disks not having `Source` since 
people often forget. :)


- Jiang Yan Xu


On Nov. 1, 2018, 1:33 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69233/
> ---
> 
> (Updated Nov. 1, 2018, 1:33 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9367
> https://issues.apache.org/jira/browse/MESOS-9367
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the XFS disk isolator didn't check that the persistent volume
> has a `DiskInfo::Source` before populating the corresponding field
> in the `ResourceStatistics` message. This caused the JSON conversion
> (triggered by operator API calls) to check fail. The fix is to simply
> check that the volume has a `DiskInfo::Source` before propagating it.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 44b7d0570b00d50e1fc454100ab73f4dfe5ca159 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> b2f977f15e2ea8cbe5f1d60e046a8f7d3560 
> 
> 
> Diff: https://reviews.apache.org/r/69233/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation.

2018-11-01 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69233/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-9367
https://issues.apache.org/jira/browse/MESOS-9367


Repository: mesos


Description
---

Since the XFS disk isolator didn't check that the persistent volume
has a `DiskInfo::Source` before populating the corresponding field
in the `ResourceStatistics` message. This caused the JSON conversion
(triggered by operator API calls) to check fail. The fix is to simply
check that the volume has a `DiskInfo::Source` before propagating it.


Diffs
-

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
44b7d0570b00d50e1fc454100ab73f4dfe5ca159 
  src/tests/containerizer/xfs_quota_tests.cpp 
b2f977f15e2ea8cbe5f1d60e046a8f7d3560 


Diff: https://reviews.apache.org/r/69233/diff/1/


Testing
---

sudo make check (Fedora 28)


Thanks,

James Peach

Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-11-01 Thread Till Toenshoff via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69224/#review210255
---


Ship it!




Ship It!

- Till Toenshoff


On Nov. 1, 2018, 3:15 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69224/
> ---
> 
> (Updated Nov. 1, 2018, 3:15 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benno Evers.
> 
> 
> Bugs: MESOS-9366
> https://issues.apache.org/jira/browse/MESOS-9366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 
> 
> 
> Diff: https://reviews.apache.org/r/69224/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-11-01 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69224/#review210250
---


Ship it!




Ship It!

- Alexander Rukletsov


On Nov. 1, 2018, 3:15 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69224/
> ---
> 
> (Updated Nov. 1, 2018, 3:15 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benno Evers.
> 
> 
> Bugs: MESOS-9366
> https://issues.apache.org/jira/browse/MESOS-9366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp da64dc2b4de6e1526628522af34ee83b8ef9f469 
> 
> 
> Diff: https://reviews.apache.org/r/69224/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>