Re: Review Request 69324: Removed some unnecessary intermediate build variables.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69324/#review210494
---



PASS: Mesos patch 69324 was successfully built and tested.

Reviews applied: `['69323', '69324']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2595/mesos-review-69324

- Mesos Reviewbot Windows


On Nov. 13, 2018, 5:30 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69324/
> ---
> 
> (Updated Nov. 13, 2018, 5:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some unnecessary intermediate build variables.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/69324/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 29)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 69325: Fixed CSI build problems for `make distcheck`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69325/
---

Review request for mesos, Benjamin Bannier and James Peach.


Repository: mesos


Description
---

Fixed CSI build problems for `make distcheck`.


Diffs
-

  src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 


Diff: https://reviews.apache.org/r/69325/diff/1/


Testing
---

make distcheck


Thanks,

Chun-Hung Hsiao

Re: Review Request 69323: Removed separate automake variables for header sources.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69323/#review210492
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69323']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2594/mesos-review-69323

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2594/mesos-review-69323/logs/mesos-tests.log):

```
W1113 06:07:17.519755 26072 slave.cpp:3923] Ignoring shutdown framework 
04534d00-41c6-4f29-a57d-3e5789c7c518- because it is terminating
I1113 06:07:17.521749 22500 master.cpp:1273] Agent 
04534d00-41c6-4f29-a57d-3e5789c7c518-S0 at slave(461)@192.10.1.8:62302 
(windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1113 06:07:17.521749 22500 master.cpp:3289] Disconnecting agent 
04534d00-41c6-4f29-a57d-3e5789c7c518-S0 at slave(461)@192.10.1.8:62302 
(windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1113 06:07:17.521749 22500 master.cpp:3308] Deactivating agent 
04534d00-41c6-4f29-a57d-3e5789c7c518-S0 at slave(461)@192.10.1.8:62302 
(windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1113 06:07:17.521749 22600 hierarchical.cpp:357] Removed framework 
04534d00-41c6-4f29-a57d-3e5789c7c518-
I1113 06:07:17.522753 22600 hierarchical.cpp:801] Agent 
04534d00-41c6-4f29-a57d-3e5789c7c518-S0 deactivated
I1113 06:07:17.523767 22600 containerizer.cpp:2465] Destroying container 
e3c6974c-5320-49d5-aeb0-8bf8b3f71413 in RUNNING state
I1113 06:07:17.523767 22600 containerizer.cpp:3132] Transitioning the state of 
container e3c6974c-5320-49d5-aeb0-8bf8b3f71413 from RUNNING to DESTROYING
I1113 06:07:17.523767 22600 launcher.cpp:161] Asked to destroy container 
e3c6974c-5320-49d5-aeb0-8bf8b3f71413
W1113 06:07:17.525744 25704 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=4060 to peer '192.10.1.8:64085': IO failed with error 
code: The specified network name is no longer available.

W1113 06:07:17.525744 25704 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=3708 to peer '192.10.1.8:64086': IO failed with error 
code: The specified network name is no longer available.

I1113 06:07:17.624004 24220 containerizer.cpp:2971] Container 
e3c6974c-5320-49d5-aeb0-8bf8b3f71413 has exited
I1113 06:07:17.652981[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (704 ms total)

[--] Global test environment tear-down
[==] 1053 tests from 103 test cases ran. (493854 ms total)
[  PASSED  ] 1052 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

 20752 master.cpp:1115] Master terminating
I1113 06:07:17.654996 22600 hierarchical.cpp:643] Removed agent 
04534d00-41c6-4f29-a57d-3e5789c7c518-S0
I1113 06:07:17.996975 25704 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 13, 2018, 5:01 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69323/
> ---
> 
> (Updated Nov. 13, 2018, 5:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In some cases, we were using separate automake sources variables
> to list source and header files, and in other cases, we just added
> both to the same variable. Standardize on the latter form since it
> makes it easier to see where files are listed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/69323/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 29)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 69324: Removed some unnecessary intermediate build variables.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69324/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

Removed some unnecessary intermediate build variables.


Diffs
-

  src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 


Diff: https://reviews.apache.org/r/69324/diff/1/


Testing
---

make check (Fedora 29)


Thanks,

James Peach

Review Request 69323: Removed separate automake variables for header sources.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69323/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

In some cases, we were using separate automake sources variables
to list source and header files, and in other cases, we just added
both to the same variable. Standardize on the latter form since it
makes it easier to see where files are listed.


Diffs
-

  src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 


Diff: https://reviews.apache.org/r/69323/diff/1/


Testing
---

make check (Fedora 29)


Thanks,

James Peach

Re: Review Request 69321: Fixed an FTS tree leakage in the copy backend.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69321/#review210491
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69321']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2593/mesos-review-69321

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2593/mesos-review-69321/logs/mesos-tests.log):

```
I1113 04:31:13.303097 27240 master.cpp:11054] Removing task 
df1c63a1-6754-415a-ad0a-e30b03572e9b with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework c981011c-825e-4f11-b1c5-adcdcab9b169- on 
agent c981011c-825e-4f11-b1c5-adcdcab9b169-S0 at slave(461)@192.10.1.5:59702 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1113 04:31:13.305099 27240 master.cpp:1273] Agent 
c981011c-825e-4f11-b1c5-adcdcab9b169-S0 at slave(461)@192.10.1.5:59702 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1113 04:31:13.305099 27240 master.cpp:3289] Disconnecting agent 
c981011c-825e-4f11-b1c5-adcdcab9b169-S0 at slave(461)@192.10.1.5:59702 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1113 04:31:13.306114 27240 master.cpp:3308] Deactivating agent 
c981011c-825e-4f11-b1c5-adcdcab9b169-S0 at slave(461)@192.10.1.5:59702 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1113 04:31:13.306114 17120 hierarchical.cpp:357] Removed framework 
c981011c-825e-4f11-b1c5-adcdcab9b169-
I1113 04:31:13.306114 33412 hierarchical.cpp:801] Agent 
c981011c-825e-4f11-b1c5-adcdcab9b169-S0 deactivated
I1113 04:31:13.307101 33412 containerizer.cpp:2465] Destroying container 
58d1d552-170d-45ca-b7c7-cd1f53b2628b in RUNNING state
I1113 04:31:13.307101 33412 containerizer.cpp:3132] Transitioning the state of 
container 58d1d552-170d-45ca-b7c7-cd1f53b2628b from RUNNING to DESTROYING
I1113 04:31:13.308104 33412 launcher.cpp:161] Asked to destroy container 
58d1d552-170d-45ca-b7c7-cd1f53b2628b
W1113 04:31:13.309104 27372 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5264 to peer '192.10.1.5:61481': IO failed with error 
code: The specified network name is no longer available.

W1113 04:31:13.309104 27372 process.cpp:1423] Failed to recv on socket 
WindowsFD::Typ[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 
(684 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (704 ms total)

[--] Global test environment tear-down
[==] 1053 tests from 103 test cases ran. (507471 ms total)
[  PASSED  ] 1052 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

e::SOCKET=5256 to peer '192.10.1.5:61480': IO failed with error code: The 
specified network name is no longer available.

I1113 04:31:13.344125 33720 containerizer.cpp:2971] Container 
58d1d552-170d-45ca-b7c7-cd1f53b2628b has exited
I1113 04:31:13.374099 30844 master.cpp:1115] Master terminating
I1113 04:31:13.376091 34728 hierarchical.cpp:643] Removed agent 
c981011c-825e-4f11-b1c5-adcdcab9b169-S0
I1113 04:31:13.869096 27372 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 13, 2018, 3:23 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69321/
> ---
> 
> (Updated Nov. 13, 2018, 3:23 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an FTS tree leakage in the copy backend.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> a3237a3ee57da209270f61745fa98fa138057513 
> 
> 
> Diff: https://reviews.apache.org/r/69321/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69321: Fixed an FTS tree leakage in the copy backend.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69321/#review210489
---


Ship it!




Ship It!

- Qian Zhang


On Nov. 13, 2018, 11:23 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69321/
> ---
> 
> (Updated Nov. 13, 2018, 11:23 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an FTS tree leakage in the copy backend.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> a3237a3ee57da209270f61745fa98fa138057513 
> 
> 
> Diff: https://reviews.apache.org/r/69321/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 69321: Fixed an FTS tree leakage in the copy backend.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69321/
---

Review request for mesos, Gilbert Song and Qian Zhang.


Repository: mesos


Description
---

Fixed an FTS tree leakage in the copy backend.


Diffs
-

  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
a3237a3ee57da209270f61745fa98fa138057513 


Diff: https://reviews.apache.org/r/69321/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69162/
---

(Updated Nov. 12, 2018, 9:49 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.


Changes
---

Rebased.


Bugs: MESOS-9293
https://issues.apache.org/jira/browse/MESOS-9293


Repository: mesos


Description
---

This patch add agent and resource provide IDs to
`UpdateOperationStatus` and `UpdateOperationStatusMessage`. With that
frameworks are able to reconcile enough information after failover to
construct operation acknowledgements.

We will add code to populate these fields in a follow-up patch.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
fcfec5e417463103e98dd6917722b4fde41cac7c 
  src/internal/evolve.cpp aa60efed5a28ed4d847a4a27aa8e994cda82175d 
  src/messages/messages.cpp dd8f60ecdbc06d10be1152bee1ddb65feaaf8fbb 
  src/messages/messages.proto 41e6a8a2eab0ae7c2878c1d3286c5dea0eb68ed7 


Diff: https://reviews.apache.org/r/69162/diff/3/

Changes: https://reviews.apache.org/r/69162/diff/2-3/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69163/
---

(Updated Nov. 12, 2018, 9:49 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.


Changes
---

Rebased; added dedicated test.


Bugs: MESOS-9293
https://issues.apache.org/jira/browse/MESOS-9293


Repository: mesos


Description
---

This patch sets agent and/or resource provider ID operation status
update messages. This is not always possible, e.g., some operations
might fail validation so that no corresponding IDs can be extracted.

Since operations failing validation are currently directly rejected by
the master without going through a status update manager, they are not
retried either. If a master status update manager for operations is
introduced at a later point it should be possible to forward
acknowledgements for updates to the master's update manager (no agent
ID, not resource provider ID).


Diffs (updated)
-

  src/common/protobuf_utils.hpp 1662125ed3e47b179ee32d08c1d3af75553066ba 
  src/common/protobuf_utils.cpp a45607eed4c4bae5010bcc3f3ffeabd6d911062a 
  src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
  src/resource_provider/manager.cpp 6c81c430e9e1205d71982a7fa2bcd9aa15fc01b2 
  src/resource_provider/storage/provider.cpp 
c137fa4f13edc58d93c03a9dd32fdf9d38b38316 
  src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69163/diff/3/

Changes: https://reviews.apache.org/r/69163/diff/2-3/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210476
---



PASS: Mesos patch 69273 was successfully built and tested.

Reviews applied: `['69273']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2592/mesos-review-69273

- Mesos Reviewbot Windows


On Nov. 12, 2018, 10:33 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69273/
> ---
> 
> (Updated Nov. 12, 2018, 10:33 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9358
> https://issues.apache.org/jira/browse/MESOS-9358
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some flakyness from the test
> SlaveRecoveryTest.AgentReconfigurationWithRunningTask
> by removing the `refuse_offers` filter and by pausing
> the clock whenever possible during the test.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/69273/diff/2/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
> --gtest_repeat=200`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

[Benno Evers]

> On Nov. 7, 2018, 9:44 p.m., Joseph Wu wrote:
> > src/tests/slave_recovery_tests.cpp
> > Line 4739 (original), 4742 (patched)
> > 
> >
> > Now that the clock is paused, we should deterministically not get extra 
> > offers.  You can probably remove these blocks from the test.
> > 
> > Here and throughout the test.

Good point, but since it seems to be dependent on resolving the issue below 
I've added a TODO for now to capture this.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210383
---


On Nov. 12, 2018, 2:33 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69273/
> ---
> 
> (Updated Nov. 12, 2018, 2:33 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9358
> https://issues.apache.org/jira/browse/MESOS-9358
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some flakyness from the test
> SlaveRecoveryTest.AgentReconfigurationWithRunningTask
> by removing the `refuse_offers` filter and by pausing
> the clock whenever possible during the test.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/69273/diff/2/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
> --gtest_repeat=200`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/
---

(Updated Nov. 12, 2018, 2:33 p.m.)


Review request for mesos, Greg Mann and Joseph Wu.


Changes
---

Added additional TODO's.


Bugs: MESOS-9358
https://issues.apache.org/jira/browse/MESOS-9358


Repository: mesos


Description
---

Removed some flakyness from the test
SlaveRecoveryTest.AgentReconfigurationWithRunningTask
by removing the `refuse_offers` filter and by pausing
the clock whenever possible during the test.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/69273/diff/2/

Changes: https://reviews.apache.org/r/69273/diff/1-2/


Testing
---

`./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
--gtest_repeat=200`


Thanks,

Benno Evers

Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69309/
---

(Updated Nov. 12, 2018, 1:39 p.m.)


Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

This fixes issues with flag propagation into shards.


Diffs (updated)
-

  support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 


Diff: https://reviews.apache.org/r/69309/diff/2/

Changes: https://reviews.apache.org/r/69309/diff/1-2/


Testing
---

`../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests`


Thanks,

Benjamin Bannier

Re: Review Request 69310: Always used absolute executable paths in parallel runner.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69310/#review210469
---


Ship it!




Ship It!

- Armand Grillet


On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69310/
> ---
> 
> (Updated Nov. 11, 2018, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows executing test which are just passed as file names, not as
> relative or absolute paths.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 
> 
> 
> Diff: https://reviews.apache.org/r/69310/diff/1/
> 
> 
> Testing
> ---
> 
> `../../../../support/mesos-gtest-runner.py stout-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69309/#review210467
---


Fix it, then Ship it!





support/mesos-gtest-runner.py
Line 72 (original), 72 (patched)


s/`command lint`/`command line`


- Armand Grillet


On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69309/
> ---
> 
> (Updated Nov. 11, 2018, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes issues with flag propagation into shards.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 
> 
> 
> Diff: https://reviews.apache.org/r/69309/diff/1/
> 
> 
> Testing
> ---
> 
> `../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69161: Renamed a function argument to not reuse member name.

[Benjamin Bannier]

> On Nov. 3, 2018, 12:35 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 3065 (original), 3065 (patched)
> > 
> >
> > Maybe `operationInfo`, or just `operation`?
> > Also if we go with this naming it would be nice to rename it in the 
> > declaration as well.

I went with `operation`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69161/#review210301
---


On Oct. 25, 2018, 12:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69161/
> ---
> 
> (Updated Oct. 25, 2018, 12:54 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While a function argument shadowing a member variable is perfectly
> legal, it is still confusing. In this patch we rename the function
> argument to remove one case of such shadowing.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> db783b53558811081fb2671e005e8bbbd9edbede 
> 
> 
> Diff: https://reviews.apache.org/r/69161/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69161: Renamed a function argument to not reuse member name.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69161/
---

(Updated Nov. 12, 2018, 9:57 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Addressed comment from Chun.


Repository: mesos


Description
---

While a function argument shadowing a member variable is perfectly
legal, it is still confusing. In this patch we rename the function
argument to remove one case of such shadowing.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
2873b1ab300cbb72951b0cca5427ebbc451ae03d 


Diff: https://reviews.apache.org/r/69161/diff/3/

Changes: https://reviews.apache.org/r/69161/diff/2-3/


Testing
---

`make check`


Thanks,

Benjamin Bannier