Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211821
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2748/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2748/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2748/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2748/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211820
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2747/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2747/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2747/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2747/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211819
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2746/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2746/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2746/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2746/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211818
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2745/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2745/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2745/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2745/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211817
---



PASS: Mesos patch 69694 was successfully built and tested.

Reviews applied: `['69694']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2737/mesos-review-69694

- Mesos Reviewbot Windows


On Jan. 10, 2019, 11:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 11:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211816
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2744/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2744/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2744/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2744/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211815
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2743/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2743/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2743/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2743/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211814
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2742/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2742/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2742/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2742/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211813
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2741/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2741/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2741/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2741/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211812
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2740/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2740/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2740/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2740/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211811
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2739/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2739/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2739/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2739/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 9, 2019, 7:52 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 9, 2019, 7:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211810
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2738/mesos-review-69694

Relevant logs:

- 
[stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2738/mesos-review-69694/logs/stout-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: stout-tests.vcxproj
```

- 
[libprocess-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2738/mesos-review-69694/logs/libprocess-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: libprocess-tests.vcxproj
```

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2738/mesos-review-69694/logs/mesos-tests-cmake.log):

```
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: mesos-tests.vcxproj
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 3:52 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/4/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/
---

(Updated Jan. 10, 2019, 3:52 a.m.)


Review request for mesos.


Repository: mesos


Description
---

Tester.


Diffs (updated)
-

  CMakeLists.txt f2885faa25f1d718d0f451aa2199e3f7692317a3 
  configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 


Diff: https://reviews.apache.org/r/69694/diff/4/

Changes: https://reviews.apache.org/r/69694/diff/3-4/


Testing
---

Dont review - just a test!


Thanks,

Till Toenshoff

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211809
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2736/mesos-review-69694

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2736/mesos-review-69694/logs/mesos-tests.log):

```
W0110 03:14:51.493924  4344 slave.cpp:3933] Ignoring shutdown framework 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9- because it is terminating
I0110 03:14:51.495923  9692 master.cpp:1271] Agent 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-S0 at slave(464)@192.10.1.7:60995 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0110 03:14:51.496987  9692 master.cpp:3274] Disconnecting agent 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-S0 at slave(464)@192.10.1.7:60995 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0110 03:14:51.496987  9692 master.cpp:3293] Deactivating agent 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-S0 at slave(464)@192.10.1.7:60995 
(windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0110 03:14:51.496987  8352 hierarchical.cpp:358] Removed framework 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-
I0110 03:14:51.497918  8352 hierarchical.cpp:802] Agent 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-S0 deactivated
I0110 03:14:51.498919  4224 containerizer.cpp:2469] Destroying container 
826a7330-c01e-4953-8f7a-f1fc66d3be62 in RUNNING state
I0110 03:14:51.498919  4224 containerizer.cpp:3136] Transitioning the state of 
container 826a7330-c01e-4953-8f7a-f1fc66d3be62 from RUNNING to DESTROYING
I0110 03:14:51.498919  4224 launcher.cpp:161] Asked to destroy container 
826a7330-c01e-4953-8f7a-f1fc66d3be62
W0110 03:14:51.499963  6164 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5272 to peer '192.10.1.7:62823': IO failed with error 
code: The specified network name is no longer available.

W0110 03:14:51.500907  6164 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5332 to peer '192.10.1.7:62822': IO failed with error 
code: The specified network name is no longer available.

I0110 03:14:51.578755  8276 containerizer.cpp:2975] Container 
826a7330-c01e-4953-8f7a-f1fc66d3be62 has exited
I0110 03:14:51.606731  9788 master.cpp:[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (703 ms total)

[--] Global test environment tear-down
[==] 1082 tests from 104 test cases ran. (503256 ms total)
[  PASSED  ] 1081 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

] Master terminating
I0110 03:14:51.608700  9692 hierarchical.cpp:644] Removed agent 
4efd57cd-a64e-4d86-b0ee-1ab88d063bf9-S0
I0110 03:14:51.890719  6164 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 10, 2019, 2:32 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 10, 2019, 2:32 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/3/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69694: Tester.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/
---

(Updated Jan. 10, 2019, 2:32 a.m.)


Review request for mesos.


Repository: mesos


Description
---

Tester.


Diffs (updated)
-

  configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 


Diff: https://reviews.apache.org/r/69694/diff/3/

Changes: https://reviews.apache.org/r/69694/diff/2-3/


Testing
---

Dont review - just a test!


Thanks,

Till Toenshoff

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211806
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69694']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2735/mesos-review-69694

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2735/mesos-review-69694/logs/mesos-tests.log):

```
I0110 00:15:06.720369  9464 executor.cpp:922] Sending SIGTERM to process tree 
at pid 973958c1a76 with resources cpus(allocated: *):4; mem(allocated: *):2048; 
disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 
03d1d533-bba4-47a2-87e0-08939d1c845b- on agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0 at slave(464)@192.10.1.6:60239 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0110 00:15:06.723381  1784 master.cpp:1271] Agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0 at slave(464)@192.10.1.6:60239 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0110 00:15:06.723381  1784 master.cpp:3274] Disconnecting agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0 at slave(464)@192.10.1.6:60239 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0110 00:15:06.723381  1784 master.cpp:3293] Deactivating agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0 at slave(464)@192.10.1.6:60239 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0110 00:15:06.724378  8236 hierarchical.cpp:358] Removed framework 
03d1d533-bba4-47a2-87e0-08939d1c845b-
I0110 00:15:06.724378  8236 hierarchical.cpp:802] Agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0 deactivated
I0110 00:15:06.724378  1784 containerizer.cpp:2469] Destroying container 
415d166c-1b89-4c12-9a50-ba2d4b0e5d26 in RUNNING state
I0110 00:15:06.724378  1784 containerizer.cpp:3136] Transitioning the state of 
container 415d166c-1b89-4c12-9a50-ba2d4b0e5d26 from RUNNING to DESTROYING
I0110 00:15:06.725369  1784 launcher.cpp:161] Asked to destroy container 
415d166c-1b89-4c12-9a50-ba2d4b0e5d26
W0110 00:15:06.726377  5100 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=2432 to peer '192.10.1.6:62062': IO failed with error 
code: The specified network name is no longer available.

W0110 00:15:06.726377  5100 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2960 to peer '192.10.1.6:62063': IO failed with error 
code: The specified network name is no longer available.

I0110 00:15:06.728366  8236 containerizer.cpp:2975] Container 
415d166c-1b89-4c12-9a50-ba2d4b0e5d2[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (587 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (605 ms total)

[--] Global test environment tear-down
[==] 1082 tests from 104 test cases ran. (492388 ms total)
[  PASSED  ] 1081 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

6 has exited
I0110 00:15:06.757387  6476 master.cpp:] Master terminating
I0110 00:15:06.758384  7156 hierarchical.cpp:644] Removed agent 
03d1d533-bba4-47a2-87e0-08939d1c845b-S0
I0110 00:15:07.014806  5100 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 9, 2019, 10:54 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 9, 2019, 10:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tester.
> 
> 
> Diffs
> -
> 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/2/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69661: Added resource provider information to v0 agent state endpoint.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69661/#review211804
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On Jan. 3, 2019, 3 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69661/
> ---
> 
> (Updated Jan. 3, 2019, 3 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource provider information to v0 agent state endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 6ef99fb66b46186c5e172ec43637fbf6f13731bd 
> 
> 
> Diff: https://reviews.apache.org/r/69661/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69694: Tester.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/
---

(Updated Jan. 9, 2019, 10:54 p.m.)


Review request for mesos.


Changes
---

test


Repository: mesos


Description (updated)
---

Tester.


Diffs (updated)
-

  configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 


Diff: https://reviews.apache.org/r/69694/diff/2/

Changes: https://reviews.apache.org/r/69694/diff/1-2/


Testing
---

Dont review - just a test!


Thanks,

Till Toenshoff

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211802
---


Fix it, then Ship it!




It looks like a great start. Thanks for adding the UI!


src/webui/app/controllers.js
Lines 697 (patched)


Instead of setting `agent.resource_providers` with 
`state.resource_providers` and mutating each item, how about initializing it to 
`{}` and constructing each item one by one, like what we do for 
`agent.frameworks`, for consistency?


- Chun-Hung Hsiao


On Jan. 7, 2019, 10:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> ---
> 
> (Updated Jan. 7, 2019, 10:33 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung 
> Hsiao.
> 
> 
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Displayed resource provider information in the Mesos webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 
>   src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/69662/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Ran a local test with a `./src/test-csi-plugin`.
> 
> 
> File Attachments
> 
> 
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69493/#review211803
---



FAIL: Failed to apply the dependent review: 67844.

Failed command: `python.exe .\support\apply-reviews.py -n -r 67844`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2734/mesos-review-69493

Relevant logs:

- 
[apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2734/mesos-review-69493/logs/apply-review-67844.log):

```
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69493/
> ---
> 
> (Updated Nov. 30, 2018, 4:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9036
> https://issues.apache.org/jira/browse/MESOS-9036
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/isolators/linux-seccomp.md PRE-CREATION 
>   docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e 
>   docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a 
> 
> 
> Diff: https://reviews.apache.org/r/69493/diff/4/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69695: Fixed compile error with Clang 3.5.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69695/#review211801
---



PASS: Mesos patch 69695 was successfully built and tested.

Reviews applied: `['69695']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2733/mesos-review-69695

- Mesos Reviewbot Windows


On Jan. 9, 2019, 2:37 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69695/
> ---
> 
> (Updated Jan. 9, 2019, 2:37 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed compile error with Clang 3.5.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
> 
> 
> Diff: https://reviews.apache.org/r/69695/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled Mesos using clang 3.5.0.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211800
---


Ship it!




Ship It!

- Meng Zhu


On Jan. 8, 2019, 6:53 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 8, 2019, 6:53 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorized function matcher would sometimes match a retry of
> the agent registration authorization. To ensure the matcher only
> matches the appropriate CREATE_VOLUME operation, we now specify
> that the argument should have the CREATE_VOLUME action.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/2/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211799
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69661', '69662']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2732/mesos-review-69662

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2732/mesos-review-69662/logs/mesos-tests.log):

```
I0109 20:38:42.886330  4032 master.cpp:11159] Removing task 
b35b955c-a9cc-48fd-834d-1fbc15463cfe with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 34bb7ca4-4c9e-4124-98b1-243d8107abeb- on 
agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.889328  4032 master.cpp:1271] Agent 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0109 20:38:42.889328  4032 master.cpp:3274] Disconnecting agent 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.889328  4032 master.cpp:3293] Deactivating agent 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.890322  2172 hierarchical.cpp:358] Removed framework 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-
I0109 20:38:42.890322  2172 hierarchical.cpp:802] Agent 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 deactivated
I0109 20:38:42.891335  3124 containerizer.cpp:2469] Destroying container 
56711a10-3af0-4094-842e-e62285fffa29 in RUNNING state
I0109 20:38:42.891335  3124 containerizer.cpp:3136] Transitioning the state of 
container 56711a10-3af0-4094-842e-e62285fffa29 from RUNNING to DESTROYING
I0109 20:38:42.891335  3124 launcher.cpp:161] Asked to destroy container 
56711a10-3af0-4094-842e-e62285fffa29
W0109 20:38:42.893324  8116 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=2992 to peer '192.10.1.4:56254': IO failed with error [ 
  OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (706 ms total)

[--] Global test environment tear-down
[==] 1082 tests from 104 test cases ran. (498198 ms total)
[  PASSED  ] 1081 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

code: The specified network name is no longer available.

W0109 20:38:42.893324  8116 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2480 to peer '192.10.1.4:56255': IO failed with error 
code: The specified network name is no longer available.

I0109 20:38:42.988771  2172 containerizer.cpp:2975] Container 
56711a10-3af0-4094-842e-e62285fffa29 has exited
I0109 20:38:43.017823  3024 master.cpp:] Master terminating
I0109 20:38:43.018806  7256 hierarchical.cpp:644] Removed agent 
34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0
I0109 20:38:43.276753  8116 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 7, 2019, 11:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> ---
> 
> (Updated Jan. 7, 2019, 11:33 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung 
> Hsiao.
> 
> 
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Displayed resource provider information in the Mesos webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 
>   src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/69662/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Ran a local test with a `./src/test-csi-plugin`.
> 
> 
> File Attachments
> 
> 
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
>   
> 

Re: Review Request 69687: Fixed flakiness of resource provider ContainerTerminationMetric test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69687/#review211798
---



PASS: Mesos patch 69687 was successfully built and tested.

Reviews applied: `['69687']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2731/mesos-review-69687

- Mesos Reviewbot Windows


On Jan. 7, 2019, 8:19 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69687/
> ---
> 
> (Updated Jan. 7, 2019, 8:19 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9130
> https://issues.apache.org/jira/browse/MESOS-9130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Plugin restarts can currently fail if the resource provider is killed
> before it has performed minimal reconciliation steps. This patch adds
> additional synchronization to ensure the plugin container can safely be
> killed to safely perform the desired test.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> e8ed20f818ed7f1a3ce15758ea3c366520443377 
> 
> 
> Diff: https://reviews.apache.org/r/69687/diff/1/
> 
> 
> Testing
> ---
> 
> * `make check`
> * ran test under stress for ~1000 iterations w/o issues
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69064/#review211797
---



PASS: Mesos patch 69064 was successfully built and tested.

Reviews applied: `['69071', '68795', '69422', '69421', '69064']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2729/mesos-review-69064

- Mesos Reviewbot Windows


On Jan. 8, 2019, 9:01 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69064/
> ---
> 
> (Updated Jan. 8, 2019, 9:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a set of unit test to verify that
> basic Master HTTP endpoints still work correctly
> under the presence of request caching.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 188a47017221a931d8b965a4af5e033b77e6ce4e 
>   src/tests/master_load_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69064/diff/7/
> 
> 
> Testing
> ---
> 
> Several internal CI runs.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69695: Fixed compile error with Clang 3.5.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69695/#review211794
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On Jan. 9, 2019, 2:37 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69695/
> ---
> 
> (Updated Jan. 9, 2019, 2:37 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed compile error with Clang 3.5.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
> 
> 
> Diff: https://reviews.apache.org/r/69695/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled Mesos using clang 3.5.0.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/#review211793
---


Ship it!




- Chun-Hung Hsiao


On Aug. 30, 2018, 5:09 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68565/
> ---
> 
> (Updated Aug. 30, 2018, 5:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-9193
> https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clang 3.5 incorrectly keeps const qualifiers when inferring the return
> types of lambdas if their return expressions are const-qualified. This
> patch makes the return types explicit to avoid this issue when compiling
> SLRP and its tests.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> fc48072aac531bac3cbffc3ba089b8dfa2a2f200 
>   src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed 
> 
> 
> Diff: https://reviews.apache.org/r/68565/diff/2/
> 
> 
> Testing
> ---
> 
> make check with clang 3.5.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69681: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69681/#review211792
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69681']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2730/mesos-review-69681

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2730/mesos-review-69681/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69680/#review211791
---



PASS: Mesos patch 69680 was successfully built and tested.

Reviews applied: `['69680']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2727/mesos-review-69680

- Mesos Reviewbot Windows


On Jan. 7, 2019, 12:25 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69680/
> ---
> 
> (Updated Jan. 7, 2019, 12:25 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-9434
> https://issues.apache.org/jira/browse/MESOS-9434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After a framework was removed and has unacknowledged operations status
> updates, it was impossible to remove terminal operations as nobody could
> acknowledge them.
> 
> In this patch we make the master acknowledge operation status updates
> for frameworks it knows are removed so that e.g., terminal operations
> can be removed. Since masters do not persist completed frameworks this
> is not reliable (e.g., an agent was partitioned for a long time and
> still tracks a completed framework's `FrameworkInfo`, and comes back
> only after the master knowing about the framework's completion has
> failed over). We merely extend the existing master behavior (e.g., send
> `ShutdownFrameworkMessage` to all currently registered agents) to
> operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69680/diff/1/
> 
> 
> Testing
> ---
> 
> * `make check`
> * tested on a number of configurations in internal CI
> * ran added test in repetition, both with and without additional stress
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211790
---


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp
Lines 1385-1386 (patched)


4 space ahead if you make it to the newline after (

I will fix it for you


- Gilbert Song


On Jan. 7, 2019, 7:27 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 7:27 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/6/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69669/#review211789
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69575', '69597', '69669']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2728/mesos-review-69669

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2728/mesos-review-69669/logs/mesos-tests.log):

```
I0109 18:58:57.001946  5572 master.cpp:1271] Agent 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-S0 at slave(468)@192.10.1.4:52219 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0109 18:58:57.001946  5572 master.cpp:3274] Disconnecting agent 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-S0 at slave(468)@192.10.1.4:52219 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:58:57.002950  5572 master.cpp:3293] Deactivating agent 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-S0 at slave(468)@192.10.1.4:52219 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:58:57.002950  6192 hierarchical.cpp:358] Removed framework 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-
I0109 18:58:57.003962  6192 hierarchical.cpp:802] Agent 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-S0 deactivated
I0109 18:58:57.003962  5572 containerizer.cpp:2463] Destroying container 
d726a03e-24ba-426d-95fd-07dcf876572d in RUNNING state
I0109 18:58:57.003962  5572 containerizer.cpp:3130] Transitioning the state of 
container d726a03e-24ba-426d-95fd-07dcf876572d from RUNNING to DESTROYING
I0109 18:58:57.004971  5572 launcher.cpp:161] Asked to destroy container 
d726a03e-24ba-426d-95fd-07dcf876572d
W0109 18:58:57.004971  6352 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=1788 to peer '192.10.1.4:54061': IO failed with error 
code: The specified network name is no longer available.

W0109 18:58:57.005954  6352 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=1800 to peer '192.10.1.4:54060': IO failed with error 
code: The specified network name is no longer available.

I0109 18:58:57.084885  6192 containerizer.cpp:2969] Container 
d726a03e-24ba-426d-95fd-07dcf876572d has exited
I0109 18:58:57.113801  6064 master.cpp:11[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (686 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (704 ms total)

[--] Global test environment tear-down
[==] 1086 tests from 104 test cases ran. (499593 ms total)
[  PASSED  ] 1084 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/1, where 
GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

11] Master terminating
I0109 18:58:57.115829  5176 hierarchical.cpp:644] Removed agent 
b4e6f5db-e8a0-4bbc-bad7-f7400b2e66b5-S0
I0109 18:58:57.374857  6352 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 4, 2019, 4:57 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69669/
> ---
> 
> (Updated Jan. 4, 2019, 4:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8783
> https://issues.apache.org/jira/browse/MESOS-8783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When an agent is being marked as unreachable due to missing
> the reregistration timeout, all operations on that agent
> are implicilty transitioned to status `OPERATION_UNREACHABLE`.
> 
> This commit adds an explicit notification for this transition
> to frameworks which opted-in to operation feedback.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 99549ab857b16d722f0dd991f98dbe54e9ed19a1 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
>   src/tests/api_tests.cpp b6064cd749e42e45c2b471c71e9769a41b59f726 
> 
> 
> Diff: https://reviews.apache.org/r/69669/diff/1/
> 
> 
> Testing
> ---
> 
> Internal CI run.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Andrei Budnik]

> On Jan. 9, 2019, 5:39 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1391-1397 (patched)
> > 
> >
> > style nits, how about:
> > 
> > ```
> >   return result
> > .onAny()
> > ```

I've removed `Future result`.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211783
---


On Jan. 7, 2019, 3:27 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 3:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/6/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211787
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69689']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2725/mesos-review-69689

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2725/mesos-review-69689/logs/mesos-tests.log):

```
I0109 18:33:53.920020  7624 master.cpp:11159] Removing task 
bb709bc3-fb02-44ad-aad0-3af745cbcddf with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 6c0e305e-b813-4541-a4b2-0c15c329e493- on 
agent 6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.923017  1924 master.cpp:1271] Agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0109 18:33:53.924015  1924 master.cpp:3274] Disconnecting agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.924015  1924 master.cpp:3293] Deactivating agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.924015  6220 hierarchical.cpp:358] Removed framework 
6c0e305e-b813-4541-a4b2-0c15c329e493-
I0109 18:33:53.924015  6220 hierarchical.cpp:802] Agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 deactivated
I0109 18:33:53.925010  2324 containerizer.cpp:2463] Destroying container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc in RUNNING state
I0109 18:33:53.926017  2324 containerizer.cpp:3130] Transitioning the state of 
container 01baeeb2-14a8-4dcb-a678-e39bcefc84fc from RUNNING to DESTROYING
I0109 [   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (682 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (700 ms total)

[--] Global test environment tear-down
[==] 1082 tests from 104 test cases ran. (498304 ms total)
[  PASSED  ] 1081 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

18:33:53.926017  2324 launcher.cpp:161] Asked to destroy container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc
W0109 18:33:53.927011  7424 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2072 to peer '192.10.1.6:53768': IO failed with error 
code: The specified network name is no longer available.

W0109 18:33:53.928010  7424 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=1800 to peer '192.10.1.6:53767': IO failed with error 
code: The specified network name is no longer available.

I0109 18:33:54.016850  1924 containerizer.cpp:2969] Container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc has exited
I0109 18:33:54.044796  6104 master.cpp:] Master terminating
I0109 18:33:54.046785  2144 hierarchical.cpp:644] Removed agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0
I0109 18:33:54.276785  7424 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 9, 2019, 2:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 9, 2019, 2:53 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorized function matcher would sometimes match a retry of
> the agent registration authorization. To ensure the matcher only
> matches the appropriate CREATE_VOLUME operation, we now specify
> that the argument should have the CREATE_VOLUME action.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/2/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69615: Disable containerizer ptrace attach.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69615/#review211786
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69615']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2726/mesos-review-69615

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2726/mesos-review-69615/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211784
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 7, 2019, 7:27 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 7:27 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211783
---




src/slave/containerizer/mesos/containerizer.cpp
Lines 1391-1397 (patched)


style nits, how about:

```
  return result
.onAny()
```


- Gilbert Song


On Jan. 7, 2019, 7:27 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 7:27 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211782
---



PASS: Mesos patch 69684 was successfully built and tested.

Reviews applied: `['69684']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2723/mesos-review-69684

- Mesos Reviewbot Windows


On Jan. 7, 2019, 3:27 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 3:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review211781
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 69701`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2724/mesos-review-69701

Relevant logs:

- 
[apply-review-69701.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2724/mesos-review-69701/logs/apply-review-69701.log):

```
error: patch failed: support/verify-reviews.py:93
error: support/verify-reviews.py: patch does not apply
```

- Mesos Reviewbot Windows


On Jan. 9, 2019, 7:46 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69701/
> ---
> 
> (Updated Jan. 9, 2019, 7:46 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improves error handling in `shell()` and decodes what is returned
> by `urllib.request.urlopen` when doing API calls.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 04ed7fe9022f0758389bd76c21e48d0cd998 
> 
> 
> Diff: https://reviews.apache.org/r/69701/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69694: Tester.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69694/#review211780
---



PASS: Mesos patch 69694 was successfully built and tested.

Reviews applied: `['69694']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2722/mesos-review-69694

- Mesos Reviewbot Windows


On Jan. 8, 2019, 9:10 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69694/
> ---
> 
> (Updated Jan. 8, 2019, 9:10 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Dont review - just a test!
> 
> 
> Diffs
> -
> 
>   configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 
> 
> 
> Diff: https://reviews.apache.org/r/69694/diff/1/
> 
> 
> Testing
> ---
> 
> Dont review - just a test!
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211779
---


Fix it, then Ship it!





src/webui/app/controllers.js
Lines 714-717 (patched)


Is this something we do elsewhere with IDs? Is it because elsewhere we 
don't have value in the json? Feels unfortunate to have to mutate the structure 
of the json (I know we have done that in a few places but this seems like a 
mutation of structure rather than adding things)

Maybe at the very least if we do think we should do this here, we can add 
some context about it (e.g. json has value for this id but not others)



src/webui/app/controllers.js
Lines 722-723 (patched)


This seems not very readable (or at least I struggled a bit with it), can 
we use underscore js clone?

https://underscorejs.org/#clone

```
provider.total_resources_full = _.clone(provider.total_resources);
```


- Benjamin Mahler


On Jan. 7, 2019, 10:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> ---
> 
> (Updated Jan. 7, 2019, 10:33 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung 
> Hsiao.
> 
> 
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Displayed resource provider information in the Mesos webui.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 
>   src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/69662/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Ran a local test with a `./src/test-csi-plugin`.
> 
> 
> File Attachments
> 
> 
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
>   
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review211778
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 9, 2019, 3:46 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69701/
> ---
> 
> (Updated Jan. 9, 2019, 3:46 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improves error handling in `shell()` and decodes what is returned
> by `urllib.request.urlopen` when doing API calls.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 04ed7fe9022f0758389bd76c21e48d0cd998 
> 
> 
> Diff: https://reviews.apache.org/r/69701/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 69701: Improved debuggability of `verify-reviews.py`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-9514
https://issues.apache.org/jira/browse/MESOS-9514


Repository: mesos


Description
---

Improves error handling in `shell()` and decodes what is returned
by `urllib.request.urlopen` when doing API calls.


Diffs
-

  support/verify-reviews.py 04ed7fe9022f0758389bd76c21e48d0cd998 


Diff: https://reviews.apache.org/r/69701/diff/1/


Testing
---


Thanks,

Armand Grillet

Re: Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69698/#review211777
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 9, 2019, 9:35 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69698/
> ---
> 
> (Updated Jan. 9, 2019, 9:35 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This improves the errors returned by reviewbot so that we can
> more easily see which issues are on the nodes running our CI.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d 
> 
> 
> Diff: https://reviews.apache.org/r/69698/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

[GitHub] dlazarus opened a new pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes

[GitBox]

dlazarus opened a new pull request #324: MESOS-9499 extended URI syntax to 
support any Zookeeper authentication schemes
URL: https://github.com/apache/mesos/pull/324
 
 
   Zookeeper URL now optionally can have syntax:
   zk://zk_auth_scheme!zk_auth_data@host:port/path
   
   If there is not "!" in URL it works as before with digest auth scheme.
   
   For example, I use it with our Zk auth plugin like this:
   zk://simple!login:password@127.0.0.1:2181/mesos
   Here "simple" is an authentication scheme name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69697/#review211776
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 9, 2019, 9:30 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69697/
> ---
> 
> (Updated Jan. 9, 2019, 9:30 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reverts the improvements made on the support script `verify-reviews.py`
> in 3badf7179992e61f30f5a79da9d481dd451c7c2f. Sadly, these changes have
> broken our Azure based Mesos CI as seen in MESOS-9514.
> 
> After comparing the code before and after the commit, we can see that
> the line failing in CI, `HEAD = shell("git rev-parse HEAD")`, is
> misplaced. It was previously located in the exit process in the
> `cleanup()` function and it is now back there, surrounded by a
> try/catch for error handling.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d 
> 
> 
> Diff: https://reviews.apache.org/r/69697/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

[Andrei Budnik]

> On Jan. 8, 2019, 8:04 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1366 (patched)
> > 
> >
> > Just realize .repair may not be sufficient because it could only handle 
> > failure case but discarded case. It is possible that `prepare(containerId, 
> > None())` just returns a discarded future and propagate that discarded to 
> > all chained .then
> > 
> > Let's use .onAny instead and make the code more clear and explicit:
> > 
> > ```
> >   Future result = prepare()
> > .then(extractContainerIO)
> > .then(_launch);
> > 
> >   TODO: remove this .onAny once we have FD wrapper.  
> >   return result
> > // extractContainerIO may be called twice, but ok sometimes it is 
> > no-op
> > .onAny(extractContainerIO)

I've refactored a bit this code to remove duplicated code and then added 
`.any(extractContainerIO)` handler.
> TODO: remove this .onAny once we have FD wrapper.

If we had FD wrapper, we would need to call `extractContainerIO` to remove a 
data structure which owns FDs (current `FDWrapper`). So, nothing changes here 
even after introducing FD wrapper in `libprocess`.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69684/#review211769
---


On Jan. 7, 2019, 3:27 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69684/
> ---
> 
> (Updated Jan. 7, 2019, 3:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6632
> https://issues.apache.org/jira/browse/MESOS-6632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the period between IOSB server is up and container process exec,
> if the containerizer launch returns failure or discarded, the FD used
> for signaling from the container process to the IOSB finish redirect
> will be leaked, which would cause the IOSB stuck at `io::redirect`
> forever. It would block the containerizer from cleaning up this
> container at IOSB.
> 
> This issue could be exposed if there are frequent check containers
> launch on an agent with heavy loads.
> 
> This patch fixes the issue by handling discard of a `launch` future,
> so the container IO is cleaned up and therefore all FDs are closed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
> 
> 
> Diff: https://reviews.apache.org/r/69684/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing:
> 
> Add `return Failure("Test!");` to `IOSwitchboard::_prepare()`: 
> https://github.com/apache/mesos/blob/7a378597d6a4359de0b1eabb563d4c12cdb4290e/src/slave/containerizer/mesos/io/switchboard.cpp#L657
> 
> 1) Compile without this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to a hanging IOSB (15 seconds timeout) after trying to 
> destroy IOSB on the HTTP error "Test!"
> 
> 1) Compile with this patch applied
> 2) Run `src/mesos-tests --verbose 
> --gtest_filter=ContentType/AgentAPITest.AttachContainerInputRepeat/0`
> 3) This test fails due to the HTTP error "Test!" and terminates immediately 
> (as expected)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69698/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-9514
https://issues.apache.org/jira/browse/MESOS-9514


Repository: mesos


Description
---

This improves the errors returned by reviewbot so that we can
more easily see which issues are on the nodes running our CI.


Diffs
-

  support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d 


Diff: https://reviews.apache.org/r/69698/diff/1/


Testing
---


Thanks,

Armand Grillet

Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69697/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-9514
https://issues.apache.org/jira/browse/MESOS-9514


Repository: mesos


Description
---

Reverts the improvements made on the support script `verify-reviews.py`
in 3badf7179992e61f30f5a79da9d481dd451c7c2f. Sadly, these changes have
broken our Azure based Mesos CI as seen in MESOS-9514.

After comparing the code before and after the commit, we can see that
the line failing in CI, `HEAD = shell("git rev-parse HEAD")`, is
misplaced. It was previously located in the exit process in the
`cleanup()` function and it is now back there, surrounded by a
try/catch for error handling.


Diffs
-

  support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d 


Diff: https://reviews.apache.org/r/69697/diff/1/


Testing
---


Thanks,

Armand Grillet