Re: Review Request 70577: Changed Agent V1 GET_STATE for any completed executor's tasks.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70577/#review214974
---



Hm.. at first glance it seems odd to put the special logic in the http response 
handler instead of just having the internal state reflect that the task is 
terminal (after all.. it is terminated). Cant't the agnet move the tasks to an 
appropriate terminal state prior to "completing" the executor?

That way, we also will know that the endpoints are accurately reflecting the 
in-memory state.

- Benjamin Mahler


On May 1, 2019, 2:13 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70577/
> ---
> 
> (Updated May 1, 2019, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9750
> https://issues.apache.org/jira/browse/MESOS-9750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It is possible for a completed executor to have a non-terminal task
> (based on last status update).  For example, during graceful shutdown
> of an agent, graceful shutdown of an executor will race with the
> agent's shutdown grace period.  If the executor does not send a
> TASK_KILLED in time, the agent will still mark the executor as complete
> and kill it.
> 
> After agent recovery, these completed executors will show up in an
> agent's /state and GET_STATE responses.  In GET_STATE however, any
> non-terminal tasks will appear under `launched_tasks`.  This may
> provide misleading information about the total number of tasks running.
> 
> This commit adds extra logic to place these non-terminal tasks under
> the `terminated_tasks` category, and adds a regression test.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70577/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> make 
> src/mesos-tests --gtest_filter="*GetStateWithNonTerminalCompletedTask*" 
> --verbose
> ```
> 
> TODO: more testing
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 70577: Changed Agent V1 GET_STATE for any completed executor's tasks.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70577/
---

Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.


Bugs: MESOS-9750
https://issues.apache.org/jira/browse/MESOS-9750


Repository: mesos


Description
---

It is possible for a completed executor to have a non-terminal task
(based on last status update).  For example, during graceful shutdown
of an agent, graceful shutdown of an executor will race with the
agent's shutdown grace period.  If the executor does not send a
TASK_KILLED in time, the agent will still mark the executor as complete
and kill it.

After agent recovery, these completed executors will show up in an
agent's /state and GET_STATE responses.  In GET_STATE however, any
non-terminal tasks will appear under `launched_tasks`.  This may
provide misleading information about the total number of tasks running.

This commit adds extra logic to place these non-terminal tasks under
the `terminated_tasks` category, and adds a regression test.


Diffs
-

  src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d 
  src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 


Diff: https://reviews.apache.org/r/70577/diff/1/


Testing
---

```
make 
src/mesos-tests --gtest_filter="*GetStateWithNonTerminalCompletedTask*" 
--verbose
```

TODO: more testing


Thanks,

Joseph Wu

Re: Review Request 70497: Optimize the random sorter with random sampling.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70497/#review214973
---



Bad review!

Reviews applied: [70497, 70576, 70419, 70418]

Error:
Circular dependency detected for review 70419.Please fix the 'depends_on' field.

- Mesos Reviewbot


On May 1, 2019, 1:36 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70497/
> ---
> 
> (Updated May 1, 2019, 1:36 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9725
> https://issues.apache.org/jira/browse/MESOS-9725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch optimizes the random sorter by avoiding
> clients shuffling. The sorter now does random sampling
> as the caller asks for the next client.
> 
> The random sampling works in two steps. Clients with the same
> relative weights are grouped together. In the first phase, we
> randomly pick a group of clients. This requires the generation
> of a weighted random number. In the second phase, a client within
> the group is picked. Since all clients in the group have the same
> weight, this can be done in constant time. This two step approach
> minimizes the cost of generating weighted random number which
> could be expensive given the size of the weights.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/random/sorter.hpp 
> 55e22d7705f163fe47d5aa47416ee0714c5a87c0 
>   src/master/allocator/sorter/random/sorter.cpp 
> 813f5b55d38dd9fa822de53ee944c3f72251a69d 
> 
> 
> Diff: https://reviews.apache.org/r/70497/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> Benchmarking: ran 
> `QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5`
>  with optimized build
> 
> Before:
> 
> Added 3000 agents in 101.884509ms
> Added 3000 frameworks in 19.711779311secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
> Made 3856 allocations in 16.283607645secs
> Made 0 allocation in 16.31197771secs
> 
> After r/70419, r/70576 and r/70497 :
> 
> Added 3000 agents in 87.147084ms
> Added 3000 frameworks in 19.246494668secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
> Made 3872 allocations in 12.230518989secs
> Made 0 allocation in 12.012211914secs
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70576: Made `RandomSorter::Node::clientPath()` return a const reference.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70576/#review214972
---



FAIL: Failed to get dependent review IDs for the current patch.

Failed command: `python.exe D:\DCOS\mesos\mesos\support\get-review-ids.py -r 
70576 -o C:\Users\jenkins\AppData\Local\Temp\mesos_dependent_review_ids`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3301/mesos-review-70576

Relevant logs:

- 
[get-review-ids.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3301/mesos-review-70576/logs/get-review-ids.log):

```
Dependent review: https://reviews.apache.org/api/review-requests/70419/
Dependent review: https://reviews.apache.org/api/review-requests/70418/
The review request 70418 is already submitted
Dependent review: https://reviews.apache.org/api/review-requests/70419/
Traceback (most recent call last):
  File "D:\DCOS\mesos\mesos\support\get-review-ids.py", line 62, in 
main()
  File "D:\DCOS\mesos\mesos\support\get-review-ids.py", line 51, in main
review_ids = handler.get_dependent_review_ids(review_request)
  File "D:\DCOS\mesos\mesos\support\common.py", line 93, in 
get_dependent_review_ids
self._review_ids(review_request, review_ids)
  File "D:\DCOS\mesos\mesos\support\common.py", line 62, in _review_ids
self._review_ids(dependent_review, review_ids)
  File "D:\DCOS\mesos\mesos\support\common.py", line 62, in _review_ids
self._review_ids(dependent_review, review_ids)
  File "D:\DCOS\mesos\mesos\support\common.py", line 61, in _review_ids
"field." % review_request["id"])
common.ReviewError: Circular dependency detected for review 70418. Please fix 
the 'depends_on' field.
```

- Mesos Reviewbot Windows


On April 30, 2019, 6:19 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70576/
> ---
> 
> (Updated April 30, 2019, 6:19 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This avoids a string copy.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 91a9d668b87079158f7072780dc86bb08865166e 
>   src/master/allocator/sorter/random/sorter.hpp 
> 55e22d7705f163fe47d5aa47416ee0714c5a87c0 
>   src/master/allocator/sorter/random/sorter.cpp 
> 813f5b55d38dd9fa822de53ee944c3f72251a69d 
> 
> 
> Diff: https://reviews.apache.org/r/70576/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> See benchmark result in https://reviews.apache.org/r/70497/
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70497: Optimize the random sorter with random sampling.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70497/
---

(Updated April 30, 2019, 6:36 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Changes
---

Rebased and updated benchmark result.


Bugs: MESOS-9725
https://issues.apache.org/jira/browse/MESOS-9725


Repository: mesos


Description
---

This patch optimizes the random sorter by avoiding
clients shuffling. The sorter now does random sampling
as the caller asks for the next client.

The random sampling works in two steps. Clients with the same
relative weights are grouped together. In the first phase, we
randomly pick a group of clients. This requires the generation
of a weighted random number. In the second phase, a client within
the group is picked. Since all clients in the group have the same
weight, this can be done in constant time. This two step approach
minimizes the cost of generating weighted random number which
could be expensive given the size of the weights.


Diffs (updated)
-

  src/master/allocator/sorter/random/sorter.hpp 
55e22d7705f163fe47d5aa47416ee0714c5a87c0 
  src/master/allocator/sorter/random/sorter.cpp 
813f5b55d38dd9fa822de53ee944c3f72251a69d 


Diff: https://reviews.apache.org/r/70497/diff/2/

Changes: https://reviews.apache.org/r/70497/diff/1-2/


Testing (updated)
---

make check

Benchmarking: ran 
`QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5`
 with optimized build

Before:

Added 3000 agents in 101.884509ms
Added 3000 frameworks in 19.711779311secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
Made 3856 allocations in 16.283607645secs
Made 0 allocation in 16.31197771secs

After r/70419, r/70576 and r/70497 :

Added 3000 agents in 87.147084ms
Added 3000 frameworks in 19.246494668secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
Made 3872 allocations in 12.230518989secs
Made 0 allocation in 12.012211914secs


Thanks,

Meng Zhu

Re: Review Request 70576: Made `RandomSorter::Node::clientPath()` return a const reference.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70576/#review214971
---



Bad review!

Reviews applied: [70576, 70419, 70418]

Error:
Circular dependency detected for review 70419.Please fix the 'depends_on' field.

- Mesos Reviewbot


On April 30, 2019, 6:19 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70576/
> ---
> 
> (Updated April 30, 2019, 6:19 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This avoids a string copy.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 91a9d668b87079158f7072780dc86bb08865166e 
>   src/master/allocator/sorter/random/sorter.hpp 
> 55e22d7705f163fe47d5aa47416ee0714c5a87c0 
>   src/master/allocator/sorter/random/sorter.cpp 
> 813f5b55d38dd9fa822de53ee944c3f72251a69d 
> 
> 
> Diff: https://reviews.apache.org/r/70576/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> See benchmark result in https://reviews.apache.org/r/70497/
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 70576: Made `RandomSorter::Node::clientPath()` return a const reference.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70576/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

This avoids a string copy.


Diffs
-

  src/master/allocator/sorter/drf/sorter.hpp 
91a9d668b87079158f7072780dc86bb08865166e 
  src/master/allocator/sorter/random/sorter.hpp 
55e22d7705f163fe47d5aa47416ee0714c5a87c0 
  src/master/allocator/sorter/random/sorter.cpp 
813f5b55d38dd9fa822de53ee944c3f72251a69d 


Diff: https://reviews.apache.org/r/70576/diff/1/


Testing
---

make check

See benchmark result in https://reviews.apache.org/r/70497/


Thanks,

Meng Zhu

Re: Review Request 70419: Refactor `Sorter::sorted()` to return a stream of clients.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70419/
---

(Updated April 30, 2019, 6:17 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Used PIMPL to return `SortedClients` by value.


Summary (updated)
-

Refactor `Sorter::sorted()` to return a stream of clients.


Bugs: MESOS-9722
https://issues.apache.org/jira/browse/MESOS-9722


Repository: mesos


Description (updated)
---

This patch refactors `Sorter::sorted` to return
`class SortedClients` instead of a whole vector.
Callers can then use SortedClients::next() to get the
next sorted client. This paves the way for sort optimization
where sorting of the whole clients can be lazily done as callers
ask for the next client.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
64a076ddd29711437d539a06bb0470755828cc87 
  src/master/allocator/sorter/drf/sorter.hpp 
91a9d668b87079158f7072780dc86bb08865166e 
  src/master/allocator/sorter/drf/sorter.cpp 
9367469132e426f0b4b66a80ad300c157fba6bf2 
  src/master/allocator/sorter/random/sorter.hpp 
55e22d7705f163fe47d5aa47416ee0714c5a87c0 
  src/master/allocator/sorter/random/sorter.cpp 
813f5b55d38dd9fa822de53ee944c3f72251a69d 
  src/master/allocator/sorter/sorter.hpp 
d56a1166a9e82b034564842ac071874ec2885004 
  src/tests/sorter_tests.cpp 9aee2b41b0d3c978bca6bd2d7ad28e32506a648a 


Diff: https://reviews.apache.org/r/70419/diff/4/

Changes: https://reviews.apache.org/r/70419/diff/3-4/


Testing (updated)
---

make check

See benchmark result in https://reviews.apache.org/r/70497/


Thanks,

Meng Zhu

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214967
---


Ship it!




Ship It!

- Gilbert Song


On April 29, 2019, 11:39 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 11:39 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214966
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70567']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3299/mesos-review-70567

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3299/mesos-review-70567/logs/mesos-tests.log):

```
I0430 20:30:29.901481 90928 master.cpp:3312] Disconnecting agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 at slave(504)@192.10.1.4:52888 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 20:30:29.901481 90928 master.cpp:3331] Deactivating agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 at slave(504)@192.10.1.4:52888 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 20:30:29.901481 87944 hierarchical.cpp:392] Removed framework 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-
I0430 20:30:29.902482 87944 hierarchical.cpp:829] Agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 deactivated
I0430 20:30:29.903481 87944 containerizer.cpp:2586] Destroying container 
9619350c-f543-47be-aabe-83458a2fce93 in RUNNING state
I0430 2[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (785 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (805 ms total)

[--] Global test environment tear-down
[==] 1166 tests from 109 test cases ran. (595892 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

0:30:29.903481 87944 containerizer.cpp:3288] Transitioning the state of 
container 9619350c-f543-47be-aabe-83458a2fce93 from RUNNING to DESTROYING
I0430 20:30:29.904494 87944 launcher.cpp:161] Asked to destroy container 
9619350c-f543-47be-aabe-83458a2fce93
W0430 20:30:29.905477 89680 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=9844 to peer '192.10.1.4:55300': IO failed with error 
code: The specified network name is no longer available.

W0430 20:30:29.905477 89680 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=9744 to peer '192.10.1.4:55301': IO failed with error 
code: The specified network name is no longer available.

I0430 20:30:29.997475 90928 containerizer.cpp:3127] Container 
9619350c-f543-47be-aabe-83458a2fce93 has exited
I0430 20:30:30.028479 82408 master.cpp:1135] Master terminating
I0430 20:30:30.029481 90928 hierarchical.cpp:680] Removed agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0
I0430 20:30:31.452474 89680 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214965
---



Patch looks great!

Reviews applied: [70567]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

[GitHub] [mesos] kaysoky commented on issue #334: Remove u8 prefix to fit C++20

[GitBox]

kaysoky commented on issue #334: Remove u8 prefix to fit C++20
URL: https://github.com/apache/mesos/pull/334#issuecomment-488061528
 
 
   Building on @rukletsov 's comment in the JIRA, this change reverts a 
previous commit (https://reviews.apache.org/r/58430/), which will break the 
Windows build on prior (released) MSVCs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214963
---


Fix it, then Ship it!




LGTM


src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
Lines 35 (patched)


s/the/The/


- Vinod Kone


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70566: Prevented logging of coverity token in CI.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70566/#review214962
---


Ship it!




Ship It!

- Alexander Rukletsov


On April 29, 2019, 9:12 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70566/
> ---
> 
> (Updated April 29, 2019, 9:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prevented logging of coverity token in CI.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 0c6988d246dee711bb78580efd7b690940c9bb63 
> 
> 
> Diff: https://reviews.apache.org/r/70566/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214961
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70567']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3297/mesos-review-70567

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3297/mesos-review-70567/logs/mesos-tests.log):

```
I0430 11:41:34.875912 88944 master.cpp:3312] Disconnecting agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 at slave(504)@192.10.1.4:62292 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 11:41:34.875912 88944 master.cpp:3331] Deactivating agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 at slave(504)@192.10.1.4:62292 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 11:41:34.875912 87492 hierarchical.cpp:392] Removed framework 
44ba2b61-f29a-48b5-af60-900144842795-
I0430 11:41:34.875912 87492 hierarchical.cpp:829] Agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 deactivated
I0430 11:41:34.891489 77184 containerizer.cpp:2586] Destroying container 
99ac903c-8c52-4462-8d58-31c250a935fb in RUNNING state
I0430 11:41:34.891489 77184 containerizer.cpp:3288] Transitioning the state of 
container 99ac903c-8c52-4462-8d58-31c250a935fb from RUNNING to DESTROYING
I0430 11:41:34.891489 77184 launcher.cpp:161] Asked to destroy container 
99ac903c[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (861 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (879 ms total)

[--] Global test environment tear-down
[==] 1166 tests from 109 test cases ran. (607272 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

-8c52-4462-8d58-31c250a935fb
W0430 11:41:34.891489 84244 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=4808 to peer '192.10.1.4:64715': IO failed with error 
code: The specified network name is no longer available.

W0430 11:41:34.891489 84244 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4776 to peer '192.10.1.4:64716': IO failed with error 
code: The specified network name is no longer available.

I0430 11:41:34.985258 86352 containerizer.cpp:3127] Container 
99ac903c-8c52-4462-8d58-31c250a935fb has exited
I0430 11:41:35.016525 87160 master.cpp:1135] Master terminating
I0430 11:41:35.016525 87696 hierarchical.cpp:680] Removed agent 
44ba2b61-f29a-48b5-af60-900144842795-S0
I0430 11:41:37.097225 84244 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70564: Fixed a performance issue in the random sorter.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70564/#review214960
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70564']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3295/mesos-review-70564

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3295/mesos-review-70564/logs/mesos-tests.log):

```
I0430 10:25:36.689410 83564 master.cpp:3312] Disconnecting agent 
4af6c3a4-e700-47a3-9216-aa0496307f57-S0 at slave(504)@192.10.1.4:59624 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 10:25:36.689410 83564 master.cpp:3331] Deactivating agent 
4af6c3a4-e700-47a3-9216-aa0496307f57-S0 at slave(504)@192.10.1.4:59624 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 10:25:36.689410 82088 hierarchical.cpp:392] Removed framework 
4af6c3a4-e700-47a3-9216-aa0496307f57-
I0430 10:25:36.689410 82088 hierarchical.cpp:829] Agent 
4af6c3a4-e700-47a3-9216-aa0496307f57-S0 deactivated
I0430 10:25:36.691385 88920 containerizer.cpp:2586] Destroying container 
959b4cc7-e242-44a2-8290-d8cd5175f5dd in RUNNING state
I0430 10:25:36.691385 88920 containerizer.cpp:3288] Transitioning the state of 
container 959b4cc7-e242-44a2-8290-d8cd5175f5dd from RUNNING to DESTROYING
I0430 10:25:36.691385 88920 launcher.cpp:161] Asked to destroy container 
959b4cc7-e242-44a2-8290-d8cd5175f5dd
W0430 10:25:36.692384 85964 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5232 to peer '192.10.1.4:61999': IO failed with error 
code: The specified network name is no longer available.

W0430[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (790 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (807 ms total)

[--] Global test environment tear-down
[==] 1166 tests from 109 test cases ran. (605058 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

 10:25:36.693365 85964 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4168 to peer '192.10.1.4:62000': IO failed with error 
code: The specified network name is no longer available.

I0430 10:25:36.710387 82088 containerizer.cpp:3127] Container 
959b4cc7-e242-44a2-8290-d8cd5175f5dd has exited
I0430 10:25:36.742403 88308 master.cpp:1135] Master terminating
I0430 10:25:36.743381 83564 hierarchical.cpp:680] Removed agent 
4af6c3a4-e700-47a3-9216-aa0496307f57-S0
I0430 10:25:38.289382 85964 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 29, 2019, 5:28 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70564/
> ---
> 
> (Updated April 29, 2019, 5:28 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a performance issue in the random sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/random/sorter.cpp 
> f4132bbacd590389ae156f964d2463e79db5e27f 
> 
> 
> Diff: https://reviews.apache.org/r/70564/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> Benchmarking:
> Optimized build with 
> QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5
> 
> Before:
> Added 3000 agents in 88.759226ms
> Added 3000 frameworks in 19.519956346secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
> Made 3856 allocations in 19.091583161secs
> Made 0 allocation in 18.428433277secs
> 
> After:
> 
> Added 3000 agents in 87.972155ms
> Added 3000 frameworks in 19.372715548secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
> Made 3856 allocations in 15.846013158secs
> Made 0 allocation in 15.756238099secs
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

[GitHub] [mesos] QuellaZhang opened a new pull request #334: Remove u8 prefix to fit C++20

[GitBox]

QuellaZhang opened a new pull request #334: Remove u8 prefix to fit C++20
URL: https://github.com/apache/mesos/pull/334
 
 
   Related to https://issues.apache.org/jira/browse/MESOS-9718.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services