Re: Review Request 70824: Fixed test `QuotaRoleAllocateNonQuotaResource`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70824/#review215783 --- Patch looks great! Reviews applied: [70824] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 11, 2019, 12:53 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70824/ > --- > > (Updated June 11, 2019, 12:53 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9835 > https://issues.apache.org/jira/browse/MESOS-9835 > > > Repository: mesos > > > Description > --- > > The test was failing because: > > After `agent3` is added, it misses a settle call where the allocation > of `agent3` is racy. > > In addition, after MESOS-8456, the allocator now offers non-quota > resources on an agent (even that means "chopping") on top of a role's > satisfied guarantees instead of skipping the agent all-together. > > This patch fixes the test by expecting the right amount of resources > to be allocated from `agent3`. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > bfea34e17151327e8c9590ecb8da74968d086ca0 > > > Diff: https://reviews.apache.org/r/70824/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 70827: Improved container-specific cgroups test by checking `cpu.shares`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70827/ --- (Updated June 11, 2019, 10:48 a.m.) Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Bugs: MESOS-9769 https://issues.apache.org/jira/browse/MESOS-9769 Repository: mesos Description --- This is to ensure the symbolic links (see below as an example) we create for the container exist. ln -s /sys/fs/cgroup/cpu,cpuacct /sys/fs/cgroup/cpu Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp 957f72d78f9ab0bf2775687915099c0109dac6e1 Diff: https://reviews.apache.org/r/70827/diff/1/ Testing (updated) --- sudo make check The tests updated in this patch would fail without the previous patch. Thanks, Qian Zhang
Review Request 70827: Improved container-specific cgroups test by checking `cpu.shares`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70827/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Bugs: MESOS-9769 https://issues.apache.org/jira/browse/MESOS-9769 Repository: mesos Description --- This is to ensure the symbolic links (see below as an example) we create for the container exist. ln -s /sys/fs/cgroup/cpu,cpuacct /sys/fs/cgroup/cpu Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp 957f72d78f9ab0bf2775687915099c0109dac6e1 Diff: https://reviews.apache.org/r/70827/diff/1/ Testing --- Thanks, Qian Zhang
Review Request 70826: Supported file operations for command tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70826/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Bugs: MESOS-9769 https://issues.apache.org/jira/browse/MESOS-9769 Repository: mesos Description --- Supported file operations for command tasks. Diffs - src/launcher/executor.cpp fa4bcaad9ac36bf380484dadb14d0b0a86a30aae Diff: https://reviews.apache.org/r/70826/diff/1/ Testing --- Thanks, Qian Zhang
Review Request 70824: Fixed test `QuotaRoleAllocateNonQuotaResource`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70824/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9835 https://issues.apache.org/jira/browse/MESOS-9835 Repository: mesos Description --- The test was failing because: After `agent3` is added, it misses a settle call where the allocation of `agent3` is racy. In addition, after MESOS-8456, the allocator now offers non-quota resources on an agent (even that means "chopping") on top of a role's satisfied guarantees instead of skipping the agent all-together. This patch fixes the test by expecting the right amount of resources to be allocated from `agent3`. Diffs - src/tests/hierarchical_allocator_tests.cpp bfea34e17151327e8c9590ecb8da74968d086ca0 Diff: https://reviews.apache.org/r/70824/diff/1/ Testing --- make check Thanks, Meng Zhu
Re: Review Request 70822: Added common protobufs for agent draining.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/#review215776 --- Patch looks great! Reviews applied: [70822] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 10, 2019, 2:24 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70822/ > --- > > (Updated June 10, 2019, 2:24 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, > Joseph Wu, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > This patch makes protobuf message updates which will be used > by both the master and the agent to facilitate automatic > draining of agents. > > > Diffs > - > > include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 > include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e > src/messages/messages.proto e30ad34cc9212b05f85ba5e1d4fcfc9e49ae92c0 > > > Diff: https://reviews.apache.org/r/70822/diff/2/ > > > Testing > --- > > `make` > > > Thanks, > > Greg Mann > >
Re: Review Request 70822: Added common protobufs for agent draining.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/ --- (Updated June 10, 2019, 11:24 a.m.) Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, Joseph Wu, and Vinod Kone. Summary (updated) - Added common protobufs for agent draining. Repository: mesos Description --- This patch makes protobuf message updates which will be used by both the master and the agent to facilitate automatic draining of agents. Diffs (updated) - include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e src/messages/messages.proto e30ad34cc9212b05f85ba5e1d4fcfc9e49ae92c0 Diff: https://reviews.apache.org/r/70822/diff/2/ Changes: https://reviews.apache.org/r/70822/diff/1-2/ Testing --- `make` Thanks, Greg Mann
Review Request 70822: Made common protobuf changes for agent draining.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/ --- Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, Joseph Wu, and Vinod Kone. Repository: mesos Description --- This patch makes protobuf message updates which will be used by both the master and the agent to facilitate automatic draining of agents. Diffs - include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e Diff: https://reviews.apache.org/r/70822/diff/1/ Testing --- `make` Thanks, Greg Mann
Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 10, 2019, 9:49 a.m.) Review request for mesos, Benno Evers, Benjamin Mahler, Joseph Wu, and Vinod Kone. Repository: mesos Description (updated) --- This patch adds a hard-coded timeout to the metrics snapshot handler which will log the names of any metrics which have not become ready after 10 seconds. A slight refactor of the snapshot code is done as well. Diffs - 3rdparty/libprocess/include/process/metrics/metrics.hpp 75711edbaf46797e5eb54ba720ea11cf3de81522 3rdparty/libprocess/src/metrics/metrics.cpp 623d44adbe838f995ddbe89ee26f5bcc9c600be5 3rdparty/libprocess/src/tests/metrics_tests.cpp 881275693e67f3c9fb670c7e70cb5014090ed7a5 Diff: https://reviews.apache.org/r/70783/diff/4/ Testing (updated) --- `make check` Also ran some metrics benchmark tests both before and after the change. Before patch: [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0 Test setup: 1 agents with a total of 100 frameworks unversioned /metrics/snapshot' response took 144.821514ms v1 'master::call::GetMetrics' application/x-protobuf response took 147.056543ms v1 'master::call::GetMetrics' application/json response took 175.9909ms [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0 (935 ms) [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1 Test setup: 1 agents with a total of 1000 frameworks unversioned /metrics/snapshot' response took 1.083320021secs v1 'master::call::GetMetrics' application/x-protobuf response took 1.105169806secs v1 'master::call::GetMetrics' application/json response took 1.238749012secs [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1 (7044 ms) [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2 Test setup: 1 agents with a total of 1 frameworks unversioned /metrics/snapshot' response took 9.400786071secs v1 'master::call::GetMetrics' application/x-protobuf response took 9.709327709secs v1 'master::call::GetMetrics' application/json response took 11.207594934secs [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2 (62656 ms) [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3 Test setup: 1 agents with a total of 2 frameworks unversioned /metrics/snapshot' response took 17.926824609secs v1 'master::call::GetMetrics' application/x-protobuf response took 19.467704754secs v1 'master::call::GetMetrics' application/json response took 21.32824915secs [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3 (132619 ms) [--] 4 tests from AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test (203255 ms total) [--] Global test environment tear-down [==] 4 tests from 1 test case ran. (203343 ms total) [ PASSED ] 4 tests. After patch: [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0 Test setup: 1 agents with a total of 100 frameworks unversioned /metrics/snapshot' response took 143.560831ms v1 'master::call::GetMetrics' application/x-protobuf response took 154.460223ms v1 'master::call::GetMetrics' application/json response took 186.55918ms [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0 (987 ms) [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1 Test setup: 1 agents with a total of 1000 frameworks unversioned /metrics/snapshot' response took 1.082617553secs v1 'master::call::GetMetrics' application/x-protobuf response took 1.097321636secs v1 'master::call::GetMetrics' application/json response took 1.273446816secs [ OK ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1 (6996 ms) [ RUN ] AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2 Test setup: 1 agents with a total of 1 frameworks unversioned /metrics/snapshot' response took 9.327752261secs v1 'master::call::GetMetrics' application/x-protobuf response took 9.944210962secs v1 'master::call::GetMetrics' application/json response took 10.800611643secs [ OK ]
Re: Review Request 70820: Updated `filesystem/linux` isolator for configurable IPC support.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70820/#review215775 --- Patch looks great! Reviews applied: [70773, 70774, 70775, 70798, 70820] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 10, 2019, 4:20 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70820/ > --- > > (Updated June 10, 2019, 4:20 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9826 > https://issues.apache.org/jira/browse/MESOS-9826 > > > Repository: mesos > > > Description > --- > > If `namespaces/ipc` isolator is not enabled, for backward > compatibility /dev/shm will still be handled in `filesystem/linux` > isolator as before. Otherwise, both /dev/shm and IPC namespace > will be handled by `namespaces/ipc` isolator. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 3cfb6e97a565420c8be2a0e31b481b39cd09d9da > > > Diff: https://reviews.apache.org/r/70820/diff/1/ > > > Testing > --- > > > Thanks, > > Qian Zhang > >
