date:20200316

Re: Review Request 72239: Added stack trace logging to program crashes on windows.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72239/#review219967
---



Patch looks great!

Reviews applied: [72239]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 17, 2020, 12:09 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72239/
> ---
> 
> (Updated March 17, 2020, 12:09 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-7245
> https://issues.apache.org/jira/browse/MESOS-7245
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For now, this starts with adding the necessary code to logging.cpp up
> in mesos. This gives us stack traces for any mesos binaries or
> libraries that initialize logging with `installFailureSignalHandler`
> set to true.
> 
> Ideally, we would either (1) move this into stout, or (2) upstream
> some changes to glog. Both approaches would allow us to also get
> stack traces from stout tests and libprocess tests.
> 
> For now however, this patch is just aiming to fix the urgent issue
> of a lack of stack traces for mesos crashes.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp baca51b3956dbaa282c03e73a2c261ff103f4821 
> 
> 
> Diff: https://reviews.apache.org/r/72239/diff/3/
> 
> 
> Testing
> ---
> 
> Ran through CI and locally, for the recent reservation update crash this 
> produces:
> 
> ```
> E 00:00:00.00 18216 logging.cpp:295] RAW: Received fatal exception 
> 0xc005 EXCEPTION_ACCESS_VIOLATION
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> google::protobuf::internal::RepeatedPtrIterator  const >::operator* [7FF75279306E+14] 
> (c:\users\bmahler\git\mesos\build\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\repeated_field.h:2266)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> mesos::authorization::ActionObject::reserve [7FF753C94880+720] 
> (c:\users\bmahler\git\mesos\src\master\authorization.cpp:236)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> mesos::internal::master::Master::Http::_reserve [7FF753D007CF+1423] 
> (c:\users\bmahler\git\mesos\src\master\http.cpp:1960)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> mesos::internal::master::Master::Http::reserveResources 
> [7FF753D07FFC+380] (c:\users\bmahler\git\mesos\src\master\http.cpp:1984)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> mesos::internal::master::Master::Http::api [7FF753CED99B+6571] 
> (c:\users\bmahler\git\mesos\src\master\http.cpp:352)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> ::operator() [7FF7527AA2E4+100] 
> (c:\users\bmahler\git\mesos\src\master\master.cpp:909)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::_Invoker_functor::_Call< 
> &,process::http::Request const 
> &,Option const &> 
> [7FF75262D61A+122] (c:\program files (x86)\microsoft visual 
> studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::invoke< 
> &,process::http::Request const 
> &,Option const &> 
> [7FF7526E55AA+122] (c:\program files (x86)\microsoft visual 
> studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::_Invoker_ret,0>::_Call<
>  &,process::http::Request const 
> &,Option const &> 
> [7FF75262D55A+122] (c:\program files (x86)\microsoft visual 
> studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::_Func_impl_no_alloc<,process::Future,process::http::Request
>  const &,Option const &>::_Do_call 
> [7FF7527EDF2F+111] (c:\program files (x86)\microsoft visual 
> studio\2017\community\vc\tools\msvc\14.16.27023\include\functional:16707566)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::_Func_class,process::http::Request
>  const &,Option const 
> &>::operator() [7FF75472BAAD+157] (c:\program files (x86)\microsoft 
> visual 
> studio\2017\community\vc\tools\msvc\14.16.27023\include\functional:16707566)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> ::operator() [7FF75471911F+335] 
> (c:\users\bmahler\git\mesos\3rdparty\libprocess\src\process.cpp:3874)
> E 00:00:00.00 18216 logging.cpp:320] RAW:   
> std::_Invoker_functor::_Call<,bool> 
> [7FF754638F1F+95] (c:\program files (x86)\microsoft

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang



> On March 16, 2020, 8:23 p.m., Greg Mann wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4624-4628 (patched)
> > 
> >
> > Are we sure this will hold for all systems? Can we just check that the 
> > task cgroup's limit is infinite?

See my comment here: https://reviews.apache.org/r/72210/#comment308193 . And 
what do you mean for `task cgroup's limit`? I do not think we support task 
group in Docker containerizer.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219954
---


On March 16, 2020, 9:52 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> ---
> 
> (Updated March 16, 2020, 9:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-16 Thread Qian Zhang



> On March 16, 2020, 8:44 p.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 465-473 (original), 525-533 (patched)
> > 
> >
> > Why are our expectations for CPU consumption changed after your update 
> > to the test? Aren't we still setting the CFS quota in the same way?
> 
> Qian Zhang wrote:
> That's actually a bug in this test: besides the CPU times consumed by the 
> task, there are also some overhead caused by the executor (e.g. launching 
> executor will also take some CPU times), so in total the actually CPU usage 
> will be a bit higher due to the overhead.

Previously in this test we did add some overhead (0.05) when checking the CPU 
time, however that overhead is not big enough so this test fails occasionally.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71953/#review219956
---


On March 16, 2020, 5:12 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71953/
> ---
> 
> (Updated March 16, 2020, 5:12 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is renamed to `ROOT_CGROUPS_CFS_CommandTaskNoLimits`, and
> besides CFS quota, now it also verifies CPU shares, memory soft and
> hard limits and OOM score adjustment.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71953/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang



> On March 16, 2020, 8:31 p.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 842-845 (patched)
> > 
> >
> > Will this be true on all systems? Can we just check that the task 
> > cgroup's memory limit is -1?

I think it will be true on all systems since root cgroup's limits cannot be 
modified (you can search `"we cannot set any limits on the root cgroup"` in 
https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt ). -1 represents 
infinite limit for CPU CFS quota but not memory limit which uses something like 
`9223372036854771712`.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219955
---


On March 16, 2020, 9:51 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> ---
> 
> (Updated March 16, 2020, 9:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/72210/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-16 Thread Qian Zhang



> On March 16, 2020, 8:44 p.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 465-473 (original), 525-533 (patched)
> > 
> >
> > Why are our expectations for CPU consumption changed after your update 
> > to the test? Aren't we still setting the CFS quota in the same way?

That's actually a bug in this test: besides the CPU times consumed by the task, 
there are also some overhead caused by the executor (e.g. launching executor 
will also take some CPU times), so in total the actually CPU usage will be a 
bit higher due to the overhead.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71953/#review219956
---


On March 16, 2020, 5:12 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71953/
> ---
> 
> (Updated March 16, 2020, 5:12 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is renamed to `ROOT_CGROUPS_CFS_CommandTaskNoLimits`, and
> besides CFS quota, now it also verifies CPU shares, memory soft and
> hard limits and OOM score adjustment.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71953/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72239: Added stack trace logging to program crashes on windows.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72239/#review219962
---



Bad patch!

Reviews applied: [72239]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72239"]

Error:
..
sr/include/apr-1.0 -pthread -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../src/common/resources.cpp  -fPIC -DPIC -o 
common/.libs/libmesos_no_3rdparty_la-resources.o
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" 
-DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../src   -Werror -DLIBDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/libexec/mes
 os\" -DPKGDATADIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/lib/mesos/modules\" 
-I../../../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
common/libmesos_no_3rdparty_la-resource_quantiti
 es.lo `test -f 'common/resource_quantities.cpp' || echo 
'../../../src/'`common/resource_quantities.cpp
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" 
-DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../src   -Werror -DLIBDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/libexec/mes
 os\" -DPKGDATADIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/tmp/SRC/build/mesos-1.10.0/_inst/lib/mesos/modules\" 
-I../../../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
common/libmesos_no_3rdparty_la-resources_utils.l
 o

Review Request 72239: Added stack trace logging to program crashes on windows.

2020-03-16 Thread Benjamin Mahler


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72239/
---

Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu.


Bugs: MESOS-7245
https://issues.apache.org/jira/browse/MESOS-7245


Repository: mesos


Description
---

For now, this starts with adding the necessary code to logging.cpp up
in mesos. This gives us stack traces for any mesos binaries or
libraries that initialize logging with `installFailureSignalHandler`
set to true.

Ideally, we would either (1) move this into stout, or (2) upstream
some changes to glog. Both approaches would allow us to also get
stack traces from stout tests and libprocess tests.

For now however, this patch is just aiming to fix the urgent issue
of a lack of stack traces for mesos crashes.


Diffs
-

  src/logging/logging.cpp baca51b3956dbaa282c03e73a2c261ff103f4821 


Diff: https://reviews.apache.org/r/72239/diff/1/


Testing
---

Ran through CI and locally, for the recent reservation update crash this 
produces:

```
E 00:00:00.00 18216 logging.cpp:295] RAW: Received fatal exception 
0xc005 EXCEPTION_ACCESS_VIOLATION
E 00:00:00.00 18216 logging.cpp:320] RAW:   
google::protobuf::internal::RepeatedPtrIterator::operator* [7FF75279306E+14] 
(c:\users\bmahler\git\mesos\build\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\repeated_field.h:2266)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
mesos::authorization::ActionObject::reserve [7FF753C94880+720] 
(c:\users\bmahler\git\mesos\src\master\authorization.cpp:236)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
mesos::internal::master::Master::Http::_reserve [7FF753D007CF+1423] 
(c:\users\bmahler\git\mesos\src\master\http.cpp:1960)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
mesos::internal::master::Master::Http::reserveResources [7FF753D07FFC+380] 
(c:\users\bmahler\git\mesos\src\master\http.cpp:1984)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
mesos::internal::master::Master::Http::api [7FF753CED99B+6571] 
(c:\users\bmahler\git\mesos\src\master\http.cpp:352)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
::operator() [7FF7527AA2E4+100] 
(c:\users\bmahler\git\mesos\src\master\master.cpp:909)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Invoker_functor::_Call< 
&,process::http::Request const 
&,Option const &> 
[7FF75262D61A+122] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::invoke< &,process::http::Request 
const &,Option const &> 
[7FF7526E55AA+122] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Invoker_ret,0>::_Call<
 &,process::http::Request const 
&,Option const &> 
[7FF75262D55A+122] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Func_impl_no_alloc<,process::Future,process::http::Request
 const &,Option const &>::_Do_call 
[7FF7527EDF2F+111] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\functional:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Func_class,process::http::Request
 const &,Option const &>::operator() 
[7FF75472BAAD+157] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\functional:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
::operator() [7FF75471911F+335] 
(c:\users\bmahler\git\mesos\3rdparty\libprocess\src\process.cpp:3874)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Invoker_functor::_Call<,bool> 
[7FF754638F1F+95] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::invoke<,bool> 
[7FF75469AB2E+94] (c:\program files (x86)\microsoft visual 
studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits:16707566)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
lambda::internal::Partial<,bool>::invoke_expand<,std::tuple,std::tuple<>,0>
 [7FF7546A2B9A+138] 
(c:\users\bmahler\git\mesos\3rdparty\stout\include\stout\lambda.hpp:292)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
lambda::internal::Partial<,bool>::operator()<>
 [7FF754620DCF+127] 
(c:\users\bmahler\git\mesos\3rdparty\stout\include\stout\lambda.hpp:331)
E 00:00:00.00 18216 logging.cpp:320] RAW:   
std::_Invoker_functor::_Call,bool>
 > [7FF75463D082+66]

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72041/#review219961
---



Bad patch!

Reviews applied: [72161, 72162, 71858, 71884, 71885, 71886, 71943, 71944, 
71950, 71951, 71952, 71953, 71955, 71956, 72210, 71983, 72022, 72027, 72211, 
72040, 72041]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72041"]

Error:
..
S_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o src/libprocess_la-latch.lo `test -f 'src/latch.cpp' || echo 
'../../../../3rdparty/libprocess/'`src/latch.cpp
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../../3rdparty/libprocess  
-DBUILD_DIR=\"/tmp/SRC/build/mesos-1.10.0/_build/sub/3rdparty/libprocess\" 
-I../../../../3rdparty/lib
 process/include -I../../../../3rdparty/libprocess/src -I../boost-1.65.0 
-I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src  
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22  
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../../3rdparty/libprocess/../stout/include 
 -DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o src/libprocess_la-logging.lo `test -f 'src/logging.cpp' || 
echo '../../../../3rdparty/libprocess/'`src/logging.cpp
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../../3rdparty/libprocess  
-DBUILD_DIR=\"/tmp/SRC/build/mesos-1.10.0/_build/sub/3rdparty/libprocess\" 
-I../../../../3rdparty/lib
 process/include -I../../../../3rdparty/libprocess/src -I../boost-1.65.0 
-I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src  
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22  
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../../3rdparty/libprocess/../stout/include 
 -DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o src/libprocess_la-memory_profiler.lo `test -f 
'src/memory_profiler.cpp' || echo 
'../../../../3rdparty/libprocess/'`src/memory_profiler.cpp
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7/#review219959
---



Bad patch!

Reviews applied: [72161, 72162, 71858, 71884, 71885, 71886, 71943, 71944, 
71950, 71951, 71952, 71953, 71955, 72216, 72217, 72221, 7]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_7"]

Error:
..
" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../../3rdparty/stout  -I../../../../3rdparty/stout/include 
-I../boost-1.65.0 -I../elfio-3.2 -I../glog-0.4.0/src 
-I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/include 
-I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include  -I/
 usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0  
-Wall -Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -fPIE -g1 
-O0 -Wno-unused-local-typedefs -std=c++11 -c -o stout_tests-ip_tests.o `test -f 
'tests/ip_tests.cpp' || echo '../../../../3rdparty/stout/'`tests/ip_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-json_tests.o `test -f 'tests/json_tests.cpp' || 
echo '../../../../3rdparty/stout/'`tests/json_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-jsonify_tests.o `test -f 'tests/jsonify_tests.cpp' 
||

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/3/

Changes: https://reviews.apache.org/r/72211/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72162/
---

(Updated March 16, 2020, 9:51 p.m.)


Review request for mesos, Andrei Budnik, Andrei Sekretenko, Benjamin Mahler, 
and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10064
https://issues.apache.org/jira/browse/MESOS-10064


Repository: mesos


Description
---

Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.


Diffs (updated)
-

  3rdparty/stout/include/stout/jsonify.hpp 
7a239d846de5679e9c2b80aa4e617a72fdeac92c 
  3rdparty/stout/include/stout/protobuf.hpp 
fcd91d5ea822612e4b32d157fcbc5f0dedeba823 
  3rdparty/stout/tests/protobuf_tests.cpp 
55889dc432a9459965d3dd75052d672828cdea90 
  3rdparty/stout/tests/protobuf_tests.proto 
5e20215fcc69e400358847d0ce943d8c18f2a9e0 


Diff: https://reviews.apache.org/r/72162/diff/5/

Changes: https://reviews.apache.org/r/72162/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/5/

Changes: https://reviews.apache.org/r/72027/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
---

(Updated March 16, 2020, 9:51 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71956/diff/8/

Changes: https://reviews.apache.org/r/71956/diff/7-8/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/4/

Changes: https://reviews.apache.org/r/71983/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
---

(Updated March 16, 2020, 9:51 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/72210/diff/3/

Changes: https://reviews.apache.org/r/72210/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-16 Thread Qian Zhang



> On March 16, 2020, 7:54 p.m., Greg Mann wrote:
> > src/docker/executor.cpp
> > Lines 201-212 (original), 201-212 (patched)
> > 
> >
> > We also have the less common case of a custom executor in a Docker 
> > container in `DockerContainerizerProcess::launchExecutorContainer()`, found 
> > in the file 'src/slave/containerizer/docker.cpp'. We should probably pass 
> > limits through there as well?

Yes, we should. Actually that is the scope of 
https://issues.apache.org/jira/browse/MESOS-10054 , and I think we can do it in 
a separate patch rather than in this patch. And as you mentioned it is a less 
common case, so I think we could do it post MVP, HDYT?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219953
---


On March 16, 2020, 5:16 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> ---
> 
> (Updated March 16, 2020, 5:16 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-16 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71953/#review219956
---




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 498 (patched)


This can probably be EXPECT_EQ?



src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 465-473 (original), 525-533 (patched)


Why are our expectations for CPU consumption changed after your update to 
the test? Aren't we still setting the CFS quota in the same way?


- Greg Mann


On March 16, 2020, 9:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71953/
> ---
> 
> (Updated March 16, 2020, 9:12 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is renamed to `ROOT_CGROUPS_CFS_CommandTaskNoLimits`, and
> besides CFS quota, now it also verifies CPU shares, memory soft and
> hard limits and OOM score adjustment.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71953/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219955
---




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 842-845 (patched)


Will this be true on all systems? Can we just check that the task cgroup's 
memory limit is -1?


- Greg Mann


On March 16, 2020, 9:14 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> ---
> 
> (Updated March 16, 2020, 9:14 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/72210/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219954
---




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4617 (patched)


s/cannot be set any limits/cannot have any limit set/



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4624-4628 (patched)


Are we sure this will hold for all systems? Can we just check that the task 
cgroup's limit is infinite?


- Greg Mann


On March 16, 2020, 9:22 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> ---
> 
> (Updated March 16, 2020, 9:22 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-16 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219953
---




src/docker/executor.cpp
Lines 201-212 (original), 201-212 (patched)


We also have the less common case of a custom executor in a Docker 
container in `DockerContainerizerProcess::launchExecutorContainer()`, found in 
the file 'src/slave/containerizer/docker.cpp'. We should probably pass limits 
through there as well?


- Greg Mann


On March 16, 2020, 9:16 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> ---
> 
> (Updated March 16, 2020, 9:16 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72041/#review219952
---



Bad patch!

Reviews applied: [72161, 72162, 71858, 71884, 71885, 71886, 71943, 71944, 
71950, 71951, 71952, 71953, 71955, 71956, 72210, 71983, 72022, 72027, 72211, 
72040, 72041]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72041"]

Error:
..
KAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../../3rdparty/stout  -I../../../../3rdparty/stout/include 
-I../boost-1.65.0 -I../elfio-3.2 -I../glog-0.4.0/src 
-I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/include 
-I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/
 include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0  -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-ip_tests.o `test -f 'tests/ip_tests.cpp' || echo 
'../../../../3rdparty/stout/'`tests/ip_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-json_tests.o `test -f 'tests/json_tests.cpp' || 
echo '../../../../3rdparty/stout/'`tests/json_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-16 Thread Greg Mann



> On March 6, 2020, 8:06 a.m., Greg Mann wrote:
> > src/docker/docker.cpp
> > Line 663 (original), 714-716 (patched)
> > 
> >
> > Do we want to set the memory reservation here as well?
> 
> Qian Zhang wrote:
> I do not think we want to do that because of backward compatibility.

Good point.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219816
---


On March 16, 2020, 9:16 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> ---
> 
> (Updated March 16, 2020, 9:16 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7/#review219950
---



Bad patch!

Reviews applied: [72161, 72162, 71858, 71884, 71885, 71886, 71943, 71944, 
71950, 71951, 71952, 71953, 71955, 72216, 72217, 72221, 7]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_7"]

Error:
..
AGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../../3rdparty/stout  -I../../../../3rdparty/stout/include 
-I../boost-1.65.0 -I../elfio-3.2 -I../glog-0.4.0/src 
-I../googletest-release-1.8.0/googlemock/include 
-I../googletest-release-1.8.0/googletest/include 
-I../libarchive-3.3.2/libarchive -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/i
 nclude  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-ip_tests.o `test -f 'tests/ip_tests.cpp' || echo 
'../../../../3rdparty/stout/'`tests/ip_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-json_tests.o `test -f 'tests/json_tests.cpp' || 
echo '../../../../3rdparty/stout/'`tests/json_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../../3rdparty/stout  
-I../../../../3rdparty/stout/include -I../boost-1.65.0 -I../elfio-3.2 
-I../glog-0.4.0/src -I../googletest-release-1.8.0/googlemock/include 
-I../googletest-rel
 ease-1.8.0/googletest/include -I../libarchive-3.3.2/libarchive 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include  -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0   -Wall -Wsign-compare -Wformat-security 
-fstack-protector-strong -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c -o stout_tests-jsonify_tests.o `test -f

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72041/
---

(Updated March 16, 2020, 5:24 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10063
https://issues.apache.org/jira/browse/MESOS-10063


Repository: mesos


Description
---

Updated default executor to call the `LaunchContainer` agent API.


Diffs (updated)
-

  src/launcher/default_executor.cpp b431d8f86a359d64f84ea1c5fae63ee6cbddba31 


Diff: https://reviews.apache.org/r/72041/diff/3/

Changes: https://reviews.apache.org/r/72041/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72040/
---

(Updated March 16, 2020, 5:23 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10051
https://issues.apache.org/jira/browse/MESOS-10051


Repository: mesos


Description
---

Updated the `LaunchContainer` agent API to support resource limits.


Diffs (updated)
-

  include/mesos/agent/agent.proto 030ed61af3c3864c2b9a63f91c37419745c8d57d 
  include/mesos/v1/agent/agent.proto be7db868b2fed961c34db6e5fb1193e310ea8991 
  src/slave/http.hpp 71fc6f7776a45d1632d0094e69979e9881d33e05 
  src/slave/http.cpp 4493abfc3d6fd53d95b7ea99a068560e3c8f51d2 
  src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a 


Diff: https://reviews.apache.org/r/72040/diff/2/

Changes: https://reviews.apache.org/r/72040/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

(Updated March 16, 2020, 5:22 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/2/

Changes: https://reviews.apache.org/r/72211/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 16, 2020, 5:17 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/4/

Changes: https://reviews.apache.org/r/72027/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/
---

(Updated March 16, 2020, 5:16 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Set resource limits and OOM score adjustment in Docker executor.


Diffs (updated)
-

  src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
  src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
  src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 


Diff: https://reviews.apache.org/r/72022/diff/4/

Changes: https://reviews.apache.org/r/72022/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 16, 2020, 5:15 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/3/

Changes: https://reviews.apache.org/r/71983/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/
---

(Updated March 16, 2020, 5:14 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/72210/diff/2/

Changes: https://reviews.apache.org/r/72210/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/
---

(Updated March 16, 2020, 5:13 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

Added a new parameter `resourceLimits` to the `createTask` methods.


Diffs (updated)
-

  src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 


Diff: https://reviews.apache.org/r/71955/diff/3/

Changes: https://reviews.apache.org/r/71955/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
---

(Updated March 16, 2020, 5:13 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71956/diff/7/

Changes: https://reviews.apache.org/r/71956/diff/6-7/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71952: Set resource limits when updating executor container.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71952/
---

(Updated March 16, 2020, 5:12 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Set resource limits when updating executor container.


Diffs (updated)
-

  src/slave/slave.hpp 03279db082bdba23dbfeb2d93081a908e609aec2 
  src/slave/slave.cpp a914de4bae5630126ae26b9e7dee8c8784ce1ee0 


Diff: https://reviews.apache.org/r/71952/diff/8/

Changes: https://reviews.apache.org/r/71952/diff/7-8/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71953/
---

(Updated March 16, 2020, 5:12 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

This test is renamed to `ROOT_CGROUPS_CFS_CommandTaskNoLimits`, and
besides CFS quota, now it also verifies CPU shares, memory soft and
hard limits and OOM score adjustment.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71953/diff/5/

Changes: https://reviews.apache.org/r/71953/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71951/
---

(Updated March 16, 2020, 5:11 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added resource limits into the `Task` protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 40c45de371b12d84aeebcc91847336c4968592f2 
  include/mesos/v1/mesos.proto 638763612ccb302f052eb30caf661984087314e1 
  src/common/protobuf_utils.cpp b3057be7460100201066a354a1f621d100546233 


Diff: https://reviews.apache.org/r/71951/diff/3/

Changes: https://reviews.apache.org/r/71951/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71950/
---

(Updated March 16, 2020, 5:11 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Updated containerizer's `update()` method to handle resource limits.


Diffs (updated)
-

  src/slave/containerizer/composing.hpp 
0f838fa63b02d38606a6c484f01d24952d569721 
  src/slave/containerizer/composing.cpp 
d854794fc4775fb8a05efc233d488a64b9ef620a 
  src/slave/containerizer/containerizer.hpp 
6a9ebed5e55ad1cfed6340479743ef2bb4c05dab 
  src/slave/containerizer/docker.hpp 0349f537cef9651427e0e3ed33fd693107e07aa0 
  src/slave/containerizer/docker.cpp 2a9b2ffcbd01ae916839ae43c8342285ac3e14a2 
  src/slave/containerizer/mesos/containerizer.hpp 
9e86ff43535c4be937baa238442e8f0db8857a27 
  src/slave/containerizer/mesos/containerizer.cpp 
d034c02c0f73a2745a063561430a1bce7b552420 
  src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276 
  src/tests/containerizer.cpp 3ac992f8599e8a48f428b506f5bdecc722050c6a 
  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
  src/tests/containerizer/mock_containerizer.hpp 
8700257a9347199ed6e32b8b6b2a58787d68af03 
  src/tests/master_draining_tests.cpp a91201e0bfb6f53f70dbdc4649cc344076ef474b 
  src/tests/master_tests.cpp d0f53b2139bf36ff15a27e438f058f4914df5caa 
  src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75 
  src/tests/registrar_zookeeper_tests.cpp 
9d3ea5f194374fb3492fdfa8bd2efeef55fc4743 
  src/tests/scheduler_tests.cpp 299d3a06ca1fd55ef55dc9be323b98a4da3be31a 
  src/tests/slave_tests.cpp 92fa2996f0e39dded79aa372ddf2390b68b885a2 


Diff: https://reviews.apache.org/r/71950/diff/4/

Changes: https://reviews.apache.org/r/71950/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71944: Set container process's OOM score adjust.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71944/
---

(Updated March 16, 2020, 5:10 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10048
https://issues.apache.org/jira/browse/MESOS-10048


Repository: mesos


Description
---

Set container process's OOM score adjust.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bf2a4d8d587969568f451f63e4f619e9c49f3642 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
a311ab4495f71bedacd2e99c84c765f0e5fe99d3 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
c62deec4b1cd749dba5fe71b901e0353806a0805 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
ac2e66b570bb84b43c4a3e8f19b40e5fcea71a4a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
27d88e91fb784179effd54781f84000fe85c13eb 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
0896d37761a11f55ba4b866d235c3bd2b79dcfba 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.hpp 
06531072f445d4ec978ebaf5ec5e4a2475517d05 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp 
ec2ce67e54387f26aa11c00d4c7f85f0807a127b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.hpp 
2c865aca35084a5db567b5f95c8c57bb6e1d5634 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
180afc936798c2fa4de0deef080276cf7cc94199 
  src/slave/containerizer/mesos/utils.hpp 
bfd07e28c78fc140e395ffccd11d65545bf007fc 
  src/slave/containerizer/mesos/utils.cpp 
d9964f0b0e8ad8a41e5f5490a1c28bba9a972ae0 


Diff: https://reviews.apache.org/r/71944/diff/8/

Changes: https://reviews.apache.org/r/71944/diff/7-8/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71943/
---

(Updated March 16, 2020, 5:07 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10048
https://issues.apache.org/jira/browse/MESOS-10048


Repository: mesos


Description
---

Set container's `memory.limit_in_bytes` to its memory limit.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
27d88e91fb784179effd54781f84000fe85c13eb 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
0896d37761a11f55ba4b866d235c3bd2b79dcfba 


Diff: https://reviews.apache.org/r/71943/diff/5/

Changes: https://reviews.apache.org/r/71943/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71886/
---

(Updated March 16, 2020, 5:07 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

Set container's `cpu.cfs_quota_us` to its CPU resource limit.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 
960bd141430387e076a8fab1948d07719613ed90 


Diff: https://reviews.apache.org/r/71886/diff/6/

Changes: https://reviews.apache.org/r/71886/diff/5-6/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71885/
---

(Updated March 16, 2020, 5:06 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10067
https://issues.apache.org/jira/browse/MESOS-10067


Repository: mesos


Description
---

Updated the `update()` method of subsystem to handle resource limits.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bf2a4d8d587969568f451f63e4f619e9c49f3642 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
a311ab4495f71bedacd2e99c84c765f0e5fe99d3 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp 
02e7163b9a7a928352715848947e608885c5242a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 
960bd141430387e076a8fab1948d07719613ed90 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
27d88e91fb784179effd54781f84000fe85c13eb 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
0896d37761a11f55ba4b866d235c3bd2b79dcfba 


Diff: https://reviews.apache.org/r/71885/diff/3/

Changes: https://reviews.apache.org/r/71885/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71884/
---

(Updated March 16, 2020, 5:05 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10065
https://issues.apache.org/jira/browse/MESOS-10065


Repository: mesos


Description
---

Updated the `update()` method of isolator to handle resource limits.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 65893e176d34d72c7d05a064a3de91217ef769c9 
  src/slave/containerizer/mesos/isolator.hpp 
a5586799c47edff9b9db4af70bfd43772bfb7da1 
  src/slave/containerizer/mesos/isolator.cpp 
ac333984db5ef0a9fed412c19152edfa4183b0e4 
  src/slave/containerizer/mesos/isolator_tracker.hpp 
563db10a5bfb78b5476100ec430ede69bdb02b31 
  src/slave/containerizer/mesos/isolator_tracker.cpp 
c78e883fa49069fbc4ca439e612b62adafa081d9 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
8718b7a40640aed284b91891321b0f69fd38b40e 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bf2a4d8d587969568f451f63e4f619e9c49f3642 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
e6fe688a247358f30bed0492ebd1baddac8809e8 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
0819738a4770d4db0450f9fd3453d6d39f7ac3ff 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
9db6ddd2d457956f3020a11ba73d96b35b0d8a15 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
dbf149ad9c8fb900bb3b56f6e90b3a8643097d25 
  src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 
cc3cab51f7dab4393b101aff8b481a5cd0a01af9 
  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
5d1821087491cedd0cfbec5d57340bd927aae725 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
c14a8cca2b049104f3529b0c38c0ea6a5ccafe11 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
65b23f00a351d63bdf3fc315191946e9a69adfd6 
  src/slave/containerizer/mesos/isolators/network/ports.hpp 
c0d08589d32ffeb2d94c2f3db7added6b0cd36bf 
  src/slave/containerizer/mesos/isolators/network/ports.cpp 
86d3053350651f2616f0574b4e03b0a60ef7d903 
  src/slave/containerizer/mesos/isolators/posix.hpp 
f8de3d2315554be3840911324ac645e21dfc04a0 
  src/slave/containerizer/mesos/isolators/posix/disk.hpp 
2e9b48189d0b6b1a7def66414a58ccef5a1a66e3 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
842facf40fec776f06d44c4e605c94f1b7d4546e 
  src/slave/containerizer/mesos/isolators/windows/cpu.hpp 
ef58d67c119fea6ba492ed19a953cb767289a605 
  src/slave/containerizer/mesos/isolators/windows/cpu.cpp 
0d3706f4a34a912aa49885a2811cdd0b818788fb 
  src/slave/containerizer/mesos/isolators/windows/mem.hpp 
1c87764c4b0dc8caac928f0e592e2853c7cff67d 
  src/slave/containerizer/mesos/isolators/windows/mem.cpp 
4fabb934df0398a44b3a20dcab237730a9218039 
  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
16bb432d8529f9ced3794fdb08089398659fc09f 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
1680a5923734a6b1a42b8288aa81c5179b206cba 
  src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b 
  src/tests/slave_tests.cpp 92fa2996f0e39dded79aa372ddf2390b68b885a2 


Diff: https://reviews.apache.org/r/71884/diff/3/

Changes: https://reviews.apache.org/r/71884/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71858: Set resource limits when launching executor container.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71858/
---

(Updated March 16, 2020, 5:04 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10046
https://issues.apache.org/jira/browse/MESOS-10046


Repository: mesos


Description
---

Set resource limits when launching executor container.


Diffs (updated)
-

  src/slave/slave.hpp 03279db082bdba23dbfeb2d93081a908e609aec2 
  src/slave/slave.cpp a914de4bae5630126ae26b9e7dee8c8784ce1ee0 


Diff: https://reviews.apache.org/r/71858/diff/12/

Changes: https://reviews.apache.org/r/71858/diff/11-12/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72162/
---

(Updated March 16, 2020, 5:03 p.m.)


Review request for mesos, Andrei Budnik, Andrei Sekretenko, Benjamin Mahler, 
and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10064
https://issues.apache.org/jira/browse/MESOS-10064


Repository: mesos


Description
---

Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.


Diffs (updated)
-

  3rdparty/stout/include/stout/jsonify.hpp 
7a239d846de5679e9c2b80aa4e617a72fdeac92c 
  3rdparty/stout/include/stout/protobuf.hpp 
fcd91d5ea822612e4b32d157fcbc5f0dedeba823 
  3rdparty/stout/tests/protobuf_tests.cpp 
55889dc432a9459965d3dd75052d672828cdea90 
  3rdparty/stout/tests/protobuf_tests.proto 
5e20215fcc69e400358847d0ce943d8c18f2a9e0 


Diff: https://reviews.apache.org/r/72162/diff/4/

Changes: https://reviews.apache.org/r/72162/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72161: Added patch for RapidJSON.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72161/
---

(Updated March 16, 2020, 5:03 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10064
https://issues.apache.org/jira/browse/MESOS-10064


Repository: mesos


Description
---

This commit updates the writer of RapidJSON to write infinite
floating point numbers as "Infinity" and "-Infinity" (i.e.,
with double quotes) rather than Infinity and -Infinity. This
is to ensure the strings converted from JSON objects conform
to the rule defined by Protobuf:
https://developers.google.com/protocol-buffers/docs/proto3#json


Diffs (updated)
-

  3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd 
  3rdparty/rapidjson-1.1.0.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/72161/diff/3/

Changes: https://reviews.apache.org/r/72161/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72041/#review219949
---



Bad review!

Reviews applied: [72041, 72040, 72211, 72027, 72022, 71983, 72210, 71956, 
71955, 71953, 71952, 71951, 71950, 71944, 71943, 71886, 71885, 71884, 71858, 
72162, 72161]

Error:
2020-03-16 09:04:50 URL:https://reviews.apache.org/r/71884/diff/raw/ 
[29892/29892] -> "71884.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp:812
error: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp: patch does 
not apply

- Mesos Reviewbot


On March 5, 2020, 1:02 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72041/
> ---
> 
> (Updated March 5, 2020, 1:02 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10063
> https://issues.apache.org/jira/browse/MESOS-10063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated default executor to call the `LaunchContainer` agent API.
> 
> 
> Diffs
> -
> 
>   src/launcher/default_executor.cpp b431d8f86a359d64f84ea1c5fae63ee6cbddba31 
> 
> 
> Diff: https://reviews.apache.org/r/72041/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

2020-03-16 Thread Qian Zhang



> On March 11, 2020, 4:34 p.m., Greg Mann wrote:
> > Could you update the description of this patch with a note that not all 
> > callsites of `Containerizer::update` are updated here, since some involve 
> > significant related code changes? In particular, I noticed that a couple 
> > callsites are updated in https://reviews.apache.org/r/71952/, but it 
> > doesn't seem desirable to merge these two patches together.

Actually the purpose of this patch is to update the signature of 
`Containerizer::update` by adding a `resourceLimits` parameter rather than 
updating the callsites of `Containerizer::update` which is purpose of 
https://reviews.apache.org/r/71952/ .


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71950/#review219883
---


On March 4, 2020, 9:43 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71950/
> ---
> 
> (Updated March 4, 2020, 9:43 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated containerizer's `update()` method to handle resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 0f838fa63b02d38606a6c484f01d24952d569721 
>   src/slave/containerizer/composing.cpp 
> d854794fc4775fb8a05efc233d488a64b9ef620a 
>   src/slave/containerizer/containerizer.hpp 
> 6a9ebed5e55ad1cfed6340479743ef2bb4c05dab 
>   src/slave/containerizer/docker.hpp 0349f537cef9651427e0e3ed33fd693107e07aa0 
>   src/slave/containerizer/docker.cpp 2a9b2ffcbd01ae916839ae43c8342285ac3e14a2 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 9e86ff43535c4be937baa238442e8f0db8857a27 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d034c02c0f73a2745a063561430a1bce7b552420 
>   src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276 
>   src/tests/containerizer.cpp 3ac992f8599e8a48f428b506f5bdecc722050c6a 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
>   src/tests/containerizer/mock_containerizer.hpp 
> 8700257a9347199ed6e32b8b6b2a58787d68af03 
>   src/tests/master_draining_tests.cpp 
> a91201e0bfb6f53f70dbdc4649cc344076ef474b 
>   src/tests/master_tests.cpp d0f53b2139bf36ff15a27e438f058f4914df5caa 
>   src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75 
>   src/tests/registrar_zookeeper_tests.cpp 
> 9d3ea5f194374fb3492fdfa8bd2efeef55fc4743 
>   src/tests/scheduler_tests.cpp 299d3a06ca1fd55ef55dc9be323b98a4da3be31a 
>   src/tests/slave_tests.cpp 92fa2996f0e39dded79aa372ddf2390b68b885a2 
> 
> 
> Diff: https://reviews.apache.org/r/71950/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

2020-03-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7/#review219947
---



Bad review!

Reviews applied: [7, 72221, 72217, 72216, 71955, 71953, 71952, 71951, 
71950, 71944, 71943, 71886, 71885, 71884, 71858, 72162, 72161]

Error:
2020-03-16 08:14:33 URL:https://reviews.apache.org/r/71884/diff/raw/ 
[29892/29892] -> "71884.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp:812
error: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp: patch does 
not apply

- Mesos Reviewbot


On March 12, 2020, 4:13 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7/
> ---
> 
> (Updated March 12, 2020, 4:13 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
> https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds validation for shared cgroups when specified
> via the agent APIs. In doing so, a new validation test is
> added for the agent's LaunchContainer API, since this was
> previously missing.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_validation_tests.cpp 
> 25019ccdc34db35770b0f69301b94e38636059b7 
> 
> 
> Diff: https://reviews.apache.org/r/7/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.

2020-03-16 Thread Qian Zhang



> On March 15, 2020, 5:04 p.m., Qian Zhang wrote:
> > src/master/validation.cpp
> > Lines 1554-1561 (patched)
> > 
> >
> > What about the task which does not set `share_cgroups` (or even not set 
> > `ContainerInfo` at all)? In that case, I think its `share_cgroups` is also 
> > true (since it is true by default), right?
> > 
> > And I think this validation will affect the command task case because 
> > command task must have `share_cgroups` as true and it is allowed to specify 
> > resource limits for it, right? So I think even a task's `share_cgroup` is 
> > true, we should still allow it to have resource limits specified if it is 
> > the first task of the executor, but we should disallow if it is the second 
> > task no matter whether the first task has resource limits specified or not 
> > because otherwise the second task's resource limits may not be enforced.
> > 
> > But it seems hard to find out whether it is the first task of the 
> > executor. So another option could be, we just do not do this validation at 
> > all, i.e., a task can always specify a resource limits regardless the value 
> > of its `share_cgroups`, so task's resource limits will actually have two 
> > differen meanings:
> > 1. If task's `share_cgroups` is false, then the resource limits are its 
> > own limits.
> > 2. If task's `share_cgroups` is true, its resource limits will 
> > contribute into the executor's resource limits, all tasks of an executor 
> > will share the same resource limits which is the sum of all task's resource 
> > limits.
> > 
> > For #2, actually that is what we are doing in our current implemention, 
> > e.g., if a customer executor launches multiple tasks, all these tasks will 
> > just share the same resource limits, i.e. the customer executor's resource 
> > limits (yes, we indeed always set memory hard limit to memory request and 
> > set CPU hard limit to CPU request if `--cgroups_enable_cfs` is true in our 
> > current implementation). So #2 sounds not that bad since it is backward 
> > compatibile?

Or in MVP, we could make an exception here for the command task (i.e. 
`!task.has_executor()`)? Like it is allowed to specify resource limits for 
command tasks, but not allowed for any other tasks whose `share_cgroup` is true.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review219933
---


On March 12, 2020, 3:10 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72216/
> ---
> 
> (Updated March 12, 2020, 3:10 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
> https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added master validation for task resource limits and shared cgroups.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 
> 
> 
> Diff: https://reviews.apache.org/r/72216/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71944: Set container process's OOM score adjust.

2020-03-16 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71944/
---

(Updated March 16, 2020, 3:17 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Updated some comments in the code.


Bugs: MESOS-10048
https://issues.apache.org/jira/browse/MESOS-10048


Repository: mesos


Description
---

Set container process's OOM score adjust.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bf2a4d8d587969568f451f63e4f619e9c49f3642 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
a311ab4495f71bedacd2e99c84c765f0e5fe99d3 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
c62deec4b1cd749dba5fe71b901e0353806a0805 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
ac2e66b570bb84b43c4a3e8f19b40e5fcea71a4a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
27d88e91fb784179effd54781f84000fe85c13eb 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
0896d37761a11f55ba4b866d235c3bd2b79dcfba 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.hpp 
06531072f445d4ec978ebaf5ec5e4a2475517d05 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp 
ec2ce67e54387f26aa11c00d4c7f85f0807a127b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.hpp 
2c865aca35084a5db567b5f95c8c57bb6e1d5634 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
180afc936798c2fa4de0deef080276cf7cc94199 
  src/slave/containerizer/mesos/utils.hpp 
bfd07e28c78fc140e395ffccd11d65545bf007fc 
  src/slave/containerizer/mesos/utils.cpp 
d9964f0b0e8ad8a41e5f5490a1c28bba9a972ae0 


Diff: https://reviews.apache.org/r/71944/diff/7/

Changes: https://reviews.apache.org/r/71944/diff/6-7/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71944: Set container process's OOM score adjust.

2020-03-16 Thread Qian Zhang



> On March 2, 2020, 9:50 p.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
> > Lines 222 (patched)
> > 
> >
> > Why don't we want to set the OOM score adjustment for custom executor 
> > containers?

For custom executor (actually same to default executor), if its soft limit < 
hard limit, that means it must launch some nested containers whose 
`share_cgroups` is false and soft limit < hard limit, in which case we will set 
OOM score adjustment for each nested container, and we assume the customer 
executor itself will not consume much memory, so we just leave its OOM score 
adjustment as 0.

If the tasks launched by custom executor have `share_cgroups` as true, then 
custom executor's soft limit must be equal to its hard limit (since no resource 
limits can be specified for those tasks), so here we will still leave custom 
executor's OOM score adjustment as 0, and this ensures backward compatibility.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71944/#review219718
---


On March 11, 2020, 5:40 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71944/
> ---
> 
> (Updated March 11, 2020, 5:40 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10048
> https://issues.apache.org/jira/browse/MESOS-10048
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set container process's OOM score adjust.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> b12b73d8e0161d448075378765e77867521de04e 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> a311ab4495f71bedacd2e99c84c765f0e5fe99d3 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp 
> c62deec4b1cd749dba5fe71b901e0353806a0805 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 
> ac2e66b570bb84b43c4a3e8f19b40e5fcea71a4a 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
> 27d88e91fb784179effd54781f84000fe85c13eb 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
> 0896d37761a11f55ba4b866d235c3bd2b79dcfba 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.hpp 
> 06531072f445d4ec978ebaf5ec5e4a2475517d05 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp 
> ec2ce67e54387f26aa11c00d4c7f85f0807a127b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.hpp 
> 2c865aca35084a5db567b5f95c8c57bb6e1d5634 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
> 180afc936798c2fa4de0deef080276cf7cc94199 
>   src/slave/containerizer/mesos/utils.hpp 
> bfd07e28c78fc140e395ffccd11d65545bf007fc 
>   src/slave/containerizer/mesos/utils.cpp 
> d9964f0b0e8ad8a41e5f5490a1c28bba9a972ae0 
> 
> 
> Diff: https://reviews.apache.org/r/71944/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

50 matches

Mail list logo