Review Request 72296: Added missing await in a cgroups isolator test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72296/ --- Review request for mesos and Qian Zhang. Repository: mesos Description --- Added missing await in a cgroups isolator test. Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp f4425f0b5fdecdad36fbd993eb75854b6764888b Diff: https://reviews.apache.org/r/72296/diff/1/ Testing --- `make check` currently fails on our internal CI. Investigation is required. Thanks, Greg Mann
Re: Review Request 72269: Added resource limits to the web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72269/#review220161 --- Ship it! Ship It! - Qian Zhang On April 1, 2020, 12:14 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72269/ > --- > > (Updated April 1, 2020, 12:14 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10055 > https://issues.apache.org/jira/browse/MESOS-10055 > > > Repository: mesos > > > Description > --- > > Added resource limits to the web UI. > > > Diffs > - > > src/webui/app/agents/agent-executor.html > 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc > > > Diff: https://reviews.apache.org/r/72269/diff/4/ > > > Testing > --- > > Viewed manually in a web browser. > > > File Attachments > > > UI Before Change > > https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png > UI After Change > > https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png > > > Thanks, > > Greg Mann > >
Re: Review Request 72269: Added resource limits to the web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72269/#review220158 --- Patch looks great! Reviews applied: [72269] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On March 31, 2020, 4:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72269/ > --- > > (Updated March 31, 2020, 4:14 p.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10055 > https://issues.apache.org/jira/browse/MESOS-10055 > > > Repository: mesos > > > Description > --- > > Added resource limits to the web UI. > > > Diffs > - > > src/webui/app/agents/agent-executor.html > 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc > > > Diff: https://reviews.apache.org/r/72269/diff/4/ > > > Testing > --- > > Viewed manually in a web browser. > > > File Attachments > > > UI Before Change > > https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png > UI After Change > > https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png > > > Thanks, > > Greg Mann > >
Re: Review Request 72269: Added resource limits to the web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72269/ --- (Updated March 31, 2020, 4:14 p.m.) Review request for mesos and Qian Zhang. Bugs: MESOS-10055 https://issues.apache.org/jira/browse/MESOS-10055 Repository: mesos Description --- Added resource limits to the web UI. Diffs - src/webui/app/agents/agent-executor.html 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc Diff: https://reviews.apache.org/r/72269/diff/4/ Testing --- Viewed manually in a web browser. File Attachments (updated) UI Before Change https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png UI After Change https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png Thanks, Greg Mann
Re: Review Request 72269: Added resource limits to the web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72269/ --- (Updated March 31, 2020, 4:12 p.m.) Review request for mesos and Qian Zhang. Bugs: MESOS-10055 https://issues.apache.org/jira/browse/MESOS-10055 Repository: mesos Description --- Added resource limits to the web UI. Diffs (updated) - src/webui/app/agents/agent-executor.html 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc Diff: https://reviews.apache.org/r/72269/diff/4/ Changes: https://reviews.apache.org/r/72269/diff/3-4/ Testing --- Viewed manually in a web browser. Thanks, Greg Mann
