Review Request 72413: Updated executor API docs to include the domain socket.

2020-04-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/
---

Review request for mesos, Benjamin Mahler and Vinod Kone.


Repository: mesos


Description
---

Updated executor API docs to include the domain socket.


Diffs
-

  docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848 


Diff: https://reviews.apache.org/r/72413/diff/1/


Testing
---

Viewed with `site/mesos-website-dev.sh`.


Thanks,

Greg Mann



Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 22, 2020, 8:13 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Fix a build error on MacOS


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72402/diff/2/

Changes: https://reviews.apache.org/r/72402/diff/1-2/


Testing (updated)
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220407
---



Patch looks great!

Reviews applied: [72408, 72409, 72410]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 21, 2020, 8:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 21, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 72410: Updated existing documentation for resource limits.

2020-04-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
---

Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
Harper.


Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115


Repository: mesos


Description
---

Updated existing documentation for resource limits.


Diffs
-

  docs/nested-container-and-task-group.md 
3325ff8e3a694ede82e22b24ab258742746c0bb7 
  docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 


Diff: https://reviews.apache.org/r/72410/diff/1/


Testing
---


Thanks,

Greg Mann



Review Request 72409: Added intro docs on running workloads.

2020-04-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/
---

Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
Harper.


Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115


Repository: mesos


Description
---

This adds a new document containing an introduction for
scheduler authors to the available methods for running
workloads in a Mesos cluster.


Diffs
-

  docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e 
  docs/running-workloads.md PRE-CREATION 


Diff: https://reviews.apache.org/r/72409/diff/1/


Testing
---

Viewed with `site/mesos-website-dev.sh`


Thanks,

Greg Mann



Review Request 72408: Made the scheduler resources a top-level item in the documentation.

2020-04-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/
---

Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.


Repository: mesos


Description
---

Made the scheduler resources a top-level item in the documentation.


Diffs
-

  docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e 


Diff: https://reviews.apache.org/r/72408/diff/1/


Testing
---

Viewed using `site/mesos-website-dev.sh`


Thanks,

Greg Mann



Re: Review Request 72353: Added a regression test for MESOS-10114.

2020-04-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72353/#review220403
---



Bad patch!

Reviews applied: [72404, 72405, 72407, 72406, 72352, 72353]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72353"]

Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
eb6959a66df2: Waiting
1105027a5560: Waiting
c4c63e2501db: Waiting
668b207c2829: Waiting
c36946130a38: Waiting
6a6a5e68faab: Waiting
80e07249924c: Waiting
ed76dddad568: Waiting
78e58219b215: Verifying Checksum
78e58219b215: Download complete
0addb6fece63: Verifying Checksum
0addb6fece63: Download complete
eb6959a66df2: Verifying Checksum
eb6959a66df2: Download complete
18d680d61657: Verifying Checksum
18d680d61657: Download complete
c36946130a38: Verifying Checksum
c36946130a38: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
80e07249924c: Verifying Checksum
80e07249924c: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
ed76dddad568: Verifying Checksum
ed76dddad568: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out 'c27c583a904bca355ece5b6fc89944f57bcac9b2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b 

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warni

Review Request 72404: Fixed discard race in libwinio io operations.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72404/
---

Review request for mesos, Andrei Sekretenko and Greg Mann.


Bugs: MESOS-10123
https://issues.apache.org/jira/browse/MESOS-10123


Repository: mesos


Description
---

When getting a discard request for an io operation on windows,
a cancellation is requested and when the io operation completes
a check is performed to see if the future had a discard requested.
However, it's possible that the operation completed successfully
or had a failure and we should not be dropping that information
from the caller.

To correctly check whether the cancellation succeded, we need
to check for ERROR_OPERATION_ABORTED.


Diffs
-

  3rdparty/libprocess/src/windows/libwinio.cpp 
85ee7ea3e148ae26f2374918ed7c853a50b3b6c1 


Diff: https://reviews.apache.org/r/72404/diff/1/


Testing
---

make check and started running it through internal CI


Thanks,

Benjamin Mahler



Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72352/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-10114
https://issues.apache.org/jira/browse/MESOS-10114


Repository: mesos


Description
---

The accept loop was chaining the loop body Future on the result of
io::poll/io::read, which meant that any failed poll/read would cause
the loop body to return a failed future and the loop to stop running.

This would lead to the server socket silently no longer accepting
incoming connections.


Diffs
-

  3rdparty/libprocess/src/ssl/openssl_socket.hpp 
0528c03faaa5f8372cf09c1f51be66934f405661 
  3rdparty/libprocess/src/ssl/openssl_socket.cpp 
3f4dab6b92f202ee89cc2e06db997c41e4c6ca00 


Diff: https://reviews.apache.org/r/72352/diff/1/


Testing
---

Added a test in subsequent patch.


Thanks,

Benjamin Mahler



Review Request 72353: Added a regression test for MESOS-10114.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72353/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-10114
https://issues.apache.org/jira/browse/MESOS-10114


Repository: mesos


Description
---

It turns out we already had a test for this case, but in MESOS-10114
we need downgrade support enabled to exercise the bug.


Diffs
-

  3rdparty/libprocess/src/tests/ssl_tests.cpp 
3f1d1039bfdd686e43395c55c8edf6ab863ca7ac 


Diff: https://reviews.apache.org/r/72353/diff/1/


Testing
---

Ran through a windows CI that exercises the open ssl socket code.


Thanks,

Benjamin Mahler



Review Request 72407: Enabled io::poll read test on Windows / added io::poll write test.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72407/
---

Review request for mesos, Andrei Sekretenko and Greg Mann.


Repository: mesos


Description
---

Now that io::poll is implemented for windows we need to test it.

This also adds a test of write polling, which was absent before.


Diffs
-

  3rdparty/libprocess/src/tests/io_tests.cpp 
7e1d5148e2e3a80dcaaa5deb9d7a3ab080735994 


Diff: https://reviews.apache.org/r/72407/diff/1/


Testing
---

make check and started running it through internal CI


Thanks,

Benjamin Mahler



Review Request 72405: Added support for read readiness polling on Windows.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72405/
---

Review request for mesos, Andrei Sekretenko and Greg Mann.


Repository: mesos


Description
---

This uses the zero byte read trick on Windows in order to
implement read readiness polling on Windows.

The documentation for io::read has also been updated to explain
how zero byte reads are treated consistently across POSIX and
Windows.

Write readiness polling is left unimplemented since it's less
straightforward. A good explanation of the Windows landscape
for polling is here:

https://github.com/python-trio/trio/issues/52

A library providing an epoll like interface on Windows can
be found here:

https://github.com/piscisaureus/wepoll


Diffs
-

  3rdparty/libprocess/include/process/io.hpp 
468b3626e0121bc380ea592f485f3cfe9796d0fe 
  3rdparty/libprocess/src/io.cpp 7288d5fa1c79f5d19a9369e6431dc98d92307868 
  3rdparty/libprocess/src/io_internal.hpp 
09bfa9a386a3eb89a987eea18e08144a50aaf5c7 
  3rdparty/libprocess/src/windows/io.cpp 
90e780d4d3eae7af71ee39ff99105147992e968d 


Diff: https://reviews.apache.org/r/72405/diff/1/


Testing
---

Added a test in subsequent patch.


Thanks,

Benjamin Mahler



Review Request 72406: Fixed a bug where the openssl socket can block forever.

2020-04-21 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72406/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-10124
https://issues.apache.org/jira/browse/MESOS-10124


Repository: mesos


Description
---

Using the zero byte read trick against io::read is problematic
since io::read aims to provide consistent behavior across POSIX
and Windows by returning immediately.

Now that io::poll for reads is implemented, we can fix this by
removing the Windows specialization and just using io::poll.


Diffs
-

  3rdparty/libprocess/src/ssl/openssl_socket.cpp 
3f4dab6b92f202ee89cc2e06db997c41e4c6ca00 


Diff: https://reviews.apache.org/r/72406/diff/1/


Testing
---

make check and started running it through internal CI


Thanks,

Benjamin Mahler



Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220400
---



Bad patch!

Reviews applied: [72398, 72399, 72400, 72401, 72391, 72402]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72402"]

Error:
..
c9-4737-a6e3-ca2edfd73017) for operation UUID 
cdf52570-bae5-483f-873e-8ebab662316c on agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0
I0421 15:16:50.142735  3116 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:39421/slave(1243)/api/v1/resource_provider
I0421 15:16:50.144177  3102 process.cpp:3671] Handling HTTP event for process 
'slave(1243)' with path: '/slave(1243)/api/v1/resource_provider'
I0421 15:16:50.147536  3110 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.154475ms
I0421 15:16:50.148366  3117 master.cpp:9485] Sending offers [ 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3 ] to framework 
bffc3f66-e431-4b06-9b3b-83e48ec55a41- (default) at 
scheduler-0d3636d3-5c9a-47b4-a491-52b46efa95bf@172.17.0.2:39421
I0421 15:16:50.149140  3117 sched.cpp:934] Scheduler::resourceOffers took 
106047ns
I0421 15:16:50.152581  3113 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0421 15:16:50.154829  3112 http.cpp:1436] HTTP POST for /master/api/v1 from 
172.17.0.2:57852
I0421 15:16:50.155150  3112 http.cpp:277] Processing call CREATE_VOLUMES
I0421 15:16:50.156154  3112 master.cpp:3705] Authorizing principal 
'test-principal' to perform action CREATE_VOLUME on object 
{"value":"storage/default-role","resource":{"provider_id":{"value":"dd6f554f-b06c-4174-8993-2f76c8863f42"},"name":"disk","type":"SCALAR","scalar":{"value":2048.0},"reservations":[{"type":"DYNAMIC","role":"storage"},{"type":"DYNAMIC","role":"storage/default-role","principal":"test-principal"}],"disk":{"persistence":{"id":"f3b30858-2e92-430b-866c-4c8594aa10de","principal":"test-principal"},"volume":{"mode":"RW","container_path":"volume"},"source":{"type":"MOUNT","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"vendor":"org.apache.mesos.csi.test.local","id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548","profile":"test"
I0421 15:16:50.157893  3117 sched.cpp:960] Rescinded offer 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3
I0421 15:16:50.157977  3117 sched.cpp:971] Scheduler::offerRescinded took 
26745ns
I0421 15:16:50.158427  3103 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548,test)]:2048,
 offered or allocated: {}) on agent bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 
from framework bffc3
 f66-e431-4b06-9b3b-83e48ec55a41-
I0421 15:16:50.158565  3110 master.cpp:11784] Removing offer 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3
I0421 15:16:50.160090  3103 hierarchical.cpp:1625] Framework 
bffc3f66-e431-4b06-9b3b-83e48ec55a41- filtered agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 for 5secs
I0421 15:16:50.162694  3113 master.cpp:11649] Sending operation '' (uuid: 
b8903c93-0234-498f-87c1-4448d77832d0) to agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 at slave(1243)@172.17.0.2:39421 
(76b885a4b2f3)
I0421 15:16:50.163290  3113 slave.cpp:4545] Ignoring new checkpointed resources 
and operations identical to the current version
I0421 15:16:50.166703  3105 provider.cpp:498] Received APPLY_OPERATION event
I0421 15:16:50.166751  3105 provider.cpp:1351] Received CREATE operation '' 
(uuid: b8903c93-0234-498f-87c1-4448d77832d0)
I0421 15:16:50.170713  3116 master.cpp:5533] Processing REVIVE call for 
framework bffc3f66-e431-4b06-9b3b-83e48ec55a41- (default) at 
scheduler-0d3636d3-5c9a-47b4-a491-52b46efa95bf@172.17.0.2:39421
I0421 15:16:50.171152  3116 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-r

Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72402/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72391/
---

(Updated April 21, 2020, 9:21 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Added special handling for command tasks.


Bugs: MESOS-10054
https://issues.apache.org/jira/browse/MESOS-10054


Repository: mesos


Description
---

Updated Docker containerizer to set Docker container's resource limits.


Diffs (updated)
-

  include/mesos/values.hpp 27f71d1e84f169e169e786372ed38e99be68e4ce 
  src/common/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660 
  src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d 
  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72391/diff/2/

Changes: https://reviews.apache.org/r/72391/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 72401: Updated Docker containerizer by not updating resources for command task.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72401/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10054
https://issues.apache.org/jira/browse/MESOS-10054


Repository: mesos


Description
---

Updated Docker containerizer by not updating resources for command task.


Diffs
-

  src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d 
  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72401/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 72400: Updated `StatisticsEndpointRunningExecutor` to support resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72400/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated `StatisticsEndpointRunningExecutor` to support resource limits.


Diffs
-

  src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db 


Diff: https://reviews.apache.org/r/72400/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 72399: Updated UCR's `usage()` method to support resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72399/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated UCR's `usage()` method to support resource limits.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
2ea033aa1869f07644b10c036fda1698d08aa89b 
  src/slave/containerizer/mesos/containerizer.cpp 
6aa4f3fe0940575aeea6a63cdb1ca3c77cd2359b 


Diff: https://reviews.apache.org/r/72399/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 72398: Updated `ResourceStatistics` to support container resource limits.

2020-04-21 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72398/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated `ResourceStatistics` to support container resource limits.


Diffs
-

  include/mesos/mesos.proto 9412ed736231547b22abc89188316b08d5445e78 
  include/mesos/v1/mesos.proto 194c42cf57e34d803a21cab03db17614855e8692 


Diff: https://reviews.apache.org/r/72398/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 72389: Fixed composing authorization callback path on Windows.

2020-04-21 Thread Andrei Sekretenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72389/
---

(Updated April 21, 2020, 8:16 a.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10120
https://issues.apache.org/jira/browse/MESOS-10120


Repository: mesos


Description
---

Fixed composing authorization callback path on Windows.


Diffs
-

  3rdparty/libprocess/src/process.cpp 4ae5de30273fdf39788de2c25126b3b92e271957 


Diff: https://reviews.apache.org/r/72389/diff/1/


Testing
---


Thanks,

Andrei Sekretenko