Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72734/#review221509 --- Bad review! Reviews applied: [72734, 72733, 72690, 72716, 72707, 72715, 72681, 72672, 72661, 72660] Error: 2020-08-08 17:23:07 URL:https://reviews.apache.org/r/72733/diff/raw/ [17892/17892] -> "72733.patch" [1] error: patch failed: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp:16 error: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp: patch does not apply - Mesos Reviewbot On Aug. 8, 2020, 3:18 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72734/ > --- > > (Updated Aug. 8, 2020, 3:18 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10154 > https://issues.apache.org/jira/browse/MESOS-10154 > > > Repository: mesos > > > Description > --- > > Implemented the `cleanup` method of `volume/csi` isolator. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72734/diff/3/ > > > Testing > --- > > > Thanks, > > Qian Zhang > >
Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 8, 2020, 11:58 p.m.) Review request for mesos, Andrei Budnik and Greg Mann. Changes --- Added a missing include. Bugs: MESOS-10152 https://issues.apache.org/jira/browse/MESOS-10152 Repository: mesos Description --- Implemented the framework and `create` method of `volume/csi` isolator. Diffs (updated) - src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72690/diff/10/ Changes: https://reviews.apache.org/r/72690/diff/9-10/ Testing --- Thanks, Qian Zhang
Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72734/ --- (Updated Aug. 8, 2020, 11:18 p.m.) Review request for mesos, Andrei Budnik and Greg Mann. Changes --- Minor changes. Bugs: MESOS-10154 https://issues.apache.org/jira/browse/MESOS-10154 Repository: mesos Description --- Implemented the `cleanup` method of `volume/csi` isolator. Diffs (updated) - src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72734/diff/3/ Changes: https://reviews.apache.org/r/72734/diff/2-3/ Testing --- Thanks, Qian Zhang
