Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

[Greg Mann]

> On Aug. 25, 2020, 2:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > 
> >
> > It seems we only want to verify the behavior of CSI server but not 
> > launch a task from end to end, maybe we do not need to start master and 
> > agent just like what we do in `ROOT_InvalidPluginConfig`?

In this case, we still need the agent so that the CSI plugin can actually be 
initialized successfully.

Another option for this test would be to use a task launch to test this same 
thing from end-to-end. I left it as-is because the task launching boilerplate 
makes the test much larger, so this version is more concise. WDYT?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
---


On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> ---
> 
> (Updated Aug. 26, 2020, 5:57 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the 'volume/csi' isolator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 
>   src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/10/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 72805: Added a test helper for CSI volumes.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/
---

Review request for mesos and Qian Zhang.


Repository: mesos


Description
---

Added a test helper for CSI volumes.


Diffs
-

  src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1 


Diff: https://reviews.apache.org/r/72805/diff/1/


Testing
---

Testing details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72804/#review221710
---



Bad patch!

Reviews applied: [72804, 72803]

Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72803

Error:
2020-08-26 05:11:22 URL:https://reviews.apache.org/r/72803/diff/raw/ 
[2084/2084] -> "72803.patch" [1]

*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for ) not allowed

Full log: 
https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/116/console

- Mesos Reviewbot


On Aug. 26, 2020, 2:38 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72804/
> ---
> 
> (Updated Aug. 26, 2020, 2:38 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10153
> https://issues.apache.org/jira/browse/MESOS-10153
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported chown CSI volumes in the `volume/csi` isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp 
> 373b629a984b6d7f207bc65899e32d5f023685ee 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 
> 02ef1f215eeb0e6436d42146b922d8a48e023607 
> 
> 
> Diff: https://reviews.apache.org/r/72804/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 72803: Added a new agent flag `--csi_volume_chown`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72803/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10153
https://issues.apache.org/jira/browse/MESOS-10153


Repository: mesos


Description
---

Added a new agent flag `--csi_volume_chown`.


Diffs
-

  docs/configuration/agent.md 4899202e1afa2988acb3c066829e26aa9612fd29 
  src/slave/flags.hpp 51770f5d6e8ba853cb5ae2e82739329a26f01ff4 
  src/slave/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3 


Diff: https://reviews.apache.org/r/72803/diff/1/


Testing
---


Thanks,

Qian Zhang

Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72804/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10153
https://issues.apache.org/jira/browse/MESOS-10153


Repository: mesos


Description
---

Supported chown CSI volumes in the `volume/csi` isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp 
373b629a984b6d7f207bc65899e32d5f023685ee 
  src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 
02ef1f215eeb0e6436d42146b922d8a48e023607 


Diff: https://reviews.apache.org/r/72804/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72787: Added basic tests for regexp-based constraints.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72787/#review221709
---



Bad patch!

Reviews applied: [72787, 72786, 72784, 72783, 72782, 72776, 72775, 72745, 
72744, 72743, 72774, 72742, 72741, 72739, 72738, 72771]

Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72782

Error:
2020-08-25 22:14:54 URL:https://reviews.apache.org/r/72782/diff/raw/ 
[527481/527481] -> "72782.patch" [1]

*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for ) not allowed

Full log: 
https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/109/console

- Mesos Reviewbot


On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72787/
> ---
> 
> (Updated Aug. 19, 2020, 12:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added basic tests for regexp-based constraints.
> 
> 
> Diffs
> -
> 
>   src/tests/master/offer_constraints_filter_tests.cpp 
> f88e2011bc510323344ffe58fd550b7683242950 
> 
> 
> Diff: https://reviews.apache.org/r/72787/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72786: Implemented regex-based offer constraints.

[Andrei Sekretenko]

> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/offer_constraints_filter.cpp
> > Lines 113-119 (patched)
> > 
> >
> > How did you figure this out? Just from your own testing?
> > 
> > What about with clang? Same result?
> > 
> > How much faster? Is it worth bothering?
> 
> Andrei Sekretenko wrote:
> Around 10% of the allocation loop time in a rather pecualr, although not 
> exotic, situation: a fast regexp that filters out most of the agents.
> Probably not worth bothering until we have a well-parametrized benchmark.
> 
> Maybe instead I should figure out if -O3 (which is the default in ther 
> Makefile, as opposed to cMake with RelWithDebInfo, which by defautl uses -O2) 
> can get us rid of this buffer zeroing: 
> https://github.com/google/re2/blob/ca11026a032ce2a3de4b3c389ee53d2bdc8794d6/re2/re2.cc#L907
> in the case of FullMatch.
> 
> If it does, it might be worth making the CMake build less consistent 
> internally but more consistent with the "standard" build flags of RE2.

Hmm.. now I don't see such a large effect with the draft benchmark I have at 
hand; either I've lost the version that was exhibiting that 10% difference or 
that was a measurement error.
Tried -O3, that doesn't help to optimize out that `memset` in `RE2::DoMatch()`. 
Dropped this wrapper.


> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > src/master/constants.hpp
> > Lines 182 (patched)
> > 
> >
> > regular
> > 
> > Anything you can add about how these numbers were produced? Would be 
> > helpful.

Added an example regex similar to what we saw in some of the real-world 
Marathon apps and extracted the minimum max_mem under which it constructs 
successfully.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/#review221697
---


On Aug. 25, 2020, 6:43 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72786/
> ---
> 
> (Updated Aug. 25, 2020, 6:43 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented regex-based offer constraints.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 05d0e9c46485c3048a65d46747d56e715883a0b3 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION 
>   src/master/allocator/mesos/offer_constraints_filter.cpp 
> d724fd0a9832feea26f6db1a498b6bdee830 
>   src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b 
>   src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 
>   src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a 
>   src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 
>   src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e 
>   src/tests/master/offer_constraints_filter_tests.cpp 
> 84a1e917a52d0b98f979e454c2b982c6402b0176 
> 
> 
> Diff: https://reviews.apache.org/r/72786/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72786: Implemented regex-based offer constraints.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/
---

(Updated Aug. 25, 2020, 6:43 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

- switched the `max_mem` flag to `Bytes`, fixed the type of 
`DEFAULT_OFFER_CONSTRAINTS_RE2_MAX_PROGRAM_SIZE`
- dropped the local `fullMatch()` wrapper


Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173


Repository: mesos


Description
---

Implemented regex-based offer constraints.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
05d0e9c46485c3048a65d46747d56e715883a0b3 
  src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
  src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION 
  src/master/allocator/mesos/offer_constraints_filter.cpp 
d724fd0a9832feea26f6db1a498b6bdee830 
  src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b 
  src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 
  src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a 
  src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 
  src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e 
  src/tests/master/offer_constraints_filter_tests.cpp 
84a1e917a52d0b98f979e454c2b982c6402b0176 


Diff: https://reviews.apache.org/r/72786/diff/6/

Changes: https://reviews.apache.org/r/72786/diff/5-6/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
---

(Updated Aug. 25, 2020, 6:38 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Extended the comment on RE2 limits


Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173


Repository: mesos


Description
---

This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.

Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.

Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
06d62f5f4ed9286a6ad50f80d1261e4e732d1bc7 
  include/mesos/v1/scheduler/scheduler.proto 
08fb10a146e0b57896a0cb098178a40e618df392 


Diff: https://reviews.apache.org/r/72784/diff/4/

Changes: https://reviews.apache.org/r/72784/diff/3-4/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 72728: Added unit tests for the CSI server.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
---




src/tests/csi_server_tests.cpp
Lines 19 (patched)


It seems we do not need this?



src/tests/csi_server_tests.cpp
Lines 106-107 (patched)


A newline between. Ditto for line 111-112.



src/tests/csi_server_tests.cpp
Lines 403 (patched)


I do not see how this volume is used by the task, I think we should set the 
volume into the task's `containerInfo.volumes`.



src/tests/csi_server_tests.cpp
Lines 408 (patched)


Can we launch the task to run a command to write to the volume rather than 
just `exit 0`?



src/tests/csi_server_tests.cpp
Lines 457 (patched)


It seems we only want to verify the behavior of CSI server but not launch a 
task from end to end, maybe we do not need to start master and agent just like 
what we do in `ROOT_InvalidPluginConfig`?


- Qian Zhang


On Aug. 25, 2020, 5:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> ---
> 
> (Updated Aug. 25, 2020, 5:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit tests for the CSI server.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/csi_server_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/9/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72785/#review221706
---



Bad patch!

Reviews applied: [72785]

Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72785

Error:
2020-08-25 14:11:32 URL:https://reviews.apache.org/r/72785/diff/raw/ 
[7759/7759] -> "72785.patch" [1]

*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for ) not allowed

Full log: 
https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/102/console

- Mesos Reviewbot


On Aug. 17, 2020, 8:20 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72785/
> ---
> 
> (Updated Aug. 17, 2020, 8:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a key-value cache that hands out shared pointers to
> cached items, but does not own the items (hence, the items get
> deleted as soon as they are no longer referenced by anything else).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am ad3f2105d9e159995be1979007d6ddbe5ec9e133 
>   3rdparty/stout/include/stout/weak_cache.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 
> e3291c72d1875f5b196dd5ea2ba20e7d53881b87 
>   3rdparty/stout/tests/weak_cache_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72785/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72786: Implemented regex-based offer constraints.

[Andrei Sekretenko]

> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > Hm.. is it possible to have a simpler patch that avoids the factory and 
> > instead passes the flags through the creation path?

This is possible; however, I would argue that putting limits on RE2 is rather 
deep implemenation detail which should not pollute the **public allocator 
interface**.

Given this, and also the need for caching, I'm not sure that passing the flags 
through creation path and removing them right after that makes a lot of sense.


> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/offer_constraints_filter.cpp
> > Lines 113-119 (patched)
> > 
> >
> > How did you figure this out? Just from your own testing?
> > 
> > What about with clang? Same result?
> > 
> > How much faster? Is it worth bothering?

Around 10% of the allocation loop time in a rather pecualr, although not 
exotic, situation: a fast regexp that filters out most of the agents.
Probably not worth bothering until we have a well-parametrized benchmark.

Maybe instead I should figure out if -O3 (which is the default in ther 
Makefile, as opposed to cMake with RelWithDebInfo, which by defautl uses -O2) 
can get us rid of this buffer zeroing: 
https://github.com/google/re2/blob/ca11026a032ce2a3de4b3c389ee53d2bdc8794d6/re2/re2.cc#L907
in the case of FullMatch.

If it does, it might be worth making the CMake build less consistent internally 
but more consistent with the "standard" build flags of RE2.


> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > src/master/flags.hpp
> > Lines 125-126 (patched)
> > 
> >
> > Just noticed that these don't line up with the above constant types, is 
> > that intentional?
> > 
> > Can we make max_mem of type `Bytes`? That would let a user specify 
> > "4kb", "4MB" etc

These are types are identical to those used in RE2. 
I'll try `Bytes`, though; if flags work with that, that would be great.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/#review221697
---


On Aug. 24, 2020, 7:46 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72786/
> ---
> 
> (Updated Aug. 24, 2020, 7:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented regex-based offer constraints.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 05d0e9c46485c3048a65d46747d56e715883a0b3 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION 
>   src/master/allocator/mesos/offer_constraints_filter.cpp 
> ef8a948260d92a9d54efb65f0e5c8aa3d0c67b91 
>   src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b 
>   src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 
>   src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a 
>   src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 
>   src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e 
>   src/tests/master/offer_constraints_filter_tests.cpp 
> f88e2011bc510323344ffe58fd550b7683242950 
> 
> 
> Diff: https://reviews.apache.org/r/72786/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.

[Andrei Sekretenko]

> On Aug. 24, 2020, 9:14 p.m., Benjamin Mahler wrote:
> > Do we also want to be checking pseudoattributes? (Different enums and 
> > handling optionality (e.g. domain)).

We surely need.
Added https://issues.apache.org/jira/browse/MESOS-10180 to the epic for this 
(and for other poorly covered functionality).


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72776/#review221695
---


On Aug. 24, 2020, 7:35 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72776/
> ---
> 
> (Updated Aug. 24, 2020, 7:35 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10172
> https://issues.apache.org/jira/browse/MESOS-10172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added basic tests for offer constraints on a string attribute equality.
> 
> 
> Diffs
> -
> 
>   src/tests/master/offer_constraints_filter_tests.cpp 
> f88e2011bc510323344ffe58fd550b7683242950 
> 
> 
> Diff: https://reviews.apache.org/r/72776/diff/4/
> 
> 
> Testing
> ---
> 
> `support/mesos-gtest-runner.py src/mesos-tests`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72727/#review221702
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 18, 2020, 9:23 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72727/
> ---
> 
> (Updated Aug. 18, 2020, 9:23 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds additional configuration flags to the
> test CSI plugin which are necessary in order to test
> the agent's CSI server.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 
> 
> 
> Diff: https://reviews.apache.org/r/72727/diff/4/
> 
> 
> Testing
> ---
> 
> These new flags are used in a subsequent test in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>