Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72806/#review221803
---


Ship it!




Ship It!

- Qian Zhang


On Sept. 4, 2020, 2:39 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72806/
> ---
> 
> (Updated Sept. 4, 2020, 2:39 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for 'volume/csi' isolator recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72806/diff/8/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

[Greg Mann]

> On Sept. 4, 2020, 3:04 a.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 1676-1689 (patched)
> > 
> >
> > Could you please elaborate a bit on why we need to publish the volume 
> > here? I think during recovery volume manager will publish the volume 
> > internally, right? And why does `targetPath` not exist when publishing 
> > volume succeeds?

I ended up removing this test since I wasn't able to synchronize it correctly.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72806/#review221801
---


On Sept. 4, 2020, 6:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72806/
> ---
> 
> (Updated Sept. 4, 2020, 6:39 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for 'volume/csi' isolator recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72806/diff/8/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72806/
---

(Updated Sept. 4, 2020, 6:39 a.m.)


Review request for mesos and Qian Zhang.


Repository: mesos


Description
---

Added tests for 'volume/csi' isolator recovery.


Diffs (updated)
-

  src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/72806/diff/8/

Changes: https://reviews.apache.org/r/72806/diff/7-8/


Testing
---

`sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`


Thanks,

Greg Mann