Re: Review Request 47641: Fix navbar alignment on large screen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47641/#review134121 --- Ship it! Ship It! - Freddy Ayuso-Henson On May 20, 2016, 8:16 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47641/ > --- > > (Updated May 20, 2016, 8:16 a.m.) > > > Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg, > and Vinod Kone. > > > Bugs: MESOS-3690 > https://issues.apache.org/jira/browse/MESOS-3690 > > > Repository: mesos > > > Description > --- > > On screens with more than 992px navbar is aligned to the bottom > of the header, this patch change this behaviour and navbar > is vertically centered > > > Diffs > - > > site/source/assets/css/main.css bfee2dd6810bb341c1e8c2504d6338a76518ace9 > > Diff: https://reviews.apache.org/r/47641/diff/ > > > Testing > --- > > ![compare](http://s32.postimg.org/6soj2c6h1/compare.png) > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47510: Adjusted style to make website mobile friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133895 --- Ship it! Ship It! - Freddy Ayuso-Henson On May 18, 2016, 6:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47510/ > --- > > (Updated May 18, 2016, 6:04 p.m.) > > > Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim > Anderegg, and Vinod Kone. > > > Bugs: MESOS-3690 > https://issues.apache.org/jira/browse/MESOS-3690 > > > Repository: mesos > > > Description > --- > > Adjusted style to make website mobile friendly. > > > Diffs > - > > site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 > site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 > site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 > > Diff: https://reviews.apache.org/r/47510/diff/ > > > Testing > --- > > # Note > @vinodkone, this should credited to @fayusohenson and @janisz when submit. > I pick the necessary changes for mobile friendly from > https://github.com/apache/mesos/pull/75 . > > And record some simple videos under mobile, tablet and pc to show this patch. > > ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif) > ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif) > ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif) > > > Thanks, > > haosdent huang > >
Re: Review Request 47510: Adjusted style to make website mobile friendly.
> On May 19, 2016, 7:12 a.m., Freddy Ayuso-Henson wrote: > > Here are some screenshots of what the original PR aimed to achieve. It's a > > bit different from what's being reviewed, I think (moving the ASF > > links/breadcrumbs to the footer, vertically centering the menu on the > > desktop, alignment of the menu on mobile, etc.) > > > > Should we add these changes to the what's being reviewed? > > > > ![Desktop](https://issues.apache.org/jira/secure/attachment/12804884/mesos-screenshot.png) > > ![Mobile without > > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile.png) > > ![Mobile with > > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile1.png) > > haosdent huang wrote: > >moving the ASF links/breadcrumbs to the footer, vertically centering the > menu on the desktop, alignment of the menu on mobile, etc > @fayusohenson I think it is better to keep the breadcrumb on the head > currently without broken current PC style. > After new design out, we could discuss if move it to the footer. For > short term, I suggest to keep it so I remove that in your patch. > Do you think this is make sense? Yes, that sounds good. - Freddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133892 --- On May 18, 2016, 6:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47510/ > ----------- > > (Updated May 18, 2016, 6:04 p.m.) > > > Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim > Anderegg, and Vinod Kone. > > > Bugs: MESOS-3690 > https://issues.apache.org/jira/browse/MESOS-3690 > > > Repository: mesos > > > Description > --- > > Adjusted style to make website mobile friendly. > > > Diffs > - > > site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 > site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 > site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 > > Diff: https://reviews.apache.org/r/47510/diff/ > > > Testing > --- > > # Note > @vinodkone, this should credited to @fayusohenson and @janisz when submit. > I pick the necessary changes for mobile friendly from > https://github.com/apache/mesos/pull/75 . > > And record some simple videos under mobile, tablet and pc to show this patch. > > ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif) > ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif) > ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif) > > > Thanks, > > haosdent huang > >
Re: Review Request 47510: Adjusted style to make website mobile friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133892 --- Here are some screenshots of what the original PR aimed to achieve. It's a bit different from what's being reviewed, I think (moving the ASF links/breadcrumbs to the footer, vertically centering the menu on the desktop, alignment of the menu on mobile, etc.) Should we add these changes to the what's being reviewed? ![Desktop](https://issues.apache.org/jira/secure/attachment/12804884/mesos-screenshot.png) ![Mobile without menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile.png) ![Mobile with menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile1.png) - Freddy Ayuso-Henson On May 18, 2016, 6:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47510/ > --- > > (Updated May 18, 2016, 6:04 p.m.) > > > Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim > Anderegg, and Vinod Kone. > > > Bugs: MESOS-3690 > https://issues.apache.org/jira/browse/MESOS-3690 > > > Repository: mesos > > > Description > --- > > Adjusted style to make website mobile friendly. > > > Diffs > - > > site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 > site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 > site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 > > Diff: https://reviews.apache.org/r/47510/diff/ > > > Testing > --- > > # Note > @vinodkone, this should credited to @fayusohenson and @janisz when submit. > I pick the necessary changes for mobile friendly from > https://github.com/apache/mesos/pull/75 . > > And record some simple videos under mobile, tablet and pc to show this patch. > > ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif) > ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif) > ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif) > > > Thanks, > > haosdent huang > >