Review Request 51157: Added testing for the container plugin of the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51157/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- While introducing testing for the container plugin, some changes were made to the plugin methods themselves mainly to allow the return of stdout by methods that make use of nsenter is some way. Diffs - src/cli_new/bin/tests.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/51157/diff/ Testing ---  Thanks, Haris Choudhary
Re: Review Request 51111: Added the container plugin to the Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated Aug. 16, 2016, 11:09 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This plugin allows us to interact with mesos containers in various ways. Testing for this plugin will be introduced at later point. Diffs (updated) - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/5/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51146: Added testing for the agent plugin of the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51146/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- Added testing for the agent plugin of the CLI. Diffs - src/cli_new/bin/tests.py PRE-CREATION src/cli_new/lib/mesos/plugins/agent/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/51146/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51145: Added testing for the cluster plugin of the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51145/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- Added testing for the cluster plugin of the CLI. Diffs - src/cli_new/bin/tests.py PRE-CREATION src/cli_new/lib/mesos/plugins/cluster/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/51145/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- (Updated Aug. 16, 2016, 7:22 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This class will be inherited by future plugin test classes and deals with setting up and bringing down a cluster for plugins to use during testing. Diffs (updated) - src/cli_new/lib/mesos/PluginTestBase.py PRE-CREATION Diff: https://reviews.apache.org/r/51110/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51127: Added the cluster plugin the the Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51127/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This plugin allows us to interact with the mesos cluster in various ways. Testing for this plugin will be introduced at a later point. Diffs - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION src/cli_new/lib/mesos/plugins/cluster/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/cluster/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/cluster/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/51127/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 51111: Added the container plugin to the Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated Aug. 16, 2016, 1:48 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This plugin allows us to interact with mesos containers in various ways. Testing for this plugin will be introduced at later point. Diffs (updated) - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/5/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51113: Added the agent plugin the the Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51113/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This plugin allows us to interact with mesos agents in various ways. Testing for this plugin will be introduced at a later point. Diffs - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/agent/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/agent/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/agent/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/51113/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- (Updated Aug. 16, 2016, 1:45 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This class will be inherited by future plugin test classes and deals with setting up and bringing down a cluster for plugins to use during testing. Diffs (updated) - src/cli_new/lib/mesos/PluginTestBase.py PRE-CREATION Diff: https://reviews.apache.org/r/51110/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 51108: Added additional parameters to the CLI config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51108/ --- (Updated Aug. 16, 2016, 1:44 a.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- These parameters will be used by future plugins in the CLI. We can either edit them directly from the config file or discover them through environment variables. The environment variables override any edits made to the config file. Also added the ability to format command flags in the base plugin class. This allows us to not import the config file within individual plugins to do so. The Key-Value pairs for formatting will be introduced with with future plugins. Diffs (updated) - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION Diff: https://reviews.apache.org/r/51108/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51111: Added the container plugin to the Mesos CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This plugin allows us to interact with mesos containers in various ways. Testing for this plugin will be introduced at later point. Diffs - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/__init__.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION Diff: https://reviews.apache.org/r/5/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- (Updated Aug. 15, 2016, 9:57 p.m.) Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- This class will be inherited by future plugin test classes and deals with setting up and bringing down a cluster for plugins to use during testing. Diffs - src/cli_new/lib/mesos/PluginTestBase.py PRE-CREATION Diff: https://reviews.apache.org/r/51110/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51110: Introduced the PluginTestBase class into the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- Review request for mesos. Repository: mesos Description --- This class will be inherited by future plugin test classes and deals with setting up and bringing down a cluster for plugins to use during testing. Diffs - src/cli_new/lib/mesos/PluginTestBase.py PRE-CREATION Diff: https://reviews.apache.org/r/51110/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51109: Added a Table abstraction and some functions to the CLI util file. These will be used by future plugins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51109/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- Added a Table abstraction and some functions to the CLI util file. These will be used by future plugins. Diffs - src/cli_new/lib/mesos/util.py PRE-CREATION Diff: https://reviews.apache.org/r/51109/diff/ Testing --- Thanks, Haris Choudhary
Review Request 51108: Added additional parameters to the CLI config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51108/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https://issues.apache.org/jira/browse/mesos-5676 Repository: mesos Description --- These parameters will be used by future plugins in the CLI. We can either edit them directly from the config file or discover them through environment variables. The environment variables override any edits made to the config file. Also added the ability to format command flags in the base plugin class. This allows us to not import the config file within individual plugins to do so. The Key-Value pairs for formatting will be introduced with with future plugins. Diffs - src/cli_new/bin/config.py PRE-CREATION src/cli_new/lib/mesos/plugins/base.py PRE-CREATION Diff: https://reviews.apache.org/r/51108/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/ --- (Updated Aug. 11, 2016, 9:54 p.m.) Review request for mesos, Kevin Klues and Vinod Kone. Bugs: Mesos-6006 https://issues.apache.org/jira/browse/Mesos-6006 Repository: mesos Description --- It currently doesn't run over any files in the code base, but we will be adding the new python CLI in a subsequent commit, which will use this new linter. Diffs (updated) - support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50910/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/ --- (Updated Aug. 11, 2016, 8:02 p.m.) Review request for mesos, Kevin Klues and Vinod Kone. Bugs: Mesos-6006 https://issues.apache.org/jira/browse/Mesos-6006 Repository: mesos Description --- It currently doesn't run over any files in the code base, but we will be adding the new python CLI in a subsequent commit, which will use this new linter. Diffs (updated) - support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50910/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
> On Aug. 10, 2016, 4:53 a.m., Vinod Kone wrote: > > support/mesos-style.py, line 242 > > <https://reviews.apache.org/r/50910/diff/1/?file=1467414#file1467414line242> > > > > Don't follow this comment? I meant that as a note to myself. Forgot to remove it. I was talking about how pylint does not give us access to the number of errors and so we need to parse the output to obtain our result. - Haris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145305 --- On Aug. 10, 2016, 10:43 p.m., Haris Choudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50910/ > --- > > (Updated Aug. 10, 2016, 10:43 p.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: Mesos-6006 > https://issues.apache.org/jira/browse/Mesos-6006 > > > Repository: mesos > > > Description > --- > > It currently doesn't run over any files in the code base, but we will > be adding the new python CLI in a subsequent commit, which will use > this new linter. > > > Diffs > - > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50910/diff/ > > > Testing > --- > > > Thanks, > > Haris Choudhary > >
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/ --- (Updated Aug. 10, 2016, 10:43 p.m.) Review request for mesos, Kevin Klues and Vinod Kone. Bugs: Mesos-6006 https://issues.apache.org/jira/browse/Mesos-6006 Repository: mesos Description --- It currently doesn't run over any files in the code base, but we will be adding the new python CLI in a subsequent commit, which will use this new linter. Diffs (updated) - support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50910/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
> On Aug. 10, 2016, 4:53 a.m., Vinod Kone wrote: > > support/mesos-style.py, lines 228-234 > > <https://reviews.apache.org/r/50910/diff/1/?file=1467414#file1467414line228> > > > > this indentation looks weird? or is it just RB? I fixed that. Hope its better now. - Haris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145305 --- On Aug. 10, 2016, 10:43 p.m., Haris Choudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50910/ > --- > > (Updated Aug. 10, 2016, 10:43 p.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: Mesos-6006 > https://issues.apache.org/jira/browse/Mesos-6006 > > > Repository: mesos > > > Description > --- > > It currently doesn't run over any files in the code base, but we will > be adding the new python CLI in a subsequent commit, which will use > this new linter. > > > Diffs > - > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50910/diff/ > > > Testing > --- > > > Thanks, > > Haris Choudhary > >
Re: Review Request 50910: Added a python linter to mesos-style.cpp.
> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > <https://reviews.apache.org/r/50910/diff/1/?file=1467414#file1467414line228> > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the virtual environment, otherwise it > > runs using the system python, which is not what we want. Especially for > > import libraries. There are two approaches to this: 1) We can either activate the virtualenv from the CLI and than run pylint. But that means if the virtualenv is not created within the CLI we will have to create it and activate it. 2) We can integrate the virtualenv to the project wide bootstrap and thus ensuring the the virtualenv is created for the project on bootstrapping mesos. This seems to be the better way to do it however might require significant changes as opposed to (1). It'd be desirable to have a project-wide virtualenv at some point however even if we choose to not do so right now. A thing to note here is that if we integrate it to the project wide bootstrap, we'll need users to have virtualenv installed for mesos instead of only the CLI. - Haris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145386 --- On Aug. 8, 2016, 10:10 p.m., Haris Choudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50910/ > --- > > (Updated Aug. 8, 2016, 10:10 p.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: Mesos-6006 > https://issues.apache.org/jira/browse/Mesos-6006 > > > Repository: mesos > > > Description > --- > > It currently doesn't run over any files in the code base, but we will > be adding the new python CLI in a subsequent commit, which will use > this new linter. > > > Diffs > - > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50910/diff/ > > > Testing > --- > > > Thanks, > > Haris Choudhary > >
Review Request 50910: Added a python linter to mesos-style.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: Mesos-6006 https://issues.apache.org/jira/browse/Mesos-6006 Repository: mesos Description --- It currently doesn't run over any files in the code base, but we will be adding the new python CLI in a subsequent commit, which will use this new linter. Diffs - support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50910/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 49864: Fixed ExecutorPIDTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/ --- (Updated July 12, 2016, 7:05 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Fixed ExecutorPIDTest. Diffs (updated) - src/tests/containerizer/mesos_containerizer_tests.cpp 57588cc1fb918924a163bdb40b195cc5f4231f6e Diff: https://reviews.apache.org/r/49864/diff/ Testing --- Make and make check Thanks, Haris Choudhary
Re: Review Request 49864: Fixed ExecutorPIDTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/ --- (Updated July 10, 2016, 6:28 a.m.) Review request for mesos and Jie Yu. Repository: mesos Description (updated) --- Fixed ExecutorPIDTest. Diffs (updated) - src/tests/containerizer/mesos_containerizer_tests.cpp 57588cc1fb918924a163bdb40b195cc5f4231f6e Diff: https://reviews.apache.org/r/49864/diff/ Testing --- Make and make check Thanks, Haris Choudhary
Re: Review Request 49864: Fixed ExecutorPIDTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/ --- (Updated July 10, 2016, 4:19 a.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Fixed ExecutorPIDTest. The ExecutorPIDTest added prevously produced the following trace: [ RUN ] MesosLauncherStatusTest.ExecutorPIDTest ABORT: (../../../3rdparty/libprocess/include/process/posix/subprocess.hpp:306): Failed to os::execvpe on path '/home/vagrant/mesos/build/src': Permission denied *** Aborted at 1467352526 (unix time) try "date -d @1467352526" if you are using GNU date *** PC: @ 0x2ac209cc9c37 (unknown) *** SIGABRT (@0x3e8730f) received by PID 29455 (TID 0x2ac2027779c0) from PID 29455; stack trace: *** @ 0x2ac209a85330 (unknown) @ 0x2ac209cc9c37 (unknown) @ 0x2ac209ccd028 (unknown) [ OK ] MesosLauncherStatusTest.ExecutorPIDTest (15 ms) This issue had been addressed with this patch. Diffs - src/tests/containerizer/mesos_containerizer_tests.cpp 57588cc1fb918924a163bdb40b195cc5f4231f6e Diff: https://reviews.apache.org/r/49864/diff/ Testing (updated) --- Make and make check Thanks, Haris Choudhary
Review Request 49864: Fixed ExecutorPIDTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- Fixed ExecutorPIDTest. The ExecutorPIDTest added prevously produced the following trace: [ RUN ] MesosLauncherStatusTest.ExecutorPIDTest ABORT: (../../../3rdparty/libprocess/include/process/posix/subprocess.hpp:306): Failed to os::execvpe on path '/home/vagrant/mesos/build/src': Permission denied *** Aborted at 1467352526 (unix time) try "date -d @1467352526" if you are using GNU date *** PC: @ 0x2ac209cc9c37 (unknown) *** SIGABRT (@0x3e8730f) received by PID 29455 (TID 0x2ac2027779c0) from PID 29455; stack trace: *** @ 0x2ac209a85330 (unknown) @ 0x2ac209cc9c37 (unknown) @ 0x2ac209ccd028 (unknown) [ OK ] MesosLauncherStatusTest.ExecutorPIDTest (15 ms) This issue had been addressed with this patch. Diffs - src/tests/containerizer/mesos_containerizer_tests.cpp 57588cc1fb918924a163bdb40b195cc5f4231f6e Diff: https://reviews.apache.org/r/49864/diff/ Testing --- Thanks, Haris Choudhary
Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
> On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580 > > <https://reviews.apache.org/r/49414/diff/1/?file=1433812#file1433812line580> > > > > Please use UUID::random here. I've made the changes. But consider if both UUID's were the same as a result of random, the test would fail. However I think its super rare for both to be generated as the same. > On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 582 > > <https://reviews.apache.org/r/49414/diff/1/?file=1433812#file1433812line582> > > > > Ditto on using UUID::random See previous comment for UUID > On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, lines 591-593 > > <https://reviews.apache.org/r/49414/diff/1/?file=1433812#file1433812line591> > > > > NO need for those default variables. I tried removing None() here but the code wouldnt compile because the arguments are required. Could you please elaborate what is required instead? Thanks - Haris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140479 --- On July 2, 2016, 9:50 p.m., Haris Choudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49414/ > --- > > (Updated July 2, 2016, 9:50 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5737 > https://issues.apache.org/jira/browse/MESOS-5737 > > > Repository: mesos > > > Description > --- > > Added Executor PID in /containers endpoint. Also Added Test Cases. > > > Diffs > - > > include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 > include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 > src/slave/containerizer/mesos/containerizer.cpp > a96b382f22886362a1159e1166dfe041072985ba > src/slave/containerizer/mesos/launcher.hpp > 05320f462653c31fc2f093d6c67e2182e9c794fa > src/slave/containerizer/mesos/launcher.cpp > ff675262af8947b89f8099828665e5e5d86491d8 > src/slave/containerizer/mesos/linux_launcher.hpp > 89bb2958a41dffe4ade9c2492b9a7412f90a432d > src/slave/containerizer/mesos/linux_launcher.cpp > 5028854fa003615f158120e030866b7ec4402b66 > src/tests/containerizer/launcher.hpp > c352634c4766d289706c7cc738677619d7d02ccd > src/tests/containerizer/mesos_containerizer_tests.cpp > 6c14f6e20b4d14d5ed095670673571739101b0e4 > > Diff: https://reviews.apache.org/r/49414/diff/ > > > Testing > --- > > make and make check. > > > Thanks, > > Haris Choudhary > >
Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/ --- (Updated July 2, 2016, 9:50 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-5737 https://issues.apache.org/jira/browse/MESOS-5737 Repository: mesos Description (updated) --- Added Executor PID in /containers endpoint. Also Added Test Cases. Diffs (updated) - include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba src/slave/containerizer/mesos/launcher.hpp 05320f462653c31fc2f093d6c67e2182e9c794fa src/slave/containerizer/mesos/launcher.cpp ff675262af8947b89f8099828665e5e5d86491d8 src/slave/containerizer/mesos/linux_launcher.hpp 89bb2958a41dffe4ade9c2492b9a7412f90a432d src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66 src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd src/tests/containerizer/mesos_containerizer_tests.cpp 6c14f6e20b4d14d5ed095670673571739101b0e4 Diff: https://reviews.apache.org/r/49414/diff/ Testing --- make and make check. Thanks, Haris Choudhary
Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5737 https://issues.apache.org/jira/browse/MESOS-5737 Repository: mesos Description --- Added Executor PID in /containers endpoint. Also Added Test Cases. In order to greatly simplify the implementation for the Mesos CLI's container plugin, we need the executor PID (Process ID) to be exposed in the /containers endpoint. [Mesos CLI Epic](https://issues.apache.org/jira/browse/MESOS-5676) This change will introduce the pid for an executor if it was launched by the mesos containerizer in the /containers endpoint of an agent. Diffs - include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba src/slave/containerizer/mesos/launcher.hpp 05320f462653c31fc2f093d6c67e2182e9c794fa src/slave/containerizer/mesos/launcher.cpp ff675262af8947b89f8099828665e5e5d86491d8 src/slave/containerizer/mesos/linux_launcher.hpp 89bb2958a41dffe4ade9c2492b9a7412f90a432d src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66 src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd src/tests/containerizer/mesos_containerizer_tests.cpp 6c14f6e20b4d14d5ed095670673571739101b0e4 Diff: https://reviews.apache.org/r/49414/diff/ Testing --- make and make check. Thanks, Haris Choudhary
