Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kartic Krish


 On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote:
  src/cli/python/mesos/__init__.py, line 27
  https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27
 
  Don't we need a `mesos.cli` here as well?

Looks like the module structure has been changed, so just 'packages': [ 'mesos' 
] should be OK.


- Kartic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95303
---


On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36819/
 ---
 
 (Updated Aug. 7, 2015, 3:08 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco 
 Massenzio.
 
 
 Bugs: MESOS-3149
 https://issues.apache.org/jira/browse/MESOS-3149
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Use setup.py in python cli package.
 
 
 Diffs
 -
 
   Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e 
   bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 
   configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 
   src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 
   src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef 
   src/cli/python/mesos/cli.py  
   src/cli/python/mesos/futures.py  
   src/cli/python/mesos/http.py  
   src/python/cli/src/mesos/__init__.py PRE-CREATION 
   src/python/interface/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
   src/python/native/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
   src/python/protocol/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
 
 Diff: https://reviews.apache.org/r/36819/diff/
 
 
 Testing
 ---
 
 make check
 
 # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04
 ## test steps:
 1. sudo make install
 2. export PYTHONPATH
 3. python -c 'import mesos; from mesos import cli, http, futures'
 
 
 Thanks,
 
 haosdent huang
 




Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kartic Krish

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95305
---


Looks good. Please include the she-bang in setup.py (as per previous reviewers 
comment).

- Kartic Krish


On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36819/
 ---
 
 (Updated Aug. 7, 2015, 3:08 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco 
 Massenzio.
 
 
 Bugs: MESOS-3149
 https://issues.apache.org/jira/browse/MESOS-3149
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Use setup.py in python cli package.
 
 
 Diffs
 -
 
   Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e 
   bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 
   configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 
   src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 
   src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef 
   src/cli/python/mesos/cli.py  
   src/cli/python/mesos/futures.py  
   src/cli/python/mesos/http.py  
   src/python/cli/src/mesos/__init__.py PRE-CREATION 
   src/python/interface/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
   src/python/native/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
   src/python/protocol/src/mesos/__init__.py 
 f48ad10528712b2b8960f1863d156b88ed1ce311 
 
 Diff: https://reviews.apache.org/r/36819/diff/
 
 
 Testing
 ---
 
 make check
 
 # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04
 ## test steps:
 1. sudo make install
 2. export PYTHONPATH
 3. python -c 'import mesos; from mesos import cli, http, futures'
 
 
 Thanks,
 
 haosdent huang