Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review86335 --- src/slave/slave.cpp https://reviews.apache.org/r/34729/#comment138292 Is the lack of a delay() in this case a bug? Doesn't this break the `forwardOversubscribedResources` loop? Is there something else going on that ensures the loop continues..? - Ben Mahler On May 29, 2015, 12:30 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 29, 2015, 12:30 a.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85659 --- Ship it! Ship It! - Niklas Nielsen On May 28, 2015, 5:30 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 28, 2015, 5:30 p.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 29, 2015, 12:30 a.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Changes --- updated slave to only forward if the new estimate is different from the previous one. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs (updated) - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
On May 27, 2015, 11:44 p.m., Jie Yu wrote: src/messages/messages.proto, lines 339-342 https://reviews.apache.org/r/34729/diff/1/?file=973027#file973027line339 It might not be an issue right now, but once we start to support updating slave's total regular resources, how can we distinguish between the following two cases: 1) We don't want to update oversubscribed resources 2) The new updated oversubscribed resources are zero I am thinking for 1) the slave should send the previous value if it doesn't want to (or have an) update. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85463 --- On May 27, 2015, 11:11 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 27, 2015, 11:11 p.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
On May 27, 2015, 11:44 p.m., Jie Yu wrote: src/messages/messages.proto, lines 339-342 https://reviews.apache.org/r/34729/diff/1/?file=973027#file973027line339 It might not be an issue right now, but once we start to support updating slave's total regular resources, how can we distinguish between the following two cases: 1) We don't want to update oversubscribed resources 2) The new updated oversubscribed resources are zero Vinod Kone wrote: I am thinking for 1) the slave should send the previous value if it doesn't want to (or have an) update. Good idea! SGTM. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85463 --- On May 27, 2015, 11:11 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 27, 2015, 11:11 p.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85462 --- Ship it! Ship It! - Jie Yu On May 27, 2015, 11:11 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- (Updated May 27, 2015, 11:11 p.m.) Review request for mesos, Jie Yu, Niklas Nielsen, and Brian Wickman. Bugs: MESOS-2770 https://issues.apache.org/jira/browse/MESOS-2770 Repository: mesos Description --- Per the latest design, the slave needs to send the total amount of oversubscribed resources (both allocated and available). Also renamed the message to UpdateSlave to make it more generic (e.g., can be used in the future to update slave's total resources too). Diffs - src/messages/messages.proto 39dac721fbe5b97842dd5d1d68cc135148ae02a2 src/slave/flags.hpp 6ca59dc9fc748ec738259406642ec17c0752590c src/slave/flags.cpp a8c7c498d674ca832fa052412a373c9ace4b3fc3 src/slave/slave.hpp 0207eafa914e23e4c72b1e5c4fb43aae6c97049c src/slave/slave.cpp b4d20294330f791e64a597c67b686aed9de84837 src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 Diff: https://reviews.apache.org/r/34729/diff/ Testing --- make check Will add a test in a subsequent review when a framework is able to launch a revocable task. Thanks, Vinod Kone
