Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review100738
---

Ship it!


- Joris Van Remoortere


On Sept. 21, 2015, 10:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/
---

(Updated Sept. 26, 2015, 10:03 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3380
https://issues.apache.org/jira/browse/MESOS-3380


Repository: mesos


Description
---

Since there is no robust standalone libev support on Windows, Mesos will
need to use libevent to support Windows, at least in the short term.

This commit will add logic to configure, build, and install libevent for
all Windows builds.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
a5f8d399e151acad87bb72ecb1f7372b2c467423 

Diff: https://reviews.apache.org/r/38550/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review100587
---

Ship it!


Ship It!

- haosdent huang


On Sept. 21, 2015, 10:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review100608
---



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 61)


80+ characters?


LGTM (-the long line).

- Artem Harutyunyan


On Sept. 21, 2015, 3:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 3:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Alex Clemmer]

> On Sept. 25, 2015, 5:03 p.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 61
> > 
> >
> > 80+ characters?

Per conversation with Joris, I think we'll probably keep this as is.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review100608
---


On Sept. 21, 2015, 10:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review99743
---


Patch looks great!

Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 
38541, 38542, 38549, 38550]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 10:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review99800
---

Ship it!


Ship It!

- Joseph Wu


On Sept. 21, 2015, 3:43 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> ---
> 
> (Updated Sept. 21, 2015, 3:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3380
> https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>