Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

> On Dec. 28, 2015, 11:31 p.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 347
> > 
> >
> > Other similar constructs will be converted when the code using them 
> > will compile on Windows.
> 
> Michael Park wrote:
> Sorry, I don't think I understand what this means. Could you 
> elaborate/clarify?

Synced with Daniel offline. This was meant to be a note that this 
transformation will need to be applied in other places in the codebase such as 
`slave.cpp`.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112086
---


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/
---

(Updated Jan. 19, 2016, 10:42 p.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Rebased.


Bugs: MESOS-4221
https://issues.apache.org/jira/browse/MESOS-4221


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
converting `_Deferred` to `std::function` must be done by explicitly calling 
`_Deferred`'s conversion function.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41459/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review113852
---

Ship it!


Ship It!

- Daniel Pravat


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/
---

(Updated Jan. 5, 2016, 11:58 p.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Rebased.


Bugs: MESOS-4221
https://issues.apache.org/jira/browse/MESOS-4221


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
converting `_Deferred` to `std::function` must be done by explicitly calling 
`_Deferred`'s conversion function.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41459/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

> On Dec. 28, 2015, 11:31 p.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 347
> > 
> >
> > Other similar constructs will be converted when the code using them 
> > will compile on Windows.

Sorry, I don't think I understand what this means. Could you elaborate/clarify?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112086
---


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > I assume you've gotten all of them?

I've gotten all of the ones in `Future`. I think as they work through rest of 
the codebase, there may be more contexts in which this comes up.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112481
---


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112481
---

Ship it!


I assume you've gotten all of them?

- Benjamin Hindman


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/
---

(Updated Dec. 28, 2015, 3:42 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-4221
https://issues.apache.org/jira/browse/MESOS-4221


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
converting `_Deferred` to `std::function` must be done by explicitly calling 
`_Deferred`'s conversion function.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 

Diff: https://reviews.apache.org/r/41459/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112086
---



3rdparty/libprocess/include/process/future.hpp (line 347)


Other similar constructs will be converted when the code using them will 
compile on Windows.


- Daniel Pravat


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/
---

(Updated Dec. 16, 2015, 7:38 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Repository: mesos


Description (updated)
---

VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
converting `_Deferred` to `std::function` must be done by explicitly calling 
`_Deferred`'s conversion function.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 

Diff: https://reviews.apache.org/r/41459/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park